--- Log opened Fri Nov 02 00:00:35 2018 --- Day changed Fri Nov 02 2018 20181102 00:00:35< celticminstrel> ^ buhman 20181102 00:47:07-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20181102 00:48:24<+wesdiscordbot> ok so for the Secret of the Ancients "Dark Business" scenerio 20181102 00:49:02<+wesdiscordbot> you have to have your leader level 2 on this stage because all the spearmen tend to attack Ardona when she is lvl 1 20181102 00:49:13<+wesdiscordbot> but when she is level 2 they attack the zombies instead 20181102 00:49:24<+wesdiscordbot> plus her attacks are way better 20181102 01:42:58-!- gfgtdf [~gfgtdf@134.76.63.8] has quit [Ping timeout: 268 seconds] 20181102 02:36:58-!- kitsunenokenja [~kitsunech@68.91.220.96] has joined #wesnoth 20181102 02:59:31-!- celticminstrel is now known as celmin|sleep 20181102 03:53:45< buhman> celmin|sleep: I feel insane enough to directly contribute to this. To get my feet wet, maybe I should open a PR to fix the argument ordering and one-indexing of add_dialog_tree_node ? 20181102 03:55:24< buhman> nobody uses that function anyway except gfgtdf :) 20181102 03:56:38< buhman> for the larger "api is weird" problem, I agree some kind of reviewed design proposal should exist 20181102 04:09:05-!- buhman_ [~rewt@c-73-162-194-50.hsd1.ca.comcast.net] has joined #wesnoth 20181102 04:09:17-!- buhman [~rewt@c-73-162-194-50.hsd1.ca.comcast.net] has quit [Disconnected by services] 20181102 04:09:19-!- buhman_ is now known as buhman 20181102 04:12:58-!- kitsunenokenja [~kitsunech@68.91.220.96] has quit [Ping timeout: 244 seconds] 20181102 04:49:39-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Ping timeout: 244 seconds] 20181102 05:48:22-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth 20181102 06:25:04<+wesdiscordbot> I don't recommend delving into a huge API redesign right now 20181102 06:25:25<+wesdiscordbot> We're still exploring the Series 2 rewrite 20181102 06:47:04<+wesdiscordbot> buhman: the #wesnoth-dev channel would be a better place to discuss that, regardless. 20181102 06:57:39<+wesdiscordbot> IMO, Wesnoth 1.x API redesign should be considered regardless of the possibility of the Wesnoth 2.x rewrite. 20181102 07:04:04<+wesdiscordbot> I disagree. 2.x will eventually replace 1.x, and sinking a ton of work into 1.x right now would be foolish. 20181102 07:04:18<+wesdiscordbot> "Here's a giant API redesign. Oh, wait, here's an even more extensive APi redesign!" 20181102 07:04:25<+wesdiscordbot> Not "will replace". It's "may replace". 20181102 07:04:27<+wesdiscordbot> 2 redesigns = more work for modders 20181102 07:05:30<+wesdiscordbot> If we were at "will replace", we wouldn't still be doing a prototype. 20181102 07:06:38<+wesdiscordbot> And even after exiting the prototype stage, it won't be guaranteed that the Wesnoth 2.x project will successfully finish. It won't be guaranteed as much as one second before it actually launches. 20181102 07:07:36-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 244 seconds] 20181102 07:08:15<+wesdiscordbot> Perhaps. But I'm not interested in arguing. 20181102 07:11:00<+wesdiscordbot> it does become a bit of a problem if you're telling someone not to work on 1.x though. 20181102 07:14:05<+wesdiscordbot> It is my recommendation. I already stated this before, remember 20181102 07:14:17<+wesdiscordbot> I said we shouldn't work on huge major 1.x projects right now 20181102 07:15:40<+wesdiscordbot> Sure, but in that case I'll state my counterpoint (that the rewrite shouldn't stop people from considering major 1.x projects). 20181102 07:34:44-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20181102 07:37:10-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 272 seconds] 20181102 07:37:59-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth 20181102 07:42:13-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: Leaving] 20181102 07:45:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth 20181102 07:50:20-!- cyphase [~cyphase@unaffiliated/cyphase] has joined #wesnoth 20181102 07:56:04-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20181102 08:05:51-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20181102 08:16:44<+wesdiscordbot> As long as that recommendation is stated informatively instead of definitively. 1.x is going to be around for a while regardless, since even if the prototype is successful it'll still be years rather than something like months before a 2.0 release would be ready. It doesn't make a great deal of sense to say that API improvements shouldn't be made to 1.x because 2.0 might replace it in 3(?) years. 20181102 08:19:08<+wesdiscordbot> TBH, "I don't recommend" (the words Vultraz used) do sound quite informative to me. But it's too easy to interpret in a wrong way. 20181102 08:21:26<+wesdiscordbot> right. the context of the project lead telling a potential new contributor "I don't recommend you do X" is pretty definitive as well. 20181102 08:39:34<+wesdiscordbot> Redoing the GUI2 Lua API is a pretty large large project. 20181102 08:41:57<+wesdiscordbot> Yeah. In fact, I'd say that it's so huge that it's not a very good idea to attempt. I just wanted to say that Wesnoth 2.x shouldn't IMO be used as a reason to avoid changes in 1.x. 20181102 10:46:01-!- Haudegen [~quassel@178.115.237.87.static.drei.at] has joined #wesnoth 20181102 11:08:30<+wesdiscordbot> @Vultraz when changing game speed , the description for this pop ups right on the value you try to change, means you cannot see to what value you change the game speed when moving the slider osx 1.14.5 20181102 11:08:30<+wesdiscordbot> https://cdn.discordapp.com/attachments/231976805987385345/507873627262287872/Screen_Shot_2018-11-02_at_12.02.34.png 20181102 11:09:40<+wesdiscordbot> maybe let it dissapear when you click the slider, while moving, and let it reapear when you release the slider, that should make it much more convenient 20181102 11:15:36<+wesdiscordbot> 🤔 20181102 11:15:39<+wesdiscordbot> that's an idea 20181102 11:15:52<+wesdiscordbot> not sure how easy it would be to implement, though... 20181102 12:22:10<+wesdiscordbot> if not, moving it up a bit is just as fine 20181102 12:32:45< celmin|sleep> buhman: There's actually a good reason for the weird argument ordering of the GUI2 API functions (value coming first) - it's leveraging varargs for the widget path. Not entirely sure what that means in the case of add_dialog_tree_node, though; does it take any argument besides the path? As for the one-indexing, that's just how Lua is, so I don't think we should "fix" it. 20181102 12:34:24-!- celmin|sleep is now known as celmin|away 20181102 13:14:11-!- Haudegen [~quassel@178.115.237.87.static.drei.at] has quit [Remote host closed the connection] 20181102 13:54:00-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 20181102 14:33:48-!- Haudegen [~quassel@212-186-77-29.static.upcbusiness.at] has joined #wesnoth 20181102 17:18:15-!- Haudegen [~quassel@212-186-77-29.static.upcbusiness.at] has quit [Remote host closed the connection] 20181102 17:22:44-!- Soo_Slow [~Soo_Slow@ppp92-100-67-43.pppoe.avangarddsl.ru] has joined #wesnoth 20181102 17:38:54-!- Soo_Slow [~Soo_Slow@ppp92-100-67-43.pppoe.avangarddsl.ru] has quit [Remote host closed the connection] 20181102 19:37:17-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20181102 19:54:24-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20181102 20:24:46-!- kitsunenokenja [~kitsunech@68.91.220.96] has joined #wesnoth 20181102 21:04:48-!- kitsunenokenja [~kitsunech@68.91.220.96] has quit [Ping timeout: 252 seconds] 20181102 21:34:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20181102 22:29:26< buhman> celmin|away: I mean, one of the lua-exposed functions has a zero-index, due to laziness I presume 20181102 23:15:53-!- HeyCitizen [HeyCitizen@gateway/vpn/privateinternetaccess/heycitizen] has quit [Quit: ZNC 1.7.1 - https://znc.in] 20181102 23:16:06-!- HeyCitizen [HeyCitizen@gateway/vpn/privateinternetaccess/heycitizen] has joined #wesnoth 20181102 23:36:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth 20181102 23:53:22< celmin|away> buhman: Ahhh, I see. I'd still say don't fix it, since it would break compatibility and we're probably not going to iterate on the existing API. 20181102 23:54:00< celmin|away> (Beyond exposing additional features maybe.) 20181102 23:54:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181102 23:54:20< celmin|away> Ideally we'd replace it with a more OO-like API. 20181102 23:56:15-!- celmin|away is now known as celticminstrel --- Log closed Sat Nov 03 00:00:46 2018