--- Log opened Sat Dec 01 00:00:23 2018 20181201 00:56:54< celmin|away> Ravana: Considering it a bit more, I think as implemented wml.load(path) would be more efficient than wml.parse(wesnoth.load_file(path)) - the latter loads the entire file as a string and then parses it, while the former passes the file stream directly to the parser. 20181201 00:57:29-!- celmin|away is now known as celticminstrel 20181201 01:33:38< irker776> wesnoth/wesnoth:master newfrenchy83 64c4d2f413 Update attack.cpp AppVeyor: All builds passed 20181201 01:49:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181201 02:53:19-!- ancestral [~anonymous@63.226.140.181] has joined #wesnoth-dev 20181201 03:16:16-!- ancestral [~anonymous@63.226.140.181] has quit [Quit: ancestral] 20181201 04:23:59-!- celticminstrel is now known as celmin|sleep 20181201 04:34:03-!- irker776 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181201 04:48:16-!- irker940 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181201 04:48:16< irker940> wesnoth/wesnoth:master josteph c59da16118 Update changelog for #3643 AppVeyor: All builds passed 20181201 06:24:10< irker940> wesnoth/wesnoth:1.14 nemaara 515ccab843 TSG S5: dialogue fix AppVeyor: All builds passed 20181201 07:27:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181201 09:24:26-!- irker940 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181201 09:57:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181201 10:20:45<+wesdiscordbot> celticminstrel: the travis validation fix is just to add [filter] tags around the id, right? 20181201 10:22:05<+wesdiscordbot> that looks correct and fixes the validation, but I don't actually know anything about the ai. 20181201 11:58:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181201 13:14:39< celmin|sleep> Yes. 20181201 13:57:46-!- irker187 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181201 13:57:46< irker187> wesnoth/wesnoth:1.14 nemaara 069be4a09e TSG S6b: minor QOL tweaks AppVeyor: All builds passed 20181201 15:57:21-!- gfgtdf [~Daniel@x4d08ace1.dyn.telefonica.de] has joined #wesnoth-dev 20181201 15:58:24< gfgtdf> in my addon i use wml.parse(wesnoth.load_file(path)) instead of wml.load(path) becasue im not sure whether the second one support relative (to the current lua file) paths. 20181201 16:43:56< gfgtdf> i wonder, if both the carryover and the scenario have a [variables] tag, which should have priority? I see usecases for both behviours, so the question is probaly which is more flexible. 20181201 16:57:47-!- irker187 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181201 18:02:11-!- celmin|sleep is now known as celticminstrel 20181201 18:02:59< celticminstrel> gfgtdf: It uses get_wml_location(), but... I dunno is that's enough to support relative paths? 20181201 18:03:06< celticminstrel> gfgtdf: Do you think I should add wml.preprocess() too? 20181201 18:03:44< celticminstrel> As to your [variables] question, I would need more information. 20181201 18:10:35-!- TheJJ [~rofl@ipbcc06208.dynamic.kabel-deutschland.de] has quit [Quit: løl] 20181201 18:17:55-!- irker859 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181201 18:17:55< irker859> wesnoth: pentarctagon wesnoth:master dbb222813c4d / data/campaigns/Northern_Rebirth/scenarios/02_01_Infested_Caves.cfg: Fix schema validation error. https://github.com/wesnoth/wesnoth/commit/dbb222813c4dfc4c7340459eafde79a892e4d739 20181201 18:18:42< celticminstrel> Those errors were missed before because somehow I broke part of the validator when fixing the build on non-MS compilers. :/ 20181201 18:41:03-!- travis-ci [~travis-ci@ec2-54-158-227-104.compute-1.amazonaws.com] has joined #wesnoth-dev 20181201 18:41:04< travis-ci> wesnoth/wesnoth#20303 (master - dbb2228 : pentarctagon): The build was fixed. 20181201 18:41:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/462239158 20181201 18:41:04-!- travis-ci [~travis-ci@ec2-54-158-227-104.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181201 18:42:21<+wesdiscordbot> woo 20181201 18:49:41<+wesdiscordbot> @shadowm "FYI Ivanovic will be offline for 3 weeks, so if you do decide to start a string freeze before he's back it'd be good if you told people to send me their stuff instead." Should this person be contacting you instead then? https://forums.wesnoth.org/viewtopic.php?f=7&t=49065&p=635899#p635492 20181201 18:53:01<+wesdiscordbot> Idk what he usually does when adding new maintainers 20181201 18:53:15<+wesdiscordbot> And I don't have time to figure it out 20181201 18:53:25<+wesdiscordbot> alright 20181201 18:57:45-!- TheJJ [~rofl@188.192.98.8] has joined #wesnoth-dev 20181201 19:02:26<+wesdiscordbot> I'm not sure if @sevu is around these days but I recall him doing some translation commits as well. 20181201 19:34:18< celticminstrel> Hmm, what Wesnoth thing should I do this weekend... 20181201 19:48:08< celticminstrel> ...wait, gfgtdf, is it load_file or read_file? 20181201 19:48:18< celticminstrel> https://wiki.wesnoth.org/LuaAPI/wesnoth#wesnoth.read_file 20181201 19:48:23< celticminstrel> ^ That might be wrong? 20181201 19:48:54< celticminstrel> BTW, is there any reason for not exposing the Lua file API other than the fact that it allows access to arbitrary files? 20181201 19:49:07< celticminstrel> I mean, would it be safe to expose it partly? 20181201 19:49:51<+wesdiscordbot> Allowing access to arbitrary files is extremely dangerous. 20181201 19:49:55< celticminstrel> I know that. 20181201 19:50:03< celticminstrel> I'm wondering if there are additional reasons beyond that. 20181201 19:50:04<+wesdiscordbot> It's all you need to develop a WannaCry clone, for example. 20181201 19:51:14< celticminstrel> For example, would it be safe to add our own version of io.open() that uses get_wml_location() to find the file but then returns a built-in file object? 20181201 19:52:22< celticminstrel> The file object has seek, lines, read, close, flush, setvbuf (WTH is that?), and write methods. 20181201 19:52:51<+wesdiscordbot> Hmm, I can't really answer to that. While I have worked on Lua codebases of hundreds of thousands of lines, we weren't using the file API. 20181201 19:52:55< celticminstrel> So if I'm not mistaken, it does not in itself allow access to arbitrary files... 20181201 19:52:59< celticminstrel> I see. 20181201 19:53:21<+wesdiscordbot> I can vouch for read_file existing 20181201 19:53:28< celticminstrel> And load_file? 20181201 19:53:32<+wesdiscordbot> though I use it for listing directories 20181201 19:53:35< celticminstrel> Maybe gfgtdf just misspoke. 20181201 19:53:43< celticminstrel> Yeah IIRC it does that, indeed. 20181201 19:53:53<+wesdiscordbot> no idea about load_file 20181201 19:56:13< celticminstrel> Hmm... maybe I could make a wesnoth.text module, but I think the only things I have to put there are format, format_conjunct_list, and format_disjunct_list... 20181201 19:56:40< celticminstrel> (Or should it be a global text module...?) 20181201 20:14:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20181201 20:14:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181201 20:14:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20181201 21:18:30-!- irker859 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181201 21:22:48< Ravana> would be nice to have limited file writing access, like only allowed under persist folder 20181201 21:23:24< celticminstrel> FTR, I wasn't even considering that - I was only thinking of general read access. 20181201 21:23:41< celticminstrel> As in you can read any file in the data or addons dir. 20181201 21:23:56< celticminstrel> But allowing to directly write files in the persist dir might be good too... 20181201 21:24:06< celticminstrel> That's where "global variables" are stored, right? 20181201 21:24:13< Ravana> yes 20181201 21:24:14<+wesdiscordbot> yep 20181201 21:26:05<+wesdiscordbot> though, is there any limitation on what can be put into a WML variable? otherwise the persistencewml already kind of allows that. 20181201 21:27:18< Ravana> structured data, like logs would be better in more common format 20181201 21:27:34< celticminstrel> Well, allowing direct access to those files would a) allow implementing PersistenceWML in Lua and b) allow storing data in non-WML format. 20181201 21:36:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181201 22:30:01-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181201 23:25:31-!- irker085 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181201 23:25:31< irker085> wesnoth/wesnoth:master newfrenchy83 4d31fa5872 Update unit.hpp AppVeyor: All builds passed 20181201 23:40:09-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] --- Log closed Sun Dec 02 00:00:24 2018