--- Log opened Sun Dec 02 00:00:24 2018
20181202 00:26:46< gfgtdf> celticminstrel: the standatd la file api has afaik no way to resic file acces, also i problay has problem with nonascii chracters on windows  as it uses the c standardlib.
20181202 00:26:58< gfgtdf> i meant read_file
20181202 00:27:57< gfgtdf> celticminstrel, this is the code https://github.com/gfgtdf/World_Conquest_II/blob/master/lua/map/filter_converter.lua#L172 is basicialyl anm autility to ocnvert wml filter to the mapgen filter syntax.
20181202 00:31:26< gfgtdf> celticminstrel, we could maybe implemnet or own equivalenct functions io.open/flush etc  that uses the wml file api and thus fixes these problems but i don't think it s worth it. 
20181202 00:56:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181202 00:58:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181202 01:30:50< celticminstrel> gfgtdf: I know io.open or whatever can't restrict fila access.
20181202 01:31:07< celticminstrel> gfgtdf: But once you have a file object, AFAICT there's no way to point it to a different file.
20181202 01:31:39< celticminstrel> gfgtdf: So what I was thinking is that we could have the C++ code basically call io.open on a safe path and return the resulting file object. Does that seem safe?
20181202 01:32:09< celticminstrel> gfgtdf: Kinda like reimplementing the functions of the io module but not the read/write/flush/etc methods.
20181202 01:32:34< celticminstrel> gfgtdf: Mind you, reimplementing everything does have the advantage that it could be built around C++ streams, which might make it easier to use on the C++ side...
20181202 01:32:44< celticminstrel> gfgtdf: And I guess it wouldn't be all that hard...
20181202 01:33:05< gfgtdf> as i said above, io.open will probaly not support nonacii failepaths on windows. so you could probably reimplement io.open but not by calling the original io.open
20181202 01:33:28< celticminstrel> Hmm.
20181202 01:33:50< celticminstrel> I see.
20181202 01:40:09< gfgtdf> actually form looking at the code it doesn't seem like we can really 'reimplement' io.open since the lua cpp api does not expose the needed functions
20181202 01:40:55< gfgtdf> what we coudl do is in the lua config file do somthing like `#define fopen wesnoth_fopen`, where wesnoth_fopen does open them in a 'safe' way.
20181202 01:44:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181202 01:46:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181202 01:46:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181202 01:53:01< irker085> wesnoth/wesnoth:master pentarctagon dbb222813c Fix schema validation error. AppVeyor: All builds passed
20181202 01:57:51< celticminstrel> Not sure why the Lua API would need to expose anything...
20181202 02:16:44-!- gfgtdf [~Daniel@x4d08ace1.dyn.telefonica.de] has quit [Quit: Leaving]
20181202 02:47:52-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 252 seconds]
20181202 02:48:09-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20181202 03:24:20< irker085> wesnoth/wesnoth:master newfrenchy83 2bf06a5a0d Update unit.hpp AppVeyor: All builds passed
20181202 05:38:23< irker085> wesnoth/wesnoth:1.14 nemaara f7315d73d0 TSG S7b: adjusted enemy gold AppVeyor: All builds passed
20181202 05:43:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20181202 06:24:23-!- celticminstrel is now known as celmin|sleep
20181202 07:49:00< irker085> wesnoth/wesnoth:master newfrenchy83 ddec569af4 Update attack.cpp AppVeyor: All builds passed
20181202 08:48:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181202 10:00:56< irker085> wesnoth/wesnoth:master newfrenchy83 d55efab128 Update attack.cpp AppVeyor: All builds passed
20181202 11:07:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181202 12:14:30< irker085> wesnoth/wesnoth:1.14 nemaara 50a6a55a04 TSG: modified Hylas' death AppVeyor: All builds passed
20181202 12:29:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181202 12:30:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181202 13:34:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181202 13:34:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181202 13:37:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181202 13:40:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181202 13:41:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181202 13:42:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181202 14:33:24-!- Grickit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 252 seconds]
20181202 14:33:50-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20181202 15:15:30-!- irker085 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181202 15:22:02-!- irker112 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181202 15:22:02< irker112> wesnoth: Celtic Minstrel wesnoth:master 16927f950811 / src/ (actions/attack.cpp actions/attack.hpp units/unit.hpp): add filter_attacker and filter_defender to abilities https://github.com/wesnoth/wesnoth/commit/16927f9508115614fab4fe46f28649982bf49d4b
20181202 15:22:21-!- celmin|sleep is now known as celticminstrel
20181202 15:23:41< celticminstrel> ...argh, I misattributed the commit again. Sigh. git pull/merge --squash is annoying.
20181202 15:23:48< celticminstrel> At least it's linked to the PR.
20181202 15:48:27-!- travis-ci [~travis-ci@ec2-54-162-134-136.compute-1.amazonaws.com] has joined #wesnoth-dev
20181202 15:48:28< travis-ci> wesnoth/wesnoth#20317 (master - 16927f9 : Celtic Minstrel): The build was broken.
20181202 15:48:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/462469433
20181202 15:48:28-!- travis-ci [~travis-ci@ec2-54-162-134-136.compute-1.amazonaws.com] has left #wesnoth-dev []
20181202 16:28:26-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 250 seconds]
20181202 16:29:01-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev
20181202 16:35:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20181202 16:37:45< irker112> wesnoth: gfgtdf wesnoth:master 646e074e5dee / src/saved_game.cpp: add assert for [load_resource] bug. https://github.com/wesnoth/wesnoth/commit/646e074e5deec29fd2f8f038373412ba99da5c66
20181202 16:42:44< irker112> wesnoth: mattsc wesnoth:master d9b1146a70fd / src/ai/ (manager.cpp manager.hpp): RCA AI manager: remove unused function add_ai_for_side() https://github.com/wesnoth/wesnoth/commit/d9b1146a70fdf003ee8a29e4b67a096da2b97c71
20181202 16:42:46< irker112> wesnoth: mattsc wesnoth:master f8871d9ad8b4 / src/ (ai/contexts.cpp ai/contexts.hpp recall_list_manager.hpp): RCA AI: remove unused function get_recall_list() https://github.com/wesnoth/wesnoth/commit/f8871d9ad8b4e63a2fb12fa5bc86e22217558b42
20181202 16:42:48< irker112> wesnoth: mattsc wesnoth:master 0ff1d9000234 / src/ai/ (7 files in 4 dirs): RCA AI: remove attack_depth aspect https://github.com/wesnoth/wesnoth/commit/0ff1d9000234447ba90e3a0a33b8a0b8a64d30e4
20181202 16:42:50< irker112> wesnoth: mattsc wesnoth:master 3da48bb57a61 / src/ai/default/aspect_attacks.cpp: RCA AI attack aspects: rename a variable https://github.com/wesnoth/wesnoth/commit/3da48bb57a61e71dd4d61aff27e1b7e32f63be35
20181202 16:42:52< irker112> wesnoth: mattsc wesnoth:master 7c34313a41e8 / data/ (70 files in 9 dirs): AI: remove attack_depth settings from mainline campaigns https://github.com/wesnoth/wesnoth/commit/7c34313a41e8af752470d38118ea6e2fc6ba59a6
20181202 16:42:54< irker112> wesnoth: mattsc wesnoth:master f53e3b9565d6 / data/schema/ai/ (aspect_complex.cfg aspect_simple.cfg modify.cfg): Schema validation: remove attack_depth aspect https://github.com/wesnoth/wesnoth/commit/f53e3b9565d65a24d54b8abc00fe2b1c1c3310ad
20181202 16:42:56< irker112> wesnoth: mattsc wesnoth:master f00f9e390126 / data/ai/utils/default_config.cfg: RCA AI: remove attack_depth aspect from default configuration https://github.com/wesnoth/wesnoth/commit/f00f9e3901265eefc679357e0be1fb7707d1343b
20181202 16:42:58< irker112> wesnoth: mattsc wesnoth:master c0bc8c548c7b / data/core/macros/ (ai.cfg utils.cfg): AI: deprecate ai_depth related macros https://github.com/wesnoth/wesnoth/commit/c0bc8c548c7bfed610ea28be304c444ec66c0879
20181202 16:43:00< irker112> wesnoth: mattsc wesnoth:master f901a0fd81ba / data/test/scenarios/ai/ (config/simple_aspect.cfg modify/aspects.cfg): Unit tests: change attack_depth to leader_value for aspect tests https://github.com/wesnoth/wesnoth/commit/f901a0fd81ba7d5399a27d2fb8e2c9f5a659ef1a
20181202 16:43:02< irker112> wesnoth: mattsc wesnoth:master 073f70b0a632 / data/_main.cfg src/ai/configuration.cpp src/ai/configuration.hpp: AI: move default algorithm definition from C++ to WML https://github.com/wesnoth/wesnoth/commit/073f70b0a632d754ebd2b01afcde721a8c1b4c47
20181202 16:43:04< irker112> wesnoth: mattsc wesnoth:master fcc22a36e20c / src/game_initialization/ (connect_engine.cpp connect_engine.hpp multiplayer.cpp): Command-line game: get default ai_algorithm from config https://github.com/wesnoth/wesnoth/commit/fcc22a36e20c61a3db79c812d2b059e282fe66c8
20181202 16:43:06< irker112> wesnoth: mattsc wesnoth:master c731be58a97e / / (7 files in 3 dirs): AI configuration: new optional parameter mp_rank= https://github.com/wesnoth/wesnoth/commit/c731be58a97e4bafc9fe17138a70c210c09af3f2
20181202 16:43:08< irker112> wesnoth: mattsc wesnoth:master afb394c4b1d9 / / (98 files in 23 dirs): Merge pull request #3723 from mattsc/rca_ai_changes https://github.com/wesnoth/wesnoth/commit/afb394c4b1d9a2f3a1c44932939d3c9e7198f9aa
20181202 17:00:44-!- travis-ci [~travis-ci@ec2-54-198-139-8.compute-1.amazonaws.com] has joined #wesnoth-dev
20181202 17:00:45< travis-ci> wesnoth/wesnoth#20319 (master - 646e074 : gfgtdf): The build is still failing.
20181202 17:00:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/462486251
20181202 17:00:45-!- travis-ci [~travis-ci@ec2-54-198-139-8.compute-1.amazonaws.com] has left #wesnoth-dev []
20181202 17:15:11<+wesdiscordbot> <josteph> celmin, setvbuf probably does what the C function of the same name does
20181202 17:23:21-!- travis-ci [~travis-ci@ec2-54-167-159-137.compute-1.amazonaws.com] has joined #wesnoth-dev
20181202 17:23:22< travis-ci> wesnoth/wesnoth#20320 (master - afb394c : mattsc): The build is still failing.
20181202 17:23:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/462487354
20181202 17:23:22-!- travis-ci [~travis-ci@ec2-54-167-159-137.compute-1.amazonaws.com] has left #wesnoth-dev []
20181202 18:38:32< irker112> wesnoth/wesnoth:master newfrenchy83 7aed34422a Update attack.cpp AppVeyor: All builds passed
20181202 19:28:38< irker112> wesnoth/wesnoth:master mattsc afb394c4b1 Merge pull request #3723 from mattsc/rca AppVeyor: vs2015/Release Failed
20181202 19:28:39< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20711862
20181202 20:44:34< irker112> wesnoth/wesnoth:master newfrenchy83 f65d32be67 Update attack.hpp AppVeyor: vs2015/Release Failed
20181202 20:44:35< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20711925
20181202 21:06:06-!- gfgtdf [~Daniel@x4d08ba94.dyn.telefonica.de] has joined #wesnoth-dev
20181202 21:26:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20181202 21:58:51< irker112> wesnoth/wesnoth:master josteph 4dcfb9c70e fixup! DiD S1: Add a dialog hint about t AppVeyor: vs2015/Release Failed
20181202 21:58:52< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20712200
20181202 22:10:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20181202 22:11:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20181202 22:36:51< irker112> wesnoth/wesnoth:master josteph 3cd225ad53 fixup! DiD S1: Add a dialog hint about t AppVeyor: vs2017/Release Failed
20181202 22:36:52< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20712201
20181202 22:53:44-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20181202 23:14:56< irker112> wesnoth/wesnoth:master newfrenchy83 59e27438ec Update attack.hpp AppVeyor: vs2017/Release Failed
20181202 23:14:57< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20712240
20181202 23:24:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20181202 23:25:00< irker112> wesnoth/wesnoth:master newfrenchy83 c5083f8c84 Update heal.cpp AppVeyor: All builds passed
--- Log closed Mon Dec 03 00:00:26 2018