--- Log opened Mon Dec 03 00:00:26 2018 20181203 00:07:01< celticminstrel> @josteph - Well I don't know what that does either, so... 20181203 00:28:39< irker112> wesnoth/wesnoth:master mattsc afb394c4b1 Merge pull request #3723 from mattsc/rca AppVeyor: 2/4 builds failed 20181203 00:28:40< irker112> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20711862 20181203 00:28:41< irker112> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20711863 20181203 00:29:29< irker112> wesnoth/wesnoth:master DisherProject 4e1bc86832 UtBS: Little cleanup AppVeyor: vs2015/Release Failed 20181203 00:29:30< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20712938 20181203 00:39:00-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181203 00:40:38< mattsc> celticminstrel: I don’t seem to be able to figure out the syntax for a schema validation that requires either, say, station_loc or station_x/y 20181203 01:30:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181203 01:33:30< mattsc> Also, the validator complains that ‘chicken’ is an invalid value for a move (in one of the unit test). :D 20181203 01:33:39< mattsc> Which, I guess, is the point. 20181203 01:34:11<+wesdiscordbot> yup 20181203 01:34:12<+wesdiscordbot> lol 20181203 01:35:23<+wesdiscordbot> set the SCHEMA_SHOULD_SKIP_THIS define to avoid that error. 20181203 01:36:59< mattsc> Okay, thanks. (I am not particularly bothered by that either way) 20181203 01:43:50< mattsc> Talking about unit tests, I assume that I did not break those? Looking at what is failing, I don’t see how my AI commits would have done that. 20181203 01:44:34< irker112> wesnoth/wesnoth:master newfrenchy83 f65d32be67 Update attack.hpp AppVeyor: 2/4 builds failed 20181203 01:44:35< irker112> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20711925 20181203 01:44:36< irker112> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20711926 20181203 01:45:17< mattsc> Oh, look at that. Good timing AppVeyor. 20181203 01:45:37<+wesdiscordbot> it looks like it did, actually 20181203 01:45:52<+wesdiscordbot> https://travis-ci.org/wesnoth/wesnoth/builds/462239158 succeeded 20181203 01:46:05<+wesdiscordbot> https://travis-ci.org/wesnoth/wesnoth/builds/462469433 broke strict builds due to a warning 20181203 01:46:06< irker112> wesnoth/wesnoth:master newfrenchy83 12a0ff72eb fix lowest sub used instead of highest AppVeyor: vs2015/Release Failed 20181203 01:46:07< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20716308 20181203 01:46:16<+wesdiscordbot> then https://travis-ci.org/wesnoth/wesnoth/builds/462487354 started failing unit tests 20181203 01:49:41<+wesdiscordbot> @Pentarctagon s/it did/I did ? 20181203 01:50:10<+wesdiscordbot> Sorry, just got back from traveling and am both out of touch and out of it, so just confirming 😉 20181203 01:50:38<+wesdiscordbot> er, right, whoops 20181203 01:51:02<+wesdiscordbot> well, not I as in me, but regardless 20181203 01:51:51<+wesdiscordbot> celticminstrels commit started breaking strict builds, your commits started breaking the unit tests 20181203 01:53:05<+wesdiscordbot> Hmm ... 20181203 01:53:51<+wesdiscordbot> I had previously tested that they (unit tests) worked, not sure what changed. 20181203 02:53:10-!- gfgtdf [~Daniel@x4d08ba94.dyn.telefonica.de] has quit [Ping timeout: 246 seconds] 20181203 02:58:52< irker112> wesnoth/wesnoth:master josteph 4dcfb9c70e fixup! DiD S1: Add a dialog hint about t AppVeyor: 1/2 builds failed 20181203 02:58:53< irker112> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20712200 20181203 03:01:14< irker112> wesnoth/wesnoth:master newfrenchy83 26b0fe77c8 Update heal.cpp AppVeyor: vs2017/Release Failed 20181203 03:01:15< irker112> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20716582 20181203 03:36:51< irker112> wesnoth/wesnoth:master josteph 3cd225ad53 fixup! DiD S1: Add a dialog hint about t AppVeyor: 1/2 builds failed 20181203 03:36:52< irker112> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20712201 20181203 04:14:57< irker112> wesnoth/wesnoth:master newfrenchy83 59e27438ec Update attack.hpp AppVeyor: 2/4 builds failed 20181203 04:14:58< irker112> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20712240 20181203 04:14:59< irker112> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20712242 20181203 05:29:29< irker112> wesnoth/wesnoth:master DisherProject 4e1bc86832 UtBS: Little cleanup AppVeyor: 2/4 builds failed 20181203 05:29:30< irker112> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20712938 20181203 05:29:31< irker112> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20712940 20181203 05:58:25< celticminstrel> mattsc: I think logic something like "if station_loc does not exist then station_x|y are required else station_loc is a string" would work. 20181203 05:58:47< celticminstrel> IIRC "key does not exist" would be something like [not]glob_on_key=* 20181203 05:59:17-!- celticminstrel is now known as celmin|sleep 20181203 06:20:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181203 06:42:33-!- valdar [~atarocch@93.56.172.28] has quit [Ping timeout: 268 seconds] 20181203 06:46:07< irker112> wesnoth/wesnoth:master newfrenchy83 12a0ff72eb fix lowest sub used instead of highest AppVeyor: 2/4 builds failed 20181203 06:46:08< irker112> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20716308 20181203 06:46:09< irker112> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20716309 20181203 08:01:16< irker112> wesnoth/wesnoth:master newfrenchy83 26b0fe77c8 Update heal.cpp AppVeyor: 2/4 builds failed 20181203 08:01:17< irker112> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20716582 20181203 08:01:18< irker112> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20716637 20181203 08:28:41-!- valdar [~atarocch@2.43.119.122] has joined #wesnoth-dev 20181203 11:13:57-!- irker112 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181203 13:21:43-!- valdar [~atarocch@2.43.119.122] has quit [Ping timeout: 245 seconds] 20181203 13:35:31-!- celmin|sleep is now known as celmin|away 20181203 13:55:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181203 14:09:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181203 14:29:55-!- valdar [~atarocch@31.159.80.5] has joined #wesnoth-dev 20181203 15:17:54< mattsc> celmin|away: Thanks, I got it to work. I’d had it almost right, but had misunderstood how the glob_on thingy works. 20181203 15:35:52-!- irker461 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181203 15:35:52< irker461> wesnoth/wesnoth:master newfrenchy83 c0edf402cd fix units no used in https://github.com/ AppVeyor: vs2017/Release Failed 20181203 15:35:52< irker461> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20731289 20181203 15:39:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181203 15:55:03-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 250 seconds] 20181203 15:55:38-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev 20181203 16:03:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181203 16:04:52-!- valdar [~atarocch@31.159.80.5] has quit [Ping timeout: 246 seconds] 20181203 16:31:24<+wesdiscordbot> I still have no idea why merging my AI PR broke all those units tests, or even how to go about figuring out what is going on. Most of those don't seem to have anything to do with what I committed. 20181203 16:31:42<+wesdiscordbot> If anybody has any insight, that would be much appreciated. 20181203 16:35:46-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20181203 16:47:06-!- SleepTalker [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has joined #wesnoth-dev 20181203 16:47:59-!- gfgtdf [~Daniel@x4dbb5c0e.dyn.telefonica.de] has joined #wesnoth-dev 20181203 16:48:12< gfgtdf> mattsc: the travis log says '20181202 17:10:56 warning ai/config: side 1: aspect with id=[mp_rank] lacks default config facet!' 20181203 16:48:32-!- SleepTalker [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has quit [Client Quit] 20181203 16:49:05< mattsc> gfgtdf: Hmm; that was fixed in one of the commits though … Let me see. 20181203 16:51:19< mattsc> Hmm. I indeed do not see this. Maybe I only fixed it locally and forgot to commit it or something? 20181203 16:51:42< mattsc> gfgtdf: and that would break the unit tests? 20181203 16:52:03< mattsc> I mena: lots of apparently unrelated unit tests? 20181203 16:52:21< gfgtdf> the probabyl assume that any wanring/error logged message imples that something went wrong 20181203 16:52:34< mattsc> Hmm, yeah. 20181203 16:57:47< irker461> wesnoth/wesnoth:master newfrenchy83 bf78eb2b02 Update abilities.cpp AppVeyor: vs2017/Release Failed 20181203 16:57:48< irker461> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20731867 20181203 17:01:28< irker461> wesnoth: mattsc wesnoth:master 31ae8fe46b78 / src/ai/configuration.cpp: AI configuration: add mp_rank to non-aspect attributes list https://github.com/wesnoth/wesnoth/commit/31ae8fe46b78a89d579fe7080a53c44b3eebce78 20181203 17:02:09< mattsc> Let’s see if that fixes it. 20181203 17:02:35< mattsc> I know I’d made that change before, I wonder where it disappeard. :P 20181203 17:26:45-!- travis-ci [~travis-ci@ec2-54-234-233-74.compute-1.amazonaws.com] has joined #wesnoth-dev 20181203 17:26:46< travis-ci> wesnoth/wesnoth#20336 (master - 31ae8fe : mattsc): The build is still failing. 20181203 17:26:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/462903668 20181203 17:26:46-!- travis-ci [~travis-ci@ec2-54-234-233-74.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181203 17:29:48< mattsc> Meh. 20181203 17:33:35< mattsc> Oh: “src/actions/attack.cpp:1599:164: error: unused parameter 'units' [-Werror=unused-parameter]” I probably didn’t cause that, did I? 20181203 17:33:35< gfgtdf> mattsc: seems liek it fixed it 20181203 17:33:39< gfgtdf> ye 20181203 17:33:55< mattsc> gfgtdf: Cool, thanks. 20181203 17:41:56< irker461> wesnoth/wesnoth:master newfrenchy83 d4894a413a Update abilities.cpp AppVeyor: vs2015/Release Failed 20181203 17:41:57< irker461> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20731868 20181203 17:45:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181203 18:37:16-!- gfgtdf [~Daniel@x4dbb5c0e.dyn.telefonica.de] has quit [Ping timeout: 268 seconds] 20181203 18:38:55< irker461> wesnoth/wesnoth:master mattsc af05162c75 Schema validation: add missing AI aspect AppVeyor: vs2017/Release Failed 20181203 18:38:56< irker461> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20734118 20181203 18:40:47-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181203 18:40:56< irker461> wesnoth: Jyrki Vesterinen wesnoth:master 892ed1b55550 / src/actions/attack.cpp: Fix build with -Werror=unused-parameter https://github.com/wesnoth/wesnoth/commit/892ed1b55550613ad5b673d2a2f0c91b8cb24650 20181203 20:35:45< irker461> wesnoth/wesnoth:master newfrenchy83 c0edf402cd fix units no used in https://github.com/ AppVeyor: 2/4 builds failed 20181203 20:35:46< irker461> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20731289 20181203 20:35:47< irker461> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20731290 20181203 20:53:57< mattsc> So the unit tests still fail. 20181203 21:10:22-!- sevu [~sevu@p54855FDC.dip0.t-ipconnect.de] has joined #wesnoth-dev 20181203 21:27:43-!- gfgtdf [~androirc@tmo-081-190.customers.d1-online.com] has joined #wesnoth-dev 20181203 21:28:32< gfgtdf> i cannot connect to irclogs.wesnoth.org, did someone else have the same problem? 20181203 21:28:59< gfgtdf> I mean wesnoth.org/irclogs 20181203 21:29:15< gfgtdf> Hmm now it works 20181203 21:39:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181203 21:40:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181203 21:40:44-!- valdar [~atarocch@93.56.172.28] has quit [Ping timeout: 246 seconds] 20181203 21:55:59-!- valdar [~atarocch@104.238.44.24] has joined #wesnoth-dev 20181203 21:57:47< irker461> wesnoth/wesnoth:master newfrenchy83 bf78eb2b02 Update abilities.cpp AppVeyor: 1/2 builds failed 20181203 21:57:48< irker461> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20731867 20181203 22:41:55< irker461> wesnoth/wesnoth:master newfrenchy83 d4894a413a Update abilities.cpp AppVeyor: 1/2 builds failed 20181203 22:41:56< irker461> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20731868 20181203 22:47:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181203 23:08:05-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181203 23:16:30-!- sevu [~sevu@p54855FDC.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20181203 23:28:14-!- gfgtdf [~androirc@tmo-081-190.customers.d1-online.com] has quit [Read error: Connection reset by peer] 20181203 23:38:55< irker461> wesnoth/wesnoth:master mattsc af05162c75 Schema validation: add missing AI aspect AppVeyor: 2/4 builds failed 20181203 23:38:56< irker461> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20734118 20181203 23:38:57< irker461> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/20734119 20181203 23:46:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] --- Log closed Tue Dec 04 00:00:27 2018