--- Log opened Tue Dec 04 00:00:27 2018
20181204 00:57:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20181204 01:00:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20181204 01:05:09-!- celmin|away is now known as celticminstrel
20181204 01:28:48< irker461> wesnoth/wesnoth:master Jyrki Vesterinen 892ed1b555 Fix build with -Werror=unused-parameter AppVeyor: All builds passed
20181204 01:50:34<+wesdiscordbot> <Pentarctagon> looks like just a bunch of schema errors now
20181204 01:51:00< celticminstrel> Hm?
20181204 02:08:00< mattsc> Hmm, alright, so I guess I’ll rebase the AI schema PR and see if the builds pass then.
20181204 02:12:49< celticminstrel> mattsc: This is really just a matter of style, but I'd prefer to see tags grouped together.
20181204 02:13:05< celticminstrel> ie, move default_ai_algorithm up to line 14.
20181204 02:13:52< mattsc> celticminstrel: okay, I can do that
20181204 02:15:15< celticminstrel> I see healer_loc was merely added, without using the macro... because all of them are optional, or...?
20181204 02:15:28< mattsc> Yes
20181204 02:15:32< celticminstrel> I guess that's alright then.
20181204 02:15:33< mattsc> Several others as well.
20181204 02:15:41< celticminstrel> Indeed. That was just the first one I saw.
20181204 02:16:06< celticminstrel> I'm kinda surprised there was only one place where you actually needed to expand the macro because it was x,y / location_id.
20181204 02:16:59< mattsc> I guess I was not surprised because I also did the changes to the MAIs themselves and noticed it then.
20181204 02:20:51< mattsc> celticminstrel: move the default_ai_algorithm line as you suggested
20181204 02:21:22< mattsc> I also rebased so that the tests start again; hopefully the unit tests will be fixed with that
20181204 02:21:35< mattsc> s/move/moved
20181204 02:50:22< celticminstrel> Nice typo. >_>
20181204 02:52:55< mattsc> :P 
20181204 04:28:56-!- irker461 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181204 05:16:43-!- celticminstrel is now known as celmin|sleep
20181204 06:18:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181204 06:22:41-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20181204 06:26:42-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181204 06:43:27-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20181204 09:05:18-!- irker563 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181204 09:05:18< irker563> wesnoth/wesnoth:master mattsc 8394549620 Schema validation: add missing AI aspect AppVeyor: All builds passed
20181204 09:15:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20181204 10:04:00-!- valdar [~atarocch@104.238.44.24] has quit [Ping timeout: 250 seconds]
20181204 10:19:57-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev
20181204 12:06:37-!- irker563 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181204 13:31:09-!- celmin|sleep is now known as celmin|away
20181204 13:34:04< celmin|away> mattsc: IMO feel free to merge it.
20181204 13:54:30-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20181204 14:05:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20181204 14:28:55-!- irker223 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181204 14:28:55< irker223> wesnoth/wesnoth:master Reuben Rakete b12ec069d0 Update hotkey filter to work with multi  AppVeyor: All builds passed
20181204 14:29:30< irker223> wesnoth: mattsc wesnoth:master dca3fe71bb3d / data/schema/ai/_main.cfg: Schema validation: add new AI keys https://github.com/wesnoth/wesnoth/commit/dca3fe71bb3dc046cb775342d61209fc45b817e1
20181204 14:29:32< irker223> wesnoth: mattsc wesnoth:master f07897cba9cb / data/schema/core/actionwml.cfg: Schema validation: support Micro AI named location keys https://github.com/wesnoth/wesnoth/commit/f07897cba9cbaddae7e1306f481b1fe0c714d1d4
20181204 14:29:34< irker223> wesnoth: mattsc wesnoth:master cf3be040cab4 / data/schema/ai/modify.cfg: Schema validation: add missing AI aspect https://github.com/wesnoth/wesnoth/commit/cf3be040cab418912c9007e29b1809d86c7effbc
20181204 14:29:36< irker223> wesnoth: mattsc wesnoth:master 25206b98bfc9 / data/schema/ (ai/_main.cfg ai/modify.cfg core/actionwml.cfg): Merge pull request #3756 from mattsc/ai_validation https://github.com/wesnoth/wesnoth/commit/25206b98bfc9abd433d1b603bd89e4f4589c4e94
20181204 14:45:47<+wesdiscordbot> <mattsc> @sevu The new AI parameters default_ai_algorithm= (073f70b0a and fcc22a36e2) and mp_rank= (c731be58a and 31ae8fe46) are now in master and can be cherry-picked into 1.14 so that cores can make use of them.
20181204 14:46:26<+wesdiscordbot> <mattsc> Let me know if you want me to do it; or just go ahead with it.
20181204 14:46:53<+wesdiscordbot> <mattsc> Is there an anticipated release of 1.14.6 yet?
20181204 15:19:53-!- Ravana [~Ravana@wesnoth/mp-mod/ravana] has quit []
20181204 15:31:55-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20181204 15:57:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20181204 16:21:08<+wesdiscordbot> <mattsc> @sevu Oh, and the reason why I am pinging you rather than just doing it is to see if you agree and whether there is anything else you think is needed.
20181204 17:30:35-!- irker223 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20181204 17:44:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20181204 18:57:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20181204 20:06:30-!- Ravana [~Ravana@wesnoth/mp-mod/ravana] has joined #wesnoth-dev
20181204 20:41:35< mattsc> Hmm, I am not sure what to do about this todo comment:
20181204 20:41:36< mattsc> https://github.com/wesnoth/wesnoth/blob/master/src/ai/composite/goal.cpp#L266
20181204 20:42:22< mattsc> It is possible to set protect_unit goals on enemy units; and there ould be legitimate reasons why one might want something like that.
20181204 20:42:41< mattsc> Or on allied units that don’t share vision.
20181204 20:43:47< mattsc> In those cases, does one include units invisible to the AI side?  (keeping in mind that this means only hiding units, not those under fog/shroud, which are always treated as visible by the AI)
20181204 20:44:49< mattsc> Given that the effect of goals on the AI is rather subtle in the first place, I’m not sure whether it really makes a difference.
20181204 20:45:11< mattsc> In general, treatment of invisible units is not really consistent throughout the AI in the first place.
20181204 20:49:05< mattsc> And to be clear: I am not sure about what the logical behavior should be (rather than how to code it; that’s comparatively easy).
20181204 20:49:48< mattsc> There are arguments for doing it either way, so I am tempted to just leave it as is (keep the comment, but remove the TODO from it).
20181204 21:35:42-!- irker604 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20181204 21:35:42< irker604> wesnoth/wesnoth:master mattsc 25206b98bf Merge pull request #3756 from mattsc/ai_ AppVeyor: All builds passed
20181204 22:03:31< irker604> wesnoth/wesnoth:master gfgtdf 83cb6d8e55 dontmergebeforerebase AppVeyor: vs2017/Release Failed
20181204 22:03:32< irker604> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/20771972
20181204 22:25:21-!- TC01 [~quassel@venus.arosser.com] has quit [Ping timeout: 268 seconds]
20181204 22:25:34-!- TC01 [~quassel@mobile-166-170-33-52.mycingular.net] has joined #wesnoth-dev
20181204 22:51:30-!- TC01 [~quassel@mobile-166-170-33-52.mycingular.net] has quit [Ping timeout: 244 seconds]
20181204 23:02:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds]
20181204 23:17:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20181204 23:25:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20181204 23:27:33< irker604> wesnoth/wesnoth:master newfrenchy83 22c20b3f9f Update abilities.cpp AppVeyor: All builds passed
20181204 23:32:05<+wesdiscordbot> <shadowm> HELLO WHAT IS THIS https://blogs.windows.com/buildingapps/2018/12/04/announcing-open-source-of-wpf-windows-forms-and-winui-at-microsoft-connect-2018/
20181204 23:45:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
--- Log closed Wed Dec 05 00:00:29 2018