--- Log opened Sun Dec 09 00:00:11 2018 20181209 00:18:41-!- TheJJ [~rofl@ipbcc06d45.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 00:22:58-!- TheJJ_ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 00:25:30-!- TheJJ_ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has quit [Read error: Connection reset by peer] 20181209 00:25:53-!- TheJJ [~rofl@ipbcc06d45.dynamic.kabel-deutschland.de] has quit [Ping timeout: 268 seconds] 20181209 00:31:53-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 01:17:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181209 01:33:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Read error: Connection reset by peer] 20181209 01:35:59-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181209 02:06:05-!- irker458 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181209 02:27:52-!- irker806 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181209 02:27:52< irker806> wesnoth/wesnoth:master nemaara 95db2f087e TSG: modified Hylas' death AppVeyor: All builds passed 20181209 02:52:13-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.] 20181209 02:55:03-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 05:28:04-!- irker806 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181209 05:50:45-!- irker714 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181209 05:50:45< irker714> wesnoth/wesnoth:master gfgtdf f09352570c fix get_variable in map generators AppVeyor: All builds passed 20181209 06:50:48-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.] 20181209 06:53:24-!- TheJJ [~rofl@188.192.139.69] has joined #wesnoth-dev 20181209 07:01:10-!- TheJJ [~rofl@188.192.139.69] has quit [Quit: No Ping reply in 180 seconds.] 20181209 07:02:57-!- celticminstrel is now known as celmin|sleep 20181209 07:04:03-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 07:26:16< irker714> wesnoth/wesnoth:master newfrenchy83 7504ff9b95 add sub and add to heal for test validat AppVeyor: All builds passed 20181209 07:39:55-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.] 20181209 07:45:46-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 08:14:20-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.] 20181209 08:16:58-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 08:26:55-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181209 09:02:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181209 09:27:44-!- TheJJ [~rofl@ipbcc08b45.dynamic.kabel-deutschland.de] has quit [Quit: No Ping reply in 180 seconds.] 20181209 09:30:39-!- TheJJ [~rofl@188.192.139.69] has joined #wesnoth-dev 20181209 09:43:01< irker714> wesnoth/wesnoth:master mattsc a2eea363e5 AI: remove invalidate_on_minor_gamestate AppVeyor: All builds passed 20181209 10:03:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181209 10:48:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181209 11:41:25-!- TheJJ [~rofl@188.192.139.69] has quit [Quit: No Ping reply in 180 seconds.] 20181209 11:47:17-!- TheJJ [~rofl@ipbcc0f8dd.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181209 12:43:40-!- irker714 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181209 14:26:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181209 14:57:21-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer] 20181209 15:00:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181209 15:25:37< celmin|sleep> newfrenchy's MO is so annoying... 20181209 15:28:53-!- celmin|sleep is now known as celticminstrel 20181209 15:31:28< celticminstrel> And his poor grasp of English does not help either... 20181209 15:41:11< mattsc> celticminstrel, gfgtdf, anybody: https://forums.wesnoth.org/viewtopic.php?f=21&t=48125&e=1&view=unread#p636163 20181209 15:41:40< mattsc> If you have any insight even on how to get started on figuring out what is going on here, that’d be much appreciated. 20181209 15:45:53< celticminstrel> I can't think of anything, sorry... 20181209 15:49:54< mattsc> Yeah, me neither. I think I just need to see if I can replicate this with a simpler test case and then just go through it step by step. 20181209 16:22:10<+wesdiscordbot> celmin, I think he means well 20181209 16:22:43< celticminstrel> Yeah. 20181209 16:22:55<+wesdiscordbot> and he does respond to feedback .. 20181209 16:23:02< celticminstrel> Kinda. 20181209 16:23:07<+wesdiscordbot> yeah πŸ˜ƒ 20181209 16:23:13<+wesdiscordbot> you saw my comment to him today? 20181209 16:23:21< celticminstrel> Yeah, I think so. 20181209 16:23:30<+wesdiscordbot> the one about "file an issue before open a PR" 20181209 16:23:34< celticminstrel> Yeah. 20181209 16:24:18<+wesdiscordbot> also would be nice if he force pushed to his branch/PR instead of constantly closing and (re)opening new ones 20181209 16:24:56<+wesdiscordbot> @Pentarctagon I'm not worried about burning up issue numbers.. but I think his "edit in github" workflow is what caused his invalid issue yesterday 20181209 16:25:15<+wesdiscordbot> I was planning to ask him to use a more normal workflow, one step at a time 20181209 16:25:18<+wesdiscordbot> first, "file issue before PR" 20181209 16:25:32<+wesdiscordbot> "use git properly" and "write regression tests" are on the menu for later on 20181209 16:26:00<+wesdiscordbot> IIRC he said he does this entirely from his phone, which is part of the reason for it. 20181209 16:26:06< celticminstrel> I don't care that much about the edit in github workflow. 20181209 16:26:36< celticminstrel> ... 20181209 16:26:47< celticminstrel> Is he going to constantly close issues and open new ones now. 20181209 16:27:20<+wesdiscordbot> @Pentarctagon I don't mind if he works from his phone. He'll just have to find a programmer's editor that runs on phones. 20181209 16:27:57<+wesdiscordbot> I mean, he'll probably want to do that, just to get indentation right. 20181209 16:28:22<+wesdiscordbot> celmin, maybe at first, but we'll educate him. 20181209 16:28:33<+wesdiscordbot> if he gets your goat just look the other way for a bit πŸ˜ƒ 20181209 16:28:45<+wesdiscordbot> by the way, his force_cth pull request, is it good to merge ? 20181209 16:28:59< celticminstrel> Uh probably, lemme look. 20181209 16:29:11<+wesdiscordbot> 3760 20181209 16:29:37< celticminstrel> Someone (probably me) also still needs to finish his incomplete weapon special abilities (he didn't pass other_unit to the filter or something)... 20181209 16:29:56<+wesdiscordbot> is there an issue for that ? 20181209 16:30:08< celticminstrel> I don't remember... 20181209 16:30:11<+wesdiscordbot> one reason I asked him to use issues instead of PR is so outstanding work would be recorded in github 20181209 16:30:13< celticminstrel> Will check. 20181209 16:30:14<+wesdiscordbot> not just in his head 20181209 16:30:20<+wesdiscordbot> please file one if needed πŸ˜ƒ 20181209 16:30:25<+wesdiscordbot> thanks for checking 20181209 16:30:55< celticminstrel> I don't see any problem in 3760 on a cursory glance. 20181209 16:34:12<+wesdiscordbot> cool. πŸ˜ƒ 20181209 16:43:47< celticminstrel> Done. 20181209 16:47:09<+wesdiscordbot> thank you, celmin 20181209 18:24:00-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181209 19:22:41-!- iwaim_ [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 252 seconds] 20181209 20:49:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181209 20:51:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181209 21:10:52-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev 20181209 21:16:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181209 21:20:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181209 21:40:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181209 21:40:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181209 21:57:04-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Read error: Connection reset by peer] 20181209 22:21:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20181209 23:01:31-!- irker391 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181209 23:01:32< irker391> wesnoth: gfgtdf wesnoth:master 830b2fdc3d42 / src/actions/advancement.cpp: check before dereferencing https://github.com/wesnoth/wesnoth/commit/830b2fdc3d425234d2637ce93ab75c98ebabcf7a 20181209 23:01:32< irker391> wesnoth: gfgtdf wesnoth:master 75a71b8dc806 / src/scripting/lua_terrainmap.cpp: fix lua mapgen map special_locations https://github.com/wesnoth/wesnoth/commit/75a71b8dc806d868b7587c8e0fd5265e4818a532 20181209 23:01:32< irker391> wesnoth: gfgtdf wesnoth:master d0fd69b92cd4 / src/scripting/lua_terrainfilter.cpp: add formula mapgen filter https://github.com/wesnoth/wesnoth/commit/d0fd69b92cd4b2f594bc6de428bbb17b2c0ae08f 20181209 23:46:58-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181209 23:58:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] --- Log closed Mon Dec 10 00:00:12 2018