--- Log opened Fri Dec 14 00:00:48 2018 20181214 00:00:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181214 00:26:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181214 00:26:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181214 05:06:20-!- celticminstrel is now known as celmin|sleep 20181214 05:24:05-!- irker731 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181214 05:24:05< irker731> wesnoth/wesnoth:master mattsc 54752c5973 AI configuration: invert mp_rank based o AppVeyor: All builds passed 20181214 06:44:04< irker731> wesnoth/wesnoth:master mattsc 8f2764268a AI configuration: invert mp_rank based o AppVeyor: All builds passed 20181214 09:23:08<+wesdiscordbot> any reason not to merge https://github.com/wesnoth/wesnoth/pull/3760 ? 20181214 09:37:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181214 09:44:09-!- irker731 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181214 11:13:50<+wesdiscordbot> I confirmed the bug (the macro expansion doesn't use CTH_NUMBER at all right now), I didn't test the fix 20181214 13:25:06-!- celmin|sleep is now known as celmin|away 20181214 13:26:13< celmin|away> ...that wasn't merged yet? o.O 20181214 14:28:22-!- irker878 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181214 14:28:22< irker878> wesnoth: newfrenchy83 wesnoth:master 550c686e7b83 / data/core/macros/utils.cfg: fix value={CTH_NUMBER} forget in force CTH macro https://github.com/wesnoth/wesnoth/commit/550c686e7b83e9465cd2811278c48f5c7db1069a 20181214 15:11:03<+wesdiscordbot> that could use a regression test, if anyone has time to kill... 20181214 15:52:21< irker878> wesnoth: Severin Glöckner wesnoth:path 23426deea311 / / (5 files in 3 dirs): remove duplicate cmd options https://github.com/wesnoth/wesnoth/commit/23426deea31185da2d7c1576fe2248577e7ea7f0 20181214 15:52:23< irker878> wesnoth: Severin Glöckner wesnoth:path ddd4fb593c48 / changelog.md: Changelog Entry for cmd options removal https://github.com/wesnoth/wesnoth/commit/ddd4fb593c4817da3042960bd9b4f9490bef48c0 20181214 15:59:01<+wesdiscordbot> ^ going to merge that later if the tests pass and nobody objects. 20181214 15:59:05<+wesdiscordbot> @Shadowm, I assume removing --path in favor of --data-path is the right way? 20181214 15:59:14<+wesdiscordbot> @shadowm 20181214 15:59:24<+wesdiscordbot> (whoever shad is) 20181214 15:59:37<+wesdiscordbot> What is --path? 20181214 15:59:51<+wesdiscordbot> Same as --data-path 20181214 16:00:15<+wesdiscordbot> I thought you might know more of the historical reasons 20181214 16:00:48<+wesdiscordbot> I don't remember at all 20181214 16:01:42<+wesdiscordbot> Alright. Well, the idea was to remove duplicate options beause it's confusing to have so many similar named paht/dir options 20181214 16:02:18<+wesdiscordbot> Talking about historical things, there was something else I wanted to ask you… 20181214 16:02:42<+wesdiscordbot> I intended to rename --config-dir/path to --user-dir/path or --profile-dir/path at some point 20181214 16:03:21<+wesdiscordbot> Since its usefulness as a shorthand for a --userconfig-dir/path and --userdata-dir/path combination shouldn't be underestimated 20181214 16:04:33<+wesdiscordbot> I think it's a good name for an option, but only one of the two should be used 20181214 16:05:57<+wesdiscordbot> we have --path --data-path --data-dir --userdata-path --userdata-dir --userconfig-paht --userconfig-dir --config-path --config-dir And none for the cache dir 20181214 16:07:15<+wesdiscordbot> That was supposed to be an exclusive or 20181214 16:10:14<+wesdiscordbot> It are just too many options to understand what they are fpr when you first look ath the manpage. --data-path makes sense, --config-path would make sense if it woul point to the config files, I guess the reason it ended up being so many is that there's no clearer term for the userdata-path 20181214 16:10:48<+wesdiscordbot> --config-path/dir came first 20181214 16:11:09<+wesdiscordbot> --userconfig-path/dir and --userdata-path/dir came up many years later 20181214 16:11:40<+wesdiscordbot> And they were ony implemented as part of the patch implementing support for using the XDG base directory spec on X11 20181214 16:12:15<+wesdiscordbot> (IIRC. They are somehow connected to that patch regardless.) 20181214 16:13:28<+wesdiscordbot> Do you think we should retain the -- config-paht/dir options? 20181214 16:13:44<+wesdiscordbot> I feel like you missed something I said above :p 20181214 16:14:23<+wesdiscordbot> "I intended to rename --config-dir/path to --user-dir/path or --profile-dir/path at some point / Since its usefulness as a shorthand for a --userconfig-dir/path and --userdata-dir/path combination shouldn't be underestimated" 20181214 16:14:37<+wesdiscordbot> So, that's a yes… Any objetions to remove --path ? 20181214 16:14:55<+wesdiscordbot> Not really, I wasn't even aware of that being a thing 20181214 16:19:51<+wesdiscordbot> If config-path would do what userconfg-path does, and and profile-path what userdata-path does, data-path what it currently does and a new cache-path would be added … that would be a reasonable sounding set of names, which is not as easy to confuse. 20181214 16:24:05<+wesdiscordbot> Maybe user-dir sound better than profile-dir… 20181214 16:25:18<+wesdiscordbot> You read what I said completely wrong 20181214 16:25:41<+wesdiscordbot> --config-path/dir does what --userconfig-path/dir and --userdata-path/dir do together 20181214 16:28:59<+wesdiscordbot> Hmmm…I'm not sure…I looked at the source yesterday, it seems more like it's an alias to the later.. If I didn't miss anything it are these two red lines: https://github.com/wesnoth/wesnoth/commit/23426deea31185da2d7c1576fe2248577e7ea7f0#diff-3a7422561a344f8f43dd3de1843269b9L322 20181214 16:29:09<+wesdiscordbot> *four red lines 20181214 16:31:39<+wesdiscordbot> Okay I guess I was wrong then and it was my intention to implement a combined option instead 20181214 16:33:01<+wesdiscordbot> On Windows I believe the user config dir defaults to the user data dir, right? 20181214 16:34:35<+wesdiscordbot> I think so. And if you build with cons, config and cache are in the same dir like the saves etc. Didn't find a way to change yet (might have missed a scons option though) 20181214 16:34:57<+wesdiscordbot> if ypu build with cmake and without optiins the three are split 20181214 16:35:14<+wesdiscordbot> Thery are only in the same path with scons if you use a specific option 20181214 16:35:35<+wesdiscordbot> prefsdir = '.wesnoth-1.15' 20181214 16:36:18<+wesdiscordbot> (Which I do because I'm not a fan of the directory separation deal XDG proposes) 20181214 16:37:56<+wesdiscordbot> It's the same I use…because I want it to not clash with the 1.12 installation... the cache directory they could share though… Didn't try the cachedir 20181214 16:39:00<+wesdiscordbot> while at it, any plans to make --userdata-dir=foo mean ./foo and not ~/foo? That gets me every time 20181214 16:40:20<+wesdiscordbot> Changing the semantics of those options is a terrible idea. 20181214 16:40:21-!- smiley` [~smiley@202.153.86.233] has joined #wesnoth-dev 20181214 16:40:48-!- smiley` [~smiley@202.153.86.233] has quit [Client Quit] 20181214 16:40:55<+wesdiscordbot> Err, right 20181214 16:41:03<+wesdiscordbot> I meant, to add a new option with sane semantics 20181214 16:41:06<+wesdiscordbot> It's one of those pulling the rug from under people's feet kind of deal since there's no way for users to tell if the behaviour changed until they notice the results. 20181214 16:41:12<+wesdiscordbot> Of course I'm not proposing to break compatibility 20181214 16:41:31< Soliton> --userdata-dir-without-implicit-prefix 20181214 16:42:42<+wesdiscordbot> yeah, something like that 😃 20181214 16:45:50<+wesdiscordbot> We're going to end up with a million options 20181214 16:46:03<+wesdiscordbot> Yeah… 20181214 16:46:06<+wesdiscordbot> I'm not totally against pulling the rug, since haveing many options confuses the people who didn't get into the old ones yet 20181214 16:47:04<+wesdiscordbot> It's a bit concerning that at this point it sounds like it'd be much simpler to write an expression minilanguage to describe Wesnoth's user profile layout 20181214 16:48:59<+wesdiscordbot> Where's the user data dir? Is it relative to the home dir or to Documents (Windows) or to the process working dir? Where is the user config dir? Relative to? Where's the cache dir? Relative to? 20181214 16:50:02<+wesdiscordbot> If the platform recommends directory separation, should that be used or should all three be based on the user data dir? 20181214 16:50:47<+wesdiscordbot> I'd never have expected a little game like this to end up with such an intricate set of options 20181214 16:51:06<+wesdiscordbot> Should be used, though there's the next problem – If you change userdata dir, you probably want to change the preferences dir too … 20181214 16:51:25<+wesdiscordbot> The above questions are not questions for you :p 20181214 16:51:48<+wesdiscordbot> They are the questions Wesnoth asks itself all the time 20181214 16:51:57<+wesdiscordbot> ideally, I'd like to have one option that has the normal path semantics: either absolute path or relative path, relative to cwd 20181214 16:52:23<+wesdiscordbot> we can have another option alongside that, --userdata-dir-relative-to-tilde-if-not-absolute, that has the semantics of the current option 20181214 16:52:41<+wesdiscordbot> I guess we'd give the new options new names and deprecate the existing names 20181214 16:52:58<+wesdiscordbot> totally doable, if we wanted to 20181214 16:55:35<+wesdiscordbot> How about: --put-everything-here= 20181214 16:57:58<+wesdiscordbot> you can sorta do this already by setting $HOME in the environment, can't you? Unless that affects some of the libraries we use 20181214 16:58:32<+wesdiscordbot> Does Wesnoth use `$HOME^ instead of reading from passwd? 20181214 16:58:52<+wesdiscordbot> if it doesn't, it should 😃 20181214 16:59:22<+wesdiscordbot> Can't say I like using environment variables for this stuff 🙄 20181214 17:00:30<+wesdiscordbot> envvars are evil, yes. I was just saying that "set the config dir, userdata dir, cache dir at once" functionality can be achieved that way without a new option 20181214 17:00:53<+wesdiscordbot> but I'm not opposed to adding that option 20181214 17:06:37<+wesdiscordbot> putting those different parts in different places at all doesn't really make a whole lot of sense to me. I can see the logic behind putting different parts in their own specific places for some things, but for wesnoth it seems more like it just fragments where everything actually is. 20181214 17:07:46-!- smiley` [mlsmiley@gateway/shell/xshellz/x-xvapvbldgnbvaqpg] has joined #wesnoth-dev 20181214 17:07:56-!- travis-ci [~travis-ci@ec2-54-163-1-198.compute-1.amazonaws.com] has joined #wesnoth-dev 20181214 17:07:57< travis-ci> wesnoth/wesnoth#20386 (path - ddd4fb5 : Severin Glöckner): The build passed. 20181214 17:07:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/468058449 20181214 17:07:57-!- travis-ci [~travis-ci@ec2-54-163-1-198.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181214 17:08:57<+wesdiscordbot> well, it's the XDG thing 20181214 17:09:13<+wesdiscordbot> the only reason why anybody would like it :p 20181214 17:10:17<+wesdiscordbot> that said… it could be indeed just one option for changing it, if you set the XDG paths only at compiletime 20181214 17:10:21< irker878> wesnoth/wesnoth:master newfrenchy83 550c686e7b fix value={CTH_NUMBER} forget in force C AppVeyor: vs2015/Release Failed 20181214 17:10:22< irker878> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21014319 20181214 17:10:31<+wesdiscordbot> Ugh compile time options 20181214 17:11:20<+wesdiscordbot> They're just awful for this kind of thing 20181214 17:15:03<+wesdiscordbot> They are nice to have anyway, because if you don't set any path related options (be it compile time or runtime) wesnoth will use .local/share/1.xy as userdata dir, but use for both e.g. 1.12 and 1.14 the same .config/wesnoth folder, which screws up the preferences file 20181214 17:17:04<+wesdiscordbot> cache can be uses in common, because the cache's filenames include the version number (even commit number). Saves/addons/… can be uses in common because thery are in an version subfolder (for each series one). preferences are an unsolved problem. 20181214 17:18:36<+wesdiscordbot> Wouldn't need to be solved with options though. Just the way it is done somewhat right now, with the sideeffect to putting the preferences out of thepreferences dir into the uerdata dir. and the cache too. 20181214 17:18:40<+wesdiscordbot> Debian changes the default config dir to .config/wesnoth-1.14. Not sure about other distros 20181214 17:21:45<+wesdiscordbot> I'm not sure why Debian does that when the patch for the XDG base dir layout actually came from Debian :p 20181214 17:22:14<+wesdiscordbot> (I mean doing that in what I presume is a patch in the Debian package as opposed to having that be Wesnoth's behaviour on all platforms) 20181214 17:24:57< Ravana> there are some commands that take path relative to ~, and some that require adding ~ as part of path https://github.com/wesnoth/wesnoth/issues/2000 20181214 17:32:10<+wesdiscordbot> @shadowm They build with -DPREFERENCES_DIR=".config/wesnoth-$(BRANCH_VERSION)" 20181214 17:32:15<+wesdiscordbot> https://salsa.debian.org/games-team/wesnoth/blob/master/debian/rules 20181214 17:32:28<+wesdiscordbot> Still weird 20181214 17:32:52<+wesdiscordbot> that solves the problem which I just described (for the config dir) 20181214 17:33:05<+wesdiscordbot> Yes but why wasn't that in the patch instead? 20181214 17:33:38<+wesdiscordbot> ¯_(ツ)_/¯ 20181214 17:35:58<+wesdiscordbot> we don't have a $(BRANCH_VERSION), but in scons is a version_suffix. I think cmake uses no such option 20181214 17:37:20<+wesdiscordbot> It's dumb to share preferences but not the user data dir with all versions 20181214 17:37:53<+wesdiscordbot> Either both should be shared (terrible idea, see issue #2710) or neither 20181214 17:44:46<+wesdiscordbot> the "correct" behavior for Debian would be to look for a subdirectory called "wesnoth-1.14" under XDG_CONFIG_HOME 20181214 17:45:04<+wesdiscordbot> I don't know if it actually does that or if it hardcodes ~/.config 20181214 17:45:17-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181214 18:00:56<+wesdiscordbot> the option looks like it hardcodes it 20181214 19:37:39< irker878> wesnoth/wesnoth:path Severin Glöckner ddd4fb593c Changelog Entry for cmd options removal AppVeyor: vs2015/Release Failed 20181214 19:37:40< irker878> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21016482 20181214 21:10:14< irker878> wesnoth/wesnoth:master newfrenchy83 550c686e7b fix value={CTH_NUMBER} forget in force C AppVeyor: 1/4 builds failed 20181214 21:10:15< irker878> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21014319 20181214 22:19:06< irker878> wesnoth/wesnoth:master newfrenchy83 1dbf872bff Update unit.hpp AppVeyor: vs2015/Release Failed 20181214 22:19:07< irker878> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21021947 20181214 23:18:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20181214 23:37:33< irker878> wesnoth/wesnoth:path Severin Glöckner ddd4fb593c Changelog Entry for cmd options removal AppVeyor: 1/4 builds failed 20181214 23:37:34< irker878> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21016482 20181214 23:44:12-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Sat Dec 15 00:00:49 2018