--- Log opened Tue Dec 18 00:00:53 2018 20181218 00:26:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181218 00:32:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181218 00:59:22< celmin|away> @jyrkive - What's the trouble with accessing the game config, exactly? 20181218 01:00:45<+wesdiscordbot> it seems like a thing we shouldn't do 20181218 01:07:09< celmin|away> Why? 20181218 01:09:04-!- celmin|away is now known as celticminstrel 20181218 01:11:15<+wesdiscordbot> might be soe private data in there, i dunno 20181218 01:31:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181218 02:03:00-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181218 02:07:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181218 03:11:18< celticminstrel> Like what? 20181218 03:26:09<+wesdiscordbot> could it access the friends list? 20181218 03:47:07< celticminstrel> Pretty sure that's stored in the preferences file. 20181218 03:47:11< celticminstrel> So, no. 20181218 03:52:04< mattsc> celticminstrel: what’s the exact syntax to run the schema validation on a specific add-on? 20181218 03:52:55< mattsc> I’ve tried on Grnk and not succeeded. I went as far a intorducing intentional mistakes and it did not flag them, so I must have gotten something wrong. 20181218 03:53:08< celticminstrel> mattsc: Running it on an add-on in the vein of the Travis validation might be a bit tricky, but... you can use also --validate-addon Addon_Folder_Name and then load your addon and check the log. 20181218 03:53:10<+wesdiscordbot> What is the bot doing? 20181218 03:54:28< celticminstrel> mattsc: In theory --validate Addon_Folder_Name/_main.cfg should work, but in practice I think it won't for lack of core macros. 20181218 03:54:47< mattsc> Who’s Roxas? 20181218 03:54:51< celticminstrel> Not sure though, you can try it. You'd also need to add --preprocessor-defines=YOUR_CAMPAIGN 20181218 03:54:55< mattsc> celticminstrel: okay, let me try 20181218 03:55:16< mattsc> (I did add the preprocessor define) 20181218 03:55:20< celticminstrel> mattsc: FTR, the man-page does document these. 20181218 03:55:39< mattsc> celticminstrel: I know. I tired followiong the manpage and it did not work. 20181218 03:55:52< mattsc> Actually, well, maybe not. I tried what was stated in --help. 20181218 03:55:55< celticminstrel> Did you use --validate-addon or --validate? 20181218 03:56:02< mattsc> Tried both. 20181218 03:56:04< celticminstrel> They should be documented in --help too I think. 20181218 03:56:20< celticminstrel> "man doc/man/wesnoth.6" should give you the man-page. 20181218 03:57:14< celticminstrel> --validate-addon is "background validation", so you'd need to actually start the campaign before you can see the validation results in the log (I'd also recommend adding --nocache). 20181218 03:57:42< mattsc> that might have been the bit I missed ... 20181218 03:58:20< celticminstrel> --validate ignores the cache and runs the validation immediately, then exits; but I might've forgotten to implement a way to automatically bring in the core macros. 20181218 04:00:01< celticminstrel> If using --validate you need to provide the preprocessor define as I mentioned, and you can provide the schema explicitly too (though it defaults to the game config schema, so not necessary here). 20181218 04:00:39< celticminstrel> Come to think of it, both ways might also give false hits for missing toplevel tags like [language] and [game_config]... 20181218 04:00:58< celticminstrel> Let me know how it works? 20181218 04:01:02< celticminstrel> ^works out 20181218 04:01:29< mattsc> So far no message at all 20181218 04:01:43< mattsc> ./Wesnoth --validate-addon ~add-ons/Grnk --preprocess-defines=CAMPAIGN_GRNK,CAMPAIGN_GRNK_PART_1 20181218 04:02:22< celticminstrel> It takes the addon ID (folder name), not the full path. Defines aren't relevant for --validate-addon, you just need to start the campaign. 20181218 04:02:38< mattsc> okay ... 20181218 04:03:26< mattsc> Ooo, lots of messages! 20181218 04:03:34< mattsc> Okay, that works. 20181218 04:04:03< mattsc> It might be worth putting a few examples onto the woiki somewhere, maybe? 20181218 04:04:19< celticminstrel> Maybe. 20181218 04:04:33< mattsc> Anyways, thanks. 20181218 04:37:37< mattsc> celticminstrel: does the schema validation know how to deal with variables? 20181218 04:37:56< celticminstrel> What do you mean exactly? 20181218 04:38:04< mattsc> I get lots of messages of type: “Invalid value '$CEH_terrain' in key 'terrain=' in tag [not]” 20181218 04:38:23< celticminstrel> I see. 20181218 04:38:40< celticminstrel> I probably overlooked the possibility that that key could have a variable. 20181218 04:38:52< celticminstrel> Is that a terrain filter? 20181218 04:40:05< celticminstrel> The schema validation "knows" how to deal with variables in that it's (supposedly) prepared to accept variables in place of a statically-valid value in places where variables make sense. 20181218 04:40:14< mattsc> Yes, that’s an SLF 20181218 04:40:27< celticminstrel> I guess I missed this for some keys though. 20181218 04:40:50< mattsc> There also seems to be some type mismatches, for example in [goal] (but I can fix those myself) 20181218 04:41:10< celticminstrel> The fix would be to replace terrain with s_terrain or terrain_list with s_terrain_list. Probably also need to declare said type in game_config.cfg using the macro. 20181218 04:41:15< mattsc> Anyway, not really working on this right now, just having a first quick look over it. 20181218 04:41:24< celticminstrel> Type mismatches? 20181218 04:41:48< mattsc> “Invalid value '100.' in key 'value=' in tag [goal]” 20181218 04:41:54< celticminstrel> Hmm. 20181218 04:42:23< celticminstrel> I think my definition of real numbers requires at least one digit on both sides of the decimal point. 20181218 04:42:29< celticminstrel> The definition could be changed, I suppose. 20181218 04:42:37< mattsc> Oh, I see. 20181218 04:43:08< mattsc> Anyways, I’ll leave it at that for now. I just wanted to have a quick look over the kind of messages I am getting. 20181218 04:43:12< celticminstrel> Okay. 20181218 04:43:53< mattsc> Those and “Invalid value 'border_size=1” seem to account for most of what I have seen so far. 20181218 04:43:58< mattsc> I’ll get back to you ... 20181218 04:44:08< mattsc> … in a couple months or so ;) 20181218 04:44:29< celticminstrel> XD 20181218 04:44:39< celticminstrel> border_size? 20181218 04:44:45< mattsc> BTW, it’s good that we are aiming for 1.1.5.0 “eventually”. 20181218 04:44:56< mattsc> Better than not aiming for it at all, I guess! 20181218 04:45:04< mattsc> @Vultraz ^ ;) 20181218 04:45:17< celticminstrel> You had an extra dot in that version number. 20181218 04:45:44< mattsc> I did. (blush) 20181218 04:46:10< mattsc> border_size used to be a key you could add to maps. 20181218 04:46:31< celticminstrel> Oh, that. Yeah, I think the schema rejects the map header even though Wesnoth still accepts (and ignores) it. 20181218 04:46:51< mattsc> I just haven’t removed it from my maps yet. 20181218 04:47:25< celticminstrel> I suppose that error message also prints the entire map too. 20181218 04:48:11< mattsc> IT does. 20181218 04:48:42< celticminstrel> Maybe that should be changed... 20181218 04:48:57< mattsc> Maybe. 20181218 04:49:28< mattsc> Or one could consider it an accomplishment to get rid of 50 lines of error message by removing a single line from a map. 20181218 04:50:00< celticminstrel> XD 20181218 04:51:20< mattsc> Anyways, as I said, this isn’t really what I am doing right now. I’ll get back to it at some point and fix up both my campaign and the remaining stray issues in schema validation (assuming I know how to do the latter). 20181218 05:12:37< celticminstrel> I still haven't implemented deprecation in the schema validator... 20181218 05:12:51< celticminstrel> Probably isn't even all that hard... 20181218 05:24:23-!- celticminstrel is now known as celmin|sleep 20181218 07:33:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181218 13:56:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181218 13:58:35-!- celmin|sleep is now known as celmin|away 20181218 14:08:37-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181218 14:26:06-!- irker047 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181218 14:26:06< irker047> wesnoth: mattsc wesnoth:master d0f1b27dee4b / src/ai/composite/goal.cpp: AI goals: do not protect units hidden from the AI https://github.com/wesnoth/wesnoth/commit/d0f1b27dee4bfa55d35f278264b3058b3576836a 20181218 14:26:06< irker047> wesnoth: mattsc wesnoth:master 6824f9bced57 / src/ai/default/ca.cpp: AI leader_shares_keep CA: re-evaluate possible_moves after move https://github.com/wesnoth/wesnoth/commit/6824f9bced575553a64e7a2e371de03eb3a92f07 20181218 14:26:06< irker047> wesnoth: mattsc wesnoth:master 761b110f1fd1 / src/ai/default/ca_move_to_targets.cpp: AI move_to_targets CA: do not use dynamic limit for a* search https://github.com/wesnoth/wesnoth/commit/761b110f1fd151877a3fdb12e1f0208b3dce19f6 20181218 14:26:07< irker047> wesnoth: mattsc wesnoth:master 5f8b0a34dfe2 / src/ai/ (18 files in 5 dirs): AI: remove outdated TODOs https://github.com/wesnoth/wesnoth/commit/5f8b0a34dfe245bf33ce7bbf95da9039cf528f1f 20181218 14:26:08< irker047> wesnoth: mattsc wesnoth:master 73bd58282e97 / src/ai/ (actions.cpp composite/ai.cpp game_info.hpp manager.cpp): AI: remove references to extended event system https://github.com/wesnoth/wesnoth/commit/73bd58282e9737338286a66b6aa84812e51981c2 20181218 14:26:10< irker047> wesnoth: mattsc wesnoth:master 3179b4707592 / src/ai/composite/ (aspect.cpp aspect.hpp): AI: remove invalidate_on_minor_gamestate_change https://github.com/wesnoth/wesnoth/commit/3179b4707592e3b74539f37c7d39f1c47c8653f7 20181218 14:26:12< irker047> wesnoth: mattsc wesnoth:master 8a7a5a153f32 / / (6 files in 3 dirs): AI configuration: invert mp_rank based ordering https://github.com/wesnoth/wesnoth/commit/8a7a5a153f32b71ff2810ddeea846e6109e83d72 20181218 14:26:14< irker047> wesnoth: mattsc wesnoth:master ba4202caf8b9 / src/ai/ (actions.cpp contexts.cpp manager.hpp): AI code: remove more outdated TODOs https://github.com/wesnoth/wesnoth/commit/ba4202caf8b916692dd254f1eddb54bff74153f6 20181218 14:26:16< irker047> wesnoth: mattsc wesnoth:master 49e216bba349 / src/ai/ (6 files in 3 dirs): AI code: remove old version annotations from TODOs https://github.com/wesnoth/wesnoth/commit/49e216bba3496f1b0bc957c28fb6f60b3c36c1e5 20181218 14:26:18< irker047> wesnoth: mattsc wesnoth:master cb3049681bb8 / / (29 files in 7 dirs): Merge pull request #3764 from mattsc/ai_todos https://github.com/wesnoth/wesnoth/commit/cb3049681bb8538f1ad9d1adf9dac5657b722382 20181218 14:49:06-!- TheJJ [~rofl@ipbcc0f8dd.dynamic.kabel-deutschland.de] has quit [Ping timeout: 250 seconds] 20181218 14:59:06-!- LovCAPONE [~LovCAPONE@23.237.104.26] has joined #wesnoth-dev 20181218 15:01:02<+wesdiscordbot> Ah, crap, stupid web interface! 20181218 15:01:39<+wesdiscordbot> Sorry for that, I'll delete that branch later ... 20181218 15:06:07<+wesdiscordbot> (once I figure out that merge conflict I'm having and then how to delete a branch on the main repository) 20181218 15:07:09<+wesdiscordbot> For the second part, see https://stackoverflow.com/a/2003515 20181218 15:08:38<+wesdiscordbot> @jyrkive Thanks. I even have that in my own notes somewhere. I just don't do it often enough that I know it without looking it up. 20181218 15:26:09< irker047> wesnoth/wesnoth:master mattsc cb3049681b Merge pull request #3764 from mattsc/ai_ AppVeyor: vs2015/Release Failed 20181218 15:26:10< irker047> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21091857 20181218 15:32:39< irker047> wesnoth: mattsc wesnoth:1.14 8beece659b5d / src/game_initialization/ (connect_engine.cpp connect_engine.hpp multiplayer.cpp): Command-line game: get default ai_algorithm from config https://github.com/wesnoth/wesnoth/commit/8beece659b5dbef5cf9849c32873f4c991bfeb78 20181218 15:32:41< irker047> wesnoth: mattsc wesnoth:1.14 a96487a8377a / data/_main.cfg src/ai/configuration.cpp src/ai/configuration.hpp: AI: move default algorithm definition from C++ to WML https://github.com/wesnoth/wesnoth/commit/a96487a8377ae4380893a4ad848573921ea984c6 20181218 15:32:43< irker047> wesnoth: mattsc wesnoth:1.14 a2c30ea66569 / / (7 files in 3 dirs): AI configuration: new optional parameter mp_rank= https://github.com/wesnoth/wesnoth/commit/a2c30ea665695d6710a5641ac374d93d94423ad8 20181218 15:32:45< irker047> wesnoth: mattsc wesnoth:1.14 650a78060322 / src/ai/configuration.cpp: AI configuration: add mp_rank to non-aspect attributes list https://github.com/wesnoth/wesnoth/commit/650a78060322a48e72f7cbb9e57ac75e3dd27d0f 20181218 15:32:47< irker047> wesnoth: mattsc wesnoth:1.14 4d43b218ee1a / / (6 files in 3 dirs): AI configuration: invert mp_rank based ordering https://github.com/wesnoth/wesnoth/commit/4d43b218ee1ac640c5f20a1e729436f71fc98466 20181218 15:32:49< irker047> wesnoth: mattsc wesnoth:1.14 7bb65f4510b8 / src/ai/default/ca.cpp: AI leader_shares_keep CA: re-evaluate possible_moves after move https://github.com/wesnoth/wesnoth/commit/7bb65f4510b86b4fc7ff66352c399f7a281363c8 20181218 15:33:52<+wesdiscordbot> @sevu That ^ backports the default_ai_algorithm and mp_rank changes to 1.14. 20181218 15:34:35-!- travis-ci [~travis-ci@ec2-54-92-168-183.compute-1.amazonaws.com] has joined #wesnoth-dev 20181218 15:34:36<+wesdiscordbot> I also added the "full" fix for the leader_shares_keep CA when an AI side has multiple leaders. 20181218 15:34:36< travis-ci> wesnoth/wesnoth#20441 (14 - cb30496 : mattsc): The build passed. 20181218 15:34:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/469554385 20181218 15:34:37-!- travis-ci [~travis-ci@ec2-54-92-168-183.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181218 15:35:13<+wesdiscordbot> I think that is all that needed to be backported. Let me know if I forgot something. 20181218 15:43:43<+wesdiscordbot> Still need to do changelogs; and some of this needs to be added on the wiki as well. 20181218 16:00:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181218 16:17:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181218 16:30:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181218 16:43:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181218 16:50:25< irker047> wesnoth: mattsc wesnoth:master f0a5ad0a824d / changelog.md: Update changelog with AI changes https://github.com/wesnoth/wesnoth/commit/f0a5ad0a824d9cc2b0c808ac31b199c37f1b485a 20181218 16:51:12< irker047> wesnoth: mattsc wesnoth:1.14 83245774c00d / changelog.md: Update changelog with AI changes https://github.com/wesnoth/wesnoth/commit/83245774c00dc09dec1998ddda874861dd0918bf 20181218 17:00:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181218 17:03:51-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181218 17:15:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181218 17:43:44-!- LovCAPONE [~LovCAPONE@23.237.104.26] has quit [Ping timeout: 250 seconds] 20181218 17:44:16-!- LovCAPONE [~LovCAPONE@modemcable067.100-22-96.mc.videotron.ca] has joined #wesnoth-dev 20181218 17:47:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181218 18:23:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181218 19:41:20-!- LovCAPONE [~LovCAPONE@modemcable067.100-22-96.mc.videotron.ca] has quit [Read error: Connection reset by peer] 20181218 19:41:38-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has joined #wesnoth-dev 20181218 19:52:04-!- irker047 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181218 20:12:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20181218 20:26:15-!- irker542 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181218 20:26:15< irker542> wesnoth/wesnoth:master mattsc cb3049681b Merge pull request #3764 from mattsc/ai_ AppVeyor: 2/6 builds failed 20181218 20:26:15< irker542> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21091857 20181218 20:26:15< irker542> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21092999 20181218 21:10:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181218 21:11:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181218 21:12:25-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has quit [Quit: Life is like a void pointer: you never know what you're going to get...] 20181218 21:13:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181218 21:14:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181218 23:00:36-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181218 23:26:50-!- irker542 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] --- Log closed Wed Dec 19 00:00:54 2018