--- Log opened Thu Dec 20 00:00:17 2018 20181220 01:00:04-!- celmin|away is now known as celticminstrel 20181220 01:09:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181220 01:29:10-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181220 01:31:09<+wesdiscordbot> if i want to compile c++ unit tests, all i have to do is scons test or not? Or is this outdated? 20181220 01:33:45< celticminstrel> That sounds right, I think. 20181220 01:34:08<+wesdiscordbot> scons boost_unit_tests 20181220 01:34:47<+wesdiscordbot> @Pentarctagon that works tanks 20181220 01:35:05< celticminstrel> (You sure "scons tests" or "scons test" doesn't also work? Only because I'm pretty sure the output executable is called one of those.) 20181220 01:35:25<+wesdiscordbot> nope scons dont know how to build test or tests 20181220 01:35:34< celticminstrel> I see. Oh well. 20181220 01:35:46<+wesdiscordbot> the output executable is also called boost_unit_tests 20181220 01:36:15<+wesdiscordbot> sounds like it was renamed at some point though 20181220 01:36:31<+wesdiscordbot> https://wiki.wesnoth.org/SoftwareTesting#C.2B.2B_unit_tests_.28game_engine_and_API.29 is then outdated 20181220 01:47:57<+wesdiscordbot> It seems i get a lot of config errors when i run the tests: error config: Error while loading the map: Unknown tile in map: (Gg) 'Gg' error config: Error while loading the map: Unknown tile in map: (Gg) 'Gg' error config: Error while loading the map: Unknown tile in map: (Gg) 'Gg' error config: Error while loading the map: Unknown tile in map: (Gg) 'Gg' error config: Error while loading the map: Unknown tile in map: 20181220 01:47:58<+wesdiscordbot> (Gg) 'Gg' error config: Error while loading the map: Unknown tile in map: (Gg) 'Gg' error config: Error while loading the map: Unknown tile in map: (Gg) 'Gg' error config: Error while loading the map: Unknown tile in map: (Gg) 'Gg' warning network: poll Rethrowing: asio.netdb:1 warning network: poll Rethrowing: asio.netdb:1 warning network: poll Rethrowing: asio.netdb:1 warning network: poll Rethrowing: asio.netdb:1 warning 20181220 01:47:58<+wesdiscordbot> network: poll Rethrowing: asio.netdb:1 warning network: poll Rethrowing: asio.netdb:1 warning network: poll Rethrowing: asio.netdb:1 warning network: poll Rethrowing: asio.netdb:1 20181220 03:50:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20181220 04:46:33-!- celticminstrel is now known as celmin|sleep 20181220 05:03:29<+wesdiscordbot> @Nostromus Yes, it's known that the unit tests print errors to the log. 20181220 05:03:44<+wesdiscordbot> We don't really care about it. The tests themselves pass. 20181220 07:47:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 20181220 08:08:56-!- valdar [~atarocch@93.56.172.28] has quit [Ping timeout: 272 seconds] 20181220 08:14:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181220 09:29:46<+wesdiscordbot> yes i figured it out how i run only a subset of tests and get a report. For me it was not obvious that all tests passes. But in general i am not a big fan of too many print errors without declaring a explicit log level. 20181220 09:33:00<+wesdiscordbot> Errors and warnings are printed by default, which is a reasonable default IMO. 20181220 09:33:53<+wesdiscordbot> WML unit tests run with strict logging (they fail if they end up causing an error or warning to be logged), so at least we discover some log spam that way. 20181220 09:34:32<+wesdiscordbot> (1.14 has one WML unit test that calls a deprecated function on purpose... I had to disable strict logging for that one, but all others do have it enabled.) 20181220 09:37:28<+wesdiscordbot> fwiw I added extra echo statements to the travis tests because I couldn't tell what counted as a failure or not. 20181220 09:37:41<+wesdiscordbot> you're right about errors and warnings. Just thought about normal log messages, but these are all warnings and errors. I wrote print errors, but thought about debug messages. 20181220 09:56:30-!- irker735 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181220 09:56:30< irker735> wesnoth: josteph wesnoth:master 21bf4557c490 / src/reports.cpp: Sidebar: Combine the type advancements and mod advancements https://github.com/wesnoth/wesnoth/commit/21bf4557c490ee163b58312b9d000d0b1e01f572 20181220 09:56:50< irker735> wesnoth: josteph wesnoth:1.14 5692a62bb798 / src/reports.cpp: Sidebar: Combine the type advancements and mod advancements https://github.com/wesnoth/wesnoth/commit/5692a62bb798d233d39b912665aa9231cd093bb2 20181220 10:21:12-!- valdar [atarocch@nat/redhat/x-xbxzbyssfjdzdcpt] has joined #wesnoth-dev 20181220 11:08:53< irker735> wesnoth/wesnoth:master nemaara 9d853718fe Minor bugfixes AppVeyor: All builds passed 20181220 11:24:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20181220 13:35:04-!- celmin|sleep is now known as celmin}away 20181220 13:53:22< irker735> wesnoth/wesnoth:1.14 josteph 5692a62bb7 Sidebar: Combine the type advancements a AppVeyor: vs2017/Release Failed 20181220 13:53:23< irker735> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21143322 20181220 15:08:19-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has joined #wesnoth-dev 20181220 15:08:56-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has quit [Client Quit] 20181220 15:09:15-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has joined #wesnoth-dev 20181220 15:46:00-!- valdar [atarocch@nat/redhat/x-xbxzbyssfjdzdcpt] has quit [Remote host closed the connection] 20181220 16:10:21< irker735> wesnoth/wesnoth:master josteph 21bf4557c4 Sidebar: Combine the type advancements a AppVeyor: All builds passed 20181220 17:38:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181220 18:20:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181220 18:28:44-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has quit [Quit: Life is like a void pointer: you never know what you're going to get...] 20181220 18:53:22< irker735> wesnoth/wesnoth:1.14 josteph 5692a62bb7 Sidebar: Combine the type advancements a AppVeyor: 1/4 builds failed 20181220 18:53:23< irker735> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21143322 20181220 20:29:29-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20181220 22:04:15-!- irker735 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181220 23:03:26-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20181220 23:04:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181220 23:06:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds] 20181220 23:06:35-!- wedge010 is now known as wedge009 20181220 23:10:35-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181220 23:18:35-!- irker881 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181220 23:18:35< irker881> wesnoth/wesnoth:1.14 mattsc 35624d0557 MP load game: do not overwrite saved AI AppVeyor: All builds passed --- Log closed Fri Dec 21 00:00:18 2018