--- Log opened Sun Dec 23 00:00:22 2018 20181223 00:32:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181223 00:48:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20181223 00:49:34-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181223 01:14:38-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181223 05:15:24-!- celticminstrel is now known as celmin|sleep 20181223 08:51:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181223 09:17:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181223 10:44:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181223 13:25:19-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev 20181223 13:54:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181223 13:56:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20181223 14:43:25-!- celmin|sleep is now known as celticminstrel 20181223 15:32:17-!- lipkab [~lipk@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 246 seconds] 20181223 15:37:18-!- irker858 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181223 15:37:18< irker858> wesnoth: newfrenchy83 wesnoth:master 4bb1b4a8e44c / src/ (actions/attack.cpp actions/attack.hpp ai/default/aspect_attacks.cpp): resolve problem of negative value for leadership (#3774) https://github.com/wesnoth/wesnoth/commit/4bb1b4a8e44cc4bfe5d5648b22b124a2a35997c7 20181223 16:30:15<+wesdiscordbot> any opinions on https://github.com/wesnoth/wesnoth/issues/3782 ? 20181223 16:42:39< irker858> wesnoth: jostephd wesnoth:master 6a96b788accf / / (3 files in 2 dirs): Recruit Unit: Add search functionality (#3787) https://github.com/wesnoth/wesnoth/commit/6a96b788accfcdcfe3d0d84d203e74316ff07bbe 20181223 16:44:54< irker858> wesnoth: jostephd wesnoth:1.14 eb06929e222d / / (3 files in 2 dirs): Recruit Unit: Add search functionality (#3787) https://github.com/wesnoth/wesnoth/commit/eb06929e222dbebe499412a0e5406e958187fe86 20181223 16:45:43< irker858> wesnoth: josteph wesnoth:1.14 0402640d0387 / changelog.md: Update changelog for #3787 https://github.com/wesnoth/wesnoth/commit/0402640d038781ed33dfcbf6265e3fb12f64cc63 20181223 17:18:17-!- TheJJ [~rofl@ipbcc1ab7a.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181223 17:28:33< Ravana> I see recruit list was merged, compiling it now 20181223 17:34:45-!- higgins [~higgins@68.ip-149-56-14.net] has quit [Ping timeout: 252 seconds] 20181223 17:51:45<+wesdiscordbot> have fun 20181223 18:05:19-!- TheJJ [~rofl@ipbcc1ab7a.dynamic.kabel-deutschland.de] has quit [Quit: løl] 20181223 18:19:22< celticminstrel> (Can I just let josteph deal with newfrenchy from now on... >_> ) 20181223 18:23:04<+wesdiscordbot> I'd appreciate some help, with the actual reviewing of changes part if nothing else 20181223 18:23:42<+wesdiscordbot> sometimes he works on parts of the C++ that I don't know well enough myself 20181223 18:43:49< celticminstrel> Sure. 20181223 18:45:23<+wesdiscordbot> 😃 20181223 18:47:23-!- TheJJ [~rofl@ipbcc1ab7a.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20181223 18:50:15-!- higgins [~higgins@68.ip-149-56-14.net] has joined #wesnoth-dev 20181223 19:01:58< irker858> wesnoth: Severin Glöckner wesnoth:1.14 2e0cdfd4500b / doc/man/ (wesnoth.6 wesnothd.6): manpages: no need for a dot here https://github.com/wesnoth/wesnoth/commit/2e0cdfd4500b2823f9b82c00c3eceaee7a643177 20181223 19:02:00< irker858> wesnoth: Severin Glöckner wesnoth:1.14 e6d3b7f30c6d / packaging/wesnoth.appdata.xml: Appdata: the tools accept the email in this form too https://github.com/wesnoth/wesnoth/commit/e6d3b7f30c6d125865b7e0e32adca5198ea65c73 20181223 19:02:02< irker858> wesnoth: Severin Glöckner wesnoth:1.14 79bd8b524167 / packaging/systemd/ (wesnothd.service.in wesnothd.tmpfiles.conf.in): systemd: add more options https://github.com/wesnoth/wesnoth/commit/79bd8b52416769c0b518883c3bfdd7733ea0974c 20181223 19:04:31< irker858> wesnoth: Severin Glöckner wesnoth:1.10 218a84f529d7 / doc/man/ (53 files in 28 dirs): manpages: remove dot https://github.com/wesnoth/wesnoth/commit/218a84f529d7a71d8e213425e341e22c15650cd7 20181223 19:05:04-!- sevu [~sevu@public-gprs408737.centertel.pl] has joined #wesnoth-dev 20181223 19:06:04< irker858> wesnoth: Severin Glöckner wesnoth:1.8 b3d6f5c0cdf2 / doc/man/ (46 files in 23 dirs): wesnoth_editor's manpage doesn't exist anymore https://github.com/wesnoth/wesnoth/commit/b3d6f5c0cdf2da4b8b3974ceea4cd0ab69129965 20181223 19:06:45< irker858> wesnoth: Severin Glöckner wesnoth:1.6 46c97d53d464 / cmake/FindFriBiDi.cmake src/font.cpp: reenable fribidi (for cmake only) https://github.com/wesnoth/wesnoth/commit/46c97d53d464308f32ff4a5f1529f8e933cfcb3b 20181223 19:06:47< irker858> wesnoth: Severin Glöckner wesnoth:1.6 908b81782710 / doc/man/ (38 files in 20 dirs): remove reference to removed manpage https://github.com/wesnoth/wesnoth/commit/908b817827109da11eda2bc67490a5f4ae367289 20181223 19:07:11<+wesdiscordbot> wow 20181223 19:08:30< irker858> wesnoth: Severin Glöckner wesnoth:1.4 746c060d2db0 / po/wesnoth-tb/.gitignore: add missing gitignore https://github.com/wesnoth/wesnoth/commit/746c060d2db020541502fee72d6077a09cd233cc 20181223 19:08:32< irker858> wesnoth: Severin Glöckner wesnoth:1.4 3cc8ddb5a262 / configure.ac: use pkg-config instead freetype-config https://github.com/wesnoth/wesnoth/commit/3cc8ddb5a262f5eede55ffe8b7a994032f6f95db 20181223 19:15:27<+wesdiscordbot> I managed to compile every series sinde 1.0 … and thought I could push some things upstream. 20181223 19:15:39-!- sevu [~sevu@public-gprs408737.centertel.pl] has quit [Remote host closed the connection] 20181223 19:18:09<+wesdiscordbot> @josteph I can implement a fix for 3782 20181223 19:20:36<+wesdiscordbot> @Yumi could you update the changelog entry for TSG – the one I added is somewhat outdated 20181223 19:21:37<+wesdiscordbot> in changelog.md, right? 20181223 19:22:15<+wesdiscordbot> yes 20181223 19:22:31<+wesdiscordbot> I think pentarctagon added a line for me before 20181223 19:22:59<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/526479848601026580/unknown.png 20181223 19:23:31<+wesdiscordbot> it would be possible for me to make something more detailed than that, but it would take up a lot of space 20181223 19:25:54<+wesdiscordbot> Ah, I see. No need to mention all kind of things. I wonder though if this is not understating the changes. Guess it's okay 20181223 19:26:39<+wesdiscordbot> also do you think you can close the two remaining issues related to TSG? 20181223 19:27:08<+wesdiscordbot> I think the rework addresses both of them except for the "enemy unit sighted" thing that you mentioned 20181223 19:27:35<+wesdiscordbot> the enemy unit sighted was just an idea, where Idon't know if it works 20181223 19:28:07<+wesdiscordbot> I can try to write something slightly more detailed than the one line in the changelog 🤔 20181223 19:28:23<+wesdiscordbot> okay, I tried to implement your ideas for the sighted thing and it didn't work 20181223 19:28:31<+wesdiscordbot> 😄 20181223 19:28:37<+wesdiscordbot> but it only remains for like 1s 20181223 19:28:40<+wesdiscordbot> so I didn't think it was a problem 20181223 19:28:51<+wesdiscordbot> I think that's fine 😃 20181223 19:29:29<+wesdiscordbot> Can be a oneliner too, maybe reworked all scenarios or sth. 20181223 19:30:44<+wesdiscordbot> For the S2 issue, the problem was not that one could win without moving deoran to the city, but that it was more attractive to go to after the bandits than for saving the city. Does that fit your changes? 20181223 19:35:00<+wesdiscordbot> And one thing which I didn't look for in the PR: As far as I understood S6a does still exist (for not breaking old S5 saves), but with new ones you jump from S5 to S7a? Does the travel path on the map in the [story] part fit this? 20181223 19:37:41<+wesdiscordbot> S2, you're now forced to make deoran move to the city 20181223 19:37:56<+wesdiscordbot> you literally can't finish the scenario in time if you try to go after the bandits 20181223 19:38:04<+wesdiscordbot> without moving to the city 20181223 19:38:43<+wesdiscordbot> I did update the travel path in [story] but actually S6a and S7a used to be where they split 20181223 19:38:51<+wesdiscordbot> so the path for S8a and S6a were pretty much the same 20181223 19:38:58<+wesdiscordbot> so just removing S6a without changing the travel path is fine 20181223 19:39:47<+wesdiscordbot> okay 20181223 19:42:19<+wesdiscordbot> I did end up changing it for S8a and S9a though, just to move it a bit more northward in S8a 20181223 19:52:28<+wesdiscordbot> Great. What about in S5: Is the bandit leader being able before sighting him still a theoretical problem? (which in practice didn't occur?) 20181223 19:52:58<+wesdiscordbot> (That shouldn't keep me from closing the issue though) 20181223 19:54:44<+wesdiscordbot> Only other thing on the list is that it was pretty useles that the Lich did send 3 units or so after sighting 20181223 20:03:53<+wesdiscordbot> the bandit leader shouldn't die before you sight him, I think 20181223 20:04:12<+wesdiscordbot> not 100% sure, I tried to mitigate it by giving the lich extra gold only after you sight the bandits 20181223 20:04:22<+wesdiscordbot> but it will still send units because of income 20181223 20:04:29<+wesdiscordbot> when you sight the lich he also gets more gold 20181223 20:06:48<+wesdiscordbot> @Yumi Great! 20181223 20:07:12< irker858> wesnoth: Severin Glöckner wesnoth:1.12 4b27834e482c / src/ (ai/lua/core.cpp lua/lbaselib.cpp scripting/lua.cpp): incomplete lua backport https://github.com/wesnoth/wesnoth/commit/4b27834e482c2218db68b7cd3f1a4ce25e701928 20181223 20:07:14< irker858> wesnoth: Severin Glöckner wesnoth:1.12 a9b0321d2ef9 / doc/man/ (52 files in 28 dirs): manpages: remove dot https://github.com/wesnoth/wesnoth/commit/a9b0321d2ef97d3a77379edfea3ea5a091045c25 20181223 20:10:43< irker858> wesnoth: Severin Glöckner wesnoth:1.12 eabce7e4e81c / src/ (ai/lua/core.cpp lua/lbaselib.cpp scripting/lua.cpp): Revert "incomplete lua backport" https://github.com/wesnoth/wesnoth/commit/eabce7e4e81c79ded88fea75ea1e4b1f7d2d599d 20181223 20:11:41<+wesdiscordbot> Okay. So, everything regaring TSG is fixed. Cool thing, thanks @Yumi 20181223 20:12:13-!- travis-ci [~travis-ci@ec2-54-196-143-88.compute-1.amazonaws.com] has joined #wesnoth-dev 20181223 20:12:14< travis-ci> wesnoth/wesnoth#20461 (1.12 - a9b0321 : Severin Glöckner): The build was broken. 20181223 20:12:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/471671211 20181223 20:12:14-!- travis-ci [~travis-ci@ec2-54-196-143-88.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181223 20:15:37<+wesdiscordbot> mhmm 20181223 20:21:59<+wesdiscordbot> Your branch is behind 'upstream/master' by 107 commits 😯 20181223 20:23:02<+wesdiscordbot> Ah, the TSG merge 20181223 20:24:21< irker858> wesnoth: Severin Glöckner wesnoth:master 03a01f27be38 / packaging/wesnoth.appdata.xml: Appdata: the tools accept the email in this form too https://github.com/wesnoth/wesnoth/commit/03a01f27be381c5ff99399d012546da3819500c9 20181223 20:24:23< irker858> wesnoth: Severin Glöckner wesnoth:master 62a1a1bdc658 / packaging/systemd/ (wesnothd.service.in wesnothd.tmpfiles.conf.in): systemd: add more options https://github.com/wesnoth/wesnoth/commit/62a1a1bdc658d43af8d1f212b22837984a32e78d 20181223 20:24:25< irker858> wesnoth: Severin Glöckner wesnoth:master 404d49534f92 / doc/man/ (wesnoth.6 wesnothd.6): manpages: no need for a dot here https://github.com/wesnoth/wesnoth/commit/404d49534f9263ae3267401ccae0bf35d1e6bc24 20181223 20:34:11<+wesdiscordbot> Btw, how does halric go @Bitron @Vultraz 20181223 20:37:17<+wesdiscordbot> haldric is currently on hold, since everyone is quite busy atm and also we are waiting for Godot 3.1 which will come with some features we definitely need for haldric. 20181223 20:38:01<+wesdiscordbot> I definitely plan to continue my work on it early next year though. 20181223 20:38:36<+wesdiscordbot> I see. The last screenshot you showed me looked quite far progressed 20181223 20:38:41<+wesdiscordbot> C# is also probably still not ready for use 😦 20181223 20:43:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181223 20:44:30<+wesdiscordbot> I think we'd do just fine with GDScript, really. It's a breeze to pick it up and will always work best with godot, as it is the main supported language. 20181223 21:17:39< irker858> wesnoth: mattsc wesnoth:1.14 9c61a230567b / / (4 files in 3 dirs): MP load game: do not overwrite saved AI https://github.com/wesnoth/wesnoth/commit/9c61a230567b134d64045ffa1da4ac82ea1ecb8c 20181223 21:20:03< irker858> wesnoth: mattsc wesnoth:master ac1e3e6120dc / / (4 files in 3 dirs): MP load game: do not overwrite saved AI https://github.com/wesnoth/wesnoth/commit/ac1e3e6120dcec3eab5216a0dce1811d4c5c4b85 20181223 21:51:17-!- travis-ci [~travis-ci@ec2-34-226-245-35.compute-1.amazonaws.com] has joined #wesnoth-dev 20181223 21:51:18< travis-ci> wesnoth/wesnoth#20464 (master - ac1e3e6 : mattsc): The build was broken. 20181223 21:51:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/471685761 20181223 21:51:18-!- travis-ci [~travis-ci@ec2-34-226-245-35.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181223 21:55:32< mattsc> Whut? It said that all builds passed while this was in the PR … 20181223 21:56:11<+wesdiscordbot> https://travis-ci.org/wesnoth/wesnoth/jobs/471685767#L1380 20181223 21:58:35< mattsc> Yes, I can see that. But it did not complain about this previously (when this commit was sitting in a PR for several days). Furthermore, it is used just like that (only inverted) a few lines before and after inside the same function. 20181223 21:58:41< mattsc> Unless I am missing something ... 20181223 22:07:30<+wesdiscordbot> It's not used "just like that" elsewhere in the same function. 20181223 22:07:32<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/ac1e3e6120dcec3eab5216a0dce1811d4c5c4b85/src/game_initialization/connect_engine.cpp#L1087 20181223 22:08:33<+wesdiscordbot> Quick check shows that saved_game is a boolean in 1.14, but not in master. 20181223 22:11:19<+wesdiscordbot> @sevu ^ wrote a couple lines in the changelog now for tsg 20181223 22:11:24<+wesdiscordbot> Oh, crap ... Yes, I missed that. And it explains why the PR passed, because that was against 1.14. 20181223 22:11:49<+wesdiscordbot> And then I cherry-picked to master. Thanks @jyrkive 20181223 22:16:52-!- gfgtdf [~Daniel@x4d037a93.dyn.telefonica.de] has joined #wesnoth-dev 20181223 22:17:40< mattsc> I should really stop messing with the C++ code … :P 20181223 22:17:55< mattsc> Or the AI, while we’re at it, or any part of Wesnoth. :D 20181223 22:18:19<+wesdiscordbot> Eh, I might well have made the same mistake. 20181223 22:19:48< mattsc> But you would have actually known (did know) what to do about it… 20181223 22:19:52< mattsc> Anyways. 20181223 22:27:05< irker858> wesnoth: mattsc wesnoth:master 9002751a2938 / src/game_initialization/connect_engine.cpp: MP saved game check: fix type mismatch introduced in ac1e3e6 https://github.com/wesnoth/wesnoth/commit/9002751a293899861ed5e1f4fb5fd934ca964b22 20181223 22:34:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds] 20181223 22:40:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181223 22:51:50< irker858> wesnoth/wesnoth:master newfrenchy83 ed03bc0dd5 resolve conflict AppVeyor: All builds passed 20181223 22:55:06-!- travis-ci [~travis-ci@ec2-34-226-245-35.compute-1.amazonaws.com] has joined #wesnoth-dev 20181223 22:55:07< travis-ci> wesnoth/wesnoth#20466 (master - 9002751 : mattsc): The build was fixed. 20181223 22:55:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/471699097 20181223 22:55:07-!- travis-ci [~travis-ci@ec2-34-226-245-35.compute-1.amazonaws.com] has left #wesnoth-dev [] 20181223 23:57:52< irker858> wesnoth/wesnoth:master nemaara 6f6a0d664e Updated TSG changelog notes for 1.14.5+d AppVeyor: vs2017/Release Failed 20181223 23:57:53< irker858> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21206886 --- Log closed Mon Dec 24 00:00:24 2018