--- Log opened Sun Dec 30 00:00:11 2018 20181230 00:09:57<+wesdiscordbot> maybe try https://forums.wesnoth.org/viewtopic.php?f=4&t=48666#p632637 ? 20181230 00:13:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20181230 00:13:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181230 00:29:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181230 01:00:22<+wesdiscordbot> hi is the replay tool broken atm? I can't load a simple local multiplayer replay with 1-2 turns? 20181230 01:01:03<+wesdiscordbot> Caught general 'N4utf822invalid_utf8_exceptionE' exception: std::exception 20181230 01:42:45< irker538> wesnoth/wesnoth:1.14 jostephd 2ac132f608 Help: Document campaign 'level' and 'dif AppVeyor: All builds passed 20181230 02:04:01< celticminstrel> ... 20181230 02:04:57< celticminstrel> Should we make a rule that issues need to be in English... 20181230 02:05:53<+wesdiscordbot> you really want to kill online in discord? 20181230 02:06:01< celticminstrel> ??? 20181230 02:07:31<+wesdiscordbot> or git. I can leave if you want, Ak72ti is iam, i just sad, because you make this rule, because moderators do not allow russian room in discord. it is just racism. 20181230 02:08:06<+wesdiscordbot> I cannot speak english normally, its just broke my mind. 20181230 02:08:49< celticminstrel> No, I have no problem with having a russian room on Discord. 20181230 02:10:29< celticminstrel> ...huh? Why does the issue not exist? 20181230 02:11:05< celticminstrel> Did GitHub itself delete it for some reason? o.O AFAIK there's no way for repo authors to delete issues...? 20181230 02:13:04< celticminstrel> :S 20181230 02:13:08 * celticminstrel is confused. 20181230 02:13:31<+wesdiscordbot> i think needed sent it from another account, there we have copyright problems with SS13 server... So, wait a 5 min. 20181230 02:13:42< celticminstrel> ... 20181230 02:13:51< celticminstrel> Okay? 20181230 02:13:58<+wesdiscordbot> We resolve this problems later, but issue need to be posted how. 20181230 02:48:02< celticminstrel> :/ 20181230 03:52:12< mattsc> celticminstrel: your commit from April: https://github.com/wesnoth/wesnoth/commit/99233339dd2b3897929ed21803e9fe9792ed73c0 20181230 03:52:27< mattsc> Is it documented somewhere how to use those custom flags? 20181230 03:54:00< mattsc> I guess the commit that’s actually in master is this one: https://github.com/wesnoth/wesnoth/commit/533040527498bce7db352fb267a9da55c5b17dbb 20181230 03:54:12< mattsc> Same content as the previous one though. 20181230 03:54:57< celticminstrel> Doesn't look like it? The calculate key is the same as passing a cost function. 20181230 03:55:33< celticminstrel> I don't see other new flags in that commit. 20181230 03:56:31< mattsc> I’m specifically interested if this lets me use teleports/tunnels when using a custom cost function. 20181230 03:56:33< celticminstrel> Basically, find_path(x1, y1, x2, y2, {calculate = fcn}) is identical to find_path(x1, y1, x2, y2, fcn) assuming fcn is indeed a function. 20181230 03:56:36< mattsc> And if so, how. 20181230 03:57:01< celticminstrel> And since that's a table, you can also add any other supported flags, like ignore_teleport=true for example. 20181230 03:57:16< mattsc> Hmm, Is see. 20181230 03:57:28< mattsc> And what does that new line 1677 do? 20181230 03:59:05< celticminstrel> If I recall/understand correctly, it means find_path(x1, y1, x2, y2, fcn, true) is equivalent to find_path(x1, y1, x2, y2, {calculate = fcn, ignore_teleport = true}) 20181230 03:59:27< mattsc> Okay. Nice. 20181230 03:59:35< celticminstrel> If I correctly understand what you're interested in, I don't think there's any obvious way? 20181230 04:00:08< mattsc> Actually, if I understand correctly, then this does let me do what I want to do. 20181230 04:00:14< celticminstrel> Really? Okay then. 20181230 04:00:34< mattsc> I need a way of having teleports/tunnels taken into account when using custom cost functions. 20181230 04:00:38< celticminstrel> It might depend on exactly how the custom cost function is used... 20181230 04:00:48< mattsc> Hmm. 20181230 04:01:23< mattsc> As long as entry and exit of a tunnel count as adjacent hexes, I think that’s okay. 20181230 04:02:08< mattsc> In any case, I’ll set up a test case and try this sometime in the next couple days. 20181230 04:02:17< mattsc> I’ll let you know. 20181230 04:02:21< irker538> wesnoth/wesnoth:1.14 Steve Cotton d5819683e2 Tutorial S2: "choose who gets the 16xp" AppVeyor: All builds passed 20181230 04:21:54< mattsc> celticminstrel: Did a really quick and dirty test in my AI test scenario and I think this is going to work for what is needed for the Goto MAI. 20181230 04:45:06< mattsc> Hmm, there is one inconsistency though: 20181230 04:45:43< mattsc> If calculate= is used, ignore_teleport defaults to no. When the custom cost function is used as 4th argument, it defaults to yes. 20181230 04:47:06< celticminstrel> Well, in that case passing false as the fifth argument should reverse the default. 20181230 04:49:13< mattsc> Yes, it does. But it doesn’t make sense that the two defaults are different. 20181230 04:51:06< mattsc> So said line 1677 should be changed that it returns ‘false’ if the argument is missing. 20181230 04:51:18< mattsc> *so that 20181230 04:51:52< celticminstrel> I don't think it matters too much though. IMO passing the function directly should be treated as a deprecated mode. 20181230 04:52:12< mattsc> That’s fine. 20181230 04:52:21< mattsc> In that case we should remove that extra argument. 20181230 04:52:22< celticminstrel> I don't remember why I even added the fifth argument, but its default was probably to maintain the same behaviour for compatibility purposes. 20181230 04:53:02< celticminstrel> I don't mind removing the fifth argument as long as we make sure it isn't used anywhere in master (I don't expect it would be but we should make sure first). 20181230 04:53:05< mattsc> Okay, that makes sense. But I think the previous behavior should be considered a bug. 20181230 04:53:43< mattsc> Sure, I can do that. 20181230 04:53:54< mattsc> Checking, I mean. 20181230 04:54:11< mattsc> Since it’s not been documented yet, it is extremely unlikely that it is used anywhere. 20181230 04:55:27< celticminstrel> Indeed. 20181230 04:56:01< celticminstrel> Maybe the fifth argument was revision 1 and the calculate key was revision 2 and I just didn't bother reverting the former before committing the latter. >_> 20181230 04:58:18< mattsc> Maybe. Whatever the reason, I’d say let’s remove it and deprecate the custom cost function as 4th argument. 20181230 05:01:17< celticminstrel> 'kay 20181230 05:02:34< celticminstrel> Note: The deprecation message should refer to it as the "last" argument rather than 4th, as it should be possible to call find_path(loc1, loc2, cost_fcn) where loc1 and loc2 are tables of the form returned by get_locations for example. 20181230 05:03:00< celticminstrel> (It should also be possible to pass a unit object as the location.) 20181230 05:03:40< celticminstrel> (Oh, I guess we've already been getting the indices wrong anyway unless you were envisioning starting from 0... >_> ) 20181230 05:05:11< mattsc> Nah, I usually use (unit, x, y, fcn), so it’s the fourth in that case. ;) 20181230 05:05:29< mattsc> Anyways, okay. 20181230 05:05:48< celticminstrel> Ah. 20181230 05:06:05< celticminstrel> Still good reason for the message to refer to it as "last" though. 20181230 05:06:17< mattsc> Right. 20181230 05:39:44-!- gfgtdf [~androirc@x4d00748a.dyn.telefonica.de] has joined #wesnoth-dev 20181230 05:41:01-!- gfgtdf [~androirc@x4d00748a.dyn.telefonica.de] has quit [Client Quit] 20181230 07:03:11-!- irker538 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181230 07:47:51<+wesdiscordbot> What are you people doing, it’s supposed to be the holidays o.o 20181230 08:23:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181230 09:02:12< zookeeper> @Ravana which works if you know the page it was originally on, and you know it has been deleted from it for some reason, etc. not very intuitive or handy. 20181230 09:58:24< vn971> @Pentarctagon: this solves the high CPU usage problem indeed: OMP_WAIT_POLICY=PASSIVE 20181230 09:58:50< vn971> is it possible that other players have this problem as well, but just don't know about it because they lack monitoring on that? 20181230 09:59:06< vn971> I mean, many others, not an insignificant number. 20181230 10:19:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181230 11:41:13<+wesdiscordbot> Ah, I wonder if that’s something else that got discarded 20181230 11:41:23<+wesdiscordbot> The openmp removal 20181230 12:06:29<+wesdiscordbot> @loonycyborg https://github.com/wesnoth/wesnoth/issues/3820 20181230 12:06:50<+wesdiscordbot> Is that the same kind of issue as the other russian one or is it different? 20181230 12:07:18<+wesdiscordbot> which other one? 20181230 12:07:41<+wesdiscordbot> @Konrad2 just one issue, but first one have problems with see 20181230 12:08:07<+wesdiscordbot> you can close first if you need. 20181230 12:08:10<+wesdiscordbot> That one. https://github.com/wesnoth/wesnoth/issues/3821 20181230 12:08:32<+wesdiscordbot> ^Its normal. 20181230 12:08:35<+wesdiscordbot> So far you translated only the second one, so no idea what the first one says. 😅 20181230 12:09:08<+wesdiscordbot> First one says same. So, we can remove first then? 20181230 12:10:31<+wesdiscordbot> but first issue has longer russian text, is it really the same? 20181230 12:11:01<+wesdiscordbot> He's the author, so if he says so..? 20181230 12:11:10<+wesdiscordbot> from different github accounts too 20181230 12:11:11<+wesdiscordbot> ah i remember sry 20181230 12:12:51<+wesdiscordbot> wow someone else translated it too already 20181230 12:13:59<+wesdiscordbot> @Immortal Viton If you think that the first issue says the same as the second issue, you can close it. Preferably while adding a comment 'duplicate'. 20181230 12:14:39<+wesdiscordbot> ok I'll translate the second one then 20181230 12:14:58<+wesdiscordbot> I can even edit it directly 20181230 12:15:06<+wesdiscordbot> @Konrad2 ok. sorry for it, again. 20181230 12:15:20<+wesdiscordbot> @Immortal Viton Sorry for what though? ._. 20181230 12:16:10<+wesdiscordbot> 2 issues from my community in same day.... 20181230 12:16:25<+wesdiscordbot> Sounds like you are invested in the game. 20181230 12:16:54<+wesdiscordbot> ;d 20181230 12:17:22<+wesdiscordbot> Just be sure that your issue doesn't raise any new/different points before closing it. ^^ 20181230 13:58:24< stikonas> loonycyborg: is there any ETA for 1.14.6? 20181230 13:58:53<+wesdiscordbot> @Vultraz ? 20181230 13:59:20< stikonas> (hopefully I'll be able to get core translations to 80% before that) 20181230 14:30:52-!- vn971 [~vasilii@ip-213-127-111-47.ip.prioritytelecom.net] has quit [Quit: Leaving.] 20181230 15:13:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181230 15:13:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181230 15:40:08-!- vn971 [~vasilii@2a02:a451:aaa9:1:c774:2d32:1da9:62e] has joined #wesnoth-dev 20181230 15:53:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181230 15:54:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181230 15:55:06-!- vn971 [~vasilii@2a02:a451:aaa9:1:c774:2d32:1da9:62e] has quit [Quit: Leaving.] 20181230 16:07:12-!- irker103 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181230 16:07:12< irker103> wesnoth/wesnoth:master equal-l2 0e0866df88 Note dependencies on OpenGL and GLEW in AppVeyor: All builds passed 20181230 16:40:29-!- vn971 [~vasilii@ip-213-127-111-47.ip.prioritytelecom.net] has joined #wesnoth-dev 20181230 16:53:30-!- gfgtdf [~Daniel@x4d00748a.dyn.telefonica.de] has joined #wesnoth-dev 20181230 17:37:05<+wesdiscordbot> should i learn to make a scenario before a campaign? 20181230 18:02:45<+wesdiscordbot> Definitely. After all a campaign is just a sequence of scenarios. 20181230 18:26:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181230 18:27:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181230 19:00:23<+wesdiscordbot> @Vultraz OpenMP enabled|disabled is no longer listed in the Features window, so I'd assume so. if it isn't, it definitely should be, at least based on everything I've heard. 20181230 19:07:20-!- irker103 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181230 19:44:05<+wesdiscordbot> also hopefully 1.14.6 is relatively soon. it's been a few months since 1.14.5, and there have been quite a few bugfixes in the mean time. 20181230 19:47:50-!- vn971 [~vasilii@ip-213-127-111-47.ip.prioritytelecom.net] has quit [Quit: Leaving.] 20181230 19:52:17< gfgtdf> @Nostromus this coudl be a problem in an addon that uses contains an invalid utf8 text. 20181230 20:07:36<+wesdiscordbot> @Bitron thk uuu 20181230 21:07:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20181230 21:08:57<+wesdiscordbot> @gfgtdf With option --noaddons after installing them too? 20181230 21:09:10-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181230 21:10:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181230 21:12:41<+wesdiscordbot> But you're probably right. The steam versions (with no addons) don't have this problem. Only my self-compiled (with addons) 20181230 21:15:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181230 21:15:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181230 21:22:52< gfgtdf> Nostromus: when exactly does the game crash ? 20181230 21:23:27< gfgtdf> Nostromus: mening, what is the pastr button you presses/clicked before it crashed? And what screen was shown before it crashed ? 20181230 21:23:30< gfgtdf> last* 20181230 21:25:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181230 21:27:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181230 21:29:18<+wesdiscordbot> steps i taken: 1. create local multiplayer game (no further changes) 2. save replay 3. Go to main menu and load replay. 4. During the phase of loading, After text "Starting game" appears . Wesnoth crashes. 20181230 21:30:42<+wesdiscordbot> I did a checkout 48bd45d7209 (same as steam) but error occurs with same replays (steam version works with same replays) 20181230 21:31:16<+wesdiscordbot> I'm on linux 20181230 21:38:59<+wesdiscordbot> could you upload the savefile here? 20181230 21:39:30<+wesdiscordbot> savefile is not important, but i can 20181230 21:40:13<+wesdiscordbot> i renamed .local, .cache and .config 20181230 21:40:23<+wesdiscordbot> the error disappears 20181230 21:41:11<+wesdiscordbot> so i downloaded a addon who corrupts my files, after this i can't load replays or savegame with replay options 20181230 21:41:44<+wesdiscordbot> dont know which addon, i downloaded all because testing creditsscreen bug 20181230 21:43:22< gfgtdf> gogle says you migth be able to find out using somethign like 'grep -axv '.*' *.cfg' in your addon directopry 20181230 21:43:41< gfgtdf> i don't really know the grep syntax though, but it shoudl be possibel 20181230 21:43:56<+wesdiscordbot> but if this is the case, we should make sure that downloading a addon have not such an impact. Some validating mechanism 20181230 21:45:22< gfgtdf> hmm yes but its hard to say which code exactly is effected, since you said it happens after 'starting game' i assume it is not a bug in the game load dialog. 20181230 21:46:26< gfgtdf> maybe we coudl also make the server run a simple utf validity check on the uploaded addons, to warn the authors. 20181230 21:46:36< gfgtdf> on uploadign i mean 20181230 21:49:26< gfgtdf> @Nostromus you said this is self compiled right= so maybe you can get a stacktrace of where the invalid_utf8_exception is thrown ? 20181230 21:49:56<+wesdiscordbot> yeah but that didnt help a lot 20181230 21:50:26<+wesdiscordbot> but i will 20181230 21:53:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20181230 21:56:50<+wesdiscordbot> #0 0x0000555555a6a7e0 in utf8::invalid_utf8_exception::invalid_utf8_exception() (this=0x55555a39edd0) at src/serialization/unicode_types.hpp:38 #1 0x0000555555a6a7a1 in ucs4_convert_impl::utf8_impl::byte_size_from_utf8_first(char) (ch=-96 '\240') at src/serialization/ucs4_convert_impl.hpp:54 #2 0x0000555555a69ad2 in ucs4_convert_impl::utf8_impl::read std::cxx11::basic_string, std::allocator > > >(gnu_cxx::__normal_iterator, std::allocator > >&, gnu_cxx::normal_iterator, std::allocator > > const&) (input=-96 '\240', end=0 '\000') at src/serialization/ucs4_convert_impl.hpp:98 #3 20181230 21:56:51<+wesdiscordbot> 0x0000555555e18c8e in ucs4::iterator_base, std::allocator >, ucs4_convert_impl::utf8_impl>::update() (this=0x7fffffffa9d8) at src/serialization/ucs4_iterator_base.hpp:100 #4 0x000055555686a651 in ucs4::iterator_base, std::allocator >, ucs4_convert_impl::utf8_impl>::operator++() (this=0x7fffffffa9d8) at 20181230 21:56:51<+wesdiscordbot> src/serialization/ucs4_iterator_base.hpp:74 #5 0x00005555568cb6a6 in font::make_text_ellipsis(std::__cxx11::basic_string, std::allocator > const&, int, int, int) (text=Python Exception Es gibt kein Mitglied mit dem Namen _M_dataplus.: , font_size=14, max_width=60, style=0) at src/font/sdl_ttf.cpp:455 20181230 21:56:53<+wesdiscordbot> #6 0x00005555568cacdf in font::draw_text_line(surface&, SDL_Rect const&, int, color_t const&, std::__cxx11::basic_string, std::allocator > const&, int, int, bool, int) (gui_surface=..., area=..., size=14,------------------Typ---Typ---------------------------------------------Typ---------Typ---Type to c---Type to continue, ---Type to c---Type to continue, or q to quit--- color=..., text=Python Exception Es gibt kein Mitglied mit dem Namen _M_dataplus.: , x=3, y=32, use_tooltips=false, style=0) at src/font/sdl_ttf.cpp:353 20181230 21:57:07<+wesdiscordbot> could you put that on pastebin or something? 20181230 21:58:38<+wesdiscordbot> https://pastebin.com/AW2L22fu 20181230 22:00:30< gfgtdf> hmm ok it seems liek draw_text_line/make_text_ellipsis used utf8::iterator but does not catch thze exception 20181230 22:00:40< gfgtdf> now we just have to dedie where to ctach it 20181230 22:05:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20181230 22:06:48-!- irker149 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181230 22:06:48< irker149> wesnoth: gfgtdf wesnoth:master 7875f4fc0824 / src/font/sdl_ttf.cpp: fix missing catch invalid_utf8_exception https://github.com/wesnoth/wesnoth/commit/7875f4fc0824a7e5f222d2d98c98bd7799789441 20181230 22:06:49< gfgtdf> untested commit ^ 20181230 22:12:53< celticminstrel> :( 20181230 22:21:57<+wesdiscordbot> don't crash anymore, got 2 warnings: 20181230 23:20:49 warning font: Invalid UTF-8 string: "<�,�,�>Replay" 20181230 23:20:54 warning font: Invalid UTF-8 string: "<�,�,�>Replay" 20181230 22:23:03< celticminstrel> Wonder what that's supposed to be... 20181230 22:31:30<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/529064011745067009/preferences_corrupt 20181230 22:31:49<+wesdiscordbot> appears only with this preferences file 20181230 22:34:01<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/529064644678254623/2S_Allschlund_Aufzeichnung_abspielen.gz 20181230 22:36:53< celticminstrel> Someone should label this "enhancement" as well as a purple tag (maybe ui? not sure). https://github.com/wesnoth/wesnoth/issues/3821 20181230 22:37:34< celticminstrel> Also the title could be clarified further. 20181230 22:38:02< celticminstrel> (Was loonycyborg a Russian speaker?) 20181230 22:38:37< loonycyborg> yes I'm a russian too 20181230 22:38:47< celticminstrel> Somehow I didn't know (or forgot). 20181230 22:40:04<+wesdiscordbot> (I am here.) 20181230 22:40:33< celticminstrel> (Yes? I'm aware?) 20181230 23:11:17< mattsc> celticminstrel: do you know what the last two arguments do here? https://github.com/wesnoth/wesnoth/blob/master/data/lua/cave_map_generator.lua#L136 20181230 23:11:25< mattsc> If they do anything? 20181230 23:12:27< mattsc> Actually, looks like gfgtdf wrote that line: https://github.com/wesnoth/wesnoth/commit/60d114b606b305099c690a8c9d6cc0eaff9a905c#diff-a8ca8be2b81b17ff3996e369cb6cc3d2R174 20181230 23:13:06< celticminstrel> Not sure, they might be unique to the mapgen kernel. 20181230 23:13:33< celticminstrel> Which has a separate implementation of find_path. 20181230 23:14:06< celticminstrel> https://github.com/wesnoth/wesnoth/blob/master/src/scripting/mapgen_lua_kernel.cpp#L168 20181230 23:14:06< mattsc> Yeah, just found that on the wiki, that they are used in the mapgen code. But without explanation what they are. 20181230 23:14:25< celticminstrel> Ugh, that's not using the location functions... 20181230 23:14:31< celticminstrel> Meaning it won't work with {x, y} format... 20181230 23:14:51< mattsc> But since this is a different implementation, I guess I don’t have to worry about it after deprecating the old custom_cost_function syntax. 20181230 23:15:02< celticminstrel> Yeah, I guess not. 20181230 23:15:17< celticminstrel> IMO we should try to make it more compatible though. 20181230 23:15:27< celticminstrel> Maybe push the width/height params into an options table. 20181230 23:16:01< mattsc> Sure. I’ll leave this to somebody else though. :P My current concern is fixing bugs in AI code. 20181230 23:16:16< mattsc> Bugs and limitations. 20181230 23:16:18< celticminstrel> I'll probably do it in my mapgen PR if I remember. Whenever I get around to working on it. 20181230 23:17:54< mattsc> Okay. 20181230 23:18:07< gfgtdf> the mapgens find_path is differntly than the usual find_path functions 20181230 23:18:19< mattsc> So in all of mainline, the only code that uses custom cost functions are two of the Micro AIs. 20181230 23:18:24< gfgtdf> this becasue there is no obvious 'map' object. 20181230 23:18:33< gfgtdf> also there are no unit during map generation 20181230 23:18:35< gfgtdf> units 20181230 23:18:50< celticminstrel> gfgtdf: IMO what we should do is move it to be a method on the map object, then it won't even need the width/height arguments. 20181230 23:19:34< celticminstrel> I guess that's yet another thing I can address in the mapgen PR... 20181230 23:19:54< gfgtdf> we could, but that way you can no longer use with withotu the map object, for example in the code lined by mattsc does not use a map object. 20181230 23:20:27< celticminstrel> Hmm. 20181230 23:20:52< celticminstrel> A map object is available at that point though. 20181230 23:21:05< gfgtdf> I mean we coudl probably make that code use the engine map object instead of the lua implementd map object. 20181230 23:21:25< celticminstrel> The engine map object is currently almost useless though. 20181230 23:21:36< celticminstrel> Because it's incompatible with the in-game map. 20181230 23:21:54< gfgtdf> why functions exatly do you miss? 20181230 23:22:44< celticminstrel> I can't remember off the top of my head. 20181230 23:23:32< gfgtdf> there is not even a 'map object' in the ingame lua api so it doesn't really amke sense to speak of compatability. 20181230 23:23:45< celticminstrel> (BTW, didn't I merge the helper.wml_error -> wml.error change? If so, we should make that replacement globally in master.) 20181230 23:23:57< celticminstrel> gfgtdf: My point is that there should be. 20181230 23:24:15< celticminstrel> And ideally it would reuse the same code as in mapgen as much as possible. 20181230 23:25:32< celticminstrel> I think my biggest complaint about your new map object is that it's not accessible from in-game. 20181230 23:29:44< gfgtdf> celticminstrel: the main reasion for that is that it's filter syntax is differnt from the ingame filter syntax and i wanted to be really sure on that before i bring two differnt filter syntaxes to the ingame lua kernel. 20181230 23:30:02< gfgtdf> or have a convertion tool. 20181230 23:30:35< celticminstrel> (FTR I'm still not exactly enthusiastic about the new filter syntax... but anyway you could probably disable just the filter syntax for the in-game map if you're not sure about it.) 20181230 23:31:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds] --- Log closed Mon Dec 31 00:00:12 2018