--- Log opened Mon Dec 31 00:00:12 2018 20181231 00:37:34< irker149> wesnoth: mattsc wesnoth:master 152eb37aecb9 / / (3 files in 2 dirs): Goto/Assassin MAIs: fix AIs not always working with tunnels https://github.com/wesnoth/wesnoth/commit/152eb37aecb9c978df582876cf2b0ff8ceccab8c 20181231 00:37:36< irker149> wesnoth: mattsc wesnoth:master 02122f2eaef2 / src/scripting/game_lua_kernel.cpp: wesnoth.find_path: deprecate old syntax for custom cost functions https://github.com/wesnoth/wesnoth/commit/02122f2eaef285c5f48ae6476b1869a3ae15a145 20181231 00:37:57< mattsc> celticminstrel: ^ 20181231 00:38:22< mattsc> Those two MAIs are the only places where custom cost functions are used in all of mainline. 20181231 00:41:17< mattsc> to Lua wesnoth.find_path(), I mean 20181231 00:42:09< celticminstrel> \o/ 20181231 00:42:19< celticminstrel> What were the deprecation levels called again, though? 20181231 00:42:38< celticminstrel> I feel like I recall FOR_REMOVAL was level 4, which wouldn't be right. 20181231 00:42:50< celticminstrel> But maybe I misremembered; if it's level 3, that's fine. 20181231 00:43:31< mattsc> Umm, I just replicated what was done for wesnoth.put_unit etc. I thought that’s the right level. 20181231 00:43:46< celticminstrel> Should that line be changed to ignore_teleport=true? Or was that the default earlier? 20181231 00:43:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181231 00:43:58< celticminstrel> If it's used for put_unit then it's probably fine. 20181231 00:44:26< celticminstrel> FTR, the default at declaration is indeed false. 20181231 00:44:29< mattsc> No, the default (intuitive behavior) should be NOT to ignore teleports. 20181231 00:44:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181231 00:44:49< mattsc> Yes, it is. 20181231 00:44:54< celticminstrel> Well, whatever, I guess I don't really care about breaking compatibility at this point in master. 20181231 00:45:18< mattsc> Agreed. 20181231 00:45:56< mattsc> FYI: deprecation.hpp:enum class DEP_LEVEL { INDEFINITE = 1, PREEMPTIVE, FOR_REMOVAL, REMOVED }; 20181231 00:46:05< mattsc> So this is indeed level 3, as I thought. 20181231 00:46:20< celticminstrel> Good good 20181231 00:49:16< mattsc> I’ll still update the wiki (sometime soon-ish). 20181231 01:06:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20181231 01:19:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181231 01:57:45-!- gfgtdf [~Daniel@x4d00748a.dyn.telefonica.de] has quit [Ping timeout: 244 seconds] 20181231 02:58:19-!- gfgtdf [~Daniel@x4d03812c.dyn.telefonica.de] has joined #wesnoth-dev 20181231 03:33:59-!- gfgtdf [~Daniel@x4d03812c.dyn.telefonica.de] has quit [Quit: Leaving] 20181231 03:38:04-!- irker149 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181231 04:10:43-!- irker230 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181231 04:10:43< irker230> wesnoth/wesnoth:master gfgtdf 7875f4fc08 fix missing catch invalid_utf8_exception AppVeyor: All builds passed 20181231 05:55:32-!- celticminstrel is now known as celmin|sleep 20181231 06:41:49< irker230> wesnoth/wesnoth:master mattsc 02122f2eae wesnoth.find_path: deprecate old syntax AppVeyor: All builds passed 20181231 07:51:08-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20181231 08:41:37< irker230> wesnoth: equal-l2 wesnoth:master f31b477e5b6d / INSTALL.md data/core/about.cfg: Note dependencies on OpenGL and GLEW in INSTALL.md https://github.com/wesnoth/wesnoth/commit/f31b477e5b6d04cf73118824a2155fc45637361a 20181231 09:17:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181231 09:42:29< irker230> wesnoth/wesnoth:master equal-l2 3275194e25 Note dependencies on OpenGL and GLEW in AppVeyor: All builds passed 20181231 11:46:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181231 12:42:46-!- irker230 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20181231 12:51:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181231 14:53:31-!- irker091 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20181231 14:53:31< irker091> wesnoth/wesnoth:master equal-l2 f31b477e5b Note dependencies on OpenGL and GLEW in AppVeyor: All builds passed 20181231 15:20:52< celmin|sleep> That issue needs labels. 20181231 15:20:57-!- celmin|sleep is now known as celticminstrel 20181231 15:39:03< Ravana> I am not sure it is something that can be solved, but I needed number to refer to 20181231 15:39:24< celticminstrel> Why would it be unsolvable? 20181231 15:40:04< Ravana> third point of https://github.com/inferno8/wesnoth-Era_of_Magic/issues/16#issuecomment-407919971 20181231 15:40:06< celticminstrel> Honestly, without looking at the code it sounds relatively simple to solve... though it could be more complicated than it seems... 20181231 16:14:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181231 16:22:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20181231 16:26:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181231 16:26:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20181231 17:08:47< irker091> wesnoth/wesnoth:master Edward Chernenko bf2a929a4a Fix typo in menu_button: active icon was AppVeyor: All builds passed 20181231 17:36:23< celticminstrel> gfgtdf seriously please tag things when commenting if they aren't already... 20181231 19:35:06< irker091> wesnoth: pentarctagon wesnoth:master e273684f6659 / CMakeLists.txt SConstruct src/CMakeLists.txt: Disable requirements for OpenGL/GLEW. https://github.com/wesnoth/wesnoth/commit/e273684f6659430d1658aca8b880c4e15047bfc1 20181231 19:35:08< irker091> wesnoth: pentarctagon wesnoth:master eb65c9b2ce68 / INSTALL.md data/core/about.cfg: Revert "Note dependencies on OpenGL and GLEW in INSTALL.md" https://github.com/wesnoth/wesnoth/commit/eb65c9b2ce68866eb3aa2093449ed77936ee4e86 20181231 20:55:23<+wesdiscordbot> Ravana, so what if the username were the real name? The username still wouldn't be sent to the server or anything like that 20181231 20:55:34<+wesdiscordbot> (context: issue 3777) 20181231 20:57:42< Ravana> https://forums.wesnoth.org/viewtopic.php?f=4&t=25660 tells to include logs 20181231 21:02:25<+wesdiscordbot> I see 20181231 21:13:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20181231 21:39:15-!- gfgtdf [~Daniel@x4d03812c.dyn.telefonica.de] has joined #wesnoth-dev 20181231 21:43:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20181231 21:58:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181231 22:14:39-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181231 22:24:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181231 22:30:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20181231 22:35:14-!- irker091 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] --- Log closed Tue Jan 01 00:00:13 2019