--- Log opened Sun Dec 30 00:00:11 2018 20181230 05:39:44-!- gfgtdf [~androirc@x4d00748a.dyn.telefonica.de] has joined #wesnoth-umc-dev 20181230 05:41:01-!- gfgtdf [~androirc@x4d00748a.dyn.telefonica.de] has quit [Client Quit] 20181230 08:23:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev 20181230 11:11:15<+wesdiscordbot> What do you have to do to make a SP modification optional (so it won't apply automatically while installed)? 20181230 11:12:58<+wesdiscordbot> Making it appear at the 'Modifications' instead. 20181230 11:12:59<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/528893249704820736/mod.png 20181230 11:13:13<+wesdiscordbot> Would I have to rewrite a lot or maybe add just 1-2 lines? 20181230 11:23:09< vn971> @Konrad2: but no modifications are added automatically after you install them I think? Or IDK, maybe this changed.. 20181230 11:23:51<+wesdiscordbot> 'Reign of the Lords Default Unit Advancements' apparently is. 😅 20181230 11:24:25<+wesdiscordbot> I'm asking the author whether he could change that and I guess the process would be faster if I can tell him how to do that. 20181230 11:29:22< vn971> @Konrad2 is the modification automatically checkbox-enabled, or is there just no checkbox and it is ALWAYS applied, with no possibility to disable? 20181230 11:30:01< Ravana> if it is always on, then it is not modification 20181230 11:30:30<+wesdiscordbot> The second one. I don't know what else it is, it's only listed as modification on the server. :/ 20181230 11:31:10< vn971> @Konrad2: so it's a type of add-on then that just adds code directly to the core WML scope, not placed inside any [modification] or similar tag. 20181230 11:31:30< vn971> the change is then to put it inside a properly defined tag. Lemme see. 20181230 11:32:41< Ravana> if it does what I expect it does, then adding tag wouldn't help 20181230 11:32:47<+wesdiscordbot> It basically enables advancements to units from an MP era. 20181230 11:33:18< vn971> @Konrad2: see here for example: https://github.com/vgaming/berserk_limiter/blob/master/berserk_limiter/_main.cfg#L26 20181230 11:33:18< vn971> If I understand it correctly, the add-on in question just added a code like [event] directly to the main scope, or maybe even the event content-s themselves, not sure. The proper fix is then to wrap it in e.g. [modification], as seen at the top of the referenced file. 20181230 11:33:48< vn971> but indeed we need to see the add-on specifically. Maybe it's the only way this add-on is supposed to work, somewhy. 20181230 11:34:02< Ravana> people who don't understand mp safety would implement it as modifying units directly, rather than with code 20181230 11:34:16<+wesdiscordbot> #textdomain wesnoth-ROTL [textdomain] name="wesnoth-ROTL" path="data/add-ons/5_Lords_Active_Advance/translations" [/textdomain] # the very being here is what makes the units advance properly # nothing more is needed for this to work because the ROTL mod # just checks to see if this exists 20181230 11:34:25<+wesdiscordbot> That's the whole addon apparently? ._. 20181230 11:34:55< Ravana> that just tells you that code is in different addon 20181230 11:35:20<+wesdiscordbot> And that add-on is Reign of the Lords. Just a second. 20181230 11:37:14<+wesdiscordbot> It's probably this part: #define ADVANCE_IFHAVEANDCAMPAGIN UNIT #ifhave ~add-ons/5_Lords_Active_Advance/_main.cfg #ifndef MULTIPLAYER [advancefrom] unit={UNIT} [/advancefrom] #endif #endif #enddef 20181230 11:37:25< Ravana> just like I expected 20181230 11:37:45< Ravana> advancefrom is horrible tag 20181230 11:38:12<+wesdiscordbot> So, it needs a rewrite? 20181230 11:38:18< Ravana> yes 20181230 11:39:22<+wesdiscordbot> Would you mind telling me how to do that? Then I can explain the author how (and preferably why) to do it. 😄 20181230 11:40:04< Ravana> unit placed events I suppose 20181230 11:41:45< Ravana> advancefrom is the only way to change unit type definition after it has been created 20181230 11:42:42< Ravana> I guess even the tag name says it is only for internal use since its advancefrom not advance_from 20181230 11:45:50< Ravana> https://github.com/wesnoth/wesnoth/issues/1451 20181230 11:47:59< Ravana> >Currently there are only 2 ways a wml developer can to fix this 20181230 11:48:04< Ravana> that says what can be done 20181230 11:48:13< Ravana> and one of the ways if not possible for that addon 20181230 12:04:38<+wesdiscordbot> Okay. :/ Thanks for the information. 20181230 12:29:00<+wesdiscordbot> alright im close to finishing the sprites of a faction ill use in my upcoming campaign 20181230 12:35:15<+wesdiscordbot> Can I change the type of an add-on after uploading it? 20181230 12:56:01< Ravana> with https://github.com/ProditorMagnus/Ageless-for-1-14/commit/a016fc9058afeeba05e148a7116a6c4116d4875b I used my bet on 1.14 (https://github.com/wesnoth/wesnoth/pull/3787) 20181230 14:30:52-!- vn971 [~vasilii@ip-213-127-111-47.ip.prioritytelecom.net] has quit [Quit: Leaving.] 20181230 15:40:08-!- vn971 [~vasilii@2a02:a451:aaa9:1:c774:2d32:1da9:62e] has joined #wesnoth-umc-dev 20181230 15:55:06-!- vn971 [~vasilii@2a02:a451:aaa9:1:c774:2d32:1da9:62e] has quit [Quit: Leaving.] 20181230 16:40:29-!- vn971 [~vasilii@ip-213-127-111-47.ip.prioritytelecom.net] has joined #wesnoth-umc-dev 20181230 16:53:30-!- gfgtdf [~Daniel@x4d00748a.dyn.telefonica.de] has joined #wesnoth-umc-dev 20181230 19:02:55<+wesdiscordbot> @Konrad2 I think you'd just update the pbl and re-upload it. 20181230 19:47:50-!- vn971 [~vasilii@ip-213-127-111-47.ip.prioritytelecom.net] has quit [Quit: Leaving.] 20181230 21:07:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20181230 21:10:22-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-umc-dev 20181230 21:25:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20181230 21:27:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-umc-dev 20181230 21:53:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20181230 22:05:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-umc-dev 20181230 23:31:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds] --- Log closed Mon Dec 31 00:00:12 2018