--- Log opened Wed Jan 02 00:00:15 2019 20190102 00:04:54-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190102 00:06:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20190102 00:53:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20190102 01:03:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20190102 01:10:40-!- irker005 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190102 02:10:58-!- irker464 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190102 02:10:58< irker464> wesnoth/wesnoth:master gfgtdf a32e49e32f fix [item] z_order being lost after relo AppVeyor: 1/4 builds failed 20190102 02:10:58< irker464> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21321144 20190102 04:31:12< irker464> wesnoth/wesnoth:master gfgtdf bc685e3851 add a comment AppVeyor: All builds passed 20190102 05:28:08-!- celticminstrel is now known as celmin|sleep 20190102 07:31:27-!- irker464 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190102 08:00:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190102 13:44:33-!- celmin|sleep is now known as celmin|away 20190102 17:10:45-!- irker150 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190102 17:10:45< irker150> wesnoth: Edward Chernenko wesnoth:master 0112a82a3546 / data/ (3 files in 2 dirs): Fix typo in menu_button: active icon was used instead of pressed icon https://github.com/wesnoth/wesnoth/commit/0112a82a3546c828de3117ef9d2a1056c7ece29f 20190102 17:13:18-!- gfgtdf [~Daniel@x4d0070e5.dyn.telefonica.de] has joined #wesnoth-dev 20190102 17:13:39< gfgtdf> any opinions on #3814 ? Otherwise i'd merge it soon. 20190102 17:15:58< irker150> wesnoth: Edward Chernenko wesnoth:1.14 000afe5e74b0 / data/ (3 files in 2 dirs): Fix typo in menu_button: active icon was used instead of pressed icon https://github.com/wesnoth/wesnoth/commit/000afe5e74b0904b834c39695166e304617337d1 20190102 17:26:51< irker150> wesnoth: Edward Chernenko wesnoth:master 4384bd550a76 / images/ (288 files in 22 dirs): optipng run: ./utils/woptipng.py -d 15 images/ https://github.com/wesnoth/wesnoth/commit/4384bd550a76bc17638b3ea55c97ce1f448de6f6 20190102 17:30:58< irker150> wesnoth/wesnoth:1.14 Edward Chernenko 000afe5e74 Fix typo in menu_button: active icon was AppVeyor: vs2017/Release Failed 20190102 17:30:59< irker150> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21337750 20190102 17:32:15< irker150> wesnoth/wesnoth:master Edward Chernenko 4384bd550a optipng run: ./utils/woptipng.py -d 15 i AppVeyor: vs2015/Release Failed 20190102 17:32:16< irker150> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21338012 20190102 18:55:30-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190102 19:06:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190102 19:29:55< irker150> wesnoth: newfrenchy83 wesnoth:master 7114174789e8 / / (4 files in 4 dirs): Fix #3811 negative value in heals ability https://github.com/wesnoth/wesnoth/commit/7114174789e850bbd7829a353e7d885791c0a664 20190102 20:51:02-!- gfgtdf [~Daniel@x4d0070e5.dyn.telefonica.de] has quit [Remote host closed the connection] 20190102 20:51:25-!- gfgtdf [~Daniel@x4d0070e5.dyn.telefonica.de] has joined #wesnoth-dev 20190102 21:16:11< irker150> wesnoth/wesnoth:master newfrenchy83 7114174789 Fix #3811 negative value in heals abilit AppVeyor: vs2017/Release Failed 20190102 21:16:12< irker150> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21340448 20190102 22:11:48< gfgtdf> when you want to give wml data to you lua campaign script what so you think is generally the better solution, in particular performance wise 1) using wesnoth.read_wml_file or 2) loading it into the main game config (for example into a dummy unit type) and then reading it from there, (for example via unit_type.__cfg) 20190102 22:13:23<+wesdiscordbot> 1) sounds far better from the API standpoint. 20190102 22:14:46< gfgtdf> but it will parse the config everytime you reload the scenario, while (2) keeps the result and parsing is only done once during the general config reload. 20190102 22:15:49<+wesdiscordbot> Still, using ugly hacks for performance doesn't sound "good" to me at all. 20190102 22:16:37< Ravana> my opinion is to try it out, and use hack if it is needed and gives enough benefit 20190102 22:17:14< gfgtdf> putting config data in the game config is what the game does all the time, i would not call it hacky at all. 20190102 22:18:21<+wesdiscordbot> Depends on what kind of WML data you're dealing with. 20190102 22:18:39<+wesdiscordbot> Putting, say, a GUI dialog definition to a dummy unit type would be horrifying. 20190102 22:23:50< gfgtdf> its custom data, parsed by my addon. And i don't really care whether you put it into a unit type or use some other method to read data from the game config. The question was more about whether to parse it once, but keeping it in ram or reparse it everytime the scenario is loaded. 20190102 22:25:30< gfgtdf> ofc i also have option 3) move the data complteley to lua. But that might bo be a good options here (although it woudl ahve other advantaes in particular makign translation easier) 20190102 22:25:42<+wesdiscordbot> so you're asking whether data only used by one addon should live in memory permanently even while that addon isn't loaded ? 20190102 22:30:59< irker150> wesnoth/wesnoth:1.14 Edward Chernenko 000afe5e74 Fix typo in menu_button: active icon was AppVeyor: 2/4 builds failed 20190102 22:31:00< irker150> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21337750 20190102 22:31:01< irker150> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21337755 20190102 22:32:02< gfgtdf> just rmembered with load_wml_wml i iirc cannot use core macros like ability_leadership so probably don't even have a choice. 20190102 22:32:15< irker150> wesnoth/wesnoth:master Edward Chernenko 4384bd550a optipng run: ./utils/woptipng.py -d 15 i AppVeyor: 2/4 builds failed 20190102 22:32:16< irker150> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21338012 20190102 22:32:17< irker150> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21338013 20190102 22:36:58<+wesdiscordbot> Is it possible to serialize/deserialize parsed WML in lua? 20190102 22:37:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20190102 22:42:34< gfgtdf> you mean lua wml table to wml text? Yes iirc celmin added a functon for that recently 20190102 22:43:22< gfgtdf> but you cannot write files, so i currently see no usecases other than debugging. 20190102 22:44:05< gfgtdf> or writing tool-addons (parsing wml, dding stuff, writing the result to stderr where the user can copy it from) 20190102 22:44:29<+wesdiscordbot> I was thinking a binary representation, like python pickle, so it'd be faster to parse 20190102 22:44:43<+wesdiscordbot> even if you can't write files, you could generate the binary representation offline, maybe? depending on use-case 20190102 22:52:04< Ravana> persistanceWML might be close enough to writing file 20190102 23:07:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190102 23:08:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190102 23:11:24-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Thu Jan 03 00:00:42 2019