--- Log opened Fri Jan 04 00:00:43 2019 20190104 00:18:37-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190104 00:55:29-!- celmin|away is now known as celticminstrel 20190104 01:46:21< celticminstrel> Oh huh, that's not good. 20190104 01:49:07-!- gfgtdf [~Daniel@x4d080075.dyn.telefonica.de] has quit [Ping timeout: 240 seconds] 20190104 03:09:27-!- gfgtdf [~Daniel@x5f74595f.dyn.telefonica.de] has joined #wesnoth-dev 20190104 03:11:02< gfgtdf> celticminstrel: an opinion on #3832 ? iirc you implemented voice= there. 20190104 03:14:21< celticminstrel> [Jan 03@8:46:21pm] celticminstrel: Oh huh, that's not good. 20190104 03:14:23< celticminstrel> :P 20190104 03:14:29< celticminstrel> Beyond that, uhh... 20190104 03:14:39< celticminstrel> voice= is implemented by placing a sound source on the unit's space. 20190104 03:14:54< celticminstrel> So, I imagine there needs to be some logic to remove the sound source under certain conditions. 20190104 03:36:19< gfgtdf> i think this is about the [story]voice= not the [message] voice= although it migth apply to the [message]voide= aswell 20190104 03:57:33< celticminstrel> ...there was a [story]voice=? 20190104 03:57:38< celticminstrel> I don't remember such a thing. 20190104 03:57:41< celticminstrel> Did I add that? 20190104 03:59:45<+wesdiscordbot> You did 20190104 03:59:55<+wesdiscordbot> Or at least you approved it 20190104 04:20:29< celticminstrel> I don't remember. >_> 20190104 04:52:58-!- gfgtdf [~Daniel@x5f74595f.dyn.telefonica.de] has quit [Quit: Leaving] 20190104 05:06:51-!- celticminstrel is now known as celmin|sleep 20190104 05:33:09-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190104 05:47:11<+wesdiscordbot> there's already a [remove_sound_source], but it only takes an id while voice only has a file name, so it sounds like there would need to be a voice_id that could be used for [remove_sound_source]? 20190104 06:48:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20190104 08:46:36-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190104 08:47:49-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190104 13:49:31-!- celmin|sleep is now known as celmin|away 20190104 13:50:04< celmin|away> ...? 20190104 13:50:42< celmin|away> I guess [message] and/or [story] would just need to set the id or something. 20190104 14:48:15-!- irker152 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190104 14:48:15< irker152> wesnoth: loonycyborg wesnoth:master 34e2ef12c762 / / (6 files in 5 dirs): Add support for ipv6 addresses to addon client and multiplayer client https://github.com/wesnoth/wesnoth/commit/34e2ef12c762b6e65664493b84eb163d39fd8093 20190104 15:19:20-!- travis-ci [~travis-ci@ec2-107-23-200-255.compute-1.amazonaws.com] has joined #wesnoth-dev 20190104 15:19:21< travis-ci> wesnoth/wesnoth#20543 (master - 34e2ef1 : loonycyborg): The build was broken. 20190104 15:19:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475333789 20190104 15:19:22-!- travis-ci [~travis-ci@ec2-107-23-200-255.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190104 15:20:56< irker152> wesnoth/wesnoth:master loonycyborg 34e2ef12c7 Add support for ipv6 addresses to addon AppVeyor: vs2015/Release Failed 20190104 15:20:57< irker152> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21383377 20190104 15:23:08<+wesdiscordbot> New file needs to be added to xcode 20190104 15:24:21<+wesdiscordbot> and msvs 20190104 17:04:47<+wesdiscordbot> @loonycyborg Why did you change the port from an int to a string? I think an integer is a more logical representation. 20190104 17:05:17<+wesdiscordbot> because both asio and original command line and dialog boxes are strings 20190104 17:05:26<+wesdiscordbot> there is no point to convert it back and forth 20190104 17:05:40<+wesdiscordbot> OK, I see. Makes sense. 20190104 17:05:40<+wesdiscordbot> asio takes it as string because it can also have textual values 20190104 17:05:45<+wesdiscordbot> like "http" 20190104 17:06:06< irker152> wesnoth: newfrenchy83 wesnoth:master 11818118721a / projectfiles/CodeBlocks/wesnoth.cbp: update CB projectfile https://github.com/wesnoth/wesnoth/commit/11818118721a5ba749e7633f45d3291af9fdad77 20190104 17:06:31< irker152> wesnoth: newfrenchy83 wesnoth:master 148ea6fbe73c / projectfiles/CodeBlocks-SCons/wesnoth.cbp: update CB scons project https://github.com/wesnoth/wesnoth/commit/148ea6fbe73c6d60ba9fd5ae90d7939ff721a97f 20190104 17:07:43<+wesdiscordbot> Yeah but no-one's going to use that here are they? 20190104 17:08:06<+wesdiscordbot> Primarily because there aren't official names for the port numbers Wesnoth uses 20190104 17:08:29<+wesdiscordbot> Secondarily because users are just going to copy-paste stuff we provide to them since, let's not forget, they are players, not programmers 20190104 17:29:14< irker152> wesnoth: Jyrki Vesterinen wesnoth:master f34f0c1006f8 / projectfiles/VC14/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/f34f0c1006f8c586b922f9c9470fe13fe1f8e0be 20190104 17:35:01-!- travis-ci [~travis-ci@ec2-54-161-157-231.compute-1.amazonaws.com] has joined #wesnoth-dev 20190104 17:35:02< travis-ci> wesnoth/wesnoth#20547 (master - 148ea6f : newfrenchy83): The build is still failing. 20190104 17:35:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475395659 20190104 17:35:03-!- travis-ci [~travis-ci@ec2-54-161-157-231.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190104 17:42:12<+wesdiscordbot> still it gets rid of two back and forth conversions, and nobody knows if using textual ports won't come in handy for someone 20190104 17:43:34<+wesdiscordbot> I prefer to err on side of generality in order to fully exploit the effects of inventor's paradox 20190104 17:44:09<+wesdiscordbot> It's not good to get too attached to dogmas 20190104 17:57:34<+wesdiscordbot> does it fail as expected if the port number is, say, 15000, with a trailing comma? 20190104 17:58:12<+wesdiscordbot> well the regex wants it to be alnum class 20190104 17:58:16<+wesdiscordbot> comma won't fit 20190104 18:00:00<+wesdiscordbot> in any case any invalid values that slip will still come through asio and tcp/up stack and emuit errors from there 20190104 18:00:09-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo.ga] 20190104 18:00:23-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev 20190104 18:01:44-!- travis-ci [~travis-ci@ec2-54-158-120-216.compute-1.amazonaws.com] has joined #wesnoth-dev 20190104 18:01:45< travis-ci> wesnoth/wesnoth#20548 (master - f34f0c1 : Jyrki Vesterinen): The build failed. 20190104 18:01:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475404945 20190104 18:01:45-!- travis-ci [~travis-ci@ec2-54-158-120-216.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190104 18:25:47<+wesdiscordbot> also that regex probably can use some improvement yet 20190104 18:29:28< Ravana> seems that version check uses _server.pbl now instead 20190104 18:29:47< Ravana> guess I don't need to commit _info.cfg anymore 20190104 18:32:21< Ravana> though since I can't commit _server.pbl I need to change it manually every time again 20190104 19:17:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190104 19:41:51< irker152> wesnoth/wesnoth:master Jyrki Vesterinen f34f0c1006 Update Visual Studio project AppVeyor: vs2015/Release Failed 20190104 19:41:52< irker152> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21387567 20190104 19:52:22-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190104 20:20:56< irker152> wesnoth/wesnoth:master loonycyborg 34e2ef12c7 Add support for ipv6 addresses to addon AppVeyor: 2/4 builds failed 20190104 20:20:57< irker152> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21383377 20190104 20:20:58< irker152> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21383378 20190104 22:04:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds] 20190104 23:06:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190104 23:20:59-!- irker152 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190104 23:41:46-!- irker462 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190104 23:41:46< irker462> wesnoth/wesnoth:master Jyrki Vesterinen f34f0c1006 Update Visual Studio project AppVeyor: 1/4 builds failed 20190104 23:41:46< irker462> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21387567 --- Log closed Sat Jan 05 00:00:44 2019