--- Log opened Sat Jan 05 00:00:44 2019 20190105 00:14:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190105 00:40:27-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190105 00:41:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds] 20190105 00:58:29-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190105 01:44:01< irker462> wesnoth: Severin Glöckner wesnoth:1.14 ff6da43c66b7 / data/campaigns/ (2 files in 2 dirs): TRoW S9: unhide yeti side when they appear https://github.com/wesnoth/wesnoth/commit/ff6da43c66b7945dc45cdb8b5496e6e19ce9f8b8 20190105 01:44:03< irker462> wesnoth: Severin Glöckner wesnoth:1.14 7ca2aede7bd3 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg: TRoW S5: remove trailing space https://github.com/wesnoth/wesnoth/commit/7ca2aede7bd3998a488ccacc4b5e347b8a361207 20190105 01:44:05< irker462> wesnoth: Severin Glöckner wesnoth:1.14 14eb80f367c9 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (08_Clearwater_Port.cfg 12_A_Final_Spring.cfg): TRoW: better lighthouse illumination simullation https://github.com/wesnoth/wesnoth/commit/14eb80f367c95123891d4dd30328e6d4532fcd7d 20190105 01:44:07< irker462> wesnoth: Severin Glöckner wesnoth:1.14 97928688e657 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/08_Clearwater_Port.cfg: TRoW S8: one more village for the ally https://github.com/wesnoth/wesnoth/commit/97928688e65747a3b6cf4f3f01d9025647c91aaa 20190105 01:44:09< irker462> wesnoth: Severin Glöckner wesnoth:1.14 ae20a1ab6591 / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: write schedule more compact https://github.com/wesnoth/wesnoth/commit/ae20a1ab6591041553871d62caa2e03a000d7682 20190105 01:44:11< irker462> wesnoth: Severin Glöckner wesnoth:1.14 d5e07b0053c5 / data/campaigns/Sceptre_of_Fire/scenarios/7_Outriding_the_Outriders.cfg: SoF7: mention correct type in message https://github.com/wesnoth/wesnoth/commit/d5e07b0053c50b3675d34fdb3c36bc768f01aefd 20190105 01:46:28< irker462> wesnoth: Severin Glöckner wesnoth:master 9f8c47939de7 / data/campaigns/ (2 files in 2 dirs): TRoW S9: unhide yeti side when they appear https://github.com/wesnoth/wesnoth/commit/9f8c47939de7c8bcd1f9122cd2658093cd96db1c 20190105 01:46:30< irker462> wesnoth: Severin Glöckner wesnoth:master b671ad777236 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg: TRoW S5: remove trailing space https://github.com/wesnoth/wesnoth/commit/b671ad77723665e2ebc5b83adb0be5c0e93dd646 20190105 01:46:32< irker462> wesnoth: Severin Glöckner wesnoth:master 717625b2cafd / data/campaigns/The_Rise_Of_Wesnoth/scenarios/ (08_Clearwater_Port.cfg 12_A_Final_Spring.cfg): TRoW: better lighthouse illumination simullation https://github.com/wesnoth/wesnoth/commit/717625b2cafd2eacc8436cdf1dab053b0dcb51df 20190105 01:46:34< irker462> wesnoth: Severin Glöckner wesnoth:master acfe47916a4e / data/campaigns/The_Rise_Of_Wesnoth/scenarios/08_Clearwater_Port.cfg: TRoW S8: one more village for the ally https://github.com/wesnoth/wesnoth/commit/acfe47916a4e76765372d39a024d9b88fc5b6719 20190105 01:46:36< irker462> wesnoth: Severin Glöckner wesnoth:master d3bb77641e07 / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: write schedule more compact https://github.com/wesnoth/wesnoth/commit/d3bb77641e07cd05d433499c9fe677ebde3d9df9 20190105 01:46:38< irker462> wesnoth: Severin Glöckner wesnoth:master 432efbac9ad4 / data/campaigns/Sceptre_of_Fire/scenarios/7_Outriding_the_Outriders.cfg: SoF7: mention correct type in message https://github.com/wesnoth/wesnoth/commit/432efbac9ad44bc3874a2cc52c6cae22d8d79cc0 20190105 01:47:13<+wesdiscordbot> Any idea what this means? Or maybe a cause? 20190105 01:47:14<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/530925200041181195/lua2.png 20190105 01:47:25<+wesdiscordbot> I never expected to run into a lua error in a mainline campaign. 20190105 01:50:38<+wesdiscordbot> yikes 20190105 01:51:45< celmin|away> Well, it's not a Lua error, technically... 20190105 01:51:58-!- celmin|away is now known as celticminstrel 20190105 01:52:14< celticminstrel> What does that mean? Someone did std::string(nullptr)? 20190105 01:54:01<+wesdiscordbot> Cool, I can do this reliably. 😄 20190105 01:54:33<+wesdiscordbot> Give me a second and I'll write up the steps to reproduce it. 20190105 01:54:45< celticminstrel> I guess lua_tostring or whatever could return nullptr maybe? 20190105 01:58:33<+wesdiscordbot> So, here we go: Load Scenario start save. On the very first 'story page' (how is this called?) press the left arrow key. (This breaks the red dot tracker of your movement on the bigmap btw.) Press Esc. Look at the bug. Or maybe look at Wesnoth crashing. I've had both results so far. 20190105 02:00:30<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/530928548303863819/wesnoth-20190105-015751-13260.log 20190105 02:02:17<+wesdiscordbot> Story screen 20190105 02:02:27<+wesdiscordbot> That's what it's called generally 20190105 02:04:44<+wesdiscordbot> I'll put both of it on github now. 20190105 02:06:17<+wesdiscordbot> How is the 'red dot tracker' called? 😅 20190105 02:16:15<+wesdiscordbot> It doesn't have a formal name but it's occasionally referred to as the journey map I think 20190105 02:16:26<+wesdiscordbot> It's technically just another story screen 20190105 02:17:51< irker462> wesnoth: Severin Glöckner wesnoth:1.14 b1b782807db9 / data/campaigns/Son_Of_The_Black_Eye/utils/utils.cfg: SotBE S6: discover units placed with lua https://github.com/wesnoth/wesnoth/commit/b1b782807db9f965379a17bf9da4527adf57c02d 20190105 02:18:08<+wesdiscordbot> Can you reproduce my bugs? 20190105 02:18:15< irker462> wesnoth: Severin Glöckner wesnoth:master fba83e70e92b / data/campaigns/Son_Of_The_Black_Eye/utils/utils.cfg: SotBE S6: discover units placed with lua https://github.com/wesnoth/wesnoth/commit/fba83e70e92b6ca8519253c7e089aba4e8530872 20190105 02:18:22<+wesdiscordbot> I don't have Wesnoth builds available atm 20190105 02:18:32< celticminstrel> That function should probably be deprecated TBH. 20190105 02:19:08< celticminstrel> It's something that shouldn't really be exposed in the API. 20190105 02:20:09<+wesdiscordbot> celticminstrel: So you can reproduce it..? 20190105 02:20:27<+wesdiscordbot> And any idea why the game sometimes crashes instead of showing me that error message? 20190105 02:20:31< celticminstrel> ??? 20190105 02:20:42< celticminstrel> I haven't even tried. 20190105 02:20:47<+wesdiscordbot> 😦 20190105 02:21:20<+wesdiscordbot> It would be nice to know whether my described steps actually work for other people. 20190105 02:24:29<+wesdiscordbot> Someone will check in time probably 20190105 02:24:40<+wesdiscordbot> It's par for the course for certain bugs to involve nondeterministic behaviour 20190105 02:25:08<+wesdiscordbot> My 'problem' is that since the first time it crashed, it always crash when I do this. 20190105 02:25:26<+wesdiscordbot> I'm not sure if I'm doing something different or not. 20190105 02:25:36<+wesdiscordbot> Nondeterministic behaviour may or may not result in a consistent pattern for some people 20190105 02:25:40<+wesdiscordbot> Just don't worry about it 20190105 02:25:47<+wesdiscordbot> Okay. ^^ 20190105 02:29:49< irker462> wesnoth: nemaara wesnoth:master be587feee887 / data/campaigns/Liberty/scenarios/02_Civil_Disobedience.cfg: Liberty S2: modified ai gold and start location https://github.com/wesnoth/wesnoth/commit/be587feee887b0e45185669f1818a26f0c001701 20190105 02:29:51< irker462> wesnoth: nemaara wesnoth:master c49536f65216 / data/campaigns/Liberty/maps/02_Civil_Disobedience.map: Liberty S2: slightly modified map https://github.com/wesnoth/wesnoth/commit/c49536f652168ee82f19dbf05e1fb002c3b1faf6 20190105 02:35:00< irker462> wesnoth: nemaara wesnoth:1.14 640a17750c68 / data/campaigns/Liberty/scenarios/02_Civil_Disobedience.cfg: Liberty S2: modified ai gold and start location https://github.com/wesnoth/wesnoth/commit/640a17750c68e5416baf2753772b4525e0ac8e25 20190105 02:35:02< irker462> wesnoth: nemaara wesnoth:1.14 21689cd11426 / data/campaigns/Liberty/maps/02_Civil_Disobedience.map: Liberty S2: slightly modified map https://github.com/wesnoth/wesnoth/commit/21689cd114263c976cb4d5b86b9b0b3d81189c8d 20190105 02:43:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20190105 02:56:58-!- travis-ci [~travis-ci@ec2-54-163-137-71.compute-1.amazonaws.com] has joined #wesnoth-dev 20190105 02:56:58< travis-ci> wesnoth/wesnoth#20549 (master - c49536f : nemaara): The build is still failing. 20190105 02:56:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475583961 20190105 02:56:59-!- travis-ci [~travis-ci@ec2-54-163-137-71.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190105 03:22:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20190105 03:26:08< irker462> wesnoth: nemaara wesnoth:master 614263ede24c / data/campaigns/The_Rise_Of_Wesnoth/scenarios/02_The_Fall.cfg: TRoW S2: moved unit variable storage https://github.com/wesnoth/wesnoth/commit/614263ede24c29b553ce62b5ca29f3d8043ceab9 20190105 03:26:10< irker462> wesnoth: nemaara wesnoth:master 07f0e1ad104e / data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg: TRoW S5: moved unit variable storage https://github.com/wesnoth/wesnoth/commit/07f0e1ad104e9c3272971b7ce9eea6ec19e2ca51 20190105 03:43:05< irker462> wesnoth: nemaara wesnoth:1.14 e97aa84e2456 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/02_The_Fall.cfg: TRoW S2: moved unit variable storage https://github.com/wesnoth/wesnoth/commit/e97aa84e2456611490e9ae54c870571db6a1a602 20190105 03:43:07< irker462> wesnoth: nemaara wesnoth:1.14 f3b9978d933d / data/campaigns/The_Rise_Of_Wesnoth/scenarios/05_The_Oldwood.cfg: TRoW S5: moved unit variable storage https://github.com/wesnoth/wesnoth/commit/f3b9978d933d9394270c300581c2b5844f626b46 20190105 04:27:17<+wesdiscordbot> 😮 20190105 04:27:40<+wesdiscordbot> @sevu 😍 committing all of my PRs 20190105 04:31:13<+wesdiscordbot> 😃 20190105 04:31:32<+wesdiscordbot> if we want to get a 1.14.6 out … 20190105 04:35:26<+wesdiscordbot> still 30 more PRs labeled for 1.14.6, but only 1 blocker 20190105 05:06:35<+wesdiscordbot> There has been one bug though, storing the unit was moved from it's last breath to the victory event… unforunately, it already died by then 20190105 05:08:10< irker462> wesnoth: Severin Glöckner wesnoth:1.14 df14522acfef / data/campaigns/The_Rise_Of_Wesnoth/scenarios/02_The_Fall.cfg: TRoW: fixup https://github.com/wesnoth/wesnoth/commit/df14522acfefdf9a2873f1cfb0a54483ae0d0c42 20190105 05:09:13< irker462> wesnoth: Severin Glöckner wesnoth:master a03aaf0f7428 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/02_The_Fall.cfg: TRoW: keep unit alive until storing https://github.com/wesnoth/wesnoth/commit/a03aaf0f74280497ef04c8af6454db107268d59b 20190105 05:10:29<+wesdiscordbot> hmm 20190105 05:10:32<+wesdiscordbot> when I tested it it worked 20190105 05:11:08<+wesdiscordbot> but adding that line doesn't hurt I guess 20190105 05:13:43< irker462> wesnoth: Severin Glöckner wesnoth:1.14 3b4348104339 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg: TRoW S7 (Cutscene): Trees are allied https://github.com/wesnoth/wesnoth/commit/3b4348104339fab899d04f98067aeea400f73093 20190105 05:14:05< irker462> wesnoth: Severin Glöckner wesnoth:master ee0034e23a42 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg: TRoW S7 (Cutscene): Trees are allied https://github.com/wesnoth/wesnoth/commit/ee0034e23a42691b1420be548e5b299e5cb047c4 20190105 05:16:29<+wesdiscordbot> maybe you missed that case that you don't ally with her 20190105 05:18:33< irker462> wesnoth: nemaara wesnoth:master e8cbe935c24c / data/campaigns/Sceptre_of_Fire/maps/8_The_Dragon.map: SoF S8: added snow to map https://github.com/wesnoth/wesnoth/commit/e8cbe935c24cb0090f913fe85373c5104e5d0e7d 20190105 05:18:35< irker462> wesnoth: nemaara wesnoth:master ec31529aabb0 / data/campaigns/Sceptre_of_Fire/scenarios/3_Searching_for_the_Runecrafter.cfg: Sof S3: spawn troll whelps instead of woses https://github.com/wesnoth/wesnoth/commit/ec31529aabb0aad9692feb7ff4ba92ee433d7d08 20190105 05:18:37< irker462> wesnoth: nemaara wesnoth:master 563d4d64d286 / data/campaigns/Sceptre_of_Fire/ (maps/6_Towards_the_Caves.map scenarios/6_Towards_the_Caves.cfg): SoF S6: added elven guards https://github.com/wesnoth/wesnoth/commit/563d4d64d286c0347f2957700db224dadc925906 20190105 05:18:39< irker462> wesnoth: nemaara wesnoth:master c0ff76ccd2bf / data/campaigns/Sceptre_of_Fire/scenarios/1_A_Bargain_is_Struck.cfg: SoF S1: increased enemy gold https://github.com/wesnoth/wesnoth/commit/c0ff76ccd2bf877833651c613baa50249ef1f56b 20190105 05:18:41< irker462> wesnoth: nemaara wesnoth:master a1f855a0a858 / data/campaigns/Sceptre_of_Fire/scenarios/2_Closing_the_Gates.cfg: SoF S2: increased enemy income and modified ai https://github.com/wesnoth/wesnoth/commit/a1f855a0a858b422c09e1bd34713cad822b1d38e 20190105 05:21:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009] 20190105 05:24:28<+wesdiscordbot> yea I checked both cases 20190105 05:24:39<+wesdiscordbot> adding that line is safer tho 🤷 20190105 05:36:50< irker462> wesnoth: nemaara wesnoth:1.14 d397c6240818 / data/campaigns/Sceptre_of_Fire/maps/8_The_Dragon.map: SoF S8: added snow to map https://github.com/wesnoth/wesnoth/commit/d397c624081805ca643632824f9e000a10ecb3c6 20190105 05:36:52< irker462> wesnoth: nemaara wesnoth:1.14 edf6f936a26e / data/campaigns/Sceptre_of_Fire/scenarios/3_Searching_for_the_Runecrafter.cfg: Sof S3: spawn troll whelps instead of woses https://github.com/wesnoth/wesnoth/commit/edf6f936a26ef056213abd5c43888fb405ac1629 20190105 05:36:54< irker462> wesnoth: nemaara wesnoth:1.14 3f9056f17747 / data/campaigns/Sceptre_of_Fire/ (maps/6_Towards_the_Caves.map scenarios/6_Towards_the_Caves.cfg): SoF S6: added elven guards https://github.com/wesnoth/wesnoth/commit/3f9056f177479131922b3bf24ccf66ca76364c72 20190105 05:36:56< irker462> wesnoth: nemaara wesnoth:1.14 f9991c72ce6c / data/campaigns/Sceptre_of_Fire/scenarios/1_A_Bargain_is_Struck.cfg: SoF S1: increased enemy gold https://github.com/wesnoth/wesnoth/commit/f9991c72ce6cc690d404a8aa6c8896b7e4e4e20c 20190105 05:36:58< irker462> wesnoth: nemaara wesnoth:1.14 987dc662f580 / data/campaigns/Sceptre_of_Fire/scenarios/2_Closing_the_Gates.cfg: SoF S2: increased enemy income and modified ai https://github.com/wesnoth/wesnoth/commit/987dc662f5800732a684424e1f838bb0f93376cd 20190105 05:37:00< irker462> wesnoth: Severin Glöckner wesnoth:1.14 a66cf5f7f261 / data/campaigns/Sceptre_of_Fire/scenarios/7_Outriding_the_Outriders.cfg: SoF S7: remove accidentally commited line https://github.com/wesnoth/wesnoth/commit/a66cf5f7f2613821d71777026336a93fbe9a8c65 20190105 05:37:15< irker462> wesnoth: Severin Glöckner wesnoth:master e9b65753aa6b / data/campaigns/Sceptre_of_Fire/scenarios/7_Outriding_the_Outriders.cfg: SoF S7: remove accidentally commited line https://github.com/wesnoth/wesnoth/commit/e9b65753aa6bf921a7d9e2c39a1351f5e3bc785e 20190105 05:38:18<+wesdiscordbot> Trust me, it's needed 20190105 05:49:19<+wesdiscordbot> @hrubymar10 Could you update the xcode project with the new files added in https://github.com/wesnoth/wesnoth/commit/34e2ef12c762b6e65664493b84eb163d39fd8093 ? 20190105 05:52:42< irker462> wesnoth: Severin Glöckner wesnoth:1.14 7392f8fe28a4 / / (5 files in 3 dirs): commandline: remove --path option https://github.com/wesnoth/wesnoth/commit/7392f8fe28a448bfd3d49125cb5d655d5027ebb8 20190105 05:53:08< irker462> wesnoth: Severin Glöckner wesnoth:master e8cc7f22bfbd / / (5 files in 3 dirs): commandline: remove --path option https://github.com/wesnoth/wesnoth/commit/e8cc7f22bfbdc6354b06d930931ee629dfb0b4b8 20190105 05:54:10-!- travis-ci [~travis-ci@ec2-54-146-23-139.compute-1.amazonaws.com] has joined #wesnoth-dev 20190105 05:54:11< travis-ci> wesnoth/wesnoth#20554 (master - a1f855a : nemaara): The build is still failing. 20190105 05:54:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475610594 20190105 05:54:11-!- travis-ci [~travis-ci@ec2-54-146-23-139.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190105 05:56:31<+wesdiscordbot> @sevu could you close the SoF issues related to those commits 😮 20190105 06:04:03<+wesdiscordbot> o.O I got too much used to the luxury of commits closing issues 20190105 06:05:24<+wesdiscordbot> 😮 😮 😮 20190105 06:32:46<+wesdiscordbot> @sevu Are you sure it's okay to just remove the --path switch in the stable branch? 20190105 06:35:49<+wesdiscordbot> I think usage of the command line options is not that widespread. In case someone uses it, it can be switched to --data-path. 20190105 06:37:09<+wesdiscordbot> (I should mention it in the changelog though) 20190105 06:37:13<+wesdiscordbot> @jyrkive 20190105 06:49:36-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190105 07:02:11-!- travis-ci [~travis-ci@ec2-54-162-153-18.compute-1.amazonaws.com] has joined #wesnoth-dev 20190105 07:02:12< travis-ci> wesnoth/wesnoth#20557 (master - e8cc7f2 : Severin Glöckner): The build is still failing. 20190105 07:02:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475616119 20190105 07:02:13-!- travis-ci [~travis-ci@ec2-54-162-153-18.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190105 07:23:17-!- celticminstrel is now known as celmin|sleep 20190105 07:27:28< irker462> wesnoth: pentarctagon wesnoth:master 48e22e821023 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg: Fix typo found by schema https://github.com/wesnoth/wesnoth/commit/48e22e821023a96b1485d78f852c1dbcbb73782c 20190105 07:28:31< celmin|sleep> Nice! 20190105 07:28:34< irker462> wesnoth: pentarctagon wesnoth:1.14 e88127a19011 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg: Fix typo found by schema https://github.com/wesnoth/wesnoth/commit/e88127a19011971de6973569321177c360fd98ac 20190105 07:28:44<+wesdiscordbot> 😄 20190105 07:46:32< irker462> wesnoth: Martin Hrubý (hrubymar10) wesnoth:master b6b7bd6cfbbe / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Fix Xcode project https://github.com/wesnoth/wesnoth/commit/b6b7bd6cfbbe74e6ff6d689fc1e14eb7c9630416 20190105 07:51:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190105 07:54:33-!- travis-ci [~travis-ci@ec2-54-242-168-24.compute-1.amazonaws.com] has joined #wesnoth-dev 20190105 07:54:34< travis-ci> wesnoth/wesnoth#20558 (master - 48e22e8 : pentarctagon): The build is still failing. 20190105 07:54:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475630246 20190105 07:54:34-!- travis-ci [~travis-ci@ec2-54-242-168-24.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190105 08:06:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20190105 08:22:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190105 08:31:07-!- travis-ci [~travis-ci@ec2-54-88-7-124.compute-1.amazonaws.com] has joined #wesnoth-dev 20190105 08:31:08< travis-ci> wesnoth/wesnoth#20560 (master - b6b7bd6 : Martin Hrubý (hrubymar10)): The build was fixed. 20190105 08:31:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/475632410 20190105 08:31:08-!- travis-ci [~travis-ci@ec2-54-88-7-124.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190105 09:48:27< irker462> wesnoth/wesnoth:master nemaara 07f0e1ad10 TRoW S5: moved unit variable storage AppVeyor: All builds passed 20190105 10:10:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190105 10:54:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190105 11:52:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190105 11:57:47< irker462> wesnoth/wesnoth:1.14 Severin Glöckner a66cf5f7f2 SoF S7: remove accidentally commited lin AppVeyor: All builds passed 20190105 13:08:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190105 13:50:26< irker462> wesnoth/wesnoth:1.14 pentarctagon e88127a190 Fix typo found by schema AppVeyor: All builds passed 20190105 15:33:04< irker462> wesnoth: Jyrki Vesterinen wesnoth:master 4147df7efcb0 / CMakeLists.txt SConstruct src/CMakeLists.txt: Explicitly link to GObject (should fix #3840) https://github.com/wesnoth/wesnoth/commit/4147df7efcb05fb3eb3be2a53ccc40eea25cf44b 20190105 15:58:22<+wesdiscordbot> currently linking it 20190105 15:58:47<+wesdiscordbot> does linking always only use one core, or are it all for you? 20190105 15:59:42<+wesdiscordbot> It uses all cores on my system. 20190105 15:59:54<+wesdiscordbot> Note that I compile with Clang and link with lld. 20190105 16:00:27< irker462> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) b6b7bd6cfb Fix Xcode project AppVeyor: All builds passed 20190105 16:05:27<+wesdiscordbot> I switched to the python3 version of scons, and it did then compplain that »my python« wouldn't support using multiple cores, though it used all for compiling… maybe it's that… (strangely I see the warning this time not) 20190105 16:05:32<+wesdiscordbot> Your fix works fine 20190105 16:05:52< irker462> wesnoth: Jyrki Vesterinen wesnoth:1.14 d664aaf96ea3 / CMakeLists.txt SConstruct src/CMakeLists.txt: Explicitly link to GObject (should fix #3840) https://github.com/wesnoth/wesnoth/commit/d664aaf96ea37dc772d3adb8ab63ed1b3e64be0a 20190105 16:06:52<+wesdiscordbot> Python's multiprocessing support doesn't matter for building. SCons runs external binaries for that. 20190105 16:08:54<+wesdiscordbot> https://lld.llvm.org/ 20190105 16:09:03<+wesdiscordbot> > LLD is very fast. When you link a large program on a multicore machine, you can expect that LLD runs more than twice as fast as GNU gold linker. Your milage may vary, though. 20190105 16:19:47< irker462> wesnoth: Jyrki Vesterinen wesnoth:1.14 47432410076e / changelog.md: Changelog entry for commit d664aaf9 https://github.com/wesnoth/wesnoth/commit/47432410076e117acd6abacf82abc0cd796faee0 20190105 16:22:36<+wesdiscordbot> @Vultraz 1.14.6 will need to be released relatively soon, before a popular GNU/Linux distribution ships Pango 1.43 (breaking build of 1.14.5). 20190105 16:35:10<+wesdiscordbot> I looked a bit into the lld (and got a habit of misstyping it as ldd) Accordigt to https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html an --fuse-ld=lld should exist, but ti doesn't work with my ~2 month old compiler… maybe they mean only gcc, not g++… 20190105 16:35:58<+wesdiscordbot> Strange. It should work with g++. 20190105 16:55:51<+wesdiscordbot> Seems not like I can get it run: g++ -o wesnoth -Wl,-O1 -pthread -fPIE -pie -Wl,-z,relro,-z,now -O3 -march=native -flto=1 -fuse-ld=lld -Wl,--whole-archive build/release/libwesnoth-widgets.a -Wl,--no-whole-archive build/release/wesnoth.o build/release/libwesnoth-client.a build/release/liblua.a build/release/libwesnoth-core.a build/release/libwesnoth-game.a build/release/libwesnoth-sdl.a build/release/libwesnoth-client.a -lm 20190105 16:55:51<+wesdiscordbot> -lboost_iostreams -lboost_random -lboost_locale -lpthread -lboost_system -lboost_thread -lboost_filesystem -licudata -licui18n -licuuc -lcrypto -lSDL2 -lSDL2_ttf -lSDL2_mixer -lSDL2_image -lvorbisfile -lgobject-2.0 -lglib-2.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -lfontconfig -lfreetype -lboost_program_options -lboost_regex -lX11 -ldbus-1 -lfribidi -lhistory -lgomp g++: Fehler: unbekannte Kommandozeilenoption »-fuse-ld=lld«; 20190105 16:55:52<+wesdiscordbot> meinten Sie »-fuse-ld=bfd«? (unknown commandline optione … maybe you meant…) 20190105 16:56:18<+wesdiscordbot> Though, I see the realson why it only uses one core, -flto=0 20190105 16:56:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds] 20190105 16:56:45<+wesdiscordbot> *1, not 0 20190105 16:57:12<+wesdiscordbot> Very odd. It even suggests -fuse-ld=bfd. 20190105 16:57:43<+wesdiscordbot> I would otherwise suspect that you just have an old version of GCC, but your system is otherwise very recent (with Pango 1.43, for one...) 20190105 16:58:03<+wesdiscordbot> bfd is probably a closer string than gold 20190105 16:58:51<+wesdiscordbot> My point is that your copy of GCC recognizes the -fuse-ld parameter, but just denies that lld is a valid value. 20190105 16:58:53<+wesdiscordbot> 8.2.1+20181127 seems to be a git version from end of november (shipped in the repo as stable) 20190105 17:00:42<+wesdiscordbot> A quick check shows that linking with LLD was already supported in GCC 6.3: https://www.phoronix.com/scan.php?page=article&item=lld4-linux-tests&num=2 20190105 17:21:53<+wesdiscordbot> maybe they compiled Arch compiler with the wrong flags… can someone build with gcc & lld instead gold? e.g. by chanhing this line https://github.com/wesnoth/wesnoth/blob/master/SConstruct#L567 20190105 17:29:22<+wesdiscordbot> …compiling takes so long … (and now I compile with 4 jobs, turned out that for some reason I had this not det) 20190105 17:35:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190105 17:54:36<+wesdiscordbot> @loonycyborg If I switch from 1.14 to 1.12 branch, scons fails ( scons: *** [translations/af/LC_MESSAGES/wesnoth-sota.mo] Source `po/wesnoth-sota/af.po' not found, needed by target `translations/af/LC_MESSAGES/wesnoth-sota.mo'.) still after removing the build/ folder and running scons -c all. What was the correct way to reset scons? 20190105 18:15:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds] 20190105 18:31:36<+wesdiscordbot> @sevu There's always git clean -fdx 20190105 18:35:51<+wesdiscordbot> @jyrkive please elaborate 20190105 18:36:17<+wesdiscordbot> https://github.com/wesnoth/wesnoth/issues/3840 20190105 18:36:51<+wesdiscordbot> Once GNU/Linux distributions update to Pango 1.43, building Wesnoth 1.14.5 on them won't be possible anymore. 20190105 18:36:56<+wesdiscordbot> Ok. 20190105 18:37:28<+wesdiscordbot> We will release this month 20190105 18:56:51<+wesdiscordbot> great ! 😃 20190105 18:57:32<+wesdiscordbot> any idea yet when will string freeze start? There are some PRs I'd like to get in 1.14.6 if I manage it 20190105 18:59:21<+wesdiscordbot> it can start tomorrow 20190105 18:59:27<+wesdiscordbot> if all PRs can be merged 20190105 19:07:11<+wesdiscordbot> I can merge them tomorrow night 20190105 19:12:45-!- buhman [~rewt@c-73-162-194-50.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 20190105 19:15:30< celmin|sleep> "all PRs" 20190105 19:15:32< celmin|sleep> :P 20190105 19:15:36-!- celmin|sleep is now known as celticminstrel 20190105 19:15:43< celticminstrel> Isn't that a bit too vague. :P 20190105 19:16:46<+wesdiscordbot> no, it's well defined. for (i = 1; i < 3840; i++) merge(i); 20190105 19:16:57<+wesdiscordbot> 😆 20190105 19:17:09< celticminstrel> That's why it's too vauge. 20190105 19:17:11< celticminstrel> vague 20190105 19:20:01-!- irker462 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190105 20:59:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20190105 21:07:42<+wesdiscordbot> I checked yesterday how many PRs are left, ~10 could be merged 20190105 21:08:47-!- irker066 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190105 21:08:47< irker066> wesnoth: Jyrki Vesterinen wesnoth:1.12 406893963f73 / CMakeLists.txt SConstruct src/CMakeLists.txt: Explicitly link to GObject (should fix #3840) https://github.com/wesnoth/wesnoth/commit/406893963f73a5cd21f19f5da6587d914f7cef1c 20190105 21:08:59< irker066> wesnoth: Jyrki Vesterinen wesnoth:1.10 16b8aac49a63 / CMakeLists.txt SConstruct src/CMakeLists.txt: Explicitly link to GObject (should fix #3840) https://github.com/wesnoth/wesnoth/commit/16b8aac49a633f7918c6abbd3179a74ec63bdb32 20190105 21:09:16< irker066> wesnoth: Jyrki Vesterinen wesnoth:1.8 bb3bed0b07de / CMakeLists.txt SConstruct src/CMakeLists.txt: Explicitly link to GObject (should fix #3840) https://github.com/wesnoth/wesnoth/commit/bb3bed0b07deee646d32d70704a947971cc972bc 20190105 21:09:18< irker066> wesnoth: Severin Glöckner wesnoth:1.8 859bfc5a7e81 / configure.ac: Explicitly link to GObject – autotools fix https://github.com/wesnoth/wesnoth/commit/859bfc5a7e81f3a5b913b4cb33477fb177986010 20190105 21:20:48<+wesdiscordbot> @shadowm do you remember how to push to 1.6? the branch and tag have the same name… I could get around by having the branch locally named differently… 20190105 21:21:26< celticminstrel> ...you can't push to a tag though, can you? 20190105 21:23:25< Ravana> I think it depends on git version https://github.com/git/git/commit/d39cab3989f9e660cae124f78143369b13ad2901 20190105 21:23:40< celticminstrel> o.o 20190105 21:23:56< celticminstrel> git is on github... 20190105 21:24:02< celticminstrel> Shock 20190105 21:24:11< celticminstrel> Horrorror 20190105 21:24:29< Ravana> its only copy 20190105 21:24:32<+wesdiscordbot> That repository isn't Git's primary repo. It's just a mirror. 20190105 21:24:33<+wesdiscordbot> The error I have with pushing: error: dst refspec 1.6 matches more than one. 20190105 21:24:44< celticminstrel> Okay, fair enough. 20190105 21:25:13< celticminstrel> Maybe you need to use a "full" refspec? Something like the path used to pull a pull request. 20190105 21:25:23<+wesdiscordbot> Last time I cloned the repo with -b option, and was thus in the branch into which I latter can't go back… this somehow worked 20190105 21:25:27< celticminstrel> (Which is refs/pulls/###/head IIRC) 20190105 21:25:36< celticminstrel> (Possibly with less S) 20190105 21:26:00< celticminstrel> (So maybe something like refs/1.6?) 20190105 21:26:04<+wesdiscordbot> Ravana: that Git commit is also about a corner case where updating a tag was possible. Almost no one pushes changes by fetching, and no one even knew it was possible to overwrite tags with it. 20190105 21:26:11< celticminstrel> (I think the tag would be refs/tags/1.6?) 20190105 21:26:25< celticminstrel> (So maybe refs/branches/1.6? This is all speculation though.) 20190105 21:26:37<+wesdiscordbot> refs/heads/1.6? 20190105 21:26:43< celticminstrel> Maybe. 20190105 21:27:07< Ravana> I see 20190105 21:27:22< Ravana> we use release branches instead of tags, so I don't have much experience with those 20190105 21:27:39< celticminstrel> Both. 20190105 21:28:02< celticminstrel> Release branches for the "minor" revision, tags for the bugfix revision. 20190105 21:40:27< irker066> wesnoth/wesnoth:master Jyrki Vesterinen 4147df7efc Explicitly link to GObject (should fix # AppVeyor: All builds passed 20190105 21:40:37<+wesdiscordbot> wow so many backports 20190105 21:40:59<+wesdiscordbot> I think it ultimately won't be necessary 20190105 21:41:43<+wesdiscordbot> not won't be harmful either 20190105 21:41:58<+wesdiscordbot> plg-config was always supposed to handle such indirect dependencies 20190105 21:42:06<+wesdiscordbot> there's no reason it would stop doing it now 20190105 21:42:10<+wesdiscordbot> other than a bug 20190105 21:42:39< irker066> wesnoth: Jyrki Vesterinen wesnoth:1.6 b82d52b72b38 / CMakeLists.txt SConstruct src/CMakeLists.txt: Explicitly link to GObject (should fix #3840) https://github.com/wesnoth/wesnoth/commit/b82d52b72b38397a0e15e40a3370a9bd934afce9 20190105 21:42:41< irker066> wesnoth: Severin Glöckner wesnoth:1.6 a93fc74ab4af / configure.ac: Explicitly link to GObject (autotools patch) https://github.com/wesnoth/wesnoth/commit/a93fc74ab4af17094ab36d2f9cbd183272aa4cdb 20190105 21:43:00<+wesdiscordbot> hmmm … 20190105 21:43:26<+wesdiscordbot> (In the end I didn't figure it out and used another git clone) 20190105 21:43:46<+wesdiscordbot> @loonycyborg We're not supposed to be able to use indirect dependencies directly. 20190105 21:44:21<+wesdiscordbot> We do call g_object_unref() directly (or to be fully pedantic, we pass it as a parameter to the C++ standard library). 20190105 21:44:28<+wesdiscordbot> hmm I guess 20190105 21:45:45<+wesdiscordbot> There is a linker feature that would allow ourselves to use functions from indirect dependencies. It's called implicit DSO linking. However, it was disabled by default in all primary linkers a few years back. 20190105 21:46:04<+wesdiscordbot> It can still be enabled manually, but it's considered a bad practice. 20190105 21:46:21<+wesdiscordbot> (There is another project of mine that does enable it.) 20190105 21:49:54<+wesdiscordbot> yes but it wasn't issue for wesnoth because pkg-config was adding -lgobject 20190105 21:50:17<+wesdiscordbot> and I kinda don't see a reason for it to stop doing it 20190105 21:50:39<+wesdiscordbot> I think it's not pkg-config itself that was doing it. More likely Pango's pkg-config configuration file. 20190105 21:51:16<+wesdiscordbot> yes it's data in .pc file 20190105 21:51:23<+wesdiscordbot> I just saw your comment. For me pkg-config --libs cairo returns only -lcairo 20190105 21:51:24<+wesdiscordbot> that pkg-config reads 20190105 21:51:32<+wesdiscordbot> but are part of the library itself 20190105 21:51:36<+wesdiscordbot> ähm 20190105 21:51:39<+wesdiscordbot> not cairo… pango 20190105 21:51:57<+wesdiscordbot> -lpango-1.0 20190105 21:53:08<+wesdiscordbot> /usr/lib64/pkgconfig/pango.pc 20190105 21:53:15<+wesdiscordbot> that's where it is 20190105 21:53:24<+wesdiscordbot> @sevu what does that file have for you? 20190105 21:54:31<+wesdiscordbot> https://bpaste.net/show/3f24399be2fd 20190105 21:56:26<+wesdiscordbot> for me it has 20190105 21:56:39<+wesdiscordbot> Requires: glib-2.0 gobject-2.0 Requires.private: fribidi 20190105 21:56:53<+wesdiscordbot> maybe that's because yours have everything in requires.private 20190105 21:58:05<+wesdiscordbot> Mine is similar to loonycyborg's. 20190105 21:58:24<+wesdiscordbot> The distro is siduction. Pango is 1.42.something. 20190105 21:59:20<+wesdiscordbot> (The file path for me is /usr/lib/x86_64-linux-gnu/pkgconfig/pango.pc.) 20190105 22:00:52<+wesdiscordbot> seems they moved it to .private to avoid overlinking 20190105 22:01:05<+wesdiscordbot> but perhaps gobject is justified to stay public 20190105 22:01:22<+wesdiscordbot> because it's part of standard patterns of using the lib 20190105 22:01:45<+wesdiscordbot> Yeah, I see the point. 20190105 22:01:55<+wesdiscordbot> Which distro do you use, @sevu ? 20190105 22:05:08<+wesdiscordbot> I'm on archlinux 20190105 22:05:50<+wesdiscordbot> I had a look in their git repo, the added a few commits after the release tag requires: ['gobject-2.0'], 20190105 22:06:11<+wesdiscordbot> this is for the generator for the pkgconfig file 20190105 22:06:36<+wesdiscordbot> Hmm, Arch. They aren't afraid to break builds of external software, right? 20190105 22:06:58<+wesdiscordbot> I think Debian, for example, has some sort of policy to avoid disruptions like this... 20190105 22:07:07<+wesdiscordbot> Arch just took what they released 20190105 22:07:11<+wesdiscordbot> yes that requires would fix it 20190105 22:08:08<+wesdiscordbot> So hmm, that commit is from mid december, Arch released pango a few days ago, but has not that commit… 20190105 22:11:09<+wesdiscordbot> OK, I found the commit myself. 20190105 22:11:10<+wesdiscordbot> https://gitlab.gnome.org/GNOME/pango/commit/d0cb6be7431d1a3c711bd45bcf05b34601604037 20190105 22:11:48<+wesdiscordbot> Yeah, looks like GNOME has already backtracked this change, after realizing that it breaks way too much stuff. 20190105 22:12:08<+wesdiscordbot> @Vultraz See above. The 1.14.6 release isn't urgent after all. 20190105 22:19:01<+wesdiscordbot> There's the boost tribool fix though 20190105 22:19:32<+wesdiscordbot> which has the same implications 20190105 22:20:55<+wesdiscordbot> Here is Pango developers' discussion about the change: https://gitlab.gnome.org/GNOME/pango/merge_requests/22#note_390137 20190105 22:21:33<+wesdiscordbot> They hadn't even expected that the change would have made GObject a private dependency. 20190105 22:57:53< irker066> wesnoth: DisherProject wesnoth:1.14 f7f3d766f016 / data/campaigns/Dead_Water/scenarios/ (02_Flight.cfg 10_The_Flaming_Sword.cfg): DW: Use show_if in the objectives tag https://github.com/wesnoth/wesnoth/commit/f7f3d766f0166a2bf7b10900abcf565434d8558a 20190105 22:57:55< irker066> wesnoth: DisherProject wesnoth:1.14 f6d10dd6c3d7 / data/campaigns/Dead_Water/scenarios/12_Revenge.cfg: DW S12: Fix event filter https://github.com/wesnoth/wesnoth/commit/f6d10dd6c3d7c8f6a604004439fceecd1286a1e4 20190105 22:57:57< irker066> wesnoth: DisherProject wesnoth:1.14 763fdff7819e / data/campaigns/Descent_Into_Darkness/scenarios/03_A_Haunting_in_Winter.cfg: DiD S3: Redraw fog and shroud after retrieving your units https://github.com/wesnoth/wesnoth/commit/763fdff7819e80bd05d95e995f505b9342187a15 20190105 22:57:59< irker066> wesnoth: DisherProject wesnoth:1.14 f48d61b69f40 / data/campaigns/Descent_Into_Darkness/scenarios/ (04_Beginning_of_the_Revenge.cfg 10_Alone_at_Last.cfg): DiD: implement filtering by type_adv_tree https://github.com/wesnoth/wesnoth/commit/f48d61b69f40e03f3f3d607ccb005a209c1f7449 20190105 22:58:01< irker066> wesnoth: DisherProject wesnoth:1.14 6e6bedb32a95 / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: Replace deprecated tag https://github.com/wesnoth/wesnoth/commit/6e6bedb32a95d3672505a8de6bf7d115d3dba965 20190105 22:58:03< irker066> wesnoth: Severin Glöckner wesnoth:1.14 971bc5663083 / data/campaigns/Dead_Water/scenarios/02_Flight.cfg: DW S2: undefine scenariospecific macro https://github.com/wesnoth/wesnoth/commit/971bc5663083394b6c9dacba6ca4ff8df4ad556f 20190105 22:58:05< irker066> wesnoth: DisherProject wesnoth:master 8d8ab8aad5c1 / data/campaigns/Dead_Water/scenarios/ (02_Flight.cfg 10_The_Flaming_Sword.cfg): DW: Use show_if in the objectives tag https://github.com/wesnoth/wesnoth/commit/8d8ab8aad5c141618ca653327176d90720833a45 20190105 22:58:07< irker066> wesnoth: DisherProject wesnoth:master daff6567198d / data/campaigns/Dead_Water/scenarios/12_Revenge.cfg: DW S12: Fix event filter https://github.com/wesnoth/wesnoth/commit/daff6567198dc83b76b6067cd69fbca6bb702c42 20190105 22:58:09< irker066> wesnoth: DisherProject wesnoth:master d62d8c067704 / data/campaigns/Descent_Into_Darkness/scenarios/03_A_Haunting_in_Winter.cfg: DiD S3: Redraw fog and shroud after retrieving your units https://github.com/wesnoth/wesnoth/commit/d62d8c067704c8dce9a79968f576e9d104cbed41 20190105 22:58:11< irker066> wesnoth: DisherProject wesnoth:master 036bded5a8bc / data/campaigns/Descent_Into_Darkness/scenarios/ (04_Beginning_of_the_Revenge.cfg 10_Alone_at_Last.cfg): DiD: implement filtering by type_adv_tree https://github.com/wesnoth/wesnoth/commit/036bded5a8bcebb2cf251e8cb5b9b453f694473e 20190105 22:58:13< irker066> wesnoth: DisherProject wesnoth:master ab16924ca975 / data/campaigns/Descent_Into_Darkness/scenarios/07_A_Small_Favor.cfg: DiD S7: Replace deprecated tag https://github.com/wesnoth/wesnoth/commit/ab16924ca97501e015c4063243bdb9a5a58cf5e8 20190105 22:58:15< irker066> wesnoth: Severin Glöckner wesnoth:master 93b4c60ca911 / data/campaigns/Dead_Water/scenarios/02_Flight.cfg: DW S2: undefine scenariospecific macro https://github.com/wesnoth/wesnoth/commit/93b4c60ca9119cf86b7afebfa0159c9779151a0f --- Log closed Sun Jan 06 00:00:46 2019