--- Log opened Sun Jan 06 00:00:46 2019 20190106 00:22:19< irker066> wesnoth: Severin Glöckner wesnoth:1.14 d4a5660d06d7 / changelog.md: changelog entries for recent merges: https://github.com/wesnoth/wesnoth/commit/d4a5660d06d7e3c90852b7ab6862b66f51b0e7ca 20190106 00:28:41< Ravana> I recall instructing being removed, which would invalidate https://github.com/wesnoth/wesnoth/issues/1464 20190106 00:37:01< irker066> wesnoth/wesnoth:1.14 Jyrki Vesterinen 4743241007 Changelog entry for commit d664aaf9 AppVeyor: All builds passed 20190106 00:37:26< celticminstrel> I guess the were probably supposed to be smart quotes or guillemots or some such thing. 20190106 01:19:09< Ravana> I suggest removing "good first issue" from https://github.com/wesnoth/wesnoth/issues/1339 since it requires modifying theme to show for each poisoned unit its poison parameters, and https://github.com/wesnoth/wesnoth/issues/1248 since it is no longer relevant 20190106 01:28:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190106 01:34:06< celticminstrel> @sevu Ravana - I suggest removing wontfix and leaving it open (maybe add low priority tag too, if that exists). 20190106 01:35:49<+wesdiscordbot> But it's not needed anymore 20190106 01:36:08< celticminstrel> It's not needed for Wesnoth's official servers. That doesn't necessarily mean it's not needed. 20190106 01:37:25<+wesdiscordbot> Somewhat it does. Who is having unofficial servers plus having the habbit of banning plenty of IPs, but never unbanning them… 20190106 01:37:54<+wesdiscordbot> One could also say, the root problem has been fixed 20190106 01:38:00< celticminstrel> Has it? 20190106 01:39:21<+wesdiscordbot> actually, I'm not sure … 20190106 01:40:09< celticminstrel> FTR, I commented on the issue itself (basically just the same stuff I said here) so you might want to respond there also. 20190106 01:46:05< Ravana> I intentionally did not mention closing the issue for this reason, both today and in the comment 20190106 01:47:09< celticminstrel> I see. 20190106 01:47:57< celticminstrel> I would've probably just re-opened it myself, but I think if it's to be re-opened then the wontfix tag should be removed at the same time, and I need to switch computers to edit labels. 20190106 01:52:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190106 02:32:00<+wesdiscordbot> Our issue counter goes close to 1000... don't we want to close some could be, but won't really do issues? 20190106 02:32:57< celticminstrel> I don't think total issue count is a reason to close issues, personally. 20190106 02:44:44<+wesdiscordbot> well, in the end it's just a number, but I'd like to see it decrease from times to time. I colosed yesterday quite a few issues and PRs, and when I looked at the github stats for this week and saw that for the 16 closed 16 new ones had been created... fells like one didn't really move sth.. 20190106 02:50:05< celticminstrel> I guess I do understand that a little... 20190106 02:50:19< celticminstrel> And it's certainly not something that's any kind of priority. 20190106 02:50:34< celticminstrel> Not haven't an issue open for it also doesn't mean it can't be done someday. 20190106 03:37:12-!- irker066 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190106 03:48:40-!- irker018 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190106 03:48:40< irker018> wesnoth/wesnoth:master nemaara 109a7b0ed6 DiD S1: updated map AppVeyor: All builds passed 20190106 04:56:26< irker018> wesnoth/wesnoth:master nemaara f90ba2daef DiD S1: updated map AppVeyor: All builds passed 20190106 05:03:50<+wesdiscordbot> the number of bugs is more important than the number of total issues, I'd say 20190106 05:16:44< celticminstrel> That's true. 20190106 07:11:39< irker018> wesnoth/wesnoth:master Severin Glöckner 93b4c60ca9 DW S2: undefine scenariospecific macro AppVeyor: All builds passed 20190106 07:40:21-!- celticminstrel is now known as celmin|sleep 20190106 07:46:53-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190106 09:18:55< irker018> wesnoth/wesnoth:1.14 Severin Glöckner d4a5660d06 changelog entries for recent merges: AppVeyor: All builds passed 20190106 09:56:51< irker018> wesnoth: loonycyborg wesnoth:master 0e06f70dda5d / src/utils/parse_network_address.cpp: Made regex for matching network addresses stricter https://github.com/wesnoth/wesnoth/commit/0e06f70dda5d5488043b9e1ba5398d4410e80d38 20190106 10:21:42<+wesdiscordbot> Things you find when you look for wesnoth portraits. 20190106 10:21:43<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/531417063680376842/konrad_adaptation.png 20190106 10:46:00< irker018> wesnoth/wesnoth:master nemaara ddb6103631 DiD S1: updated map AppVeyor: All builds passed 20190106 11:48:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190106 13:27:59< irker018> wesnoth/wesnoth:master nemaara 35145d75c2 DiD S2: changed scenario music AppVeyor: All builds passed 20190106 14:55:25< irker018> wesnoth/wesnoth:master nemaara ffca5f6344 DiD S3: added text for dwarf leader deat AppVeyor: All builds passed 20190106 15:41:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190106 15:41:42< irker018> wesnoth: Severin Glöckner wesnoth:master 174c6ac020c7 / data/campaigns/Dead_Water/scenarios/12_Revenge.cfg: DW S12: fix SUF https://github.com/wesnoth/wesnoth/commit/174c6ac020c743f259e07623029e522dd1b27e02 20190106 15:41:44< irker018> wesnoth: Severin Glöckner wesnoth:master 452f5fc69447 / data/campaigns/Dead_Water/scenarios/12_Revenge.cfg: DW 12: refactor event code https://github.com/wesnoth/wesnoth/commit/452f5fc694479cee879924f0bd131215881fdeb1 20190106 15:41:46< irker018> wesnoth: Severin Glöckner wesnoth:master eab13f3fb1c9 / data/campaigns/Dead_Water/scenarios/12_Revenge.cfg: DW 12: remove bat event after the necklace has been picked up https://github.com/wesnoth/wesnoth/commit/eab13f3fb1c95bd33d4d2066d260e680899b38a6 20190106 15:42:39< irker018> wesnoth: Severin Glöckner wesnoth:1.14 3d7f5baafdca / data/campaigns/Dead_Water/scenarios/12_Revenge.cfg: DW S12: fix SUF https://github.com/wesnoth/wesnoth/commit/3d7f5baafdcacdbdf81eea927a111251eb97046c 20190106 15:47:00< irker018> wesnoth: nemaara wesnoth:master e3e83ba7f5b2 / data/campaigns/Sceptre_of_Fire/scenarios/5_Hills_of_the_Shorbear_Clan.cfg: SoF S5: made objective clearer https://github.com/wesnoth/wesnoth/commit/e3e83ba7f5b22b81449aaebfca19cc5994fbc86d 20190106 15:48:14< irker018> wesnoth: nemaara wesnoth:1.14 8880775c80b2 / data/campaigns/Sceptre_of_Fire/scenarios/5_Hills_of_the_Shorbear_Clan.cfg: SoF S5: made objective clearer https://github.com/wesnoth/wesnoth/commit/8880775c80b2ab209854355c00459b9fb6de13ed 20190106 15:49:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20190106 15:54:55<+wesdiscordbot> that "Add search functionality" change is a lot more popular than I would ever have guessed 20190106 15:57:17< irker018> wesnoth: nemaara wesnoth:master 824e6bf7a355 / data/campaigns/Eastern_Invasion/scenarios/02_The_Escape_Tunnel.cfg: EI S2: modified player fog and shroud settings https://github.com/wesnoth/wesnoth/commit/824e6bf7a35560b91aacf525aa67d5a47681c9fc 20190106 15:57:19< irker018> wesnoth: nemaara wesnoth:master 9cbd4a71f3eb / data/campaigns/Eastern_Invasion/scenarios/02_The_Escape_Tunnel.cfg: EI S2: minor shroud and dialogue changes https://github.com/wesnoth/wesnoth/commit/9cbd4a71f3ebaa2ad99ac3de472ff5978f4748c5 20190106 15:57:46-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 15:57:47< travis-ci> wesnoth/wesnoth#20576 (master - e3e83ba : nemaara): The build was canceled. 20190106 15:57:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476008833 20190106 15:57:47-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 15:58:41< irker018> wesnoth: nemaara wesnoth:1.14 f295895f9d76 / data/campaigns/Eastern_Invasion/scenarios/02_The_Escape_Tunnel.cfg: EI S2: modified player fog and shroud settings https://github.com/wesnoth/wesnoth/commit/f295895f9d76b581a5166d050cee6dd3aa7c4a36 20190106 15:58:43< irker018> wesnoth: nemaara wesnoth:1.14 649f2b8a3a0e / data/campaigns/Eastern_Invasion/scenarios/02_The_Escape_Tunnel.cfg: EI S2: minor shroud and dialogue changes https://github.com/wesnoth/wesnoth/commit/649f2b8a3a0e29c496fec73c421d77e520ae7199 20190106 15:59:11<+wesdiscordbot> @sevu Thanks, I would have merged it later today otherwise. 20190106 16:14:12<+wesdiscordbot> @josteph You're welcome. Would you maybe like to merge the c++ PRs? 20190106 16:27:44<+wesdiscordbot> @sevu Which ones? I have a few string freeze PRs on my list 20190106 16:28:45<+wesdiscordbot> 3759 and 3683 20190106 16:31:27-!- celmin|sleep is now known as celticminstrel 20190106 16:36:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190106 16:49:04< celticminstrel> ...WTH? o.O https://wiki.wesnoth.org/index.php?title=SingleUnitWML&curid=1513&diff=60134&oldid=60120 20190106 16:50:14<+wesdiscordbot> okay 20190106 16:50:28-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190106 16:52:32< irker018> wesnoth: Celtic Minstrel wesnoth:1.14 21352b01e666 / src/gui/dialogs/lua_interpreter.cpp: Fix crash when invoking Lua console from the main menu https://github.com/wesnoth/wesnoth/commit/21352b01e666e8ab935f85a4a3436c42c75c2dfe 20190106 16:54:05<+wesdiscordbot> Anyone wants to go through https://wiki.wesnoth.org/SpellingMistakes ? 20190106 16:58:29< irker018> wesnoth: Steve Cotton wesnoth:1.14 2d32fbb6b93c / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Tutorial S2: "choose who gets the 16xp" is a topic for the rookie campaigns https://github.com/wesnoth/wesnoth/commit/2d32fbb6b93cba29ba2658c7b1da1abe5560d501 20190106 17:00:53< irker018> wesnoth/wesnoth:master loonycyborg 0e06f70dda Made regex for matching network addresse AppVeyor: All builds passed 20190106 17:00:54< irker018> wesnoth: Steve Cotton wesnoth:master 309b6e9eae27 / data/campaigns/tutorial/scenarios/02_Tutorial_part_2.cfg: Tutorial S2: Hint that it's better to keep units about-to-level (#3683) https://github.com/wesnoth/wesnoth/commit/309b6e9eae27a401a1023018637becc55fbe8fc9 20190106 17:09:33-!- travis-ci [~travis-ci@ec2-54-204-136-9.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 17:09:34< travis-ci> wesnoth/wesnoth#20579 (master - 9cbd4a7 : nemaara): The build was broken. 20190106 17:09:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476011499 20190106 17:09:34-!- travis-ci [~travis-ci@ec2-54-204-136-9.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 17:12:00<+wesdiscordbot> @Yumi You broke the build with this. 20190106 17:12:02<+wesdiscordbot> https://github.com/wesnoth/wesnoth/commit/f295895f9d76b581a5166d050cee6dd3aa7c4a36#diff-d5fb319c7a5c004af16cb6699e66bc12R401 20190106 17:12:25<+wesdiscordbot> side= isn't valid in [lift_fog], at least according to the WML schema validator. 20190106 17:20:11<+wesdiscordbot> [lift_fog] [filter_side] side=1 [/filter_side] x,y=2-4,2-3 [/lift_fog] 20190106 17:20:17<+wesdiscordbot> @jyrkive how about this? ^ 20190106 17:20:43<+wesdiscordbot> Yes, that should work. 20190106 17:21:44-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 17:21:45< travis-ci> wesnoth/wesnoth#20581 (1.14 - 21352b0 : Celtic Minstrel): The build passed. 20190106 17:21:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476024856 20190106 17:21:45-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 17:22:22<+wesdiscordbot> guess I need to make another PR then 20190106 17:23:06< celticminstrel> (I think some valid but deprecated things aren't in the schema though, FTR. Not sure if that's one of them.) 20190106 17:23:37<+wesdiscordbot> Well, we should avoid using deprecated stuff in mainline anyway. 20190106 17:24:24<+wesdiscordbot> yah 20190106 17:26:04<+wesdiscordbot> no need to make a PR, I'm editing the file currently 20190106 17:26:21<+wesdiscordbot> oh okay 20190106 17:32:38<+wesdiscordbot> can we close #3782 then? 20190106 17:33:19<+wesdiscordbot> Is the facet change on https://github.com/wesnoth/wesnoth/pull/3847/files correct? I looked at the boost documentation and I'm still not sure. 20190106 17:42:09-!- travis-ci [~travis-ci@ec2-54-225-13-200.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 17:42:10< travis-ci> wesnoth/wesnoth#20582 (1.14 - 2d32fbb : Steve Cotton): The build passed. 20190106 17:42:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476025964 20190106 17:42:11-!- travis-ci [~travis-ci@ec2-54-225-13-200.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 17:43:35<+wesdiscordbot> A try to make it more clear for thich way the signpost stands for 20190106 17:43:35<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/531528265731670018/signpost.png 20190106 17:43:48<+wesdiscordbot> @josteph @Yumi what about that? 20190106 17:44:26<+wesdiscordbot> @sevu Is the door hex walkable? 20190106 17:44:44<+wesdiscordbot> There would be an event to open it if one stands in front of it 20190106 17:49:33<+wesdiscordbot> to be honest, I think hwich way the signpost stands for is clear in 1.14 as it is 20190106 17:49:49<+wesdiscordbot> the unclear thing was which of two ways leads to the exit 20190106 17:49:50<+wesdiscordbot> I don't mind either way 20190106 17:50:07<+wesdiscordbot> even now, both the chamber and the escape tunnel have illuminated hexes, so it's not entirely clear 20190106 17:50:20<+wesdiscordbot> should we unshroud the grass hex at the end of the east tunnel ? 20190106 18:01:23-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 18:01:24< travis-ci> wesnoth/wesnoth#20583 (master - 309b6e9 : Steve Cotton): The build failed. 20190106 18:01:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476026529 20190106 18:01:25-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 18:04:12< irker018> wesnoth: Reuben Rakete wesnoth:master 18cc72e167b8 / / (3 files in 2 dirs): Add filter box to hotkey preferences https://github.com/wesnoth/wesnoth/commit/18cc72e167b8fb0e6293cea83ae0377fc31b05c4 20190106 18:04:14< irker018> wesnoth: Reuben Rakete wesnoth:master af4701c3e43b / / (5 files in 4 dirs): Update hotkey filter to work with multi menu toggles https://github.com/wesnoth/wesnoth/commit/af4701c3e43be53d857489d4d527a39c5924803e 20190106 18:04:16< irker018> wesnoth: Reuben Rakete wesnoth:master 05db975788fb / data/gui/window/preferences/02_hotkeys.cfg src/gui/dialogs/preferences_dialog.cpp: Change hotkey filter to use multi word search https://github.com/wesnoth/wesnoth/commit/05db975788fbbe340b9ecbb7b53b9b4e22f1b773 20190106 18:08:57<+wesdiscordbot> I don't think the chamber should have illuminated hexes to begin with 20190106 18:09:43<+wesdiscordbot> I figured they could be useful if trolls/undead followed you there and you had to fight your way out? 20190106 18:09:57<+wesdiscordbot> I get experimental_ai errors on 1.14 trying to open the title screen http://sprunge.us/DVZpDf 20190106 18:10:33<+wesdiscordbot> meh, I'd rather extend the lift shroud so you can see the whole room 20190106 18:10:34< irker018> wesnoth: Reuben Rakete wesnoth:1.14 607a6987e8be / / (3 files in 2 dirs): Add filter box to hotkey preferences https://github.com/wesnoth/wesnoth/commit/607a6987e8be3a30215b921c70f5b76cc0df4f17 20190106 18:10:36< irker018> wesnoth: Reuben Rakete wesnoth:1.14 1028be06dab2 / / (5 files in 4 dirs): Update hotkey filter to work with multi menu toggles https://github.com/wesnoth/wesnoth/commit/1028be06dab2318f8c571d9af7dc827de1382a63 20190106 18:10:38< irker018> wesnoth: Reuben Rakete wesnoth:1.14 27f89d47387f / data/gui/window/preferences/02_hotkeys.cfg src/gui/dialogs/preferences_dialog.cpp: Change hotkey filter to use multi word search https://github.com/wesnoth/wesnoth/commit/27f89d47387ffed2bd71140526f12c9c7a526d95 20190106 18:10:59<+wesdiscordbot> sounds reasonable 20190106 18:13:58<+wesdiscordbot> ah, my AI error must be because of a bad git merge I'd aborted, I'll fix 20190106 18:16:14< irker018> wesnoth: josteph wesnoth:master c157fc8a9990 / changelog.md: Remove changelog line of #3759 as it has been added on 1.14. https://github.com/wesnoth/wesnoth/commit/c157fc8a9990e887066596c62d405871c88230ce 20190106 18:31:16-!- travis-ci [~travis-ci@ec2-54-196-178-81.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 18:31:17< travis-ci> wesnoth/wesnoth#20584 (master - 05db975 : Reuben Rakete): The build is still failing. 20190106 18:31:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476042650 20190106 18:31:17-!- travis-ci [~travis-ci@ec2-54-196-178-81.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 18:32:27<+wesdiscordbot> @Vultraz I've done the merges I spoke about yesterday. 20190106 18:32:44<+wesdiscordbot> Ok 20190106 19:08:58-!- travis-ci [~travis-ci@ec2-54-147-157-67.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 19:08:59< travis-ci> wesnoth/wesnoth#20586 (master - c157fc8 : josteph): The build is still failing. 20190106 19:08:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476045924 20190106 19:08:59-!- travis-ci [~travis-ci@ec2-54-147-157-67.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 19:09:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc] 20190106 20:52:11< irker018> wesnoth: josteph wesnoth:master 7017fd44e377 / src/display.cpp: Center the "Planning mode activated" announcement when there's a left sidebar. https://github.com/wesnoth/wesnoth/commit/7017fd44e3771006bb5ad5ff6f3c448024e7feb8 20190106 20:52:26< irker018> wesnoth: josteph wesnoth:1.14 3376e140ca2d / src/display.cpp: Center the "Planning mode activated" announcement when there's a left sidebar. https://github.com/wesnoth/wesnoth/commit/3376e140ca2d9414ddbf7e3e0f001cf41db43ea3 20190106 21:06:52<+wesdiscordbot> @Yumi @josteph enlighting the chamber … okay. Should I "push" the door anyways or not? … Can Trolls use doors…? 20190106 21:07:12<+wesdiscordbot> I don't mind the door 20190106 21:07:19<+wesdiscordbot> as in 20190106 21:07:22<+wesdiscordbot> it would be okay to have the door 20190106 21:07:31<+wesdiscordbot> (if you already did it, might as well add it) 20190106 21:08:03<+wesdiscordbot> did it halfway, must look up the coordintes 20190106 21:09:08<+wesdiscordbot> I guess trolls can use doors, but I don't know if they can make doors 20190106 21:09:27<+wesdiscordbot> They use clubs and slings and "rough shod armor" according to unit descriptions 20190106 21:10:40<+wesdiscordbot> I don't mind the door though. Or maybe the door is of dwarvish make 20190106 21:18:46-!- travis-ci [~travis-ci@ec2-54-80-186-133.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 21:18:47< travis-ci> wesnoth/wesnoth#20587 (master - 7017fd4 : josteph): The build is still failing. 20190106 21:18:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476088495 20190106 21:18:47-!- travis-ci [~travis-ci@ec2-54-80-186-133.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 21:29:26< irker018> wesnoth: Severin Glöckner wesnoth:1.14 366f57af8a2e / data/campaigns/Eastern_Invasion/scenarios/02_The_Escape_Tunnel.cfg: EI: make the way out obvious https://github.com/wesnoth/wesnoth/commit/366f57af8a2e67369012f835d01d5b75c459b6c9 20190106 21:29:58< irker018> wesnoth: Severin Glöckner wesnoth:master 137d8d66b818 / data/campaigns/Eastern_Invasion/scenarios/02_The_Escape_Tunnel.cfg: EI: make the way out obvious https://github.com/wesnoth/wesnoth/commit/137d8d66b818411916c8359ec8032097544a7738 20190106 21:31:06<+wesdiscordbot> so… with door and without shroud. Wonder if it's really better, the coordinates before were showing the whole chamber except the walls, guess it was intentional to be missleading. 20190106 21:31:27<+wesdiscordbot> or a mistake from me 20190106 21:31:36<+wesdiscordbot> 😖 20190106 21:32:07<+wesdiscordbot> how on earth do you get your lips in that shape 20190106 21:32:37< celticminstrel> I imagine troll-made doors would be of the carefully-balanced giant block of stone type. 20190106 21:33:35<+wesdiscordbot> magic 20190106 21:34:04<+wesdiscordbot> thanks for fixing that 😃 20190106 21:34:39<+wesdiscordbot> Doing everything for closing issues. Even fixing them :p 20190106 21:35:40<+wesdiscordbot> yeah, can't ignore everything 😛 20190106 21:35:46<+wesdiscordbot> That's...somewhat drastic, isn't it? 20190106 21:36:14<+wesdiscordbot> your moveto event is for 30,9 which is impassable ? 20190106 21:36:31<+wesdiscordbot> Wonder who wrote the signpost. The dwarves or the Trolls. It sounds actually like Saurians 20190106 21:36:33<+wesdiscordbot> yeah 20190106 21:37:04<+wesdiscordbot> 31, 10 20190106 21:37:19<+wesdiscordbot> 30,9 i in front of it 20190106 21:37:25<+wesdiscordbot> I'm trying to clear as many of the campaign label issues as I can 20190106 21:38:05<+wesdiscordbot> the bulk of course are in other areas, but I don't have an easy way to build wesnoth, so no c++ for me 20190106 21:38:36<+wesdiscordbot> @sevu 30,9 is impassable, so the event won't fire 20190106 21:39:00<+wesdiscordbot> why can't you build ? 20190106 21:39:16<+wesdiscordbot> I changes the map at that plkace a bit, not only the door… event works 20190106 21:39:19<+wesdiscordbot> no linux no visual studio 20190106 21:39:42<+wesdiscordbot> and I'm stupid so I can't figure out another way to do it haaaaaaa 20190106 21:40:01<+wesdiscordbot> wasn't there a freee version for C++ with Visual Studio 20190106 21:40:21<+wesdiscordbot> although tbh I have enough on my plate with my campaign and the DiD revision 20190106 21:40:30<+wesdiscordbot> @Yumi I'll try not to lose that race. 😄 20190106 21:40:37<+wesdiscordbot> PLS 20190106 21:40:44<+wesdiscordbot> XD 20190106 21:40:59<+wesdiscordbot> I'll finish TRoW and then take a break from mainline, okay? 20190106 21:41:06<+wesdiscordbot> a lot of them are on NR and TRoW, which are due for rewriting 20190106 21:41:24<+wesdiscordbot> so when Vultraz/others are ready to do that, we can fix those en masse 20190106 21:41:45<+wesdiscordbot> @sevu I think you forgot to push the map ? 20190106 21:42:07<+wesdiscordbot> Duh. Exactly… Thanks 20190106 21:42:26<+wesdiscordbot> otherwise I think I'll then take a look at Pentarctagon's Dark Forecast issue 20190106 21:42:37<+wesdiscordbot> after DiD and after I work a bit more on my campaign 20190106 21:42:38<+wesdiscordbot> there was a thread today about LoW issues 20190106 21:42:52<+wesdiscordbot> LoW goes in the same category as NR and TRoW 20190106 21:42:55<+wesdiscordbot> needs rewrite 20190106 21:43:14<+wesdiscordbot> Hmmm 20190106 21:43:16< irker018> wesnoth: Severin Glöckner wesnoth:master f6156305e0b7 / data/campaigns/Eastern_Invasion/maps/02_The_Escape_Tunnel.map: EI S2: map change for the added door event https://github.com/wesnoth/wesnoth/commit/f6156305e0b71c4d8127d76c83a844c4b68fd04f 20190106 21:43:18<+wesdiscordbot> like, major major revision 20190106 21:43:25<+wesdiscordbot> not just me touching up the scenarios 20190106 21:43:25<+wesdiscordbot> I should play those campaigns then so I can help with the revision 20190106 21:43:34<+wesdiscordbot> Or maybe I should play DW first because it's fun 😃 20190106 21:43:37< irker018> wesnoth: Severin Glöckner wesnoth:1.14 437eb9847fa4 / data/campaigns/Eastern_Invasion/maps/02_The_Escape_Tunnel.map: EI S2: map change for the added door event https://github.com/wesnoth/wesnoth/commit/437eb9847fa449448517556cbcf4e1c3fa2564e0 20190106 21:43:42<+wesdiscordbot> sure haha 20190106 21:44:12<+wesdiscordbot> by the way, in general how different are MEDIUM and HARD of a campaign ? 20190106 21:44:20<+wesdiscordbot> very dependent on campaign 20190106 21:44:25<+wesdiscordbot> I've been wondering if I should try to beat campaigns on HARD without playing them on MEDIUM first 20190106 21:44:29<+wesdiscordbot> does anyone mind if I fix the schema issue, so travis stops complaining? 20190106 21:44:44<+wesdiscordbot> That'd be appreciated Pent 20190106 21:44:45<+wesdiscordbot> it actually looks like in DiD, for example, the creator didn't make much of a difference in them at all 20190106 21:44:55<+wesdiscordbot> often, one gold value is used for all 3 difficulties 20190106 21:45:01<+wesdiscordbot> @Yumi If you take a look at the Dark Forecast, checking out the add-on 'Murky Weather' might be helpful. (It's some modified version of Dark Forecast, no idea what the difference is though.) 20190106 21:45:11<+wesdiscordbot> 🤔 20190106 21:45:13<+wesdiscordbot> :thonk: 20190106 21:45:22<+wesdiscordbot> Is that schema issue about EI S2? That I just pushed 20190106 21:45:23<+wesdiscordbot> maybe an opportunity to mainline it if it looks good 20190106 21:45:37<+wesdiscordbot> @Konrad2 what addon server is it on? 14/12/10 20190106 21:45:42<+wesdiscordbot> 1.14 20190106 21:45:50<+wesdiscordbot> I typed it into my list just today. 20190106 21:45:57<+wesdiscordbot> ah, found it, thanks 20190106 21:46:38<+wesdiscordbot> @sevu ah, yep, that was it. 20190106 21:47:30<+wesdiscordbot> The schema validator is great. I would have broken TRoW for 1.14.6 otherwise. 20190106 21:48:18<+wesdiscordbot> celmin ^ 20190106 21:48:29< celticminstrel> ? 20190106 21:48:44< celticminstrel> Why am I being pinged here? 20190106 21:48:53< celticminstrel> Is there something wrong with the schema validator? 20190106 21:49:07<+wesdiscordbot> No, the opposite. Thanks Celmin 20190106 21:49:11< celticminstrel> Oh okay. 20190106 21:51:55<+wesdiscordbot> @Yumi I disagree about DiD. 20190106 21:52:30<+wesdiscordbot> While there are some scenarios where your gold doesn't depend on the difficulty, the enemy gold does. 20190106 21:52:48<+wesdiscordbot> (Also, turn limit.) 20190106 21:52:58<+wesdiscordbot> turn limit also doesn't seem to change between difficulties in many scenarios 20190106 21:53:19<+wesdiscordbot> a 30 gold gap is 2, maybe 2.5 units 20190106 21:53:26<+wesdiscordbot> it's not insignificant, but also not a lot 20190106 21:53:39<+wesdiscordbot> it's just less of a gap than in other campaigns 20190106 21:54:20<+wesdiscordbot> (this is not really a bad thing, just the way it is) 20190106 21:54:47<+wesdiscordbot> But I want to feel proud for beating it on the hardest difficulty. 😦 😦 20190106 21:55:02<+wesdiscordbot> xD 20190106 21:55:10<+wesdiscordbot> I was just about to suggest to @Yumi to add a 4th, "Nightmare" difficulty 20190106 21:55:23<+wesdiscordbot> mmmmm 20190106 21:55:42<+wesdiscordbot> better recruits also means the AI spends more gold on them 20190106 21:55:58<+wesdiscordbot> what would be the purpose of having the nightmare difficulty? 20190106 21:56:07<+wesdiscordbot> extra challenge for anyone who wants it 20190106 21:56:49<+wesdiscordbot> if that happens I'll do that in an extra commit dedicated to only that 20190106 21:56:54<+wesdiscordbot> after all gameplay revisions 20190106 21:57:06<+wesdiscordbot> or at least after all dialogue revisions :thonk: 20190106 21:57:13<+wesdiscordbot> probably after all gameplay revisions 20190106 21:57:45<+wesdiscordbot> soudns right 20190106 21:57:52<+wesdiscordbot> well… having more difficulties means more testing and work... maybe just make the current hard one nightmarish, and the others maybe a bit too 20190106 21:58:08<+wesdiscordbot> it's not too bad tbh 20190106 21:58:08<+wesdiscordbot> the current ones as normal/challenging/difficult 20190106 21:58:09<+wesdiscordbot> *a bit harder, not a bit nightmarish ^^ 20190106 21:58:19<+wesdiscordbot> because if I test one difficulty 20190106 21:58:34<+wesdiscordbot> it's actually not too hard to predict how hard the other difficulties will be 20190106 21:58:44<+wesdiscordbot> so we could rename the existing ones easy/normal/challenging, and add a new 4th difficulty as new "Difficult" (rather than Nightmare) 20190106 21:59:05<+wesdiscordbot> I don't really know how the current difficulty 20190106 21:59:07<+wesdiscordbot> but then, one reason I suggested to add Nightmare is that even if we mis-balance it, it won't be a bug 20190106 21:59:08<+wesdiscordbot> does challenging sound harder to you than difficult? :thonk: 20190106 21:59:15<+wesdiscordbot> not a bad one anyway 20190106 21:59:20<+wesdiscordbot> well, that's the order 20190106 21:59:29<+wesdiscordbot> beginner easy normal challenging difficult nightmare 20190106 21:59:29<+wesdiscordbot> No, it doesn't. 20190106 21:59:33<+wesdiscordbot> oh? 20190106 21:59:33<+wesdiscordbot> okay 20190106 21:59:38<+wesdiscordbot> sure then 20190106 21:59:42<+wesdiscordbot> that's the order of difficulties in mainline 20190106 22:00:01<+wesdiscordbot> fine by me! 20190106 22:00:08<+wesdiscordbot> but, dialogue first 20190106 22:00:10<+wesdiscordbot> then gameplay 20190106 22:00:15<+wesdiscordbot> then that 20190106 22:00:27<+wesdiscordbot> gah it's 5 pm and I haven't even finished one scenario today 20190106 22:00:32<+wesdiscordbot> yeah, https://github.com/wesnoth/wesnoth/pull/3841 20190106 22:00:47<+wesdiscordbot> Hmm, maybe post to the Writer's Forum about that pr ? 20190106 22:01:48<+wesdiscordbot> it doesn't seem to be too active of a forum, so I didn't think about that 20190106 22:02:36<+wesdiscordbot> also since you had some comments, maybe I should look at those first, make necessary changes, then see about looking for more feedback? 20190106 22:04:25<+wesdiscordbot> well, it's up to you, but I think it's at the point where you can ask for multiple feedbacks at once 20190106 22:04:52<+wesdiscordbot> yah the only problem is I may forget 20190106 22:04:55<+wesdiscordbot> hopefully I won't 20190106 22:06:13< irker018> wesnoth/wesnoth:master Vlad Drozdov 6d4ed45f9a Campaign selection: Add search functiona AppVeyor: All builds passed 20190106 22:06:25<+wesdiscordbot> Btw… why does TRoW need a rewrite? It looked solid to me, played it halfway 20190106 22:06:30<+wesdiscordbot> Just do it now, or write it down somewhere you'll see it 20190106 22:07:00<+wesdiscordbot> TRoW is too long 20190106 22:07:16<+wesdiscordbot> writing is good, probably doesn't need too much revision there 20190106 22:07:22< irker018> wesnoth: Steve Cotton wesnoth:1.14 2f681515b805 / data/campaigns/An_Orcish_Incursion/scenarios/01_Defend_the_Forest.cfg: AoI S1: Hint about recruiting a healer, if the player doesn't have any https://github.com/wesnoth/wesnoth/commit/2f681515b805b8d8e177e8c29c2a34a2cbaed78b 20190106 22:07:38<+wesdiscordbot> gameplay also can use some help 20190106 22:07:48<+wesdiscordbot> most of the scenarios are just plug and play defeat enemy leader 20190106 22:08:02<+wesdiscordbot> Wesnoth campaigns in one sentence 20190106 22:08:10<+wesdiscordbot> hey, the new TSG is pretty not like that 20190106 22:08:12<+wesdiscordbot> 😄 20190106 22:08:27<+wesdiscordbot> not? I worried because you remove some unique things 20190106 22:08:48<+wesdiscordbot> not too many, I think 20190106 22:09:04<+wesdiscordbot> only that one scenario because it was essentially a duplicate 20190106 22:09:27<+wesdiscordbot> although I better keep track of the defeat enemy leader condition for DiD 20190106 22:09:51<+wesdiscordbot> I guess the majority of the scenarios are like that 20190106 22:10:13<+wesdiscordbot> anyway, I think Vultraz was expressing the desire to revise NR first, TRoW is somewhere along the line, but prob. not first 20190106 22:10:15< irker018> wesnoth: Steve Cotton wesnoth:master d0178fa3419d / data/campaigns/An_Orcish_Incursion/scenarios/01_Defend_the_Forest.cfg: AoI S1: Hint about recruiting a healer, if the player doesn't have any https://github.com/wesnoth/wesnoth/commit/d0178fa3419d2e15b8114b7b0ec7953e333b8987 20190106 22:22:18< irker018> wesnoth: josteph wesnoth:master 49a5acee5060 / data/campaigns/Liberty/scenarios/06_The_Grey_Woods.cfg: Liberty S6: Give the cave underground time of day. https://github.com/wesnoth/wesnoth/commit/49a5acee50603546a55cf96337aa15a053c680d0 20190106 22:23:20< irker018> wesnoth: josteph wesnoth:1.14 31c3e6a872fc / data/campaigns/Liberty/scenarios/06_The_Grey_Woods.cfg: Liberty S6: Give the cave underground time of day. https://github.com/wesnoth/wesnoth/commit/31c3e6a872fc31453a3cce5113c3b6a470ab2c6f 20190106 22:24:06<+wesdiscordbot> Thanks for merging that 20190106 22:25:50<+wesdiscordbot> I just pulled the trigger, and nothing more… Feel free to merge more things. I asked conrad because I don't know the scenario… the balance effect shouldn't be too bad 20190106 22:26:44<+wesdiscordbot> I'm a bit busy with some chats right now 20190106 22:26:59< celticminstrel> ...conrad o.o 20190106 22:27:02<+wesdiscordbot> I didn't playtest it at all, but if y'all are sure then great 😃 20190106 22:30:37<+wesdiscordbot> I'm touched by your trust. XD 20190106 22:31:50-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 22:31:51< travis-ci> wesnoth/wesnoth#20591 (master - 137d8d6 : Severin Glöckner): The build was fixed. 20190106 22:31:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476099664 20190106 22:31:51-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 22:33:25<+wesdiscordbot> Btw, why does the 'Dark Forecast' issue have the campaign label instead of the MP label? 20190106 22:33:43< celticminstrel> No idea! Someone please fix it? 20190106 22:35:10<+wesdiscordbot> I guess since it's a scenario, but yeah it should be MP 20190106 22:37:35< celticminstrel> It shouldn't have the campaign label, because it's not a campaign. 20190106 22:38:24<+wesdiscordbot> For the Liberty PR, the only thing which could need some checking would be if the terrain code for the schedule matches as expected... 20190106 22:40:21<+wesdiscordbot> the campaign label is appropriate there, I think 20190106 22:40:35<+wesdiscordbot> the issue is about the balance of that one specific scenario, not about the MP mechanics in general 20190106 22:41:39< celticminstrel> Dark Forecast is not a campaign. 20190106 22:41:44< celticminstrel> It's a single scenario. 20190106 22:42:08< celticminstrel> I don't think the campaign label fits. Maybe we need a new label though for that sort of thing. 20190106 22:42:53<+wesdiscordbot> I think we have enoght labels… campaign fits somewhat and somewhat not 20190106 22:43:19<+wesdiscordbot> A campaign is something in the Campaigns list, I would think. Dark Forecast is an MP scenario 20190106 22:44:06<+wesdiscordbot> Would a 'MP Scenario' label hurt? 20190106 22:44:47<+wesdiscordbot> I wanted to say that it's about scenario scripting in WML, but as it's written in Lua … 20190106 22:44:57<+wesdiscordbot> XD 20190106 22:51:43<+wesdiscordbot> can we just change the description of the label 20190106 22:51:59<+wesdiscordbot> "Issues in single campaigns or scenarios" (WML or Lua, not C++) 20190106 22:52:14< Ravana> I have considered label that says if issue needs c++/lua/wml/python changes 20190106 22:59:02<+wesdiscordbot> that'd make it easier for people to find issues they can/can't help with 20190106 23:06:32-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has joined #wesnoth-dev 20190106 23:06:33< travis-ci> wesnoth/wesnoth#20594 (master - 49a5ace : josteph): The build was fixed. 20190106 23:06:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/476115428 20190106 23:06:33-!- travis-ci [~travis-ci@ec2-54-226-36-247.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190106 23:07:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds] 20190106 23:09:11< irker018> wesnoth/wesnoth:master Vlad Drozdov e74797ff1d Campaign selection: Add search functiona AppVeyor: All builds passed 20190106 23:12:55-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Mon Jan 07 00:00:47 2019