--- Log opened Sat Jan 12 00:00:37 2019 20190112 00:35:39-!- celmin|away is now known as celticminstrel 20190112 00:38:03< irker531> wesnoth/wesnoth:1.14 Steve Cotton a6bb960f88 New description for the Goblin Knight, m AppVeyor: All builds passed 20190112 02:04:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190112 03:38:15-!- irker531 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190112 06:33:50-!- irker576 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190112 06:33:50< irker576> wesnoth/wesnoth:master Sean Yeh f530999033 Make defender's "first strike" inactive AppVeyor: All builds passed 20190112 07:06:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190112 08:48:34<+wesdiscordbot> I've been traveling all over this week, which is why I haven't set a date for 1.14.6 yet 20190112 08:48:36<+wesdiscordbot> sorry 20190112 09:00:43<+wesdiscordbot> does anyone object to a freeze starting tomorrow? 20190112 09:02:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds] 20190112 09:05:28<+wesdiscordbot> some of https://github.com/wesnoth/wesnoth/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+milestone%3A1.14.6 should either then be merged or moved to 1.14.7 then 20190112 09:06:46<+wesdiscordbot> HM 20190112 09:22:59<+wesdiscordbot> heh, it's exactly 1 year since #2365 was opened :thonk: 20190112 09:23:14<+wesdiscordbot> no progress, though 20190112 09:24:20<+wesdiscordbot> #3853 uhhhhhh I really don't think that's the right fix 20190112 09:24:48<+wesdiscordbot> like i said in #3849 I think a commit got missed in backporting...I didn't get a chance to check, though 20190112 09:26:17<+wesdiscordbot> there's too much stuff in the utbs PR to carefully review. 20190112 09:26:24<+wesdiscordbot> i presume the author tested stuff 20190112 09:28:07<+wesdiscordbot> https://github.com/wesnoth/wesnoth/commit/1b4cd8195b063f89fcce73620c12bb007f116eb6 relies on there being a move constructor for tree_view_node 20190112 09:28:11<+wesdiscordbot> I distinctly remember adding one... 20190112 09:28:13<+wesdiscordbot> checks 20190112 09:29:07<+wesdiscordbot> er, sorry, move overload for add_child 20190112 09:29:33<+wesdiscordbot> hmmm 20190112 09:29:37<+wesdiscordbot> the code seems to be there... 20190112 09:30:14<+wesdiscordbot> yes, it is there... e247892616aca160fea8df5d34fcca52c891baf2 20190112 09:30:21<+wesdiscordbot> so I guess I fucked something up 🤔 20190112 09:33:57-!- irker576 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190112 09:45:53<+wesdiscordbot> i guess I'll have to look into that this week 20190112 09:45:55<+wesdiscordbot> can't right now 20190112 09:50:23<+wesdiscordbot> Again, my short analysis of that crash is here: https://github.com/wesnoth/wesnoth/issues/3849#issuecomment-451769843 20190112 09:50:58<+wesdiscordbot> team_tree_map_[side->team_name()]->add_child(std::move(node.first), get_side_node_position(side)); ``crashes because it's equivalent tonullptr->add_child(std::move(node.first), get_side_node_position(side)); ` 20190112 09:56:58<+wesdiscordbot> then the problem must be in the init process 20190112 09:57:12<+wesdiscordbot> an invalid team name, perhaps 20190112 09:57:38<+wesdiscordbot> Just a team that doesn't have any sides assigned. 20190112 09:58:05<+wesdiscordbot> The code currently in master only creates a UI element for every team that has a side. 20190112 09:58:36<+wesdiscordbot> The only change in #3853 is to immediately create a UI element for every team, even if it doesn't have any sides assigned. 20190112 09:59:30<+wesdiscordbot> I... see 20190112 09:59:34<+wesdiscordbot> hmm 20190112 10:44:56-!- irker732 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190112 10:44:56< irker732> wesnoth/wesnoth:master nemaara c185023006 DiD S3: word choice AppVeyor: All builds passed 20190112 11:09:04< irker732> wesnoth/wesnoth:master nemaara 67f577c9ef DiD S3: word choice AppVeyor: All builds passed 20190112 11:11:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190112 11:35:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190112 12:37:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20190112 12:52:27-!- vn971 [~vasilii@2a02:a210:2203:c000:7f64:7780:4177:6131] has joined #wesnoth-dev 20190112 12:52:39< vn971> ouch, wesnoth crashed.:( 20190112 12:52:50< vn971> wesnoth: /build/wesnoth/src/wesnoth/src/attack_prediction.cpp:1660: static void {anonymous}::monte_carlo_combat_matrix::scale_probabilities(const std::vector&, std::vector&, double, unsigned int): Assertion `std::abs(std::accumulate(target.begin(), target.end(), 0.0) - 1.0) < 0.001' failed. 20190112 12:53:01< vn971> v1.14.5 (48bd45d7209-Clean) 20190112 12:54:46< vn971> probably fixed by jyrkive here: https://github.com/wesnoth/wesnoth/issues/3650 20190112 13:06:46< vn971> yes, I think it's fixed indeed. Waiting for 1.14.6 then.:) 20190112 13:49:38<+wesdiscordbot> Anyone avaible to test a bug for me? 20190112 13:49:46<+wesdiscordbot> *confirm 20190112 13:53:00<+wesdiscordbot> I also need some help with describing it properly. So, when someone is avaible, ping me please. 20190112 13:53:21< Ravana> try 20190112 13:56:37<+wesdiscordbot> Load a scenario save file, press alt+tab once you arrive at the story screen or if there is none, once your units start talking, so you see a different window. Then press it again to go back and you'll see that the story screen/dialog disappeared. 20190112 13:56:58<+wesdiscordbot> That is another result though. 20190112 13:56:58<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/533645565330849792/1bug.png 20190112 13:57:35<+wesdiscordbot> (windows) 20190112 13:58:08<+wesdiscordbot> Disappeared -> You see the map instead. 20190112 13:58:43<+wesdiscordbot> I guess the story screen is actually some overlay to 'hide' the map while the story is told? 20190112 13:59:42<+wesdiscordbot> Something similiar happens to the 'loading saves window' (however that might be called). 20190112 14:00:15<+wesdiscordbot> And apparently I don't need alt+tab. Changing the window is enough. 20190112 14:00:27< Ravana> doesn't happen for me 20190112 14:00:51<+wesdiscordbot> (It was invisible until I moused over some things.) 20190112 14:00:51<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/533646542452686849/2bug.png 20190112 14:00:52<+wesdiscordbot> Huh. 20190112 14:01:04< Ravana> (windows 10, started first campaign, shift+k enemy, return to main, load scenario save, alt tab) 20190112 14:01:04<+wesdiscordbot> Do you play on windows? 20190112 14:01:08<+wesdiscordbot> Huh. 20190112 14:01:23<+wesdiscordbot> No auto save. 20190112 14:01:30<+wesdiscordbot> Scenario start save. ^^ 20190112 14:01:51<+wesdiscordbot> Or do you mean the 2nd scenario save? >-< 20190112 14:02:03< Ravana> no problem with autosave either 20190112 14:02:34<+wesdiscordbot> Any idea what I should do now? 😦 20190112 14:03:00<+wesdiscordbot> Or what the difference between us might be. 20190112 14:03:12< Ravana> share affected save 20190112 14:03:19<+wesdiscordbot> Restarting wesnoth fixed it. 20190112 14:03:35< Ravana> can't help then 20190112 14:04:38<+wesdiscordbot> I think I've figured it out. It's very likely due to a WML bug of an add-on. I'll try to confirm that once the author uploaded a fix. 20190112 14:07:18<+wesdiscordbot> Should it be 'allowed' for a WML bug of one add-on to affect the core game? 20190112 14:08:22< Ravana> there is no way to stop it if you word it so broadly 20190112 14:09:20-!- irker732 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190112 14:10:17<+wesdiscordbot> Okay, is it 'allowed' for this WML bug (see link, scroll down) to cause the bugs I've screenshotted? Or should have been theoretically prevented by the game? https://forums.wesnoth.org/viewtopic.php?p=637447#p637447 20190112 14:11:26< Ravana> that message should be prevented yes 20190112 14:11:42< Ravana> I would flip the values in that case 20190112 14:33:18-!- gfgtdf [~Daniel@x4d0363e7.dyn.telefonica.de] has joined #wesnoth-dev 20190112 15:15:34-!- sevu [~sevu@p54854685.dip0.t-ipconnect.de] has joined #wesnoth-dev 20190112 15:16:26-!- sevu [~sevu@p54854685.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 20190112 16:00:49<+wesdiscordbot> Could someone help review the gettext.cpp changes in https://github.com/wesnoth/wesnoth/pull/3847/files#diff-e113376dbe38a56bd7b78ceee408d203R518 ? 20190112 16:01:00<+wesdiscordbot> An earlier version of the PR used a mutex there but I don't know if it's needed, and can't find docs 20190112 16:21:49< gfgtdf> get_locale() call shodul be pretected by mutex, otherwise update_locale_internal() might be called by two differnt threads at the same time. 20190112 16:22:15-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190112 16:22:29-!- irker599 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190112 16:22:29< irker599> wesnoth: josteph wesnoth:master 8cbc3a4477d3 / data/tools/wesnoth/README.md: Fix markup in README. https://github.com/wesnoth/wesnoth/commit/8cbc3a4477d34fbb414877d84d59e805055d832c 20190112 16:32:53<+wesdiscordbot> gfgtdf, thanks 20190112 16:34:14<+wesdiscordbot> gfgtdf, for 3866 how feasible is it to just have two wesnoth instances open? 20190112 16:34:20<+wesdiscordbot> one in lobby, one in mp staging 20190112 16:35:50< gfgtdf> It's possible, but you needs two accounts a good enough cpmouter etc. . The tabbed loby sulution i suggested woul certainly be more user firendly. 20190112 16:39:52<+wesdiscordbot> sure, I'm just considering alternatives 20190112 16:40:33<+wesdiscordbot> for example, we could allow 2 login sessions with one account, and if one needs a "good enough computer" to be in the mp lobby twice then.... why ? 20190112 16:41:50< Ravana> unless your name is number-only, you can log in with same account 20190112 16:43:31<+wesdiscordbot> People shoudn't rely on that, to be honest 20190112 16:44:03<+wesdiscordbot> It's an accidental side effect of Wesnoth's lazy case-sensitive approach to life 20190112 16:52:16< gfgtdf> the good enough computer meant to have wesnoth.exe programm open running two times. 20190112 16:53:12< gfgtdf> also what i just said might only apply to windows, for example android might not allow two seperate instances of the same programm, not sure. 20190112 16:54:58-!- travis-ci [~travis-ci@ec2-54-90-111-248.compute-1.amazonaws.com] has joined #wesnoth-dev 20190112 16:54:59< travis-ci> wesnoth/wesnoth#20636 (master - 8cbc3a4 : josteph): The build has errored. 20190112 16:54:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/478777863 20190112 16:54:59-!- travis-ci [~travis-ci@ec2-54-90-111-248.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190112 16:55:26<+wesdiscordbot> Almost any computer running the three main OSes is good enough btw 20190112 16:55:37<+wesdiscordbot> Wesnoth isn't that demanding on resources if you don't care about performance 20190112 16:55:45<+wesdiscordbot> Or temperatures 20190112 17:01:11< gfgtdf> hmm ye probably, but is that guraenteed to stay true in the future? in particular if we ever manage to implment ar. 20190112 17:02:17<+wesdiscordbot> Computers can create multiple accelerated graphics contexts, no problem. Your web browser is already using one, for example. 20190112 17:04:03<+wesdiscordbot> really, if we find that modern computers aren't powerful enough to run two copies of wesnoth mp lobby in the same time, then we've done something wron 20190112 17:04:04<+wesdiscordbot> g 20190112 17:04:04< Ravana> having multiple clients open when not playing on both at once is only workaround 20190112 17:04:38<+wesdiscordbot> is anyone looking into the travis osx issue ? 20190112 17:04:50< Ravana> cases like https://github.com/wesnoth/wesnoth/issues/1540 assume that people won't use multiple clients 20190112 17:25:02<+wesdiscordbot> travis error is now: https://travis-ci.org/wesnoth/wesnoth/jobs/478777871#L1062-L1064 20190112 17:25:36<+wesdiscordbot> so the only alternative would be to disable ccache for osx builds until homebrew figures itself out. 20190112 17:25:52<+wesdiscordbot> assuming there aren't any other problems 20190112 17:46:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer] 20190112 17:47:31-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190112 17:48:50< vn971> I wonder, is it considered a bug now? Steps: start 2vs2 game. I'm game host. One player in enemy team resigns. The other player of this team wants to continue. When turn comes to the "resigned" player-s side, I can order the enemy leader, but I cannot re-assign the side. 20190112 17:50:34< gfgtdf> as the host you shoudl be able to reassign side, what happens if you try ? 20190112 17:53:40< vn971> gfgtdf: when I typed in "give_control", I only saw 3 sides in the sides list. 20190112 17:54:06< gfgtdf> and whyn you try directly via :control command ? 20190112 17:54:20< vn971> gfgtdf: didn't think of that TBH. 20190112 17:55:01< vn971> I only remember the "give_control" command off the top of my head.. 20190112 17:55:45< gfgtdf> was that a mainline 4p scenario ? 20190112 17:58:12< gfgtdf> anyway the give_control dialog oynl sems to skiopoing over hidden sides https://github.com/wesnoth/wesnoth/blob/1.14.5/src/gui/dialogs/multiplayer/mp_change_control.cpp#L99 which i dont think any of the mainline 4p scearnios sides are 20190112 17:58:40< vn971> gfgtdf: it was CreepWars 20190112 17:58:55< vn971> gfgtdf: the resigned side was a normal human side 20190112 18:59:29<+wesdiscordbot> @Vultraz I coud use until tuesday for the string freeze to backport a few things from the recent pr 20190112 19:11:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190112 19:15:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190112 19:22:47-!- irker599 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190112 20:08:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190112 20:10:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190112 20:25:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190112 21:06:05<+wesdiscordbot> @loonycyborg So, I can't build Wesnoth on Debian sidhttps://pastebin.com/XdF0t9aP 20190112 21:06:54<+wesdiscordbot> It's scons 3.0.1 and I'm confused why it's trying to load python 2 crap? 20190112 21:07:04<+wesdiscordbot> I thought this version used python 3 20190112 21:07:57<+wesdiscordbot> It can currently be run with both 20190112 21:08:21<+wesdiscordbot> also the error you got means it failed to run mysql_config 20190112 21:09:03<+wesdiscordbot> seems mysql dev files are not installed or it doesn't provide that script in newer versions of mariadb/mysql 20190112 21:09:31<+wesdiscordbot> if you don't need it you can pass forum_user_handler=false 20190112 21:09:37<+wesdiscordbot> Let me check what I have or don't have installed then and yes I need it 20190112 21:09:40<+wesdiscordbot> I strongly need it 20190112 21:10:09<+wesdiscordbot> Yeah stuff got uninstalled somehow 20190112 21:11:26<+wesdiscordbot> Could you find a way to make the error not be stupid like that? 20190112 21:11:38<+wesdiscordbot> Because as it is it's just Python gibberish 20190112 21:12:07<+wesdiscordbot> Eh okay I installed the dev package and I still have the same issue 20190112 21:13:06<+wesdiscordbot> The command provided by libmariadb-dev as of version 1:10.3.12-1 in Debian sid is mariadb_config, not mysql_config 20190112 21:13:42<+wesdiscordbot> Oh, there's a separate compatibility package 20190112 21:14:24<+wesdiscordbot> Okay, it works after installing libmariadb-dev-compat, but I feel like we shouldn't need to have that requirement? 20190112 21:14:56<+wesdiscordbot> I can make it try both 20190112 21:15:02<+wesdiscordbot> I guess it's not a huge issue since MariaDB is supposed to be API-compatible with MySQL 20190112 21:15:14<+wesdiscordbot> can you check if it has pkg-config support for you? 20190112 21:15:20<+wesdiscordbot> like does it have .pc files? 20190112 21:15:21<+wesdiscordbot> I just said it works 20190112 21:15:26<+wesdiscordbot> Oh you mean 20190112 21:15:52<+wesdiscordbot> libmariadb-dev provides the following: /usr/lib/x86_64-linux-gnu/pkgconfig/libmariadb.pc /usr/lib/x86_64-linux-gnu/pkgconfig/mariadb.pc 20190112 21:16:16<+wesdiscordbot> Whereas libmariadb-dev-compat ONLY provides this: /usr/lib/x86_64-linux-gnu/pkgconfig/mysqlclient.pc 20190112 21:17:07<+wesdiscordbot> ideally I'd want to make it use pkg-config 20190112 21:17:22<+wesdiscordbot> but not sure if it'll break stuff on older distros 20190112 21:17:44<+wesdiscordbot> Or non-Debian distributions for that matter 20190112 21:18:23<+wesdiscordbot> fwiw I have those .pc files on gentoo too 20190112 21:18:47<+wesdiscordbot> Fedora/RHEL etc. 20190112 21:19:16<+wesdiscordbot> That's a more reasonable deployment target for wesnothd+FUH than Gentoo FWIW :p 20190112 22:07:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20190112 22:21:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190112 22:28:31-!- irker602 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190112 22:28:31< irker602> wesnoth/wesnoth:master ProditorMagnus 0d898bfcff Reformat code (other than test WML fragm AppVeyor: All builds passed 20190112 23:48:26-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 268 seconds] 20190112 23:55:44< irker602> wesnoth/wesnoth:master ProditorMagnus 1e97954af3 Reformat code (other than test WML fragm AppVeyor: All builds passed 20190112 23:58:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev --- Log closed Sun Jan 13 00:00:38 2019