--- Log opened Wed Jan 16 00:00:42 2019 20190116 00:30:52<+wesdiscordbot> MFW you fix the phone line on your own 😂 20190116 00:34:07<+wesdiscordbot> wait, how? 20190116 00:35:55-!- irker702 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190116 00:35:55< irker702> wesnoth/wesnoth:master Lovens Weche be72706a75 Fixes for addon manager crash commit AppVeyor: vs2015/Debug Failed 20190116 00:35:55< irker702> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21644387 20190116 00:36:29<+wesdiscordbot> turns out it was just a case of a wire snapping in the input box 20190116 00:36:35<+wesdiscordbot> stripped some more and reattached 20190116 00:36:58<+wesdiscordbot> useless-ass ISP 20190116 01:05:23-!- celmin|away is now known as celticminstrel 20190116 01:05:42 * celticminstrel hugs Vultraz's Internet. 20190116 01:08:16<+wesdiscordbot> careful not to break it again 😛 20190116 01:36:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190116 03:36:41-!- irker702 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190116 03:48:17-!- irker866 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190116 03:48:17< irker866> wesnoth/wesnoth:master Lovens Weche be72706a75 Fixes for addon manager crash commit AppVeyor: 1/4 builds failed 20190116 03:48:17< irker866> Details vs2015/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21644387 20190116 04:54:21-!- celticminstrel is now known as celmin|sleep 20190116 06:23:38< irker866> wesnoth/wesnoth:master nemaara 7310824981 DiD S8: removed duplicate image AppVeyor: vs2015/Release Failed 20190116 06:23:39< irker866> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21652213 20190116 07:34:20-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 244 seconds] 20190116 07:38:03-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190116 07:41:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190116 10:16:42-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Remote host closed the connection] 20190116 10:30:04-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev 20190116 11:23:40< irker866> wesnoth/wesnoth:master nemaara 7310824981 DiD S8: removed duplicate image AppVeyor: 1/2 builds failed 20190116 11:23:41< irker866> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21652213 20190116 12:36:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190116 12:57:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190116 13:24:36-!- celticminstrel is now known as celmin|away 20190116 13:56:07< irker866> wesnoth/wesnoth:master nemaara 0cac69edc1 DiD S9: undef spawn macros AppVeyor: All builds passed 20190116 16:30:43<+wesdiscordbot> Vultraz, take a photo of the input box so you know the layout in case that happens again 20190116 16:43:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190116 16:56:17-!- irker866 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190116 17:45:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190116 20:50:53<+wesdiscordbot> what does the string freeze mean? translators are supposed to send translation before or during string freeze? 20190116 20:51:44< loonycyborg> both works 20190116 20:52:05< loonycyborg> but if you work on it during freeze you won't have to redo stuff because string changes are forbidden 20190116 20:52:47< loonycyborg> so string freeze is at least a good point to make final revisions and full review 20190116 20:54:29<+wesdiscordbot> Sending translations before the string freeze is a terrible idea 20190116 21:15:54<+wesdiscordbot> if you already translated what's currently in git, do send it in. But the source strings may change again up to when string freeze starts 20190116 21:16:49<+wesdiscordbot> That said, if you intend to update the translation again during string freeze, there's no point in sending it in now after all. 20190116 22:56:33<+wesdiscordbot> @loonycyborg Do you remember why you last build the campaignd trunk instance? 20190116 22:56:46<+wesdiscordbot> (not when, why) 20190116 22:57:26<+wesdiscordbot> The previous build (1.13.12-2235-g6a96b788acc) was on December 23 and I'm fairly sure that wasn't me 20190116 22:58:18<+wesdiscordbot> Even with a fresh build from the tip of master just now we're experiencing an issue where campaignd does not seem to see or report (can't tell which yet) any add-ons 20190116 23:00:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20190116 23:06:55<+wesdiscordbot> @shadowm Probably 0e2b415177e8abe08da1a0da3d836fddfe1f4532 20190116 23:07:45<+wesdiscordbot> it's two commits before 6a96b788acc. 20190116 23:07:48<+wesdiscordbot> That shouldn't cause any issues unless campaignd somehow gained a disability that only allows it to spit out empty WML documents 20190116 23:07:52<+wesdiscordbot> as a side effect 20190116 23:08:12<+wesdiscordbot> Well, not fully empty, actually, otherwise the client would go nuts 20190116 23:08:14<+wesdiscordbot> 1.14 campaignd? 20190116 23:08:20<+wesdiscordbot> I said campaignd trunk instance 20190116 23:08:24<+wesdiscordbot> oh 20190116 23:08:30<+wesdiscordbot> Do you know when the last working build was ? 20190116 23:08:36<+wesdiscordbot> I should have rebuilt it to enable ipv6 support 20190116 23:08:41<+wesdiscordbot> Not really, I assume it might be the build previous to that 20190116 23:09:00<+wesdiscordbot> which was what commit? 20190116 23:09:49<+wesdiscordbot> drwxr-xr-x 4 wesnoth wesnoth 4096 Apr 17 2018 campaignd-trunk-git-1.13.12-587-g6d5f5d4299 20190116 23:09:53<+wesdiscordbot> Probably 20190116 23:11:01<+wesdiscordbot> so only 1500 commits to bisect... 20190116 23:12:24<+wesdiscordbot> Also, that 587 build is on old master 20190116 23:12:44<+wesdiscordbot> 2235 is on new master 20190116 23:12:51<+wesdiscordbot> rip 20190116 23:13:18<+wesdiscordbot> 6d5f5d4299 became 1b94aad4162c4c413233206518878eec0e531aeb on new master. 20190116 23:16:04<+wesdiscordbot> So the server sees the add-ons 20190116 23:17:31<+wesdiscordbot> any errors logged ? 20190116 23:17:47<+wesdiscordbot> 20190116 20:15:46 info campaignd: sending campaign list to ::1 using gzip Invasion_from_the_Unknown After_the_Storm Test_Addon_420 20190116 20:17:08 info server: ::1 connection closed 20190116 23:17:58<+wesdiscordbot> I merely made it spit out names during the filter loop 20190116 23:19:29<+wesdiscordbot> There's a filter issue 20190116 23:19:47<+wesdiscordbot> they print at the start of the loop but not at the end? 20190116 23:19:59<+wesdiscordbot> I'm doing this the old fashioned way because I don't have time to bisect 20190116 23:20:12<+wesdiscordbot> sure 20190116 23:20:25<+wesdiscordbot> Something goes wrong with the timestamp filter pass 20190116 23:20:44<+wesdiscordbot> bf2d7d53e6ad9f7052dbdbf79afaba2c4f8a98a4 ? 20190116 23:20:54<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/master/src/campaign_server/campaign_server.cpp#L614 20190116 23:21:25<+wesdiscordbot> ah, "timestamp", sorry 20190116 23:21:26<+wesdiscordbot> Execution skips the current iteration at some point before if(!lang.empty()) 20190116 23:21:50<+wesdiscordbot> So did the semantics of the calls involved there change recently? 20190116 23:22:18<+wesdiscordbot> yes, there were some changes 20190116 23:22:26<+wesdiscordbot> let me get you the git command... 20190116 23:22:34<+wesdiscordbot> git log 1b94aad4162c4c413233206518878eec0e531aeb..1.13.12-2235-g6a96b788acc src/campaign_server/ 20190116 23:22:39<+wesdiscordbot> look at vultraz's commits 20190116 23:22:45<+wesdiscordbot> sadasfas 20190116 23:22:46<+wesdiscordbot> the oldest one, I guess 20190116 23:23:35<+wesdiscordbot> So I'm sure this is caused by e2a64541002f0b4ee885f699c4f0901e441f938a somehow 20190116 23:23:49<+wesdiscordbot> Since that's where the relevant code diverges from 1.14 which works correctly 20190116 23:25:24<+wesdiscordbot> Let me guess 20190116 23:25:37<+wesdiscordbot> what's the value of i["timestamp"] ? 20190116 23:25:38<+wesdiscordbot> to_time_t() doesn't throw an exception if the input is an empty string andlexical_cast()` did 20190116 23:25:58<+wesdiscordbot> (I'm speculating here) 20190116 23:28:16<+wesdiscordbot> but tm.empty() must have returned false 20190116 23:28:19<+wesdiscordbot> Okay, my assumption is correct 20190116 23:28:47<+wesdiscordbot> Reverting the first two changes in campaign_server.cpp to use lexical_cast() again fixes it 20190116 23:29:12<+wesdiscordbot> It's a terrible pattern either way so might as well just check for the presence of those attributes instead of relying on weird exception semantics 20190116 23:29:36<+wesdiscordbot> Let this serve as a lesson for @Vultraz to not mass-replace code without looking at it really closely though 20190116 23:30:07<+wesdiscordbot> 😐 20190116 23:30:09<+wesdiscordbot> fml 20190116 23:31:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190116 23:35:12<+wesdiscordbot> at least I see from your log that it can use ipv6 now 😛 20190116 23:38:09-!- irker467 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190116 23:38:09< irker467> wesnoth: Iris Morelle wesnoth:master 318a6242ee85 / src/campaign_server/campaign_server.cpp: campaignd: Explicitly check for before= and after= in add-ons list requests https://github.com/wesnoth/wesnoth/commit/318a6242ee855bca754404ad369d39069e4c594d --- Log closed Thu Jan 17 00:00:34 2019