--- Log opened Tue Jan 22 00:00:33 2019 --- Day changed Tue Jan 22 2019 20190122 00:00:33< irker441> wesnoth: Severin Glöckner wesnoth:master 07205960284d / data/campaigns/The_Hammer_of_Thursagan/scenarios/08_Fear.cfg: THoT S8: Ulfserkers aren't masked https://github.com/wesnoth/wesnoth/commit/07205960284d9df7cf011b9e9d19ec3052f914cb 20190122 00:00:51-!- travis-ci [~travis-ci@ec2-52-203-244-194.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 00:00:52< travis-ci> wesnoth/wesnoth#20706 (master - ce8c8b7 : Andrius Štikonas): The build was canceled. 20190122 00:00:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482660970 20190122 00:00:52-!- travis-ci [~travis-ci@ec2-52-203-244-194.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 00:08:14<+wesdiscordbot> hmm 20190122 00:08:25<+wesdiscordbot> this second commit requires pot-update too right? 20190122 00:08:31<+wesdiscordbot> seems it has comments for po 20190122 00:08:47<+wesdiscordbot> well it would be included in the pot update regardless, yes? 20190122 00:09:21<+wesdiscordbot> I did pot-update before noticing it 20190122 00:09:37<+wesdiscordbot> second one I mean 20190122 00:09:41<+wesdiscordbot> didn't push yet thoguh 20190122 00:10:33<+wesdiscordbot> just ping me when string freeze really begins 😛 20190122 00:11:13<+wesdiscordbot> it's begun 😛 20190122 00:11:31<+wesdiscordbot> i dunno why sevu pushed that 20190122 00:11:42<+wesdiscordbot> but im not complaining 20190122 00:16:21<+wesdiscordbot> Doesn't need to go into the pot update – it's an old string, most likely nobody will read it 20190122 00:17:36<+wesdiscordbot> But, there's sth else I had on mind… After someone told me they used an online translator for the alternative Northern Rebirth branch … should we remove it now? Or in 1.15 20190122 00:18:41< stikonas> Vultraz: is this also intentional [-"More-]{+"Mostly+} likely he has cloaked himself, 20190122 00:18:51< stikonas> that's in data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg:301 20190122 00:19:12< stikonas> I would think it should be "Most likely" 20190122 00:19:20<+wesdiscordbot> @sevu That's not really an argument 20190122 00:19:40<+wesdiscordbot> Whoever is using an online translator for anything needs a pie to the face 20190122 00:20:25<+wesdiscordbot> sitkonas: oh dear 20190122 00:20:31<+wesdiscordbot> who committed that 20190122 00:20:41<+wesdiscordbot> Well, he saw it's unused, but still in the po's. And yeah… 20190122 00:20:54<+wesdiscordbot> I guess it's another string.. 20190122 00:22:39< irker441> wesnoth: Charles Dang wesnoth:1.14 e0a65883c391 / data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg: THoT S12: fixed typo https://github.com/wesnoth/wesnoth/commit/e0a65883c39171e73315ac747bd6e3f3e80d39af 20190122 00:23:14< irker441> wesnoth: Charles Dang wesnoth:master 16d3080c761e / data/campaigns/The_Hammer_of_Thursagan/scenarios/12_The_Underlevels.cfg: THoT S12: fixed typo https://github.com/wesnoth/wesnoth/commit/16d3080c761e8816613e9ee89f315c90197d933d 20190122 00:23:28<+wesdiscordbot> stikonas: anything else you notice? 20190122 00:23:56< stikonas> Vultraz: nothing else for now... 20190122 00:24:07< stikonas> well, I was going through that big pot-update for now 20190122 00:24:23< stikonas> mostly done except for the biggest file (tsg) 20190122 00:25:44<+wesdiscordbot> alright, i'll give you a few mins 20190122 00:26:07< irker441> wesnoth: Wedge009 wesnoth:master eba9987cc231 / src/sound_music_track.cpp: Cross-platform music track reading https://github.com/wesnoth/wesnoth/commit/eba9987cc2312a476d49388804aaeee5ebd8ee2e 20190122 00:26:50< stikonas> just got for it, I don't think I'll unfuzzy everything today... 20190122 00:27:08< irker441> wesnoth: Wedge009 wesnoth:1.14 897fbd2b104c / src/sound_music_track.cpp: Cross-platform music track reading https://github.com/wesnoth/wesnoth/commit/897fbd2b104cf8498a0734b27fa8020f20ee585a 20190122 00:27:13<+wesdiscordbot> @loonycyborg ok, you can you run the pot update again 😬 20190122 00:27:14< stikonas> a few minutes wouldn't change anything 20190122 00:31:15<+wesdiscordbot> better to violate the freeze for a bit to fix typos than make translators have yo translate them and then fix them later 20190122 00:33:29<+wesdiscordbot> pofix was created to solve that problem 🤦 20190122 00:33:51<+wesdiscordbot> LovCAPONE: Added you back to the Developers group. The thread regarding the Inactive Developers group is here: https://forums.wesnoth.org/viewtopic.php?f=16&t=48381 as well as the final specifics in this post: https://forums.wesnoth.org/viewtopic.php?f=16&t=48381#p630585 20190122 00:36:16< irker441> wesnoth/wesnoth:master Wedge009 eba9987cc2 Cross-platform music track reading AppVeyor: vs2015/Release Failed 20190122 00:36:17< irker441> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21787735 20190122 00:43:28<+wesdiscordbot> I'm going to make the release date for 1.14.7 relatively soon after we get 1.14.6 out 20190122 00:43:41<+wesdiscordbot> Basically, just all of @Yumi 's dialog changes in DID, etc 20190122 00:43:45<+wesdiscordbot> that are still pening 20190122 00:44:26<+wesdiscordbot> 😮 20190122 00:44:34<+wesdiscordbot> it will need some time for playtesting 20190122 00:45:05<+wesdiscordbot> (I guess maybe a month to be safe?) 20190122 00:45:37<+wesdiscordbot> @Yumi you have a month. 1.14.6 won't be out until the end of Feb. 20190122 00:45:38<+wesdiscordbot> then again I should have a fully working version maybe by the end of this weekend 20190122 00:45:47<+wesdiscordbot> so playtesters will have time 20190122 00:46:20< stikonas> ok, maybe I'll have time to get to 80% in core domains then :), if not 1.14.6, then 1.14.7 20190122 00:46:22<+wesdiscordbot> but I'm hoping for a freeze for 1.14.7 by early March 20190122 00:46:26<+wesdiscordbot> mostly to give other ppl time, I obvs playtest it all myself 20190122 00:46:38<+wesdiscordbot> also @josteph wants to review the scenarios too 20190122 00:46:52<+wesdiscordbot> hope he can find time 20190122 00:46:56<+wesdiscordbot> why the fuck is it the end of January already 20190122 00:47:04<+wesdiscordbot> it was just new years 20190122 00:47:06<+wesdiscordbot> 🤷 20190122 00:47:45<+wesdiscordbot> I'll probably get in some other minor campaign fixes then... 20190122 00:47:50<+wesdiscordbot> for 1.14.7 I mean 20190122 00:47:52<+wesdiscordbot> again, you have a month 20190122 00:47:58<+wesdiscordbot> yea, I hope it's enough 20190122 00:48:03<+wesdiscordbot> def okay for me, just idk about other ppl 20190122 00:48:14<+wesdiscordbot> you can construct a branch ready to merge as soon as 1.14.6 is out 20190122 00:48:30<+wesdiscordbot> I'm probably going to give a week between the 1.14.6 release and 1.14.7 freeze 20190122 00:49:05<+wesdiscordbot> should I be doing that or is it better for someone with commit access to just cherrypick my stuff from master to 1.14? 20190122 00:49:12<+wesdiscordbot> coz otherwise I have to make separate PRs for 1.14 20190122 00:49:52<+wesdiscordbot> topic updated 20190122 00:50:06<+wesdiscordbot> you don't have commit access? 20190122 00:50:14<+wesdiscordbot> nah 20190122 00:50:19<+wesdiscordbot> the hell 20190122 00:50:37<+wesdiscordbot> not sure how good of an idea it is either, I make a lot of mistakes with git rn 20190122 00:50:56<+wesdiscordbot> well if you'd rather not 20190122 00:50:57<+wesdiscordbot> have 20190122 00:50:57<+wesdiscordbot> it 20190122 00:51:09<+wesdiscordbot> I guess it doesn't matter either way if other ppl are merging my stuff 20190122 00:51:29< irker441> wesnoth/wesnoth:1.14 loonycyborg e43f454de8 pot-update and regenerate doc files AppVeyor: All builds passed 20190122 00:51:29-!- travis-ci [~travis-ci@ec2-54-196-104-168.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 00:51:30< travis-ci> wesnoth/wesnoth#20708 (master - 0720596 : Severin Glöckner): The build was broken. 20190122 00:51:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482661601 20190122 00:51:30-!- travis-ci [~travis-ci@ec2-54-196-104-168.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 00:51:37<+wesdiscordbot> invite sent 20190122 00:53:14< irker441> wesnoth: loonycyborg wesnoth:1.14 ba469e2d60cc / po/ (118 files in 2 dirs): pot-update for typo fixes https://github.com/wesnoth/wesnoth/commit/ba469e2d60cc4269049e5cfcf535b271c78c9823 20190122 00:53:59<+wesdiscordbot> ok, can someone email the translators 20190122 00:56:39< irker441> wesnoth: Edward Chernenko wesnoth:master d5d23fb5238c / data/tools/wmllint: wmllint: fix "local variable 'unit_id' referenced before assignment" https://github.com/wesnoth/wesnoth/commit/d5d23fb5238c45573685958d6a1eada3b49bc295 20190122 00:57:30< irker441> wesnoth: Edward Chernenko wesnoth:1.14 8d3554cb2099 / data/tools/wmllint: wmllint: fix "local variable 'unit_id' referenced before assignment" https://github.com/wesnoth/wesnoth/commit/8d3554cb2099cd51d49359ef02a3a71edd268184 20190122 01:05:59< irker441> wesnoth/wesnoth:master Edward Chernenko d5d23fb523 wmllint: fix "local variable 'unit_id' r AppVeyor: vs2015/Release Failed 20190122 01:06:00< irker441> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21788083 20190122 01:14:40< irker441> wesnoth: Charles Dang wesnoth:1.14 dc71359a01dd / data/campaigns/ (22 files in 13 dirs): Campaigns: wmlindent pass https://github.com/wesnoth/wesnoth/commit/dc71359a01dd70f4ae118078bd6ed1032755b404 20190122 01:15:07<+wesdiscordbot> I hope that doesn't fuck something up with the translations, since in some places newlines were removed 💭 20190122 01:20:44<+wesdiscordbot> loony is gonna murder me 😬 20190122 01:22:20-!- travis-ci [~travis-ci@ec2-54-211-174-236.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 01:22:21< travis-ci> wesnoth/wesnoth#20711 (1.14 - ba469e2 : loonycyborg): The build was broken. 20190122 01:22:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482672702 20190122 01:22:21-!- travis-ci [~travis-ci@ec2-54-211-174-236.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 01:23:20<+wesdiscordbot> that line can just wait until 14.7 20190122 01:23:21< irker441> wesnoth: Charles Dang wesnoth:1.14 33a424f36aeb / data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg: NR S05a: fixed typo in key name https://github.com/wesnoth/wesnoth/commit/33a424f36aeb3898adb25f0fdfd43ef2ef47511f 20190122 01:23:24< irker441> wesnoth: Charles Dang wesnoth:1.14 cc9b20cd2044 / data/campaigns/Two_Brothers/scenarios/03_Guarded_Castle.cfg: AToTB S3: fixed dialog line not being marked translatable https://github.com/wesnoth/wesnoth/commit/cc9b20cd2044a85706fcf2598e29fadb263dad7c 20190122 01:24:12< irker441> wesnoth: Charles Dang wesnoth:master 3bc8f7e6a00e / data/campaigns/Two_Brothers/scenarios/03_Guarded_Castle.cfg: AToTB S3: fixed dialog line not being marked translatable https://github.com/wesnoth/wesnoth/commit/3bc8f7e6a00e8a65019d42657683d4845ca98674 20190122 01:24:13<+wesdiscordbot> looks like the NR thing was fixed in master but not 1.14 😐 20190122 01:24:15<+wesdiscordbot> someone forgot to backport 20190122 01:29:11< irker441> wesnoth: Charles Dang wesnoth:master 4d09e8719395 / data/campaigns/Under_the_Burning_Suns/_main.cfg: UtBS: compatibility be gone! https://github.com/wesnoth/wesnoth/commit/4d09e871939560352d4c908bb7cc6e1ba74c94d4 20190122 01:31:04< irker441> wesnoth: Charles Dang wesnoth:1.14 955d605d8a84 / data/campaigns/Under_the_Burning_Suns/_main.cfg: UtBS: compatibility be gone! https://github.com/wesnoth/wesnoth/commit/955d605d8a8447ff6682a320394937f0bc6ff3bc 20190122 01:40:45<+wesdiscordbot> @Vultraz thanks for invite 😮 20190122 01:40:52< irker441> wesnoth/wesnoth:master Charles Dang 4d09e87193 UtBS: compatibility be gone! AppVeyor: vs2015/Release Failed 20190122 01:40:53< irker441> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21788529 20190122 01:40:59-!- travis-ci [~travis-ci@ec2-35-153-80-45.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 01:41:00< travis-ci> wesnoth/wesnoth#20712 (master - d5d23fb : Edward Chernenko): The build is still failing. 20190122 01:41:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482673415 20190122 01:41:00-!- travis-ci [~travis-ci@ec2-35-153-80-45.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 01:43:58<+wesdiscordbot> The AToTB line should go into the pot… or be removed … 20190122 01:44:40<+wesdiscordbot> wonders why the abbreviation is not TB 20190122 01:45:23<+wesdiscordbot> looks like https://github.com/wesnoth/wesnoth/pull/3851 broke the macos builds 20190122 01:45:38<+wesdiscordbot> /Users/travis/build/wesnoth/wesnoth/src/sound_music_track.cpp:22:10: fatal error: 'vorbis/vorbisfile.h' file not found #include "vorbis/vorbisfile.h" 20190122 01:46:59<+wesdiscordbot> also, @sevu , not providing an explicit side breaks schema in https://github.com/wesnoth/wesnoth/commit/07205960284d9df7cf011b9e9d19ec3052f914cb 20190122 01:48:02<+wesdiscordbot> uh… I have seen this a while ago and though I switch to this way of writing. 20190122 01:49:56<+wesdiscordbot> UNIT () should be UNIT 2 the former works, I assume, but with the macro it ends with with a line as just side=, which schema doesn't like. 20190122 01:50:11<+wesdiscordbot> *ends up with 20190122 01:52:24<+wesdiscordbot> makes sense 20190122 01:52:40< irker441> wesnoth: Severin Glöckner wesnoth:1.14 fa25ec47c4dd / data/campaigns/The_Hammer_of_Thursagan/scenarios/08_Fear.cfg: SoF S8: fixup for schema validation https://github.com/wesnoth/wesnoth/commit/fa25ec47c4ddd2e87631d168d87ba290dd8e43e5 20190122 01:53:26< irker441> wesnoth: Severin Glöckner wesnoth:master 548e8584b821 / data/campaigns/The_Hammer_of_Thursagan/scenarios/08_Fear.cfg: SoF S8: fixup for schema validation https://github.com/wesnoth/wesnoth/commit/548e8584b821c78029b9f254f5733a63177c1f87 20190122 01:57:49-!- travis-ci [~travis-ci@ec2-54-83-86-5.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 01:57:50< travis-ci> wesnoth/wesnoth#20713 (1.14 - 8d3554c : Edward Chernenko): The build failed. 20190122 01:57:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482673592 20190122 01:57:50-!- travis-ci [~travis-ci@ec2-54-83-86-5.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 02:01:32< irker441> wesnoth/wesnoth:1.14 Severin Glöckner fa25ec47c4 SoF S8: fixup for schema validation AppVeyor: vs2015/Release Failed 20190122 02:01:33< irker441> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21788812 20190122 02:14:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190122 02:17:55< irker441> wesnoth/wesnoth:master Severin Glöckner 548e8584b8 SoF S8: fixup for schema validation AppVeyor: vs2017/Release Failed 20190122 02:17:56< irker441> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21788827 20190122 02:36:38-!- travis-ci [~travis-ci@ec2-35-153-80-45.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 02:36:39< travis-ci> wesnoth/wesnoth#20715 (master - 548e858 : Severin Glöckner): The build is still failing. 20190122 02:36:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482687052 20190122 02:36:39-!- travis-ci [~travis-ci@ec2-35-153-80-45.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 02:47:32-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 02:47:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 03:02:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 03:02:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 03:33:48-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 03:33:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 04:20:19-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 04:20:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 05:04:06-!- celmin|away is now known as celmin|sleep 20190122 05:18:02-!- irker441 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190122 05:36:23-!- irker438 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190122 05:36:23< irker438> wesnoth/wesnoth:master Wedge009 eba9987cc2 Cross-platform music track reading AppVeyor: 2/4 builds failed 20190122 05:36:23< irker438> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21787735 20190122 05:36:23< irker438> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21787736 20190122 06:06:00< irker438> wesnoth/wesnoth:master Edward Chernenko d5d23fb523 wmllint: fix "local variable 'unit_id' r AppVeyor: 2/4 builds failed 20190122 06:06:01< irker438> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21788083 20190122 06:06:02< irker438> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21788084 20190122 06:40:52< irker438> wesnoth/wesnoth:master Charles Dang 4d09e87193 UtBS: compatibility be gone! AppVeyor: 2/4 builds failed 20190122 06:40:53< irker438> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21788529 20190122 06:40:54< irker438> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21788534 20190122 07:01:34< irker438> wesnoth/wesnoth:1.14 Severin Glöckner fa25ec47c4 SoF S8: fixup for schema validation AppVeyor: 2/4 builds failed 20190122 07:01:35< irker438> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21788812 20190122 07:01:36< irker438> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21788814 20190122 07:17:56< irker438> wesnoth/wesnoth:master Severin Glöckner 548e8584b8 SoF S8: fixup for schema validation AppVeyor: 2/4 builds failed 20190122 07:17:57< irker438> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21788827 20190122 07:17:58< irker438> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21788828 20190122 07:21:13<+wesdiscordbot> @Pentarctagon The music track name reading also breaks Visual Studio builds. 20190122 07:21:25<+wesdiscordbot> Libvorbisfile is now a required dependency on all platforms. 20190122 07:48:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190122 09:05:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 09:05:12-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 09:17:11<+wesdiscordbot> where does one acquire this 20190122 09:17:14<+wesdiscordbot> libvorbisfile :thonk: 20190122 09:18:23<+wesdiscordbot> https://xiph.org/downloads/ 20190122 09:18:41<+wesdiscordbot> I think it's in the libvorbis or vorbis-tools package. 20190122 09:19:01<+wesdiscordbot> (Note that libvorbisfile depends on libvorbis, so it's needed in any case.) 20190122 09:22:00<+wesdiscordbot> ok, there's vorbis/vorbisfile.h 20190122 09:22:32<+wesdiscordbot> but where's the .lib... 20190122 09:23:01<+wesdiscordbot> They're probably distributing only the source code, so you'd need to build it yourself. 20190122 09:23:10<+wesdiscordbot> mein gott 20190122 09:23:24<+wesdiscordbot> well, there is a VS 2010 file... 20190122 09:23:25<+wesdiscordbot> at least 20190122 09:25:57<+wesdiscordbot> looks like it's looking for something in an ogg/ folder 20190122 09:26:23<+wesdiscordbot> That sounds strange to me. 20190122 09:26:44<+wesdiscordbot> #include 20190122 09:27:01<+wesdiscordbot> Ogg is a container format, and Vorbis is an audio stream format. An Ogg file can contain Vorbis streams. 20190122 09:27:15<+wesdiscordbot> So I'd expect libogg to depend on libvorbis, not the reverse. 20190122 09:27:30<+wesdiscordbot> (side note: how does Boost take almost 12 minutes to extract from a .7z file even with an SSD and 16 GB of RAM 😐 ) 20190122 09:28:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190122 09:32:40<+wesdiscordbot> ok, the files it's looking for are indeed in libogg 20190122 09:34:43<+wesdiscordbot> it's the libvorbis_static project that builds as a dependency of libvorbisfile that requires libogg 🤔 20190122 09:35:20<+wesdiscordbot> I think the static project is what you want. 20190122 09:35:45<+wesdiscordbot> The dynamic one would attempt to load libogg DLL at runtime, so you'd need to compile libogg separately. 20190122 09:35:55<+wesdiscordbot> I now have 2 libs. libvorbis_static.lib and libvorbisfile_static.lib 20190122 09:36:21<+wesdiscordbot> No DLLs? 20190122 09:37:17<+wesdiscordbot> not seeing any 20190122 09:37:40<+wesdiscordbot> Then I'm taking my earlier words back. You probably want the dynamic project instead. 20190122 09:38:11<+wesdiscordbot> It would place the actual code to libvorbis.dll and maybe libvorbisfile.dll. 20190122 09:38:17<+wesdiscordbot> let us see 20190122 09:38:30<+wesdiscordbot> (And also generate .lib files, but much smaller ones.) 20190122 09:39:27<+wesdiscordbot> You can then just replace the libvorbis and libvorbisfile DLLs in this directory with yours, assuming that they have the same names. 20190122 09:39:28<+wesdiscordbot> https://github.com/aquileia/external/tree/VC15/dll 20190122 09:39:42<+wesdiscordbot> dynamic building needs libogg built beforehand 20190122 09:39:44<+wesdiscordbot> (If they don't, then you can just have both sets of DLLs there.) 20190122 09:39:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190122 09:40:03<+wesdiscordbot> Hmm, OK. Then it's maybe easier to just stick with static linking. 20190122 09:40:08<+wesdiscordbot> guess that's why the README says this: libvorbis has libogg as a dependency, you need to have libogg compiled beforehand. 20190122 09:41:13<+wesdiscordbot> Now you need to add libvorbis_static.lib and libvorbisfile_static.lib to the aquileia/external repository, and add them as dependencies for Wesnoth in Visual Studio project settings. 20190122 09:41:17<+wesdiscordbot> the static project will build with the ogg source alongside the vorbis folder. 20190122 09:41:25<+wesdiscordbot> It's somewhere in Linker -> Input IIRC. 20190122 09:41:33<+wesdiscordbot> the dynamic one fails at link because it cannot open libogg_static.lib 20190122 09:54:31<+wesdiscordbot> well this is weird. the boost 1.69 7z file I downloaded now refuses to be moved or deleted from my downloads folder P_P 20190122 09:55:07<+wesdiscordbot> Sounds like the file is locked. 20190122 09:55:22<+wesdiscordbot> locked? 20190122 09:56:04<+wesdiscordbot> Windows can lock files to make them impossible to delete or edit (and often does it implicitly). 20190122 09:56:23<+wesdiscordbot> For example, FileASSASSIN would help with it: https://www.portablefreeware.com/index.php?id=1092 20190122 11:06:22-!- irker438 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190122 11:17:14<+wesdiscordbot> looks like libogg is required at link time even with static libvorbis 20190122 11:26:06<+wesdiscordbot> URG 20190122 11:26:08<+wesdiscordbot> unresolved external symbol _BZ2_compressBlock 20190122 11:26:12<+wesdiscordbot> Y U DO DIS BOOST 20190122 11:34:46<+wesdiscordbot> ok, rebuilt boost with iostreams enabled this time (forgot the first time and did it separately) and it works \o/ 20190122 11:35:32<+wesdiscordbot> this does appear now, though 🤔 MSVCRT.lib(initializers.obj) : warning LNK4098: defaultlib 'libcmt.lib' conflicts with use of other libs; use /NODEFAULTLIB:library 20190122 11:37:55<+wesdiscordbot> Some information about it: https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-warning-lnk4098 20190122 11:38:05<+wesdiscordbot> > The run-time libraries now contain directives to prevent mixing different types. You will receive this warning if you try to use different types or debug and non-debug versions of the run-time library in the same program. For example, if you compiled one file to use one kind of run-time library and another file to use another kind (for example, single-threaded versus multithreaded) and tried to link them, you will get 20190122 11:38:06<+wesdiscordbot> this warning. You should compile all source files to use the same run-time library. See the Use Run-Time Library (/MD, /MT, /LD) compiler options for more information. 20190122 11:38:38<+wesdiscordbot> IIRC, we're supposed to use "Multi Threaded DLL" in release builds and "Multi Threaded Debug DLL" in debug builds. 20190122 11:39:55<+wesdiscordbot> but I haven't added any dlls 20190122 11:40:04<+wesdiscordbot> you told me to use static vorbis 20190122 11:40:26<+wesdiscordbot> The preference means which version of Microsoft's Visual C++ runtime library is used. 20190122 11:40:56<+wesdiscordbot> There is no way to not use the MSVCRT at all. All C++ code compiled with VS depends on it. 20190122 11:40:56<+wesdiscordbot> ohh... 20190122 11:44:05<+wesdiscordbot> I'm guessing it must be some inconsistency with the libogg/libvorbis project settings? 20190122 11:44:38<+wesdiscordbot> Yes, it may be that the run-time library setting is different across projects. 20190122 11:44:57<+wesdiscordbot> Should I try to resolve it? 20190122 11:45:18<+wesdiscordbot> It's not a severe problem, so I think you can leave it be. 20190122 12:05:00-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 12:05:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 12:27:01<+wesdiscordbot> Do you have write access to the externals repo? 20190122 12:27:14<+wesdiscordbot> No, I don't. 20190122 12:27:21<+wesdiscordbot> herm 20190122 12:27:22<+wesdiscordbot> neither I 20190122 12:27:43<+wesdiscordbot> Huh. I thought you had it. 20190122 12:34:53-!- irker634 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190122 12:34:53< irker634> wesnoth: Charles Dang wesnoth:1.14 816809bcad0a / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): VS projectfile update https://github.com/wesnoth/wesnoth/commit/816809bcad0a50602b5fa105f450a4407d0f7fb3 20190122 12:38:28<+wesdiscordbot> https://github.com/aquileia/external/pull/31 20190122 12:39:06<+wesdiscordbot> merge conflicts 😦 20190122 12:40:09<+wesdiscordbot> damn 20190122 12:40:18<+wesdiscordbot> ok, seems.. 20190122 12:40:22<+wesdiscordbot> wedge actually updated SDL already 20190122 12:40:38<+wesdiscordbot> I was working on a branch 20190122 12:40:40<+wesdiscordbot> 😬 20190122 12:40:48<+wesdiscordbot> also he had updated to 1.68 20190122 12:40:54<+wesdiscordbot> but this is 1.69, so I need to resolve over that 20190122 12:44:44< irker634> wesnoth/wesnoth:1.14 Charles Dang 816809bcad VS projectfile update AppVeyor: vs2017/Release Failed 20190122 12:44:45< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21799463 20190122 12:55:16<+wesdiscordbot> ok, looks like wedge didn't update all the other DLLs included in the SDL packages 20190122 12:55:33<+wesdiscordbot> besides the main ones 20190122 13:54:41-!- celmin|sleep is now known as celmin|away 20190122 14:23:38-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 14:23:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 14:28:04<+wesdiscordbot> external PR should be good now 20190122 14:28:52<+wesdiscordbot> Great. 👍 I can deal with VS2013 and VS2015 builds of libvorbis and libvorbisfile. 20190122 14:30:28<+wesdiscordbot> mine should work with 2015, should they not? 20190122 14:31:04<+wesdiscordbot> Yes, VS2015 and VS2017 are ABI compatible. 20190122 14:31:20<+wesdiscordbot> But if I'm building the libraries for 2013, I can just as well build them for 2015 too. 20190122 14:31:29<+wesdiscordbot> ah 20190122 14:32:14<+wesdiscordbot> I wonder if VS 2019 will be ABI compatible with 2017 🤔 20190122 14:37:07<+wesdiscordbot> From what I can tell, Microsoft hasn't told about it, but it's speculated that VS2019 will break the ABI. 20190122 15:17:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 15:17:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 15:22:08-!- Ravana [~Ravana@wesnoth/mp-mod/ravana] has quit [Ping timeout: 244 seconds] 20190122 15:24:28< irker634> wesnoth: Charles Dang wesnoth:1.14 9a5487a098ff / src/serialization/string_utils.cpp: Always used fixed precision for formatting size strings (#3871) https://github.com/wesnoth/wesnoth/commit/9a5487a098ff39268f27917e324e2886b92ae97b 20190122 15:26:51< irker634> wesnoth: Charles Dang wesnoth:master 9b436ef74348 / src/serialization/string_utils.cpp: Always used fixed precision for formatting size strings (#3871) https://github.com/wesnoth/wesnoth/commit/9b436ef7434810b61bc7c8159520346f900bdad0 20190122 15:34:32< irker634> wesnoth/wesnoth:1.14 Charles Dang 9a5487a098 Always used fixed precision for formatti AppVeyor: vs2017/Release Failed 20190122 15:34:33< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21804118 20190122 15:46:20-!- travis-ci [~travis-ci@ec2-54-225-38-34.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 15:46:21< travis-ci> wesnoth/wesnoth#20716 (1.14 - 9a5487a : Charles Dang): The build is still failing. 20190122 15:46:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482941628 20190122 15:46:21-!- travis-ci [~travis-ci@ec2-54-225-38-34.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 15:57:52< irker634> wesnoth/wesnoth:master Charles Dang 9b436ef743 Always used fixed precision for formatti AppVeyor: vs2015/Release Failed 20190122 15:57:53< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21804187 20190122 16:06:02-!- travis-ci [~travis-ci@ec2-54-225-38-34.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 16:06:03< travis-ci> wesnoth/wesnoth#20717 (master - 9b436ef : Charles Dang): The build is still failing. 20190122 16:06:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/482942790 20190122 16:06:03-!- travis-ci [~travis-ci@ec2-54-225-38-34.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 16:13:26<+wesdiscordbot> Can someone update the mac projfile with libvorbis? 20190122 16:16:10<+wesdiscordbot> Also could someone update the INSTALL file if applicable 20190122 17:44:44< irker634> wesnoth/wesnoth:1.14 Charles Dang 816809bcad VS projectfile update AppVeyor: 2/4 builds failed 20190122 17:44:45< irker634> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21799463 20190122 17:44:46< irker634> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21799464 20190122 17:48:27<+wesdiscordbot> Hmm. Regarding the MSVCRT defaults, they are indeed different fir libogg and libvorbis by default. 20190122 17:49:00<+wesdiscordbot> Libogg defaults to Multi Threaded, whereas libvorbis uses Multi Threaded DLL by default. 20190122 17:49:08<+wesdiscordbot> I'll build both with the DLL. 20190122 17:57:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 17:57:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 18:01:11<+wesdiscordbot> @Vultraz do I have push access to the wesnoth repo as well, or only to project haldric. Asking because if so then I could push translations myself instead of asking sevu or ivanovic. 20190122 18:02:58< irker634> wesnoth/wesnoth:master nemaara 0ab5629038 AToTB S3: added castle ToD and rebalance AppVeyor: vs2017/Release Failed 20190122 18:02:59< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21808130 20190122 18:23:59< irker634> wesnoth/wesnoth:master nemaara 4b1335b5a2 DW S3: added event for storm trident AppVeyor: vs2015/Release Failed 20190122 18:24:00< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21808705 20190122 18:28:39< irker634> wesnoth: Jyrki Vesterinen wesnoth:master 86c2833f843b / projectfiles/VC14/wesnoth.vcxproj: Visual Studio project: link to libogg, libvorbis and libvorbisfile https://github.com/wesnoth/wesnoth/commit/86c2833f843b79ad8807bd528c248003e1eca5f3 20190122 18:47:14< irker634> wesnoth/wesnoth:master Jyrki Vesterinen 86c2833f84 Visual Studio project: link to libogg, l AppVeyor: vs2015/Release Failed 20190122 18:47:15< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21809075 20190122 18:56:37-!- travis-ci [~travis-ci@ec2-54-82-123-158.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 18:56:38< travis-ci> wesnoth/wesnoth#20720 (master - 86c2833 : Jyrki Vesterinen): The build is still failing. 20190122 18:56:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/483021100 20190122 18:56:38-!- travis-ci [~travis-ci@ec2-54-82-123-158.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 19:11:36< irker634> wesnoth/wesnoth:master newfrenchy83 83a17315fc codeblock: link to libogg, libvorbis and AppVeyor: vs2017/Release Failed 20190122 19:11:37< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21809843 20190122 19:13:49<+wesdiscordbot> Wedge009: I just opened https://github.com/aquileia/external/pull/32 and https://github.com/aquileia/external/pull/33 20190122 19:13:56<+wesdiscordbot> Please merge them, as well as #31. 20190122 19:14:33< irker634> wesnoth: newfrenchy83 wesnoth:master cf800bc95890 / projectfiles/CodeBlocks/wesnoth.cbp: codeblock: link to libogg, libvorbis and libvorbisfile https://github.com/wesnoth/wesnoth/commit/cf800bc95890143068ce25f7d43739a468ccb63e 20190122 19:27:24< irker634> wesnoth/wesnoth:master newfrenchy83 cf800bc958 codeblock: link to libogg, libvorbis and AppVeyor: vs2015/Release Failed 20190122 19:27:25< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21810113 20190122 19:34:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 19:34:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 19:45:10-!- travis-ci [~travis-ci@ec2-54-196-189-124.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 19:45:11< travis-ci> wesnoth/wesnoth#20722 (master - cf800bc : newfrenchy83): The build is still failing. 20190122 19:45:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/483041382 20190122 19:45:11-!- travis-ci [~travis-ci@ec2-54-196-189-124.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 19:56:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190122 20:34:33< irker634> wesnoth/wesnoth:1.14 Charles Dang 9a5487a098 Always used fixed precision for formatti AppVeyor: 2/4 builds failed 20190122 20:34:34< irker634> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21804118 20190122 20:34:35< irker634> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21804122 20190122 20:35:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190122 20:57:52< irker634> wesnoth/wesnoth:master Charles Dang 9b436ef743 Always used fixed precision for formatti AppVeyor: 2/4 builds failed 20190122 20:57:53< irker634> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21804187 20190122 20:57:54< irker634> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21804188 20190122 21:25:31< galegosimpatico> I'd love to try to PR the macOS stuff, if hruby is off, but I can't really commit time until around May. :| 20190122 21:27:55<+wesdiscordbot> @Bitron you have both 20190122 21:48:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 21:48:10-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 21:55:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection] 20190122 21:55:34-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev 20190122 21:57:26<+wesdiscordbot> Alright, then. Thank you. 20190122 21:59:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Client Quit] 20190122 22:38:34< irker634> wesnoth/wesnoth:1.14 newfrenchy83 232f66a98b codeblock: link to libogg, libvorbis and AppVeyor: vs2017/Release Failed 20190122 22:38:35< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21814992 20190122 22:54:46-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190122 22:55:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds] 20190122 23:02:58< irker634> wesnoth/wesnoth:master nemaara 0ab5629038 AToTB S3: added castle ToD and rebalance AppVeyor: 2/4 builds failed 20190122 23:02:59< irker634> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21808130 20190122 23:03:00< irker634> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21808131 20190122 23:05:26< irker634> wesnoth: newfrenchy83 wesnoth:1.14 b7d5341561ad / projectfiles/CodeBlocks/wesnoth.cbp: codeblock: link to libogg, libvorbis and libvorbisfile for stable branch https://github.com/wesnoth/wesnoth/commit/b7d5341561adbb7899e9fdf3e18bb721108de013 20190122 23:14:34< irker634> wesnoth/wesnoth:1.14 newfrenchy83 b7d5341561 codeblock: link to libogg, libvorbis and AppVeyor: vs2017/Release Failed 20190122 23:14:35< irker634> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21815804 20190122 23:23:59< irker634> wesnoth/wesnoth:master nemaara 4b1335b5a2 DW S3: added event for storm trident AppVeyor: 2/4 builds failed 20190122 23:24:00< irker634> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21808705 20190122 23:24:01< irker634> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21808734 20190122 23:27:44-!- travis-ci [~travis-ci@ec2-54-221-187-114.compute-1.amazonaws.com] has joined #wesnoth-dev 20190122 23:27:45< travis-ci> wesnoth/wesnoth#20724 (1.14 - b7d5341 : newfrenchy83): The build is still failing. 20190122 23:27:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/483145764 20190122 23:27:45-!- travis-ci [~travis-ci@ec2-54-221-187-114.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190122 23:47:14< irker634> wesnoth/wesnoth:master Jyrki Vesterinen 86c2833f84 Visual Studio project: link to libogg, l AppVeyor: 2/4 builds failed 20190122 23:47:15< irker634> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/21809075 20190122 23:47:16< irker634> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/21809076 20190122 23:48:13<+wesdiscordbot> @Vultraz if I put a sconce below a stone wall, it doesn't show up at all or do anything 20190122 23:48:25<+wesdiscordbot> eh? 20190122 23:48:27<+wesdiscordbot> "do anything" 20190122 23:48:29<+wesdiscordbot> ? 20190122 23:48:37<+wesdiscordbot> does not illuminate the hex 20190122 23:48:39<+wesdiscordbot> it's not supposed to 20190122 23:48:54<+wesdiscordbot> okay, but it doesn't show up 20190122 23:48:55<+wesdiscordbot> I have to put it on the wall 20190122 23:48:56<+wesdiscordbot> lit stone walls never were illuminated terrains 20190122 23:49:06<+wesdiscordbot> and only in a very specific location 20190122 23:49:12<+wesdiscordbot> :thonk: 20190122 23:49:15<+wesdiscordbot> it doesn't show up on all wall angles 20190122 23:49:30<+wesdiscordbot> (one sec I'll give an example) 20190122 23:49:43<+wesdiscordbot> fun fun fun 20190122 23:50:43<+wesdiscordbot> wait 20190122 23:50:45<+wesdiscordbot> I'm stupid 20190122 23:50:58<+wesdiscordbot> you need two adjacent walls with sconces on them for it to show up 20190122 23:51:01<+wesdiscordbot> >:O 20190122 23:51:03<+wesdiscordbot> thonk intensifies 20190122 23:51:05<+wesdiscordbot> :thonk: 20190122 23:51:16<+wesdiscordbot> this has always been the case, ya know 20190122 23:51:34<+wesdiscordbot> yes, I don't know why my brain didn't connect the dots 20190122 23:51:51<+wesdiscordbot> but at least this clarified whether or not they're supposed to illuminate 20190122 23:52:32<+wesdiscordbot> I'll fix up that map to work with sconces then 20190122 23:54:11<+wesdiscordbot> Sconce All The Things --- Log closed Wed Jan 23 00:00:42 2019