--- Log opened Mon Jan 07 00:00:00 2019 --- Day changed Mon Jan 07 2019 20190107 00:00:00<+wesdiscordbot> @Konrad2 the bug happens just with rulers of irdya, right? 20190107 00:00:08<+wesdiscordbot> the name is name= _ "The Rising Storm" 20190107 00:00:20<+wesdiscordbot> hello @The_Gnat 20190107 00:00:26<+wesdiscordbot> Hi 20190107 00:01:02<+wesdiscordbot> Also note that I was lazy with the #textdomain and didn't change it to say the correct name 😋 would that cause any issues? 20190107 00:01:13<+wesdiscordbot> what's the textdomain ? 20190107 00:01:27<+wesdiscordbot> At the top of every scenario it says '#textdomain wesnoth-dl' 20190107 00:01:37<+wesdiscordbot> But i assume it didn't matter 20190107 00:01:50<+wesdiscordbot> Hmm, I wonder if @Konrad2 has a duplicate textdomain 20190107 00:02:17<+wesdiscordbot> actually, that's very likely, I think 20190107 00:02:24<+wesdiscordbot> you copied wesnoth-dl from somewhere, right 20190107 00:02:25<+wesdiscordbot> ? 20190107 00:02:28<+wesdiscordbot> Well potentially it could even be an internal error because the main.cfg file says [textdomain] name="wesnoth-tRoI" [/textdomain] 20190107 00:02:30<+wesdiscordbot> Konrad2 must have installed that one 20190107 00:02:39<+wesdiscordbot> so, let's see 20190107 00:02:57<+wesdiscordbot> @Konrad2 can you remove the lone underscore before the campaign name and see if that makes the campaign name not be considered invalid ? 20190107 00:03:06<+wesdiscordbot> Dragons Lair is the text domain I copied I think 20190107 00:03:32<+wesdiscordbot> @Konrad2 do you have dragons lair installed ? 20190107 00:03:37<+wesdiscordbot> Nope. 20190107 00:03:49<+wesdiscordbot> nope, not installed? 20190107 00:03:56<+wesdiscordbot> Not installed. ^^ 20190107 00:04:08<+wesdiscordbot> right, then see my previous statement about underscore 20190107 00:04:09<+wesdiscordbot> @josteph does it matter if the textdomain is inconsistent? 20190107 00:04:49<+wesdiscordbot> @The_Gnat If two campaigns have the same textdomain and both ship po files... I'm not sure what would happen 20190107 00:05:01<+wesdiscordbot> a misspelled textdomain wouldn't cause havoc 20190107 00:05:10<+wesdiscordbot> But what if some files say #textdomain wesnoth-tRoI and some say #textdomain wesnoth-dl ? 20190107 00:05:24<+wesdiscordbot> does your campaign ship with translations ? 20190107 00:05:24<+wesdiscordbot> 😅 20190107 00:05:28<+wesdiscordbot> Nope 20190107 00:05:45<+wesdiscordbot> Do you mean the Scenario name? 20190107 00:05:48<+wesdiscordbot> okay, so the wesnoth-dl files might use translations shipped with dragons lair I suppose 20190107 00:05:55<+wesdiscordbot> but that's it Gnat 20190107 00:06:15<+wesdiscordbot> @Konrad2 find one place that says foo = _ "Bar" and delete the underscore 20190107 00:06:29<+wesdiscordbot> it says currently name= _ "The Rising Storm" and should say name= "The Rising Storm" 20190107 00:06:32<+wesdiscordbot> where Bar is one of the things from your error log 20190107 00:07:48<+wesdiscordbot> I presume I should copy the removed add-ons back in? 20190107 00:08:01<+wesdiscordbot> @josteph what is the significance of the underscore? 20190107 00:08:02<+wesdiscordbot> It's kinda meaningless if I don't. 20190107 00:08:07<+wesdiscordbot> @Konrad2 Yes 20190107 00:08:15<+wesdiscordbot> (This will take a few moments.) 20190107 00:08:21<+wesdiscordbot> @Konrad2 We are trying to find two situations, one that works and one that doesn't, that are as similar 20190107 00:08:39<+wesdiscordbot> @The_Gnat means the string after it is translated 20190107 00:09:04<+wesdiscordbot> @The_Gnat Look at https://github.com/wesnoth/wesnoth/blob/1.14/po/wesnoth-help/wesnoth-help.pot 20190107 00:09:41<+wesdiscordbot> @The_Gnat Actually, look at https://github.com/wesnoth/wesnoth/blob/1.14/po/wesnoth-help/wesnoth-help.pot#L4560-L4568 while you're there 20190107 00:09:55<+wesdiscordbot> you can see an example of contexts as I mentioned on the DiD thread 20190107 00:11:59<+wesdiscordbot> Ah of course 🙂 20190107 00:12:49<+wesdiscordbot> The voiceover project is really a special kind of translation 20190107 00:13:07<+wesdiscordbot> Several translations, actually, since you do voiceovers in multiple languages 20190107 00:14:28<+wesdiscordbot> Removing the underscore works. 20190107 00:15:01<+wesdiscordbot> Okay should I reupload the add-on fixing the text domains then? 20190107 00:15:11<+wesdiscordbot> okay, so try putting the underscore back, mov ejust dragons lair away, delete cache, and retry @Konrad2 20190107 00:15:39<+wesdiscordbot> @The_Gnat You should, yes, but let's see if that fixes konrad's issue 20190107 00:15:42<+wesdiscordbot> But I don't have dragons lair installed. >.< 20190107 00:16:00<+wesdiscordbot> I'm only down to 8 possible responsible add-ons. 20190107 00:16:08<+wesdiscordbot> is any of them called DL ? 20190107 00:16:34<+wesdiscordbot> Not at all. 20190107 00:17:16<+wesdiscordbot> I suppose some of them might use wesnoth-dl too... 20190107 00:17:21<+wesdiscordbot> But TRoI isn't called DL either, soo.... 20190107 00:17:23<+wesdiscordbot> Yeah. 20190107 00:17:24<+wesdiscordbot> I don't suppose that one of those 8 is by @The_Gnat ? 20190107 00:17:55<+wesdiscordbot> Haha good point Reign of the Lords is also by me 20190107 00:17:58<+wesdiscordbot> Hmm, let me try changing "wesnoth-aoi" to "wesnoth-httt" and see what hppens 20190107 00:18:09<+wesdiscordbot> Rulers of Irdya has been updated on the 1.14 add-on server 20190107 00:18:34<+wesdiscordbot> (no special warnings) 20190107 00:18:51<+wesdiscordbot> @Konrad2 can you re-download it and see if it solves the issue 20190107 00:20:07<+wesdiscordbot> @The_Gnat Not yet. Because if it did, I'd never find out with what add-on it conflicted. 20190107 00:20:29<+wesdiscordbot> Good point 20190107 00:20:35<+wesdiscordbot> Well, what the heck. 20190107 00:20:37<+wesdiscordbot> None. 20190107 00:20:55<+wesdiscordbot> In that case try re-downloading , technically it shouldn't solve the error 20190107 00:21:20<+wesdiscordbot> You now get the error even with no other addons installed ? 20190107 00:21:43<+wesdiscordbot> No, it works. 20190107 00:21:52<+wesdiscordbot> It's just, there was no add-on it didn't work with. 20190107 00:21:57<+wesdiscordbot> Ah, it works even with all other addons installed ? 20190107 00:22:05<+wesdiscordbot> No. xD 20190107 00:22:34<+wesdiscordbot> Im confused? So it works with no other add-ons? Does it work with all other add-ons? 20190107 00:22:36<+wesdiscordbot> Can some cache be made/modified by the interaction of add-ons? Possibly some with dependencies? 20190107 00:22:56<+wesdiscordbot> yeah, addons can affect each other 20190107 00:23:06<+wesdiscordbot> for example if one redefines another's macro 20190107 00:23:21<+wesdiscordbot> or if one addon executes ActionWML without proper ifdef guards 20190107 00:23:23<+wesdiscordbot> It does not work with all add-ons installed. It works with all add-ons I had installed while I did my binary search. 20190107 00:23:57<+wesdiscordbot> what's the smallest set of addons you identified that still reproduces the error? 20190107 00:24:03<+wesdiscordbot> You mentioned 8 earlier ? 20190107 00:24:56<+wesdiscordbot> Those 8 were the ones I didn't test yet together with TRoI. But as it turned out, it works with those. 20190107 00:25:10<+wesdiscordbot> So, my smallest set of add-ons so far is...all of them. 20190107 00:25:43<+wesdiscordbot> wait, you tested them one by one? 20190107 00:25:51<+wesdiscordbot> as in, TRoI with A, TRoI with B, TRoI with C? 20190107 00:26:17<+wesdiscordbot> No, binary search. 20190107 00:26:30<+wesdiscordbot> TRoI with half of my add-ons. 20190107 00:26:43<+wesdiscordbot> TRoI with half of half of my other add-ons. 20190107 00:26:45<+wesdiscordbot> And so on. 20190107 00:27:17<+wesdiscordbot> When you have TRoI active do you also have ROTL and the 5 Lords active advance add-on? 20190107 00:27:32<+wesdiscordbot> I have ROTL and ROTL Potraits active. 20190107 00:27:43<+wesdiscordbot> did you have them active at all times during the binary search ? 20190107 00:27:43<+wesdiscordbot> It works when I have only those 3 active btw. 20190107 00:27:46<+wesdiscordbot> Yes. 20190107 00:28:09<+wesdiscordbot> Okay, can you try one more thing please 20190107 00:28:17<+wesdiscordbot> you said you tried with half your addons, then with half of the other half 20190107 00:28:26<+wesdiscordbot> Can you try with the whole other half too 20190107 00:28:33<+wesdiscordbot> My guess now is that there is a set of add-ons that cause the problem. On it. 20190107 00:29:10<+wesdiscordbot> So it works with both halfs but not with the whole? 20190107 00:29:23<+wesdiscordbot> We don't know yet. 20190107 00:29:33<+wesdiscordbot> He said it worked with 1..50 and with 51..75 20190107 00:29:38<+wesdiscordbot> but he never tried 51..100 20190107 00:30:16<+wesdiscordbot> So if he tries 51..100 and it also reproduces, that's great 20190107 00:30:31<+wesdiscordbot> it 1..100 fails, but 1..50 and 51..100 both work... that's gonna be interesting 20190107 00:31:14<+wesdiscordbot> (That would mean that we failed to slim down the number of possibly responsible add-ons. Which would be awful tbh.) 20190107 00:31:59<+wesdiscordbot> That would mean that the problem is probably an interaction of two addons from opposite ends of the alphabet 😃 20190107 00:32:17<+wesdiscordbot> That's another way to put it, yeah. 20190107 00:33:09<+wesdiscordbot> Possibly more than two though. But that's another problem. xD 20190107 00:33:16<+wesdiscordbot> What I am wondering is why a add-on conflict would corrupt all the strings in the scenario? 20190107 00:34:03<+wesdiscordbot> @josteph Do you have access to Wesnoth right now? 20190107 00:34:10<+wesdiscordbot> yes 20190107 00:34:38<+wesdiscordbot> @The_Gnat Probably some bug somewhere... 20190107 00:34:43<+wesdiscordbot> Good question 20190107 00:34:51<+wesdiscordbot> ...I was going to ask if you'd mind installing all UMC campaigns + dependencies, but that would probably take ages. xD 20190107 00:35:27<+wesdiscordbot> Hmm 20190107 00:35:41<+wesdiscordbot> I could wget them in parallel from the addons page, but wouldn't shadowm kill me if I tried 20190107 00:35:48<+wesdiscordbot> Furthermore I noticed when inspecting the save game I found something really interesting. Only string from the file 01_the_rising_storm.cfg are corrupted, any and all string loaded from definitions from my utils files work normally... 20190107 00:36:01<+wesdiscordbot> I mean, what if you can't reproduce it even if you have the same add-ons as I do? 20190107 00:36:05<+wesdiscordbot> what's textdomain of the utils file @The_Gnat 20190107 00:36:25<+wesdiscordbot> @Konrad2 Yes, good thinking, but how many addons do you have installed ? 20190107 00:36:35<+wesdiscordbot> How many subdirs do you have in data/addons ? 20190107 00:36:41<+wesdiscordbot> 137... 20190107 00:36:45<+wesdiscordbot> @josteph - none 20190107 00:37:15<+wesdiscordbot> I can manage that I guess : ) 20190107 00:37:27<+wesdiscordbot> So, it works with the 51...100. 20190107 00:37:44<+wesdiscordbot> @The_Gnat So they'd use the textdomain of whatever file theyre {included} in 20190107 00:37:53<+wesdiscordbot> what's that? 20190107 00:37:57<+wesdiscordbot> (in the version Konrad has) 20190107 00:38:06<+wesdiscordbot> Okay ... 20190107 00:38:32<+wesdiscordbot> I'll try shaving off addon's from the top. 1/3, 1/4 and so on. 20190107 00:39:01<+wesdiscordbot> Yeah, as many as you can while still reproducing 20190107 00:39:06<+wesdiscordbot> Do you want to send me your list of 137? 20190107 00:39:24<+wesdiscordbot> if you can send me the list of names of subdirs of data/addons that'd be easiest for me 20190107 00:40:25<+wesdiscordbot> Sorry, no idea how to do that. Explain it to me please? Also, it's 'only' every campaign + dependencies + goblin football. 20190107 00:40:52<+wesdiscordbot> you're on windows ? 20190107 00:40:57<+wesdiscordbot> open a command prompt 20190107 00:41:15<+wesdiscordbot> it's called cmd 20190107 00:41:19<+wesdiscordbot> Done. 20190107 00:41:28<+wesdiscordbot> Go to the addons directory 20190107 00:41:33<+wesdiscordbot> you change directories by writing 20190107 00:41:41<+wesdiscordbot> cd name-of-directory 20190107 00:41:46<+wesdiscordbot> @The_Gnat help me out here ? 20190107 00:42:09<+wesdiscordbot> so, cd Documents\wesnoth\data\add-ons or whatever the path is 20190107 00:42:22<+wesdiscordbot> you have tab completion 20190107 00:42:37<+wesdiscordbot> Then? 20190107 00:42:46<+wesdiscordbot> type dir and send me the output 20190107 00:44:55<+wesdiscordbot> Goblin Football looks hilarious 20190107 00:46:25<+wesdiscordbot> I'm kinda moving around a lot of add-ons (remnants of the binary search) so this might take a while. 20190107 00:46:36<+wesdiscordbot> I'd rather not send an imcomplete list. 20190107 00:48:35<+wesdiscordbot> How do I send the full output? 20190107 00:48:51<+wesdiscordbot> yo ucan do: 20190107 00:48:55<+wesdiscordbot> dir > foo.txt 20190107 00:49:01<+wesdiscordbot> and then open foo.txt in notepad 20190107 00:49:14<+wesdiscordbot> don't worry about all the filesize and so on in the listing, I can deal with it 20190107 00:51:29<+wesdiscordbot> "Goblin Football" 20190107 00:52:31<+wesdiscordbot> https://animeright.news/wp-content/uploads/sites/2/2018/10/Screenshot-208-768x532.png 20190107 00:54:20< celticminstrel> ? 20190107 00:54:39< celticminstrel> What's this all of a sudden, VYNLT 20190107 00:54:58< celticminstrel> ...wait, Josteph said it first? 20190107 00:55:04< celticminstrel> ??? 20190107 00:55:35< celticminstrel> Ignoring the GS screenshot for now, where the heck did "Goblin Football" come from? 20190107 00:55:42<+wesdiscordbot> Me. 20190107 00:56:00< celticminstrel> I see where you said it now, but I still don't get it... 20190107 00:56:14<+wesdiscordbot> It's about what add-ons I have installed. 20190107 00:56:32< celticminstrel> In any case, GS is definitely not something relevant here, I'd say. 20190107 00:56:45< celticminstrel> Ah, so Goblin Football is the name of an addon? 20190107 00:56:50<+wesdiscordbot> Yup. 20190107 00:57:04<+wesdiscordbot> And @VYNLT got triggered by the 'Goblin' part. ^^ 20190107 00:57:10<+wesdiscordbot> lol 20190107 00:57:19<+wesdiscordbot> Can you deny it? xD 20190107 00:57:24< celticminstrel> Clearly, but jumping from there in a Wesnoth context to GS is quite a stretch. 20190107 00:57:27<+wesdiscordbot> well im not Goblin Slayer 20190107 00:57:28<+wesdiscordbot> so yes 20190107 00:57:50<+wesdiscordbot> I wonder who sent that meme though... :thonk: 20190107 00:57:54< celticminstrel> ??? 20190107 00:58:05< celticminstrel> Is it even a meme if there's no text 20190107 00:58:34<+wesdiscordbot> Okay, fine, it's a reaction? 20190107 00:58:42< celticminstrel> I dunno 20190107 00:59:14<+wesdiscordbot> i wanted to use a "TRIGGERED" meme but couldnt find one 20190107 00:59:17<+wesdiscordbot> so that was the best i had 20190107 00:59:20<+wesdiscordbot> @Konrad2 Some of your campaigns arent on the 1.14 server 20190107 00:59:22< celticminstrel> Oh. 20190107 00:59:32<+wesdiscordbot> a friendship test, bear's campaign 20190107 01:00:18<+wesdiscordbot> Huh. That's weird. 20190107 01:00:48<+wesdiscordbot> Are you sure? It certainly was once... 20190107 01:01:05<+wesdiscordbot> I checked both from wesnoth and from firefox 20190107 01:01:16<+wesdiscordbot> Isn't it from tribe55? 20190107 01:01:25<+wesdiscordbot> I don't know 20190107 01:01:52<+wesdiscordbot> Looks like he took it down. 20190107 01:02:04<+wesdiscordbot> I'll move it somewhere else. 20190107 01:02:12<+wesdiscordbot> possibly because it had fatal bugs that broke other add-ons? 20190107 01:03:21<+wesdiscordbot> you also have AtS installed and it's only available on 1.12, not on 1.14 20190107 01:03:48<+wesdiscordbot> Well...playtesting. 20190107 01:03:55<+wesdiscordbot> I'll move that one away as well. 20190107 01:04:23<+wesdiscordbot> I wonder if there's a way to locate the misbehaving addons ... 20190107 01:04:50<+wesdiscordbot> well, I suppose you just need to do a binary search from one end only 20190107 01:05:01<+wesdiscordbot> that is, 1..50, 1..25, 1..12, 1..6 until you see a difference 20190107 01:05:16<+wesdiscordbot> I do think that's what I said. ._. 20190107 01:05:53<+wesdiscordbot> I meant, the most efficient way for you to do it would be to use binary search 20190107 01:05:56<+wesdiscordbot> halving each time 20190107 01:06:00<+wesdiscordbot> as opposed to 1/3 as you said 20190107 01:06:02<+wesdiscordbot> Just in a less efficent way. 20190107 01:06:04<+wesdiscordbot> Yep. xD 20190107 01:06:21<+wesdiscordbot> this binary search is very wesnothy 20190107 01:06:31<+wesdiscordbot> we can'd do 1..12.5 because it's not an integer 20190107 01:06:33<+wesdiscordbot> so we round down 20190107 01:06:50<+wesdiscordbot> just like the hitpoints dialog 😃 20190107 01:07:37<+wesdiscordbot> I feel very trolled right now, because it works and I only removed those two? I'll try again. 20190107 01:08:17<+wesdiscordbot> And both of those were in the 1...50, which is weird. 20190107 01:09:12<+wesdiscordbot> I can't reproduce the errors with my addons plus AtS from 1.12 20190107 01:09:56<+wesdiscordbot> I can, with my add-ons + AFriendshipTested. 20190107 01:09:59<+wesdiscordbot> ._. 20190107 01:10:14<+wesdiscordbot> but not with your addons without AFT? 20190107 01:11:11<+wesdiscordbot> Not with my add-ons without AFT/AtS. 20190107 01:11:14<+wesdiscordbot> @josteph - "@The_Gnat So they'd use the textdomain of whatever file theyre {included} in" - Yes apparently so 20190107 01:11:39<+wesdiscordbot> That is very interesting 20190107 01:11:45<+wesdiscordbot> @The_Gnat I'm guessing that the texxtdomain of the file utils are included in isn't wesnoth-dl. Am i right? 20190107 01:11:53<+wesdiscordbot> Yep 20190107 01:11:57<+wesdiscordbot> @Konrad2 That's great news. Can you zip me AFT ? 20190107 01:12:10<+wesdiscordbot> I'll try. xD 20190107 01:12:28<+wesdiscordbot> My brother is a Silver Mage, I'll ask him to hop over to yours 20190107 01:12:48<+wesdiscordbot> @josteph - Okay since that is the case it clearly is isolated to wesnoth-dl 20190107 01:12:58<+wesdiscordbot> Actually, I shuold've asked of this an hour ago 20190107 01:13:08<+wesdiscordbot> Btw, it does work with only AFT and TLoI. 20190107 01:13:09<+wesdiscordbot> How has it been going while I have been away? Any progress on the search? 20190107 01:13:11<+wesdiscordbot> I should've asked @Konrad2 to change wesnoth-dl to wesnoth-whatklfjdskljfdklsjfdkls at the top of the file 20190107 01:13:19<+wesdiscordbot> @The_Gnat There goes your fantasy. 20190107 01:13:24<+wesdiscordbot> @Konrad2 That's definitely an interesting bug 20190107 01:13:53<+wesdiscordbot> @The_Gnat You came back for the photo finish 😃 20190107 01:14:23<+wesdiscordbot> Is a .rar fine too? 20190107 01:14:24<+wesdiscordbot> I read through the thread but I still don't think I understand what happened... 20190107 01:14:31<+wesdiscordbot> tar would be easier 20190107 01:14:36<+wesdiscordbot> but yeah I have unrar 20190107 01:14:39<+wesdiscordbot> 😉 20190107 01:14:50<+wesdiscordbot> @The_Gnat Progress has been made 20190107 01:15:03<+wesdiscordbot> .rar is too big for discord. :/ 20190107 01:15:16<+wesdiscordbot> I don't need the images subdir 20190107 01:15:18<+wesdiscordbot> if it has one 20190107 01:15:24<+wesdiscordbot> Or send it on the forum 20190107 01:15:44<+wesdiscordbot> @josteph - good to know 😃 20190107 01:16:03<+wesdiscordbot> Too large for the forum as well. xD 20190107 01:16:10<+wesdiscordbot> even without the images ? 20190107 01:16:18<+wesdiscordbot> google drive ? 20190107 01:16:22<+wesdiscordbot> or dropbox? 20190107 01:16:24<+wesdiscordbot> how large is it ? 20190107 01:17:30<+wesdiscordbot> 22.223 KiB 20190107 01:17:50<+wesdiscordbot> is that period a thousands separator or a decimal separator ? 20190107 01:18:09<+wesdiscordbot> is it 22KiB or 22MiB ? 20190107 01:18:20<+wesdiscordbot> MiB 20190107 01:18:37<+wesdiscordbot> Somehow .rar made it smaller by only 1MiB? 20190107 01:18:41<+wesdiscordbot> That's weir.d 20190107 01:18:45<+wesdiscordbot> have you removed the images ? 20190107 01:18:57<+wesdiscordbot> sounds like it's 21MB images, 1MB cfg that got compressed 20190107 01:19:02<+wesdiscordbot> Im going to have to go but I would be interested in knowing how this turns out. Also if I need to do anything to my add-on please let me know! 20190107 01:19:12<+wesdiscordbot> sure thing 20190107 01:19:38<+wesdiscordbot> images were about 6MB, removed them before. 20190107 01:19:51<+wesdiscordbot> can you email it to me ? 20190107 01:19:58<+wesdiscordbot> josteph at fastmail.com 20190107 01:22:21<+wesdiscordbot> Done. 20190107 01:23:29<+wesdiscordbot> received 20190107 01:24:02<+wesdiscordbot> I'll look through it, in the meantime you could try to identify the additional campaign(s?) that are required to reproduce, if you have time 20190107 01:24:19<+wesdiscordbot> I'm on it. It's not AtS btw. 20190107 01:24:39<+wesdiscordbot> I'll just do the binary search again, adding the 50...100 first. 20190107 01:26:26<+wesdiscordbot> @Konrad2 unrar failed 20190107 01:26:40<+wesdiscordbot> I don't have additional errors, just "Failed" for each of 56 files 20190107 01:26:44<+wesdiscordbot> XD 20190107 01:28:08<+wesdiscordbot> Can you try to zip / tar and send me again? 20190107 01:28:17<+wesdiscordbot> And you can remove the music dir 😃 20190107 01:28:25<+wesdiscordbot> I don't know how to do that. :/ 20190107 01:28:58<+wesdiscordbot> How to zip ? 20190107 01:29:17<+wesdiscordbot> Windows Explorer can create zip files natively nowadays, I think 20190107 01:29:30<+wesdiscordbot> So...it works with the 50...100. ._. 20190107 01:29:32<+wesdiscordbot> right click on the directory AF 20190107 01:29:40<+wesdiscordbot> AFriendshipTested 20190107 01:29:47<+wesdiscordbot> so the 3rd culprit is one of them ... 20190107 01:30:23<+wesdiscordbot> err, wait. Adding 50..100 fixed it ? 20190107 01:30:36<+wesdiscordbot> didn't break it 20190107 01:31:05<+wesdiscordbot> sorry, I don'tfollow 20190107 01:31:08<+wesdiscordbot> It works with AFT, AtS and TRoI. 20190107 01:31:19<+wesdiscordbot> Now I've added 50...100. 20190107 01:31:28<+wesdiscordbot> ah, ok 20190107 01:31:28<+wesdiscordbot> And it didn't break it. 20190107 01:31:44<+wesdiscordbot> and we know from before that if you now add 1..49 as well, it'll break 20190107 01:31:55<+wesdiscordbot> Yes. 20190107 01:32:15<+wesdiscordbot> I'll do that first, just to be sure that it is indeed still true. 20190107 01:32:32<+wesdiscordbot> 👍 20190107 01:33:08<+wesdiscordbot> if you have a minute after that to install 7-zip or something and send me AFT, that'd be helpful 20190107 01:33:35<+wesdiscordbot> or to create a zip from Windows Explorer, if it has that feature 20190107 01:33:58<+wesdiscordbot> Music was like 90% of that addon, with 9% images. ._. 20190107 01:34:00<+wesdiscordbot> Sent. 20190107 01:34:36<+wesdiscordbot> 93KB 😃 20190107 01:34:40<+wesdiscordbot> thanks 20190107 01:35:38<+wesdiscordbot> okay 20190107 01:35:52<+wesdiscordbot> it has several textdomains, including both wesnoth-ft and wesnoth-FT 20190107 01:35:56<+wesdiscordbot> is that going to be a problem on windows ? 20190107 01:36:13<+wesdiscordbot> (I just asked that on dev too) 20190107 01:36:16<+wesdiscordbot> I think you should know that my answer is 'no idea'. xD 20190107 01:36:44<+wesdiscordbot> well, I play in English on Linux, so I wouldn't know either 😃 20190107 01:37:53<+wesdiscordbot> Luckily I can confirm that adding the 1...49 breaks it. Now to remove 1...25. 20190107 01:40:32<+wesdiscordbot> Not broken anymore. 20190107 01:40:34<+wesdiscordbot> Adding some more. ^^ 20190107 01:40:54<+wesdiscordbot> I think I have a recommendation for you soon, give me a minute 20190107 01:42:20<+wesdiscordbot> @Konrad2 Try removing the directory "Trader" 20190107 01:42:38<+wesdiscordbot> What do you expect to happen? 20190107 01:43:30<+wesdiscordbot> Trader also has two textdomains that are identical up to case 20190107 01:43:48<+wesdiscordbot> so I expect ... that when you remove it, you'll get whatever happened when you removed AFT 20190107 01:44:26<+wesdiscordbot> That would be having all add-ons and TLoI not being broken. 20190107 01:44:50<+wesdiscordbot> yeah, so, all addons except AFT and Trader and not being broken 20190107 01:44:59<+wesdiscordbot> all addons and either AFT or Trader or both, and being broken 20190107 01:45:17<+wesdiscordbot> Right now I have Trader and AFT and TLoI is not broken. :/ 20190107 01:45:44<+wesdiscordbot> back to the drawing board then 20190107 01:51:28<+wesdiscordbot> Take a look at 'A Beastly Tale' or 'A Fiery Birth'. 20190107 01:51:58<+wesdiscordbot> yes? 20190107 01:52:22<+wesdiscordbot> That's the last two add-ons I didn't test yet. 20190107 01:52:34<+wesdiscordbot> A Fiery Birth it is. 20190107 01:52:43<+wesdiscordbot> I have both of them installed and couldn't reproduce the error 20190107 01:52:47<+wesdiscordbot> AFB? 20190107 01:52:51<+wesdiscordbot> Yep. 20190107 01:52:58<+wesdiscordbot> so... 20190107 01:53:14<+wesdiscordbot> what are the criteria for the error, again? 20190107 01:53:52<+wesdiscordbot> I'll start now removing some other add-ons, while keeping AFB, AFT and TRoI. For now, AFB + AFT + TRoI. 20190107 01:54:50<+wesdiscordbot> okay, let me try that 20190107 01:55:34<+wesdiscordbot> You also need RotL and RotL Portraits. 20190107 01:55:37<+wesdiscordbot> Because dependencies. 20190107 01:56:04<+wesdiscordbot> ok 20190107 01:57:09<+wesdiscordbot> And guess what. 20190107 01:57:21<+wesdiscordbot> okay, so I have these AFriendshipTested A_Fiery_Birth Reign_of_the_Lords Reign_of_the_Lords_Portraits The_Rulers_of_Irdya 20190107 01:57:24<+wesdiscordbot> *It's not broken.' 20190107 01:57:39<+wesdiscordbot> and no error 20190107 01:57:39<+wesdiscordbot> So I need another add-on. 😄 20190107 01:57:57<+wesdiscordbot> I'm speechless 20190107 01:58:15<+wesdiscordbot> I'm starting to think you might be better off without binary search 20190107 01:58:22<+wesdiscordbot> just good old linear search 20190107 01:58:42<+wesdiscordbot> Binary is probably still faster. 20190107 01:59:27<+wesdiscordbot> I mean, I have no idea which add-on I need. I don't even know whether it's just one. 20190107 02:00:51<+wesdiscordbot> when we find the root cause... 20190107 02:01:04<+wesdiscordbot> I'd call that optimism. 20190107 02:01:08<+wesdiscordbot> It's bound to be something simple 20190107 02:01:36<+wesdiscordbot> Could it depend on the number of addons you have at any particular time? 20190107 02:01:48<+wesdiscordbot> That's what I'm testing right now. 😄 20190107 02:02:22<+wesdiscordbot> I removed a random one. That made it work. Now I'm adding the one add-on I didn't have before. 20190107 02:03:16<+wesdiscordbot> And now, it's broken. 20190107 02:03:48<+wesdiscordbot> At exactly 136 add-ons it breaks. 20190107 02:04:20<+wesdiscordbot> I think it might be something to do with size, not count 20190107 02:04:56<+wesdiscordbot> quick question 20190107 02:05:01<+wesdiscordbot> can you hop on to the addon manager 20190107 02:05:27<+wesdiscordbot> filter by status=installed and type=[everything except for campaign/scenario variants] and say how many you have installed that match? 20190107 02:05:57<+wesdiscordbot> Just a second. 20190107 02:06:03<+wesdiscordbot> or another way to do it 20190107 02:06:07<+wesdiscordbot> I can tell now for sure that it's not the number. 😦 20190107 02:06:11<+wesdiscordbot> move To Lands Unknown aside and see if you can get to 137 20190107 02:06:38<+wesdiscordbot> Fun fact, I removed TLU and one of it's resources to go down to 135 20190107 02:06:43<+wesdiscordbot> But broken. 20190107 02:07:13<+wesdiscordbot> Can you do a wiki page or an issue or something with all the combinations? 20190107 02:07:19<+wesdiscordbot> I'm starting to lose track 20190107 02:07:48<+wesdiscordbot> I'm installing Tunnel Rats (98MB) now to test 20190107 02:08:16<+wesdiscordbot> 27 non campaign/scenario variants. 20190107 02:08:35<+wesdiscordbot> *28 20190107 02:08:59<+wesdiscordbot> okay, so ~110 campaign/scenario variants 20190107 02:09:07<+wesdiscordbot> probably not a power of 2 thing then 20190107 02:09:22<+wesdiscordbot> As I said, it's not the number. :/ 20190107 02:09:38<+wesdiscordbot> I thought it might be the number of type=campaign issues 20190107 02:09:42<+wesdiscordbot> addons 20190107 02:09:45<+wesdiscordbot> Oh. 20190107 02:10:06<+wesdiscordbot> But at leasts it's not a general add-on number. 20190107 02:10:23<+wesdiscordbot> yeah, that'd be odd 20190107 02:11:09<+wesdiscordbot> I just removed 5 campaigns, let's ee what happens. 20190107 02:11:11<+wesdiscordbot> *see 20190107 02:13:32<+wesdiscordbot> Works. 20190107 02:14:06<+wesdiscordbot> Any idea what would be meaningful to remove? 20190107 02:14:31<+wesdiscordbot> to remove ? 20190107 02:14:42<+wesdiscordbot> don't you need to add things no to make it break ? 20190107 02:15:27<+wesdiscordbot> Yes, but since the 'critical' point seems to be 'a lot', it seems to make more sense to remove stuff to see when it works. 20190107 02:16:02<+wesdiscordbot> ah, you meant to remove from the original state 20190107 02:16:07<+wesdiscordbot> not from the current state after you already removed 5 20190107 02:16:44<+wesdiscordbot> at this point... remove the campaign that has the largest number of translated strings? 20190107 02:16:51<+wesdiscordbot> (yes I know that's not easy to identify) 20190107 02:17:14<+wesdiscordbot> is there something like valgrind for windows 20190107 02:17:29<+wesdiscordbot> sorry, it's late here, I can't think straight 20190107 02:19:14<+wesdiscordbot> I went with removing something larger than ABT and AFB combined. Works. 20190107 02:19:56<+wesdiscordbot> A Friendship Tested might not be at fault. 20190107 02:20:17<+wesdiscordbot> I'll install something that's big enough to act as a substitute. 20190107 02:20:50<+wesdiscordbot> I wonder what the measure of "big" here is 20190107 02:21:00<+wesdiscordbot> I think it might be not the raw size, but the number of translated strings 20190107 02:21:27<+wesdiscordbot> so if you edit a campaign and add tons of translated strings to it, that should cause/break the bug 20190107 02:21:35<+wesdiscordbot> like, add "1", "2", _ "3" etc 20190107 02:22:02<+wesdiscordbot> I'm going for raw size for now, because I can measure that. 20190107 02:22:15<+wesdiscordbot> Btw, could you reproduce my bug with all my add-ons? 20190107 02:22:27<+wesdiscordbot> pretty unlikely, I think 20190107 02:22:40<+wesdiscordbot> images aren't going to be loaded until they're needed 20190107 02:22:45<+wesdiscordbot> I mean, did you? 20190107 02:23:24<+wesdiscordbot> I haven't tried, actually. I was going to but then I came back here to tell you that AFT wasn't installed and then I unzipped AFT and started investigating it and never got back to the original issue ... 20190107 02:23:42<+wesdiscordbot> and I still don't have bear somethingorother installed 20190107 02:23:49<+wesdiscordbot> from your list 20190107 02:23:54<+wesdiscordbot> Bear? 20190107 02:23:56<+wesdiscordbot> ._. 20190107 02:24:05<+wesdiscordbot> I thought you meant with that the author 20190107 02:24:31<+wesdiscordbot> That should be Kalburaks Journey I guess? 20190107 02:24:40<+wesdiscordbot> Bears_Campaign 20190107 02:24:52<+wesdiscordbot> Kalburaks Journey it is. 20190107 02:24:58<+wesdiscordbot> I have about half of your addons already installed 20190107 02:25:08<+wesdiscordbot> plus some that you don't have installed 20190107 02:25:15<+wesdiscordbot> and with that I can't reproduce the error 20190107 02:25:36<+wesdiscordbot> 1,8 GB in your add-on file? 20190107 02:26:08<+wesdiscordbot> 2.2, actually 20190107 02:26:31<+wesdiscordbot> Desert Map Pack from your list is also not available for 1.14 20190107 02:26:53<+wesdiscordbot> it's a dependency of the one I installed half an hour ago, but it's not on 1.14, I assume it's on 1.12 20190107 02:27:44<+wesdiscordbot> People keep taking stuff down. 😦 20190107 02:28:14<+wesdiscordbot> So, it's apparently not size. 20190107 02:28:39<+wesdiscordbot> I don't think it's taking down, I think it wasn't uploaded to 1.14 20190107 02:28:55<+wesdiscordbot> though the upload shouldn't have been accepted with broken deps 20190107 02:30:00<+wesdiscordbot> It was uploaded, because I downloaded it from there. 20190107 02:30:07<+wesdiscordbot> Same with A Friendship Tested. 20190107 02:30:21<+wesdiscordbot> AtS is the only campaign I didn't get from the server. 20190107 02:30:26<+wesdiscordbot> *add-on 20190107 02:31:23<+wesdiscordbot> ok 20190107 02:31:33<+wesdiscordbot> Could it be the number of macros? 20190107 02:31:40<+wesdiscordbot> easy enough to test 20190107 02:31:45<+wesdiscordbot> how many do you want? 20190107 02:32:39<+wesdiscordbot> Just to be sure, numer of macros = number of new cache files? 20190107 02:32:47<+wesdiscordbot> not sure how macros would affect translated strings do 20190107 02:32:50<+wesdiscordbot> no 20190107 02:32:58<+wesdiscordbot> there's one cache file per cfg file, I think 20190107 02:33:03<+wesdiscordbot> or possibly per _main.cfg file 20190107 02:33:23<+wesdiscordbot> I'm getting 547 cache files. 20190107 02:33:25<+wesdiscordbot> anyway http://sprunge.us/TdHgTb here's a file with 10k macro definitions 20190107 02:33:31<+wesdiscordbot> For my 137 add-ons. 20190107 02:34:20<+wesdiscordbot> (I mean, probably some of those are from mainline.) 20190107 02:34:33<+wesdiscordbot> how do you measure? 20190107 02:34:45<+wesdiscordbot> do you open wesnoth and close it? Or do you open the campaign selection dialog? 20190107 02:35:15<+wesdiscordbot> I get 765 cache files the latter way. Though again, I doubt that's directly related 20190107 02:35:18<+wesdiscordbot> I open wesnoth and close it. 20190107 02:35:30<+wesdiscordbot> open the campaign selection dialog before closing wesnoth 20190107 02:35:43<+wesdiscordbot> there will be a delay there while wesnoth parses stuff 20190107 02:36:11<+wesdiscordbot> anyway... so we're saying the problem happens when there are "too many addons" ? 20190107 02:36:33<+wesdiscordbot> But why does this error only happen on tRoI? 20190107 02:36:41<+wesdiscordbot> No clue. 20190107 02:36:55<+wesdiscordbot> And also why are only the scenario 1 lines corrupt? 20190107 02:37:26<+wesdiscordbot> @josteph Basically, yes. Not exactly, but it only happens with a lot of add-ons. @The_Gnat Why are you so sure about that? 20190107 02:37:42<+wesdiscordbot> Well you sent me the log on the forum 20190107 02:37:53<+wesdiscordbot> And the save game 20190107 02:37:57<+wesdiscordbot> Part of the log. 20190107 02:38:15<+wesdiscordbot> @The_Gnat that's useful information 20190107 02:38:22<+wesdiscordbot> But from the save game file there are still lines 20190107 02:38:26<+wesdiscordbot> konrad, you can play binary search on the source code of troi 20190107 02:38:40<+wesdiscordbot> remove lines of code from troi as much as you can while the error still happens 20190107 02:38:50<+wesdiscordbot> I used the inspector and found all the lines from util files including deaths and etc. 20190107 02:39:37<+wesdiscordbot> can't reproduce the error with 100k translated strings added to AFT _main.cfg 20190107 02:39:58<+wesdiscordbot> There is a problem. I believe I've accidentally updated my TLoI... 20190107 02:40:07<+wesdiscordbot> Ironically enough the tRoI is a pretty small scenario 20190107 02:40:12<+wesdiscordbot> @The_Gnat It works btw. 20190107 02:40:25<+wesdiscordbot> @Konrad2 great 😃 20190107 02:40:32<+wesdiscordbot> Also if you want I can send you an old version 20190107 02:40:59<+wesdiscordbot> Pretty please. 20190107 02:41:11<+wesdiscordbot> Okay I think I made a backup but I have to find it now haha 20190107 02:41:38<+wesdiscordbot> at least one of the two of you should learn git 20190107 02:41:39<+wesdiscordbot> 😃 20190107 02:42:03<+wesdiscordbot> Pretty old version 20190107 02:42:04<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531663781927976960/The_Rulers_of_Irdya.7z 20190107 02:42:07<+wesdiscordbot> I use git 20190107 02:42:18<+wesdiscordbot> I may have a version from yesterday 20190107 02:42:19<+wesdiscordbot> Just for collaborative project tho 20190107 02:43:56<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531664250943569930/The_Rulers_of_Irdya.tar.gz 20190107 02:43:59<+wesdiscordbot> @Konrad2 ^ 20190107 02:44:50<+wesdiscordbot> That's good, the other one failed to load. xD 20190107 02:45:13<+wesdiscordbot> XD 20190107 02:46:26<+wesdiscordbot> @Bern-Gnard Anything to discuss about DiD while we're both here ? 20190107 02:46:32<+wesdiscordbot> sorry, @The_Gnat 20190107 02:46:35<+wesdiscordbot> @Bern-Gnard Sorry, ignore 20190107 02:47:39<+wesdiscordbot> It's a broken version, that's good. 20190107 02:47:48<+wesdiscordbot> So, what did you want me to do with it? 20190107 02:48:02<+wesdiscordbot> you said you accidentally upgraded troi 20190107 02:48:07<+wesdiscordbot> you can now downgrade back 20190107 02:48:18<+wesdiscordbot> and continue analysis 20190107 02:48:22<+wesdiscordbot> I did just now. 20190107 02:48:22<+wesdiscordbot> bughunt 20190107 02:48:39<+wesdiscordbot> @josteph - Yes we should but probably not on the same forum or it will get really confusing fast 😉 20190107 02:48:55<+wesdiscordbot> But you wanted me to do something with the downgraded version, something about deleting lines? 20190107 02:49:02<+wesdiscordbot> let's use #development then, nemaara is there too 20190107 02:49:20<+wesdiscordbot> Ah, yes 20190107 02:49:22<+wesdiscordbot> Tell her I'm sorry about finding a new bug. xD 20190107 02:49:27<+wesdiscordbot> so, you can reproduce the failure now ? 20190107 02:49:31<+wesdiscordbot> Yes. 20190107 02:49:53<+wesdiscordbot> Okay, so now the idea is, remove as much as you can from troi while still reproducing the bug 20190107 02:50:09<+wesdiscordbot> deletes the folder 20190107 02:50:10<+wesdiscordbot> you can use binary search for that too, if you want 20190107 02:50:15<+wesdiscordbot> removing half the file first, then the other half 20190107 02:50:56<+wesdiscordbot> this is because campaigns other than troi don't trigger the bug 20190107 02:51:07<+wesdiscordbot> so we want as minimal a version of troi as possible, that still reproduces the bug 20190107 02:51:43<+wesdiscordbot> I recently did some crazy things with macros. Could that be causing the issue? 20190107 02:52:09<+wesdiscordbot> did you mess with translatable strings? 20190107 02:52:13<+wesdiscordbot> _ "foo" 20190107 02:52:28<+wesdiscordbot> (What does foo mean?) 20190107 02:52:33<+wesdiscordbot> Yes all the strings in the game have the _ so that I could add translation later 20190107 02:52:38<+wesdiscordbot> Foo is just a generic variable 20190107 02:53:31<+wesdiscordbot> it just stands in for some value whatever it may be 20190107 02:53:32<+wesdiscordbot> Someone recommended I do so but I haven't looked into the translation yet 20190107 02:53:53<+wesdiscordbot> yeah, but do the macros mess with the translatable strings? 20190107 02:54:15<+wesdiscordbot> basically I created a randomizer than runs 1-5 possibles of random strings as dialgoue 20190107 02:54:25<+wesdiscordbot> Makes the same event able to happen multiple times 20190107 02:56:44<+wesdiscordbot> doesn't sound related 20190107 02:56:54<+wesdiscordbot> Okay good 20190107 02:57:03<+wesdiscordbot> I'm thinking more along the lines of being out of memory 20190107 02:57:07<+wesdiscordbot> But why only tRoI????! 20190107 02:57:18<+wesdiscordbot> Was mine the last add-on he installed? 20190107 02:57:25<+wesdiscordbot> ask him 😃 20190107 02:57:29<+wesdiscordbot> but yeah, good questoin 20190107 02:57:54<+wesdiscordbot> when konrad finishes minimizing troi I'll look at what he had left and try to learn something 20190107 02:59:19<+wesdiscordbot> No. 20190107 02:59:29<+wesdiscordbot> Okay hmm 20190107 02:59:30<+wesdiscordbot> The last one was 'A Whim of Fate' 20190107 02:59:35<+wesdiscordbot> And it works? 20190107 02:59:41<+wesdiscordbot> So then it must be something in tRoI 20190107 02:59:43<+wesdiscordbot> Wierd 20190107 03:00:07<+wesdiscordbot> It works, but there were a few invalid strings too, if I remember correctly. 20190107 03:00:32<+wesdiscordbot> But maybe he didn't add _ before most of the strings? 20190107 03:00:35<+wesdiscordbot> @The_Gnat troi's [binary_path] is outside the ifdef 20190107 03:01:07<+wesdiscordbot> ... 20190107 03:01:11<+wesdiscordbot> That was dumb of me 20190107 03:01:17<+wesdiscordbot> Why would I have done that? 20190107 03:01:26<+wesdiscordbot> (What does that do?) 20190107 03:01:34<+wesdiscordbot> It always loads everything 20190107 03:01:41<+wesdiscordbot> Even if the campaign is not runnning 20190107 03:02:03<+wesdiscordbot> binary_path tells the engine where to find images and stuff 20190107 03:02:19<+wesdiscordbot> Would that effect translations? 20190107 03:03:14<+wesdiscordbot> Maybe? 20190107 03:03:21<+wesdiscordbot> It might affect where mo files are looked pu 20190107 03:03:22<+wesdiscordbot> dunno 20190107 03:03:50<+wesdiscordbot> Okay well does it work if you fix that? 20190107 03:04:06<+wesdiscordbot> @Konrad2 can you test? 20190107 03:04:33<+wesdiscordbot> @The_Gnat Tbh, I simply don't know if only your campaign is affected. There could be like 5 more. There are so maaaaaany campaigns. Though I've started like 80% of them. Give me a moment please? I'm still cannibalizing your scenario. 20190107 03:04:45<+wesdiscordbot> Haha okay 20190107 03:05:06<+wesdiscordbot> Doing both at the same time could/would falsify my results. :/ 20190107 03:05:11<+wesdiscordbot> True 20190107 03:08:20<+wesdiscordbot> (You can already try explaning to me how I'd even do that, because I have no clue.) 20190107 03:09:00<+wesdiscordbot> Open main.cfg 20190107 03:09:02<+wesdiscordbot> Just pastebin him a new file 20190107 03:09:07<+wesdiscordbot> Okay good idea 😃 20190107 03:09:24<+wesdiscordbot> Don't forget to base your file on the tar.gz I uploaded, not on latest version 20190107 03:09:25<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531670664940093440/main.cfg 20190107 03:09:38<+wesdiscordbot> Why? 20190107 03:09:45<+wesdiscordbot> To not invalidate his results 20190107 03:09:55<+wesdiscordbot> Okay 20190107 03:11:02<+wesdiscordbot> New version 20190107 03:11:02<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531671072509263873/main.cfg 20190107 03:11:28<+wesdiscordbot> @Konrad2 make sure to use the main.cfg just above, not the other one if you saw it 20190107 03:12:01<+wesdiscordbot> I assume you should put it in the tRoI directory replacing the existing _main.cfg there 20190107 03:12:31<+wesdiscordbot> Yep 20190107 03:14:00<+wesdiscordbot> @The_Gnat You've added enough events for a whole campaign, didn't you? 20190107 03:14:39<+wesdiscordbot> Haha pretty much 20190107 03:14:42<+wesdiscordbot> His [end_level] key is very hard to reach, you see... 20190107 03:15:18<+wesdiscordbot> It is kind of confusing because there are about 200 events, basically there are 3 ways to end the scenario but they all go to the same next level 20190107 03:15:42<+wesdiscordbot> Oh, @Konrad2 , one more thing 20190107 03:15:58<+wesdiscordbot> A campaign is loaded by loading its _main.cfg file with the campaign define set 20190107 03:16:08<+wesdiscordbot> the _main.cfg file usually includes other files 20190107 03:16:20<+wesdiscordbot> troi's main.cfg does this too 20190107 03:16:36<+wesdiscordbot> so in principle, @Konrad2, the error won't necessarily be in the S1 scenario file 20190107 03:16:45<+wesdiscordbot> it might be in any of the files that _main.cfg includes 20190107 03:16:57<+wesdiscordbot> Well since all the strings corrupt in sc1 it is a good gues 20190107 03:17:08<+wesdiscordbot> probably in one of those that are included before scenarios/01, but no promises 20190107 03:17:22<+wesdiscordbot> yeah, but the cause might be in another scenario 20190107 03:17:35<+wesdiscordbot> konrad's cannibalization may simply end with an empty file that any string placed in which gets corrupted 20190107 03:17:43<+wesdiscordbot> Good point 20190107 03:18:07<+wesdiscordbot> Since the macro's are loaded before the scenario 1 it would make sense that they break it 20190107 03:18:15<+wesdiscordbot> you include macros/ before scenarios/ 20190107 03:18:19<+wesdiscordbot> Esp. since the scenario is corrupted right from the start 20190107 03:18:20<+wesdiscordbot> so it would be interesting to 20190107 03:18:30<+wesdiscordbot> 1. change the order in main.cfg, include macros/ after scenarios/ 20190107 03:18:41<+wesdiscordbot> 2. delete scenarios/01, change first_scenario in _main.cfg 20190107 03:18:55<+wesdiscordbot> actually, 1. might not even run, but 2. is worthwhile 20190107 03:18:58<+wesdiscordbot> @Konrad2 ^ 20190107 03:19:01<+wesdiscordbot> No it will break then 20190107 03:19:11<+wesdiscordbot> The macros are used but you could try 2 20190107 03:19:31<+wesdiscordbot> yeah, @Konrad2 , try this one "delete scenarios/01....cfg, change first_scenario in _main.cfg" 20190107 03:19:56<+wesdiscordbot> @The_Gnat would you talk him through it ? I need to leave at some poitn, I'm afraid 20190107 03:20:25<+wesdiscordbot> I still don't exactly know what he is trying to do 20190107 03:20:53<+wesdiscordbot> I'm trying to follow orders. xD 20190107 03:20:55<+wesdiscordbot> to cannibalize troi as much as possible while still reproducing the error 20190107 03:21:05<+wesdiscordbot> in order to have a minimal example for the error 20190107 03:21:12<+wesdiscordbot> Well how did it work when he deleted everything in sc1 20190107 03:21:13<+wesdiscordbot> ? 20190107 03:21:20<+wesdiscordbot> @Konrad2 is a loyal unit. 😃 20190107 03:21:30<+wesdiscordbot> ask him not me 20190107 03:21:54<+wesdiscordbot> If I delete everything, how do I start the scenario? 20190107 03:22:07<+wesdiscordbot> How do I see whether a string is invalid, if there is no string? ._. 20190107 03:22:12<+wesdiscordbot> You just go straight to sc2 20190107 03:22:26<+wesdiscordbot> clarification, I didn't mean "delete verything in S1" 20190107 03:22:35<+wesdiscordbot> I meant, delete the S1 file 20190107 03:23:14<+wesdiscordbot> So, no cannibalising right now? You need to tell me when I should abort an earlier order. xD 20190107 03:23:15<+wesdiscordbot> New main file that will load sc2 20190107 03:23:15<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531674148150312971/main.cfg 20190107 03:23:45<+wesdiscordbot> If you put this in and delete sc1 what happens? 20190107 03:23:48<+wesdiscordbot> don't delete 20190107 03:23:57<+wesdiscordbot> move it to my documents or something 20190107 03:24:04<+wesdiscordbot> in case you need to continue the cannibalization later 20190107 03:24:19<+wesdiscordbot> @josteph good ide 20190107 03:24:23<+wesdiscordbot> move it somewhere wesnoth won't ever find it 20190107 03:26:06<+wesdiscordbot> add-ons folder. xD 20190107 03:26:24<+wesdiscordbot> A joke hopefully 😉 20190107 03:27:13<+wesdiscordbot> Gnat, you can verify S1 wasnt included by using :cl in game 20190107 03:27:31<+wesdiscordbot> In the command console? 20190107 03:27:35<+wesdiscordbot> yeah 20190107 03:27:47<+wesdiscordbot> it'll list all [scenario]s defined in this campaign 20190107 03:28:03<+wesdiscordbot> @Konrad2 tell us when you have started S2 20190107 03:28:09<+wesdiscordbot> and if you get the error there 20190107 03:28:11<+wesdiscordbot> I have to rename main to _main, right? 20190107 03:28:15<+wesdiscordbot> Yep 20190107 03:28:25<+wesdiscordbot> It removes the underscore when we uploaded it 20190107 03:29:24<+wesdiscordbot> Failed to load scenario. 20190107 03:29:25<+wesdiscordbot> ._. 20190107 03:30:06<+wesdiscordbot> Hmm 20190107 03:30:11<+wesdiscordbot> What did it say? 20190107 03:30:42<+wesdiscordbot> That's all it said. :/ 20190107 03:31:05<+wesdiscordbot> did it work for you locally gnat ? 20190107 03:31:52<+wesdiscordbot> I'll chekc 20190107 03:32:16<+wesdiscordbot> Nope... 20190107 03:32:43<+wesdiscordbot> I can start S02 directly if I make the _main.cfg mod 20190107 03:32:44<+wesdiscordbot> I'll fix the main file 20190107 03:33:08<+wesdiscordbot> Fixed 20190107 03:33:08<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531676634424672256/main.cfg 20190107 03:33:12<+wesdiscordbot> Sorry my bad 20190107 03:33:27<+wesdiscordbot> I am constantly renaming the scenarios so they have differnt names in each version which causes problems 20190107 03:34:33<+wesdiscordbot> @Konrad2 - Does it work now 20190107 03:37:00<+wesdiscordbot> Yes, yes it does. 20190107 03:37:05<+wesdiscordbot> And no bugs. 20190107 03:37:33<+wesdiscordbot> Okay so it is sc1?? ... or its one of the macros sc1 loads that sc2 doesn't. Because sc2 isn't complete it has much less code 20190107 03:37:53<+wesdiscordbot> And this is the cannibalised scenario one. josteph was right, sadly. 20190107 03:37:54<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531677830967328768/01_the_rising_storm.cfg 20190107 03:38:02<+wesdiscordbot> What was he right about? 20190107 03:38:30<+wesdiscordbot> This scenario is literally scenario name, 3 sides. 20190107 03:38:48<+wesdiscordbot> Does it work? 20190107 03:39:02<+wesdiscordbot> No, that's the point. 20190107 03:39:13<+wesdiscordbot> that's fantastic news 20190107 03:39:20<+wesdiscordbot> So then try this file 20190107 03:39:28<+wesdiscordbot> It's the smallest version of the scenario that doesn't work. xD 20190107 03:39:44<+wesdiscordbot> So then it is the textdomain? 20190107 03:39:46<+wesdiscordbot> so, if you remove the textdomain line? 20190107 03:40:03<+wesdiscordbot> or if you remove the [story]..[/story] entirely? 20190107 03:40:07<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531678392396021783/01_the_rising_storm.cfg 20190107 03:40:17<+wesdiscordbot> This should be tested before he removes either of those 20190107 03:40:30<+wesdiscordbot> Why though? 20190107 03:40:31<+wesdiscordbot> The old file was still loading 1 macro so just to be safe 20190107 03:40:47<+wesdiscordbot> Good to be sure about what we are doing 20190107 03:41:11<+wesdiscordbot> the map file looks fine 20190107 03:41:56<+wesdiscordbot> What about the units the leader can recruit would they be loaded? 20190107 03:42:21<+wesdiscordbot> yes, but not because of the recruit line 20190107 03:42:29<+wesdiscordbot> but because of the {units/} line in main.cfg 20190107 03:42:40<+wesdiscordbot> the recruit line does cause them to be added to known units though 20190107 03:42:52<+wesdiscordbot> anyway, just kill that line 20190107 03:42:58<+wesdiscordbot> They are units from the other add-on the dependency ROTL 20190107 03:43:17<+wesdiscordbot> A smaller version of that add-on. 20190107 03:43:18<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531679190223814676/01_the_rising_storm.cfg 20190107 03:43:23<+wesdiscordbot> They won't be loaded by the units/ line 20190107 03:43:40<+wesdiscordbot> So, I'll test now the fire from Gnat and afterwards do the domain removing? 20190107 03:43:41<+wesdiscordbot> @Konrad2 - does it work now 😃 20190107 03:44:20<+wesdiscordbot> @The_Gnat I'd have failed if it did. xD The goal is still the smallest scenario that doesn't work. >.< 20190107 03:44:45<+wesdiscordbot> Great! 20190107 03:44:50<+wesdiscordbot> Then is it the italics? 20190107 03:45:11<+wesdiscordbot> or the newline just before them 20190107 03:45:36<+wesdiscordbot> We did already establish that removing the _ fixes it, right? 20190107 03:45:45<+wesdiscordbot> We just have no idea why. 20190107 03:46:06<+wesdiscordbot> the error message is generated by the translated strings C++ code 20190107 03:46:50<+wesdiscordbot> Konrad2, are you trying the italics ? 20190107 03:47:35<+wesdiscordbot> Just a second. I'm trying to figure out whether @The_Gnat 's file works or not. 20190107 03:48:19<+wesdiscordbot> It is larger than yours so it wont 20190107 03:48:30<+wesdiscordbot> but it's not a superset 20190107 03:48:32<+wesdiscordbot> And I know now that I can't know. @The_Gnat You removed every string. How am I supposed to tell whether the strings are invalid or not? xD 20190107 03:48:42<+wesdiscordbot> scenario name 20190107 03:48:45<+wesdiscordbot> is still there 20190107 03:48:54<+wesdiscordbot> The team name 20190107 03:49:17<+wesdiscordbot> It was always the story text and the messages. 20190107 03:49:29<+wesdiscordbot> But the team name broke also 20190107 03:49:38<+wesdiscordbot> And so did the scenario name right 20190107 03:50:11<+wesdiscordbot> Okay, it broke. 20190107 03:50:25<+wesdiscordbot> So even without the italics or any story? 20190107 03:50:28<+wesdiscordbot> See? 20190107 03:50:29<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531680999940030464/tRoI--Auto-Save1.gz 20190107 03:50:33<+wesdiscordbot> Yep. XD 20190107 03:51:06<+wesdiscordbot> thats on the_gnat's file right? 20190107 03:51:07<+wesdiscordbot> I have no idea what this means. 20190107 03:51:11<+wesdiscordbot> Yes. 20190107 03:51:32<+wesdiscordbot> Should I try removing the domain? 20190107 03:52:05<+wesdiscordbot> either that, or remove both underscores 20190107 03:53:15<+wesdiscordbot> Both? There is only one, right? 20190107 03:53:22<+wesdiscordbot> And in the team name 20190107 03:53:32<+wesdiscordbot> Removing the domain fixes it. 20190107 03:53:44<+wesdiscordbot> okay, now try something else please 20190107 03:54:15<+wesdiscordbot> add/change the domain to #textdomain wesnoth-tRoI 20190107 03:55:06<+wesdiscordbot> (Leaving the underscores alone, right?) 20190107 03:55:10<+wesdiscordbot> and after that, try also #textdomain wesnoth-tsg and #textdomain notarealtextdomain 20190107 03:55:11<+wesdiscordbot> yes 20190107 03:55:19<+wesdiscordbot> we're not trying alternative ways to minimize Gnat's file 20190107 03:55:23<+wesdiscordbot> now* 20190107 03:56:22<+wesdiscordbot> Works. 20190107 03:56:54<+wesdiscordbot> Both of those options work 20190107 03:57:14<+wesdiscordbot> Both of the three? 😛 20190107 03:57:30<+wesdiscordbot> Works too. 20190107 03:58:34<+wesdiscordbot> (Taking that back, I forgot to delete the cache.) 20190107 03:59:15<+wesdiscordbot> so, again 20190107 03:59:33<+wesdiscordbot> for each of the 5 values dl, (unset), tRoI,tsg, notarealtextdomain, what's the behavior? 20190107 03:59:37<+wesdiscordbot> please 20190107 04:00:49<+wesdiscordbot> i don't mean test again, just say again clearly 20190107 04:01:22<+wesdiscordbot> Oh. Breaks, works, works, works, works. 20190107 04:01:33<+wesdiscordbot> thanks 20190107 04:02:01<+wesdiscordbot> Are you any closer to figuring out the root cause? 20190107 04:02:18<+wesdiscordbot> no 20190107 04:02:33<+wesdiscordbot> in fact, I'm surprised, because main.cfg declares tRoI and includes scenario 01 20190107 04:03:00<+wesdiscordbot> so that proves that textdomain is per file, not transitive through included files, unlike what I told @The_Gnat 20190107 04:03:07<+wesdiscordbot> So basically anything except the dl works? 20190107 04:03:27<+wesdiscordbot> So did I just get super unlucky when I choose my acronym ;P 20190107 04:03:33<+wesdiscordbot> I guess, grep for wesnoth-dl 20190107 04:03:37<+wesdiscordbot> in the addon folder 20190107 04:03:44<+wesdiscordbot> how's the command called again... 20190107 04:03:56<+wesdiscordbot> Ah, windows search may be able to do it 20190107 04:04:28<+wesdiscordbot> @Konrad2 - Do you get anything when you grep for wesnoth-dl ? 20190107 04:04:31<+wesdiscordbot> @The_Gnat Could you give konrad a find command line for windows ? 20190107 04:04:36<+wesdiscordbot> he's on windows, no grep 20190107 04:04:50<+wesdiscordbot> Oh okay lets see 20190107 04:05:06<+wesdiscordbot> @Konrad2 Open another cmd and change directory (cd) to data/add-ons 20190107 04:06:36<+wesdiscordbot> I think windows search command in the folder explorer would be "content:wesnoth-dl" 20190107 04:06:37<+wesdiscordbot> How do I do that again..? 20190107 04:06:55<+wesdiscordbot> I just use the tools windows-grep usually tho it is much faster 20190107 04:08:22<+wesdiscordbot> http://gnuwin32.sourceforge.net/packages/grep.htm 20190107 04:08:25<+wesdiscordbot> It says something about the sytax being wrong. 20190107 04:09:23<+wesdiscordbot> Hmm 20190107 04:10:02<+wesdiscordbot> shall we just install grep ? 20190107 04:10:31<+wesdiscordbot> So, how do I use this? 20190107 04:10:43<+wesdiscordbot> download and run http://downloads.sourceforge.net/gnuwin32/grep-2.5.4-setup.exe 20190107 04:12:02<+wesdiscordbot> Installed and now? 20190107 04:12:12<+wesdiscordbot> Open a new instance of cmd 20190107 04:12:22<+wesdiscordbot> Don't use existing instances, you have to open a new one for PATH changes to take effect 20190107 04:12:51<+wesdiscordbot> Type grep foo bar (literally),. What error message do you get? 20190107 04:13:54<+wesdiscordbot> The command 'grep' was either misspelled or couldn't be found. 20190107 04:14:12<+wesdiscordbot> oops 😦 20190107 04:14:17<+wesdiscordbot> @The_Gnat any idea^ ? 20190107 04:14:21<+wesdiscordbot> @Konrad2 in the meantime 20190107 04:14:27<+wesdiscordbot> Try find /? 20190107 04:14:46<+wesdiscordbot> does it look like a command that takes a string argument and prints what files that string appears in? 20190107 04:15:45-!- gfgtdf [~Daniel@x4d0391de.dyn.telefonica.de] has joined #wesnoth-umc-dev 20190107 04:16:58<+wesdiscordbot> Something about it's format being wrong..? 20190107 04:17:15<+wesdiscordbot> Okay, next up 20190107 04:17:18<+wesdiscordbot> Meanwhile if you can't get grep working you can always just put "content: wesnoth-dl" into your windows explorer 20190107 04:17:23<+wesdiscordbot> Create the directory C:\grep 20190107 04:17:42<+wesdiscordbot> Download http://downloads.sourceforge.net/gnuwin32/grep-2.5.4-bin.zip and unzip it in that directory 20190107 04:17:54<+wesdiscordbot> Gnat, isn't that what he tried before? 20190107 04:18:09<+wesdiscordbot> I think he might have put it into his cmd 20190107 04:18:36<+wesdiscordbot> Either way it will take windows explorer 3hours :p 20190107 04:18:40< celticminstrel> This channel is so active... x_x 20190107 04:18:54< celticminstrel> I suppose it's a good thing though... x_x 20190107 04:20:05<+wesdiscordbot> It doesn't find anything with 'content: wesnoth-dl'. :/ 20190107 04:20:11<+wesdiscordbot> Maybe it's a language barrier? 20190107 04:20:16<+wesdiscordbot> it probably doesnt search cfg files 20190107 04:20:17< celticminstrel> ? 20190107 04:20:25<+wesdiscordbot> @josteph true 20190107 04:20:44<+wesdiscordbot> Konrad2, can you try my instructions with http://downloads.sourceforge.net/gnuwin32/grep-2.5.4-bin.zip from a few minutes ago ? 20190107 04:20:49< celticminstrel> Oh. 20190107 04:20:59<+wesdiscordbot> @The_Gnat maybe it needs double quotes because of the minus? 20190107 04:22:17<+wesdiscordbot> It's claiming that there is no such content despite me knowing that there is in Sc1 of tRoI... 20190107 04:22:35<+wesdiscordbot> Yeah I don't think windows explorer searches cfg files... 20190107 04:23:01<+wesdiscordbot> So let's go back to grep, shall we, @Konrad2 ? 20190107 04:23:13<+wesdiscordbot> I am doing that. xD 20190107 04:23:19<+wesdiscordbot> Okay ! 😃 20190107 04:23:24<+wesdiscordbot> Now what? 20190107 04:23:29<+wesdiscordbot> Unzipped. 20190107 04:23:31<+wesdiscordbot> Does C:\grep\bin exist? 20190107 04:23:45<+wesdiscordbot> Surprisingly hard to just search a simple string 😉 20190107 04:23:46<+wesdiscordbot> Yes. 20190107 04:23:54<+wesdiscordbot> Okay. Open cmd 20190107 04:24:10<+wesdiscordbot> Type C:\grep\bin\grep foo bar again and tell me what error you get 20190107 04:24:24<+wesdiscordbot> @The_Gnat Why isn't WIndows POSIX-compatible again? 20190107 04:24:43<+wesdiscordbot> libintl3.dll wasn't found. 20190107 04:24:55<+wesdiscordbot> https://www.quora.com/Why-doesnt-Microsoft-make-Windows-POSIX-compliant 20190107 04:25:05<+wesdiscordbot> And that's why the exectution of the code was stopped? 20190107 04:25:09<+wesdiscordbot> give me a minute 20190107 04:25:39<+wesdiscordbot> @Konrad2 You need to get http://downloads.sourceforge.net/gnuwin32/grep-2.5.4-dep.zip too 20190107 04:25:58<+wesdiscordbot> and unzip it to the same folder, so bin*.dll and bin\grep.exe are in the same folder 20190107 04:26:15<+wesdiscordbot> When you have done run C:\grep\bin\grep foo bar again 20190107 04:27:43<+wesdiscordbot> No such file or directory. 20190107 04:28:01<+wesdiscordbot> At least we are going somewhere now 20190107 04:28:03<+wesdiscordbot> C:\grep\bin\grep --help 20190107 04:28:05<+wesdiscordbot> please 20190107 04:28:18<+wesdiscordbot> Wall of text. 20190107 04:28:31<+wesdiscordbot> finally 20190107 04:28:36<+wesdiscordbot> 😃 20190107 04:28:39<+wesdiscordbot> okay, now cd to your data\add-ons dir 20190107 04:29:14<+wesdiscordbot> when you reach it, run C:\grep\bin\grep -ERil wesnoth.dl . > foo.txt 20190107 04:29:26<+wesdiscordbot> not that it's just one ell in there, not two 20190107 04:31:03<+wesdiscordbot> Only tRoI turned up. :/ 20190107 04:31:24<+wesdiscordbot> Uggg 20190107 04:31:24<+wesdiscordbot> No way. 20190107 04:32:44<+wesdiscordbot> Okay, it's a longshot, but one more 20190107 04:32:54<+wesdiscordbot> C:\grep\bin\grep -ERi wesnoth-d . > foo.txt 20190107 04:35:40<+wesdiscordbot> (It's still searching.) 20190107 04:39:29<+wesdiscordbot> (Make sure you typed the . before the >) 20190107 04:40:02<+wesdiscordbot> Copypasted 20190107 04:40:27<+wesdiscordbot> What is that -ERi btw? 20190107 04:40:48<+wesdiscordbot> -E tells it to use a different regular expressions flavor 20190107 04:41:04<+wesdiscordbot> -R means recurse files and directories 20190107 04:41:09<+wesdiscordbot> -i means case insensitive 20190107 04:41:18<+wesdiscordbot> -l means show the filename only 20190107 04:41:41<+wesdiscordbot> Why no l this time? 20190107 04:41:44<+wesdiscordbot> . means the current directory, as you remember 20190107 04:41:52<+wesdiscordbot> so it recurses under . 20190107 04:41:58<+wesdiscordbot> no -l because I wanted to see the matches this time 20190107 04:42:13<+wesdiscordbot> Still searching. 20190107 04:42:14<+wesdiscordbot> because I actually want wesnoth-d as a whole word, but there might be wesnoth-dadada 20190107 04:42:16<+wesdiscordbot> ok 20190107 04:42:36<+wesdiscordbot> are you sure @Konrad2 ? 20190107 04:42:41<+wesdiscordbot> the previous grep took three minutes 20190107 04:43:28< celticminstrel> [Jan 06@11:20:59pm] wesdiscordbot: @The_Gnat maybe it needs double quotes because of the minus? 20190107 04:43:29< celticminstrel> WML syntax confers no special status to a minus, so whatever you're talking about, this probably isn't the solution. 20190107 04:43:49<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531694419867336705/grep.png 20190107 04:43:53<+wesdiscordbot> celmin, we were talking about windows explorer search, but thanks 20190107 04:44:06< celticminstrel> FTR, shells also don't confer special meaning AFAIK. 20190107 04:44:16< celticminstrel> Oh, explorer search. 20190107 04:44:22<+wesdiscordbot> @Konrad2 looks good, it definitely is running 20190107 04:44:33< celticminstrel> That one I have no idea about, though I'd be kinda surprised if it supports any special syntax... 20190107 04:44:37<+wesdiscordbot> yeah, - isn't special to shells. It's just special to option parsers 20190107 04:50:44<+wesdiscordbot> it really should have finished by now 20190107 04:51:15<+wesdiscordbot> Could open another cmd and run the command again? Just direct the output to another file 20190107 04:51:52-!- gfgtdf [~Daniel@x4d0391de.dyn.telefonica.de] has quit [Quit: Leaving] 20190107 04:52:18<+wesdiscordbot> Started it now. 20190107 04:54:21<+wesdiscordbot> Lot's of 'no space left on device'. ._. 20190107 04:54:45<+wesdiscordbot> The .txt is too big for my editors. 20190107 04:54:46<+wesdiscordbot> ._. 20190107 04:54:55<+wesdiscordbot> kill it and delete the output files 20190107 04:55:01<+wesdiscordbot> both of them 20190107 04:55:05<+wesdiscordbot> Ctr+C kills it. 20190107 04:55:08<+wesdiscordbot> Ctrl+C 20190107 04:55:19<+wesdiscordbot> 124 GB 20190107 04:55:24<+wesdiscordbot> What have you done? XD 20190107 04:55:38<+wesdiscordbot> Just what I planned all along. 20190107 04:55:42<+wesdiscordbot> ._. 20190107 04:56:05<+wesdiscordbot> I guess it matched on its own output 20190107 04:56:15<+wesdiscordbot> so. 20190107 04:56:22<+wesdiscordbot> in the addons directory 20190107 04:56:47<+wesdiscordbot> C:\grep\bin\grep -FRin wesnoth-d . > ..\out.txt 20190107 04:57:08<+wesdiscordbot> -n means line numbers, -F means literal patterns, the .. fix the presumable cause of the runaway 20190107 04:57:21<+wesdiscordbot> it should finish in three minutes. 20190107 04:57:38<+wesdiscordbot> if it still runs in six minutes or if the output file is > 1.8GB, kill it 20190107 04:58:22<+wesdiscordbot> It already finished, but I'm still looking for the file. 20190107 04:58:46<+wesdiscordbot> Found it. 20190107 04:59:27<+wesdiscordbot> well, show us 20190107 04:59:55<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531698465659551755/out.txt 20190107 05:00:40<+wesdiscordbot> ok, that doesn't help 20190107 05:00:46<+wesdiscordbot> so we're stuck with the result from before 20190107 05:01:52<+wesdiscordbot> dl, (unset), tRoI,tsg, notarealtextdomain Breaks, works, works, works, works. 20190107 05:02:16<+wesdiscordbot> and we already checked earlier that changing dl to whatever works for the noncannibalized scenario too 20190107 05:02:48<+wesdiscordbot> I'm out of ideas 20190107 05:03:03<+wesdiscordbot> Could you file an issue please 20190107 05:04:07<+wesdiscordbot> I don't even know what to say. XD 20190107 05:05:00<+wesdiscordbot> This was very unenlightening bug understanding session. 20190107 05:08:54<+wesdiscordbot> It was indeed. So basically dl breaks the game... 20190107 05:09:10<+wesdiscordbot> wait, let's try something else 20190107 05:09:15<+wesdiscordbot> let's change aoi s1 to wesnoth-dl 20190107 05:09:20<+wesdiscordbot> I have one more idea to test.... 20190107 05:09:27<+wesdiscordbot> @josteph - read my mind 20190107 05:09:47<+wesdiscordbot> works 20190107 05:10:08<+wesdiscordbot> @Konrad2 could you test that ? 20190107 05:10:24<+wesdiscordbot> change the textdomain to wesnoth-dl in... 20190107 05:10:31<+wesdiscordbot> @The_Gnat in macros/ first, sruely? 20190107 05:10:33<+wesdiscordbot> before AOI 20190107 05:12:08<+wesdiscordbot> Hmm... Instead of changing an orcish incursion could you change a add-on campaign? 20190107 05:12:37<+wesdiscordbot> Also perhaps it is the lack of "Textdomain" in the macros that are then embedded in the sc1. 20190107 05:12:53<+wesdiscordbot> If we add #textdomain wesnoth-dl to the macro files does it still break? 20190107 05:13:14<+wesdiscordbot> So, what to do now? 20190107 05:14:40<+wesdiscordbot> @josteph @The_Gnat 20190107 05:19:24<+wesdiscordbot> @Konrad2 Change all the files in tRoI/macros/ to have #textdomain wesnoth-dl as their first line, and see if strings defined in those files are affected 20190107 05:19:45<+wesdiscordbot> Actually my previous idea wont work 20190107 05:20:14<+wesdiscordbot> But it might be worth testing a campaign (such as IFTU) if it break with wesnoth-dl 20190107 05:20:57<+wesdiscordbot> I'll do so after awakening. 20190107 05:21:13<+wesdiscordbot> @Konrad2 Thanks for all the investigations! 20190107 05:21:28<+wesdiscordbot> It was fun. 20190107 05:21:33<+wesdiscordbot> I'm curious to see what it's going to be... 20190107 05:33:19<+wesdiscordbot> Yes I too need to go to sleep haha. But I would definitely be interested in how this turns out! 20190107 06:42:31-!- celticminstrel is now known as celmin|sleep 20190107 07:27:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev 20190107 08:34:07-!- vn971 [~vasilii@2a02:a210:2203:c000:7f64:7780:4177:6131] has quit [Quit: Leaving.] 20190107 09:11:16-!- vn971 [~vasilii@office.zivver.org] has joined #wesnoth-umc-dev 20190107 11:48:44<+wesdiscordbot> Changing the macro files didn't fix it. Changing the AOI Sc1 file didn't break it. Changing the TTSS Sc1 file didn't break it. 😅 20190107 11:49:08<+wesdiscordbot> @josteph ^ @The_Gnat 20190107 12:47:33-!- celmin|sleep is now known as celmin|away 20190107 13:52:02<+wesdiscordbot> @Konrad2 Look for a file called wesnoth-dl.mo (not only under data/add-ons but also elsewhere) 20190107 13:56:30<+wesdiscordbot> I don't have such a file. 20190107 13:57:44< celmin|away> FTR you don't need such a file, the game can also directly load the po files as long as they're in the right place. 20190107 13:58:09<+wesdiscordbot> Good point 20190107 13:58:31<+wesdiscordbot> How would they be named? wesnoth-dl/foo.po ? 20190107 13:58:50< celmin|away> I forget and don't have time to check ATM. 20190107 13:59:04< celmin|away> But I think it would be something like that. 20190107 13:59:24<+wesdiscordbot> ok 20190107 13:59:35<+wesdiscordbot> @Konrad2 do you have a file called wesnoth-dl.po or a directory called wesnoth-dl? 20190107 13:59:41<+wesdiscordbot> Or anything whatsoever called wesnoth-dl, really 20190107 14:02:33<+wesdiscordbot> Nothing. 20190107 14:04:41<+wesdiscordbot> let's take this to the dev channel or forum or github, maybe others have ideas 20190107 14:05:14<+wesdiscordbot> if it were happening on my machine I'd have fired a debugger now to see what it does differently on "wesnoth-dl" 20190107 14:11:10<+wesdiscordbot> What I can (and will) try soon, is to reproduce it on my other PC. 20190107 15:41:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20190107 15:42:17<+wesdiscordbot> @josteph I managed to replicate the bug on my other PC! Yay! 20190107 15:42:28<+wesdiscordbot> My Laptop is not cursed! ...or if it is, so is my PC. 20190107 15:42:36<+wesdiscordbot> Oh no, not another variable 😛 20190107 15:51:02<+wesdiscordbot> Anyway, no idea what to do with this now. 20190107 15:54:04<+wesdiscordbot> post to the forum and ask for ideas 20190107 15:54:34<+wesdiscordbot> or use a watchpoint in a debugger to see how "wesnoth-dl" is handled differently 20190107 15:56:14<+wesdiscordbot> But really, how am I supposed to describe it? 'Hi, I have this weird bug noone else has and basically it happens when you have a lot of add-ons and it only happens to this one scenario in that one add-on and we have no clue why?' 😅 20190107 15:57:11<+wesdiscordbot> describe the symptoms and state the conditions you identified as required 20190107 15:57:25<+wesdiscordbot> the fancier the conditions are, the more interesting the bug is, and the more replies you'll get 20190107 15:57:35<+wesdiscordbot> the bit about wesnoth-dl magic string is particularly nice 20190107 15:57:39<+wesdiscordbot> Oh! 20190107 15:57:46<+wesdiscordbot> that string is used elsewhere in troi, isn't it? 20190107 15:57:53<+wesdiscordbot> Would you mind posting it for me? ...what? 20190107 15:57:57<+wesdiscordbot> @The_Gnat ^ (my last line) 20190107 15:58:07<+wesdiscordbot> the string "wesnoth-dl" is used several times in tRoI, is it not? 20190107 15:58:22<+wesdiscordbot> can you go to addons/The Rulers of Irdya/ 20190107 15:58:23<+wesdiscordbot> That scenario or all files in the directory? 20190107 15:58:34<+wesdiscordbot> once in the scenario, multiple in the directory 20190107 15:58:42<+wesdiscordbot> can you go to addons/tRoI/ 20190107 15:59:03<+wesdiscordbot> C:\grep\bin\grep -FRn wesnoth-dl . 20190107 15:59:18<+wesdiscordbot> and change all instances to wesnoth-notdl 20190107 15:59:23<+wesdiscordbot> and see if the bug still happens 20190107 16:01:12<+wesdiscordbot> We already now that, no? 20190107 16:01:22<+wesdiscordbot> The only instances are that one time in Sc1. 20190107 16:01:36<+wesdiscordbot> (And also in the macros, because you wanted me to add it there.) 20190107 16:02:11<+wesdiscordbot> Probably explains why Sc2 is not corrupted, because it has no textdomain. 20190107 16:02:15<+wesdiscordbot> *invalid 20190107 16:03:52<+wesdiscordbot> I thought wesnoth-dl occurs multiple times in that dir 20190107 16:04:00<+wesdiscordbot> my bad 20190107 16:04:37<+wesdiscordbot> @Konrad2 Could you post your error message again ? 20190107 16:05:21<+wesdiscordbot> Err....changing it to wesnoth-notdl did not fix it. 20190107 16:05:23<+wesdiscordbot> Weird. 20190107 16:05:33<+wesdiscordbot> ! 20190107 16:05:34<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531865991450329088/wesnoth-20190107-170344-12528.log 20190107 16:05:50<+wesdiscordbot> We tested this yesterday too, didn't we? 20190107 16:06:09<+wesdiscordbot> No, we only tested changing it to some specific ones. 20190107 16:06:12<+wesdiscordbot> oh, remember the 0x81 from yesterday? 20190107 16:06:20<+wesdiscordbot> But not this specific one. Yes? 20190107 16:06:25<+wesdiscordbot> now it's different. 0x04 0x81 0x00 20190107 16:06:33<+wesdiscordbot> except on one line, where it is 20190107 16:06:56<+wesdiscordbot> 0x01 tRoI- 0x04 0x81 0x00 The Rising Storm 20190107 16:07:17<+wesdiscordbot> That's one with wesnoth-dl 20190107 16:07:18<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531866423774150659/wesnoth-20190107-151203-11096.log 20190107 16:07:18<+wesdiscordbot> and some of them are 80 not 81 20190107 16:07:42<+wesdiscordbot> same values in both of these 20190107 16:07:55<+wesdiscordbot> 20190107 16:08:00<+wesdiscordbot> what? 20190107 16:08:14<+wesdiscordbot> anyway, can you try changing the textdomain of say aoi to wesnoth-notaoi ? 20190107 16:08:14<+wesdiscordbot> I copy pasted one of the symbols. xD 20190107 16:08:29<+wesdiscordbot> I received an empty line 20190107 16:08:41<+wesdiscordbot> Yup. I can see that. 20190107 16:08:48<+wesdiscordbot> Didn't know that this is possible. 20190107 16:09:56< Ravana> if you need to use grep with full path, it means you haven't restarted after adding it to PATH 20190107 16:10:43< Ravana> personally I use cygwin when I use windows 20190107 16:11:13<+wesdiscordbot> Personally, I don't use anything like that. ._. 20190107 16:11:26<+wesdiscordbot> I'm just under orders. 20190107 16:11:47< Ravana> there are GUI grep programs for windows 20190107 16:11:51<+wesdiscordbot> @josteph Didn't break. 20190107 16:12:56<+wesdiscordbot> but 20190107 16:13:03<+wesdiscordbot> 20190107 03:59:33<+wesdiscordbot> for each of the 5 values dl, (unset), tRoI,tsg, notarealtextdomain, what's the behavior? 20190107 04:01:22<+wesdiscordbot> Oh. Breaks, works, works, works, works. 20190107 16:13:15<+wesdiscordbot> so notarealtextdomain works but wesnoth-notdl breaks ?? 20190107 16:17:14<+wesdiscordbot> Yes. 20190107 16:17:42<+wesdiscordbot> let me try changing AOI to wesnoth-dl 20190107 16:17:57<+wesdiscordbot> That worked for me. 20190107 16:18:12<+wesdiscordbot> for me too 20190107 16:18:55<+wesdiscordbot> how about wesnoth-notarealtextdomain ? 20190107 16:19:08<+wesdiscordbot> I wonder if anything that starts with wesnoth- breaks it 20190107 16:19:44<+wesdiscordbot> Read your quote above. 20190107 16:19:57<+wesdiscordbot> ... 20190107 16:20:06<+wesdiscordbot> Read my last line? 20190107 16:20:12<+wesdiscordbot> Okay, notarealtextdomain does not work? 20190107 16:20:16<+wesdiscordbot> notarealtextdomain != wesnoth-notarealtextdomain 20190107 16:20:36<+wesdiscordbot> I must have made a mistake the laste time. 20190107 16:21:23<+wesdiscordbot> you didn't try wesnoth-notarealtextdomain last time, only notarealtextdomain 20190107 16:21:45<+wesdiscordbot> I tried wesnoth-notarealtextdomain. 20190107 16:22:10<+wesdiscordbot> I probalby forgot to delete the cache or only thought that I had tested it. 20190107 16:22:21<+wesdiscordbot> Now, one last test. I need to take a break afterwards. 20190107 16:22:27<+wesdiscordbot> ok, no problem 20190107 16:22:34<+wesdiscordbot> so, current status 20190107 16:22:37<+wesdiscordbot> wesnoth-dl broken 20190107 16:22:40<+wesdiscordbot> wesnoth-notarealtextdomain works 20190107 16:22:42<+wesdiscordbot> right ? 20190107 16:22:46<+wesdiscordbot> No. 20190107 16:22:48<+wesdiscordbot> Breaks. 20190107 16:22:55<+wesdiscordbot> does not work 20190107 16:23:17<+wesdiscordbot> (Feel free to post on the forum about this bug, I'll do my best to supply any information. Or run tests.) 20190107 16:23:37<+wesdiscordbot> I will in a minute 20190107 16:23:51<+wesdiscordbot> just can you tell me two textdomains, one that works and one that doesn't 20190107 16:23:52<+wesdiscordbot> ? 20190107 16:25:22<+wesdiscordbot> ....no? Weird. 20190107 16:25:39<+wesdiscordbot> wesnoth-tRoI did work, I'm sure. But it doesn't anymore. 20190107 16:27:13<+wesdiscordbot> wesnoth-tsg works 20190107 16:27:21<+wesdiscordbot> Off I go. 20190107 16:28:17<+wesdiscordbot> Okay, so -tsg works and -dl breaks 20190107 16:38:44<+wesdiscordbot> @Konrad2 @The_Gnat https://forums.wesnoth.org/viewtopic.php?f=4&t=49263 20190107 16:41:19<+wesdiscordbot> But it also occurs with -notdl, -notarealtextdomain, -tRoI? 20190107 16:55:44< Soliton> the control characters are those constants https://github.com/wesnoth/wesnoth/blob/master/src/tstring.cpp#L40 i would guess. 20190107 16:59:59<+wesdiscordbot> where would the 0x80 come from? 20190107 17:00:46< Soliton> no clue. the NUL also looks suspicious. 20190107 17:00:57< Soliton> maybe something got overwritten. 20190107 17:01:29<+wesdiscordbot> I did try to add 1M #textdomain lines but that didn't produce the error 20190107 17:01:37<+wesdiscordbot> maybe I need 1M [textdomain] tags 20190107 17:03:31<+wesdiscordbot> @Konrad2 Can you figure out which of the six "invalid string" errors is the one you run into? 20190107 17:03:45<+wesdiscordbot> @Konrad2 Change them to "invalid string 1", "invalid string 2", etc and recompile 20190107 17:05:55< Soliton> if it starts with \2 then i guess it should be the UNTRANSLATABLE_PART case. 20190107 17:07:10<+wesdiscordbot> You'll have to explain that to me. What six error types and how would I recompile? And how would I know which one it is? 20190107 17:08:00<+wesdiscordbot> In src/tstring.cpp the string "invalid string" occurs six times. 20190107 17:08:14<+wesdiscordbot> Change the first occurence to "invalid string 1", the second to"invalid string 2"`, and so on. 20190107 17:11:28< Ravana> compiling wesnoth is quite difficult 20190107 17:12:01<+wesdiscordbot> Ah, right, I misread 20190107 17:12:04< Soliton> i switch my guess to ID_TRANSLATABLE_PART with an invalid textdomain id. 20190107 17:12:09<+wesdiscordbot> If you haven't compiled wesnoth before... 20190107 17:12:28<+wesdiscordbot> Soliton, I wonder if there's an overflow at https://github.com/wesnoth/wesnoth/blob/49a5acee50603546a55cf96337aa15a053c680d0/src/tstring.cpp#L119 20190107 17:12:41<+wesdiscordbot> 0x81 0x00 could be 20190107 17:12:46<+wesdiscordbot> 0x80 + 256 * 1 20190107 17:13:35< Soliton> i would think there just aren't 129 text domains. 20190107 17:13:50<+wesdiscordbot> konrad may have 129 domains easily 20190107 17:13:56<+wesdiscordbot> he has tons of UMC campaigns 20190107 17:14:41< Soliton> well, how do you get to 256*1? 0x81 is one byte. 20190107 17:14:50< Soliton> the next byte is 0. 20190107 17:16:03<+wesdiscordbot> Not sure 20190107 17:16:09<+wesdiscordbot> That might have been nonsense 20190107 17:16:18<+wesdiscordbot> Look at the t_string_base ctor though 20190107 17:16:25<+wesdiscordbot> the casts 20190107 17:16:45< Soliton> if konrad manages to recompile printing id and id_to_textdomain.size() would be interesting. 20190107 17:17:50<+wesdiscordbot> Wouldn't it be easier if you get all the add-on I have? 20190107 17:18:09<+wesdiscordbot> *add-ona 20190107 17:18:15<+wesdiscordbot> *-ons 20190107 17:18:42<+wesdiscordbot> It'd be easier for someone to compile and send you an exe, if you're willing to run that 20190107 17:18:58<+wesdiscordbot> There's on guarantee that someone could repro with all of your addons 20190107 17:19:06<+wesdiscordbot> And remember that some of them aren't downloadable 20190107 17:20:23<+wesdiscordbot> I think I can do that. I could reproduce it with a different PC while having the same add-ons, so it's likely, right? Dropbox or something like that? 20190107 17:25:21< Soliton> if the issue is a mismatch in the encountered textdomains and rogue strings with an unknown (higher) textdomain id. there is probably some serious debugging needed to find the point where it goes wrong. so someone being able to reproduce would be ideal... 20190107 17:26:27< Ravana> remember to delete image and sound files before sending anything 20190107 17:26:53<+wesdiscordbot> I wonder if I should ask Konrad to send me just his textdomains 20190107 17:27:24<+wesdiscordbot> grep -FnA 1 textdomain over all his cfg files 20190107 17:27:54<+wesdiscordbot> oh, wow 20190107 17:28:01<+wesdiscordbot> is char signed on windwos? 20190107 17:28:22< Soliton> that is a good thought. 20190107 17:28:45<+wesdiscordbot> what's the answer? 😃 20190107 17:29:29< Soliton> well, it's implementation defined so you cannot rely on one or the other. 20190107 17:29:46<+wesdiscordbot> yes, I know that 20190107 17:30:09<+wesdiscordbot> https://stackoverflow.com/a/2054959 20190107 17:30:10<+wesdiscordbot> but if the windows implementation provides char == signed char, the bitwise operators in the ctor could be having a field day 20190107 17:30:24<+wesdiscordbot> On MSVC, the default is signed but you can modify that with /J. 20190107 17:30:27<+wesdiscordbot> thanks @jyrkive 20190107 17:30:42<+wesdiscordbot> so this line does a conversion value_ += static_cast(id & 0xff); 20190107 17:31:00<+wesdiscordbot> 0x81 as a signed char is -127 20190107 17:32:46<+wesdiscordbot> http://sprunge.us/jCpP1F 20190107 17:33:51<+wesdiscordbot> I'm going to push this 20190107 17:34:32< Soliton> i'm guessing only the tstring.cpp change. :-P 20190107 17:35:14<+wesdiscordbot> ah, sorry, yes 20190107 17:35:17<+wesdiscordbot> the rest is nemaara 20190107 17:36:25<+wesdiscordbot> Actually, why do the different kinds of invalid strings not have different names? 20190107 17:39:09< Soliton> @josteph changing the + to and should also fix it? perhaps also changing the multiplication to a shift. 20190107 17:39:30<+wesdiscordbot> the + to or, you mean ? 20190107 17:39:39< Soliton> err, yes. 20190107 17:39:52<+wesdiscordbot> I don't think it matters either way. 20190107 17:40:01<+wesdiscordbot> The integer promotion rules are the same for + and |, right? 20190107 17:40:09<+wesdiscordbot> And the optimizer converts *256 to <<8 anyway 20190107 17:40:37< Soliton> but the bitpattern is not wrong, no? 20190107 17:40:59<+wesdiscordbot> the bitpattern ought to be right 20190107 17:41:12<+wesdiscordbot> On two's complement anyway 20190107 17:41:13<+wesdiscordbot> ? 20190107 17:41:29< Soliton> i think that's in the standard nowadays. 20190107 17:41:42< Soliton> or there is no other architecture anyway. 20190107 17:42:38<+wesdiscordbot> yeah 20190107 17:42:49<+wesdiscordbot> @Konrad2 If someone compiles wesnoth.exe for you would you test the bug again with it? 20190107 17:44:21<+wesdiscordbot> Yes. 20190107 17:45:09<+wesdiscordbot> thanks 20190107 17:57:58-!- vn971 [~vasilii@office.zivver.org] has quit [Quit: Leaving.] 20190107 18:57:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev 20190107 22:07:36<+wesdiscordbot> @josteph So, is it fixed? Or do I still have to be careful about not updating tRoI? ^^ 20190107 22:09:59<+wesdiscordbot> @Konrad2 I think the fix is correct... but I made enough stupid mistakes today to be a bit careful before saying that yes it's 100% absolutely definitely fixed. 20190107 22:10:39<+wesdiscordbot> It would be nice if you could get a wesnoth.exe of current 1.14 and test with it, before you upgrade 20190107 22:10:54<+wesdiscordbot> but we'll leave without it if that's infeasible 😃 20190107 22:11:35<+wesdiscordbot> We'll, that's kinda at your end of the ability spectrum. :D 20190107 22:12:00<+wesdiscordbot> I think I butchered a idiom from my language there. Oops. 20190107 22:12:26<+wesdiscordbot> I think I know what you mean 20190107 22:12:35<+wesdiscordbot> I mean, I have no idea how to get that .exe without any of you giving it to me. 20190107 22:12:54<+wesdiscordbot> well, I can show you where the instructions are 20190107 22:13:00<+wesdiscordbot> but I can't give you an exe because I don't have windows here 20190107 22:13:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds] 20190107 23:01:10<+wesdiscordbot> @Yumi Do you have second for something of lesser importance? 20190107 23:05:14<+wesdiscordbot> heh? 20190107 23:05:38<+wesdiscordbot> ask away 20190107 23:09:14<+wesdiscordbot> How do I make sides enemies with each other while in the map editor? 20190107 23:09:27<+wesdiscordbot> I've placed 3 sides, but somehow they are allied. 20190107 23:09:42<+wesdiscordbot> And I don't know how to unally them. :/ 20190107 23:12:54<+wesdiscordbot> Somebody uses the scenario editor 🙀 20190107 23:14:17<+wesdiscordbot> @Konrad2 Partei -> Partei bearbeiten -> Allianzkennung 20190107 23:14:54<+wesdiscordbot> Try that again, but in english. xD 20190107 23:15:19<+wesdiscordbot> side -> edit side -> Team identifier 20190107 23:15:30<+wesdiscordbot> Not using the German translation? 20190107 23:15:38<+wesdiscordbot> Not using them. 20190107 23:15:58<+wesdiscordbot> My Teams are 'Human', 'Invisible' and 'Shrouded'. So why are they allies? 20190107 23:17:37<+wesdiscordbot> they should not be.... do you have them in "team name" or "team identifier"? 20190107 23:18:37<+wesdiscordbot> team identifier 20190107 23:18:55<+wesdiscordbot> Their team names are also the same as their team identifier. 20190107 23:20:30<+wesdiscordbot> maybe save it (but don't close the editor, I'm not sur eif it can load scenario again) and look in the file for (user_)team_name 20190107 23:25:04<+wesdiscordbot> 3 sides, 3 teamnames. 20190107 23:26:05<+wesdiscordbot> https://cdn.discordapp.com/attachments/442775044590927873/531976853032796161/test.cfg 20190107 23:27:59<+wesdiscordbot> what makes you think they're allied ? 20190107 23:28:50<+wesdiscordbot> The blue marble next to their hitpoint bar 20190107 23:30:35<+wesdiscordbot> it's probably better to just learn WML 20190107 23:30:40<+wesdiscordbot> you can't really do much in the scenario editor 20190107 23:32:14<+wesdiscordbot> according to WML, they're enemies 20190107 23:32:33<+wesdiscordbot> I think the editor is showing wrong orb colors, that's all 20190107 23:33:03<+wesdiscordbot> I agree with josteph, I don't see how they would be allies --- Log closed Tue Jan 08 00:00:50 2019