--- Log opened Sat Feb 09 00:00:04 2019 --- Day changed Sat Feb 09 2019 20190209 00:00:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20190209 00:26:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev 20190209 00:58:58-!- celmin|away is now known as celticminstrel 20190209 01:32:55-!- valdar [~atarocch@93.56.172.28] has quit [Read error: Connection reset by peer] 20190209 01:33:30-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190209 01:39:58< irker526> wesnoth/wesnoth:master Nils Kneuper 702f93def9 updated Italian translation AppVeyor: All builds passed 20190209 02:00:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190209 02:02:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190209 02:06:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190209 02:07:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190209 02:07:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190209 02:58:42< irker526> wesnoth/wesnoth:master gfgtdf 2f54ecbc53 fix display chat messages disappearing AppVeyor: 1/4 builds failed 20190209 02:58:43< irker526> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22235609 20190209 04:23:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.] 20190209 05:04:12<+wesdiscordbot> gfgtdf: Where have you gotten the info that SDL_GetTicks() can be slow? Have you tested it yourself or something? 20190209 05:59:16-!- irker526 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190209 07:54:17-!- celticminstrel is now known as celmin|sleep 20190209 09:30:40-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190209 09:32:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190209 10:01:41-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20190209 10:03:13-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20190209 10:12:59<+wesdiscordbot> Slow for what use? 20190209 10:14:00<+wesdiscordbot> The old code was calling it once per every message in chat: https://github.com/wesnoth/wesnoth/commit/2f54ecbc53abe69a294b5384b974537d84efa80d 20190209 10:18:37<+wesdiscordbot> reference for SDL_GetTicks says it wraps around every 49 days 20190209 10:18:44-!- irker672 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190209 10:18:44< irker672> wesnoth/wesnoth:master Sean Yeh fe1dcb54bc Make defender's "first strike" inactive AppVeyor: All builds passed 20190209 10:19:09<+wesdiscordbot> if a wesnoth client runs for this time I wonder what glich would this cause at the time for wrap around 😛 20190209 11:17:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190209 11:24:02< irker672> wesnoth/wesnoth:master Sean Yeh ad0512bebf Make defender's "first strike" inactive AppVeyor: All builds passed 20190209 12:16:51-!- gfgtdf [~Daniel@x4d030c49.dyn.telefonica.de] has joined #wesnoth-dev 20190209 12:20:16< gfgtdf> @jyrkive im not sure about SDL_GetTicks in particular but i once tested that certain (windows api and boost) functions to get the current time are quite slow. 20190209 12:21:46< gfgtdf> @jyrkive since i dont dont fure sure how SDL_GetTicks is implemented and the implementaiton is probably plattform depended i think it better to be on the safe side in particuarl since in that linked commit does does not have any disadvantages. 20190209 12:24:18< gfgtdf> @jyrkive that said, in the current implementation, prune_chat_messages it called very rarely (see the added NOTE in the code) so its irrelevant. But once chat line again really works (again see the added NOTE). It might become relevant if we call that function like 'at any draw' for example 20190209 12:46:56<+wesdiscordbot> So what happens to it after 49 days? 20190209 12:48:39<+wesdiscordbot> better use unix epoch, it will wrap around only in 2038 😛 20190209 12:48:48<+wesdiscordbot> on 32-bit systems though 20190209 12:50:17< irker672> wesnoth: josteph wesnoth:master 05cd1521ffb1 / data/multiplayer/scenarios/2p_Dark_Forecast.lua: Dark Forecast: Enemies that spawn on a village now take ownership of https://github.com/wesnoth/wesnoth/commit/05cd1521ffb13f33a2879dc660be5a9164afdbc9 20190209 12:53:18< irker672> wesnoth: Sean Yeh wesnoth:master ef37e84fe148 / src/units/ (abilities.cpp attack_type.hpp): Make defender's "first strike" inactive if the attacker also has "first strike" https://github.com/wesnoth/wesnoth/commit/ef37e84fe14824c7cad13aa6477ebe144365cb2a 20190209 12:53:20< irker672> wesnoth: jostephd wesnoth:master 80b00fc38b66 / src/units/ (abilities.cpp attack_type.hpp): Merge pull request #3800 from seanyeh/firststrike-both-inactive https://github.com/wesnoth/wesnoth/commit/80b00fc38b66273fd87ede407eef626eafcca26b 20190209 13:15:46< gfgtdf> loonycyborg, not sure this was really just abotu the performacne of that function. 20190209 13:16:19< gfgtdf> loonycyborg: i think unix epoch is only seconds though? 20190209 13:16:53< loonycyborg> hmm yes 20190209 13:17:12< loonycyborg> but there are platform independent functions in boost for dealing with time 20190209 13:17:15< loonycyborg> boost.crono 20190209 13:17:46< loonycyborg> we already pulled it in as indirect dependency I think 20190209 13:18:03< loonycyborg> oh also std::chrono 20190209 13:18:55< loonycyborg> https://en.cppreference.com/w/cpp/chrono/steady_clock consider using this instead 20190209 13:18:59<+wesdiscordbot> isn't granularity of seconds good enough for chat messages ? 20190209 13:19:22< loonycyborg> I was joking about unix epoch 20190209 13:19:50<+wesdiscordbot> I'm not 20190209 13:20:00<+wesdiscordbot> We are talking about the clock used to expire chat messages, right? 20190209 13:20:31< loonycyborg> yes 20190209 13:20:56< gfgtdf> @josteph hmm i thought we are using about 'possibel issues arising from yes SDL_GetTicks wrtapping' might might effect more than just chat messages. 20190209 13:21:21< loonycyborg> I think if possible best use std::chrono for that 20190209 13:21:24< gfgtdf> @josteph for chat messages is see no reason against using a second based solution. 20190209 13:21:44< loonycyborg> mind you it's hard to hit such issues in practice I think 20190209 13:21:56< loonycyborg> but such corner cases are most devious and confusing 20190209 13:24:22<+wesdiscordbot> we have ~80 uses of SDL_GetTicks, I don't know how many of them need performance 20190209 13:24:43<+wesdiscordbot> and for that matter I don't know whether SDL_GetTicks performs poorly on any platform 20190209 13:39:25-!- Polsaker [jn2RsLgImV@donger/wielder/Polsaker] has quit [Read error: Connection reset by peer] 20190209 14:07:01<+wesdiscordbot> SDL_GetTicks() uses QueryPerformanceCounter() on Windows: https://github.com/SDL-mirror/SDL/blob/7fb47ca1f1126f7fdafef1864b7ee6d2371ac72b/src/timer/windows/SDL_systimer.c#L130 20190209 14:09:41<+wesdiscordbot> https://docs.microsoft.com/fi-fi/windows/desktop/SysInfo/acquiring-high-resolution-time-stamps 20190209 14:09:50<+wesdiscordbot> "On a relatively small number of platforms that can't use the TSC register as the QPC basis, for example, for reasons explained in Hardware timer info, acquiring high resolution time stamps can be significantly more expensive than acquiring time stamps with lower resolution." 20190209 14:09:50-!- Polsaker [JD7wXNIHla@donger/wielder/Polsaker] has joined #wesnoth-dev 20190209 14:10:11<+wesdiscordbot> TSC is available on pretty much all modern systems, so this only matters for ancient PCs. 20190209 14:31:08<+wesdiscordbot> Thanks. 20190209 15:53:45-!- irker672 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190209 18:24:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20190209 18:44:32< gfgtdf> loonycyborg: at http://replays.wesnoth.org/1.14/20190209/ Aquamarins Partie at 18:27 has a strange desciptions for 'players' 20190209 18:44:40< gfgtdf> loonycyborg: is this some known server bug? 20190209 18:55:11-!- irker126 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190209 18:55:11< irker126> wesnoth: gfgtdf wesnoth:oos_debug_info 6d7af266543b / src/server/game.cpp: how activemods in server log https://github.com/wesnoth/wesnoth/commit/6d7af266543b297904e1cbe57c66bd96b4e81a80 20190209 18:57:40< loonycyborg> gfgtdf: there is one real person there though 20190209 18:58:01< loonycyborg> perhaps he loaded a game with large number of players and substituted them with AI 20190209 18:58:42< loonycyborg> oh wait 2 of them 20190209 18:58:48< gfgtdf> i don't think so that is a 6p map and the descriptiosn lists an redicouy amount of player. 20190209 18:58:50< loonycyborg> maybe they're playing some special era 20190209 18:59:17< gfgtdf> loonycyborg: this was wc2 with standard wc2 era, a very common era and scenario 20190209 19:00:33< loonycyborg> 18:32 has something like that too 20190209 19:03:18<+wesdiscordbot> it's all the units defined in the [side] 20190209 19:05:40<+wesdiscordbot> Soliton made a change to also list side after I asked about it, since otherwise there were games that listed no players at all. 20190209 19:06:21< loonycyborg> Seems all lists of Computer X on that page are associated with ageless scrolling survival 20190209 19:09:01< gfgtdf> is there a lonk to the commit of that change ? 20190209 19:09:12< gfgtdf> Soliton: ^ 20190209 19:31:46< irker126> wesnoth/wesnoth:master jostephd 80b00fc38b Merge pull request #3800 from seanyeh/fi AppVeyor: All builds passed 20190209 20:08:34-!- travis-ci [~travis-ci@ec2-184-73-70-222.compute-1.amazonaws.com] has joined #wesnoth-dev 20190209 20:08:35< travis-ci> wesnoth/wesnoth#20840 (oos_debug_info - 6d7af26 : gfgtdf): The build passed. 20190209 20:08:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/491031448 20190209 20:08:35-!- travis-ci [~travis-ci@ec2-184-73-70-222.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190209 22:32:35-!- irker126 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190209 22:56:52-!- irker321 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190209 22:56:52< irker321> wesnoth/wesnoth:master nemaara d68a30ad3c DiD S5: gameplay and dialogue fixes AppVeyor: All builds passed 20190209 23:20:44-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] --- Log closed Sun Feb 10 00:00:12 2019