--- Log opened Mon Feb 11 00:00:13 2019
20190211 00:03:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20190211 00:47:38-!- gfgtdf [~Daniel@x5f709f75.dyn.telefonica.de] has joined #wesnoth-dev
20190211 00:49:56< gfgtdf> using dice operators in filters should be safe use (although i'D recomend to use lua_function + wesnoth.random instead since lua can also cehck the synced state so that you can for example set what value shodul be displayed in attack prediction)
20190211 00:52:28< Ravana> you mean attack prediction is aware of lua_function?
20190211 00:54:25< gfgtdf> attack prediction just runs the filter on your attack specialy (like [damage]) including all supported filter attributes
20190211 00:57:10< gfgtdf> if you for exampel wanted to implement a 'critical hit with double damage every 100th hit' feature and used for example [filter_self] formula="1d100 == 1" for an [damage], then the attack prediction would print the double damage every 100th time.
20190211 00:57:40< gfgtdf> it woudl non cause OOS tough
20190211 00:58:42< gfgtdf> with lua however you add extra conditional to make it always returns false unless it it for the actual hit 
20190211 00:59:36< gfgtdf> like in `function give_double_damage() if is_real_attack() then return wesnoth.random(100) == 1 else return false end end`
20190211 00:59:50< gfgtdf> where is_real_attack() coudl be implemented in multiple ways
20190211 01:01:03< gfgtdf> in particular that way it doesn't print very misleading values in damage prediction.
20190211 01:56:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20190211 02:05:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20190211 02:10:53-!- irker264 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20190211 02:11:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20190211 02:47:11-!- irker640 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20190211 02:47:11< irker640> wesnoth/wesnoth:master newfrenchy83 3c80b15718 Check whether special is active by tag n AppVeyor: 1/2 builds failed
20190211 02:47:11< irker640> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22261542
20190211 02:54:05< celticminstrel> gfgtdf: Can you prove the dice operator is safe?
20190211 02:54:42< celticminstrel> It seems pretty unlikely.
20190211 02:55:01< celticminstrel> If it's using an unsynced random number generator, then it will produce different results on each client.
20190211 02:55:25< celticminstrel> But even if it's using a synched random number generator, it might be called a different number of times on each client, thus desynching the generator state.
20190211 02:55:49< celticminstrel> Because filters are called from UI code.
20190211 02:58:23< celticminstrel> Unless the calls from UI code guard the generator state somehow...
20190211 02:58:39< celticminstrel> Like saving it and then restoring it after they're done.
20190211 03:09:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20190211 03:13:52< irker640> wesnoth/wesnoth:master newfrenchy83 03c5cb8560 Check whether special is active by tag n AppVeyor: 1/2 builds failed
20190211 03:13:53< irker640> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/22261544
20190211 03:52:25< gfgtdf> <celticminstrel: it is using the usual random generator which dewtects autopmaticialyl whether its synced or not.
20190211 03:52:55< gfgtdf> see https://wiki.wesnoth.org/OOS_(Out_of_Sync)#The_rng
20190211 03:53:27< gfgtdf> basicially it detects whether it was called form ui or from synced code and has two seperate random generators for those two.
20190211 03:53:41< celticminstrel> I see, so it might be okay then...
20190211 03:53:52< celticminstrel> Feel free to revise what I added to that page if it's inaccurate?
20190211 03:55:13< celticminstrel> Obviously lua_function can already cause out-of-sync errors though.
20190211 03:56:47< gfgtdf> will do that tomorrow have to sleep now
20190211 03:56:50-!- gfgtdf [~Daniel@x5f709f75.dyn.telefonica.de] has quit [Quit: Leaving]
20190211 04:31:08< irker640> wesnoth: nemaara wesnoth:1.14 3b32cecbbc08 / data/campaigns/ (Eastern_Invasion/units/Bone_Knight.cfg Liberty/units/Bone_Knight.cfg): Added default AMLA to Bone Knight https://github.com/wesnoth/wesnoth/commit/3b32cecbbc0812b80ea54d49fd1f42477789d391
20190211 04:33:22< irker640> wesnoth: nemaara wesnoth:master 82d88ad941f3 / data/campaigns/ (Eastern_Invasion/units/Bone_Knight.cfg Liberty/units/Bone_Knight.cfg): Added default AMLA to Bone Knight https://github.com/wesnoth/wesnoth/commit/82d88ad941f3757d48070707e67462e1cb280e65
20190211 04:33:25<+wesdiscordbot> <Yumi> @Konrad2 ^
20190211 04:33:33<+wesdiscordbot> <Yumi> closing your issue now
20190211 05:03:27< irker640> wesnoth/wesnoth:1.14 Maximilian Fricke ce9873700c unit: Fix bug in unit movement animation AppVeyor: All builds passed
20190211 05:42:56-!- celticminstrel is now known as celmin|sleep
20190211 06:36:12< irker640> wesnoth/wesnoth:master Maximilian Fricke 2b975e65a7 unit: Fix bug in unit movement animation AppVeyor: All builds passed
20190211 06:47:43< irker640> wesnoth: Iris Morelle valen:master a26374beeec9 / bin/valen.pl: valen: Update for the new domain name and configuration on basilic for 1.14 https://github.com/wesnoth/valen/commit/a26374beeec942bca674ca6fd27a3a9412fca66c
20190211 06:50:14< irker640> wesnoth: Iris Morelle valen:master 33a5e2c0a01f / bin/valen.pl: valen: Fix duplicate entry for baldras 1.10 wesnothd port https://github.com/wesnoth/valen/commit/33a5e2c0a01f502a6180f5a010f847988caf07d8
20190211 06:54:00< irker640> wesnoth: Iris Morelle wesnoth:1.14 83a3c43100f2 / data/game_config.cfg: Re-add server2.w.o to the built-in list of alternate servers https://github.com/wesnoth/wesnoth/commit/83a3c43100f2a147d821e6c7b37f9113433617ac
20190211 06:54:09< irker640> wesnoth: Iris Morelle wesnoth:master 7a999125ea64 / data/game_config.cfg: Re-add server2.w.o to the built-in list of alternate servers https://github.com/wesnoth/wesnoth/commit/7a999125ea64773929759ae411be198349467626
20190211 08:56:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20190211 09:07:09< Ravana> interesting. I will have to try out if I can implement some eventbased ability ai-guide using lua_function weapon special
20190211 09:17:15< irker640> wesnoth/wesnoth:1.14 doofus-01 981ce3f905 rename lancer frames to mimic knight dir AppVeyor: All builds passed
20190211 11:25:16< irker640> wesnoth/wesnoth:1.14 nemaara 3b32cecbbc Added default AMLA to Bone Knight AppVeyor: All builds passed
20190211 13:07:56< irker640> wesnoth/wesnoth:1.14 Iris Morelle 83a3c43100 Re-add server2.w.o to the built-in list  AppVeyor: All builds passed
20190211 13:22:28-!- celmin|sleep is now known as celmin|away
20190211 15:00:54-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has joined #wesnoth-dev
20190211 16:08:11-!- irker640 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20190211 16:12:07< Soliton> gfgtdf: a server side script produces replays.wesnoth.org. it's not checked in.
20190211 16:13:08< Soliton> at some point it needs to be rewritten with a proper WML parser since save WML has evolved to not make its task easy anymore.
20190211 16:22:49-!- irker618 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20190211 16:22:49< irker618> wesnoth/wesnoth:master Iris Morelle 7a999125ea Re-add server2.w.o to the built-in list  AppVeyor: All builds passed
20190211 17:14:42< irker618> wesnoth/wesnoth:master newfrenchy83 89edcb97c7 Update abilities.cpp AppVeyor: vs2015/Release Failed
20190211 17:14:43< irker618> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22278125
20190211 17:49:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20190211 18:03:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20190211 18:04:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20190211 18:13:14-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has quit [Quit: Life is like a void pointer: you never know what you're going to get...]
20190211 18:19:02< irker618> wesnoth/wesnoth:master U-DESKTOP-5KURQFU\dlshc a4f87ab6dd Add quick-start instructions on compilin AppVeyor: All builds passed
20190211 19:48:04< irker618> wesnoth: Lovens Weche wesnoth:master b3b4f97cf1f3 / data/tools/wesnoth/wmlparser3.py: Fix wmlparser3 considers "_" part of attribute value https://github.com/wesnoth/wesnoth/commit/b3b4f97cf1f3bbd47bb386d4d8d996fb4583a18d
20190211 19:48:06< irker618> wesnoth: Lovens Weche wesnoth:master 7976d69973e9 / data/tools/wesnoth/wmlparser3.py: Merge pull request #3911 from LovCAPONE/bug_3903_fix https://github.com/wesnoth/wesnoth/commit/7976d69973e972155beaf73e5fb678d23d8c834d
20190211 20:48:08< irker618> wesnoth/wesnoth:master Lovens Weche edd5c976f2 Fix wmlparser3 creation unnecessary attr AppVeyor: vs2017/Release Failed
20190211 20:48:09< irker618> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/22282705
20190211 21:14:37< irker618> wesnoth/wesnoth:master newfrenchy83 89edcb97c7 Update abilities.cpp AppVeyor: 1/4 builds failed
20190211 21:14:37< irker618> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22278125
20190211 21:17:58-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has joined #wesnoth-dev
20190211 21:54:59<+wesdiscordbot> <Konrad2> Thanks to all of you for the time you've put into working on Wesnoth, fixing it and keeping it alive so players can enjoy it.
20190211 22:02:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20190211 22:20:07-!- LovCAPONE [LovCAPONE@gateway/vpn/privateinternetaccess/lovcapone] has quit [Quit: Life is like a void pointer: you never know what you're going to get...]
20190211 22:54:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20190211 23:09:56-!- valdar [~atarocch@93.56.172.28] has quit [Ping timeout: 250 seconds]
20190211 23:13:10-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev
20190211 23:26:07< irker618> wesnoth/wesnoth:master newfrenchy83 f1dda71393 Update abilities.cpp AppVeyor: vs2017/Release Failed
20190211 23:26:08< irker618> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/22286052
20190211 23:40:30-!- vn971_ [~quassel@2a02:7aa0:1619::bac5:9483] has joined #wesnoth-dev
20190211 23:42:36-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20190211 23:45:17-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20190211 23:46:49-!- Netsplit *.net <-> *.split quits: nurupo, vn971
20190211 23:46:49-!- nurupo_ is now known as nurupo
--- Log closed Tue Feb 12 00:00:15 2019