--- Log opened Sun Feb 24 00:00:31 2019 20190224 00:20:33<+wesdiscordbot> This post-release silence… scary 20190224 00:31:29< irker502> wesnoth: Charles Dang wesnoth:1.14 1dda95ef6010 / Doxyfile changelog.md src/wesconfig.h: Post-release version bump https://github.com/wesnoth/wesnoth/commit/1dda95ef601029585528bfa049e3cf85b71bbc32 20190224 00:31:50<+wesdiscordbot> oi where did the tag go :thonk: 20190224 00:34:34<+wesdiscordbot> well that's odd 20190224 00:36:23<+wesdiscordbot> ... 20190224 00:36:28<+wesdiscordbot> ok that's not whta i wanted to do 20190224 00:36:30<+wesdiscordbot> what the fuck 20190224 00:38:55< irker502> wesnoth: Vultraz wesnoth: fb522fd923c7 tagged as 1.14.6 20190224 00:38:58<+wesdiscordbot> there 20190224 00:39:12<+wesdiscordbot> I had accidentally created a branch locally and not a tag 😬 20190224 00:39:18<+wesdiscordbot> @Packagers 1.14.6 tagged 20190224 01:02:52<+wesdiscordbot> @Vultraz does this mean I can start merging DiD? 20190224 01:03:15<+wesdiscordbot> into the 1.14 branch I mean 20190224 01:03:35<+wesdiscordbot> MERGE. ALL THE THINGS 20190224 01:03:44<+wesdiscordbot> 👀 20190224 01:17:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190224 01:18:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190224 01:19:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190224 01:23:13< irker502> wesnoth: Severin Glöckner wesnoth:1.14 b37ad05d87d2 / data/campaigns/Under_the_Burning_Suns/scenarios/03_Stirring_in_the_Night.cfg: UtBS: change textdomain https://github.com/wesnoth/wesnoth/commit/b37ad05d87d21991a5b316fdd13474ee8436148a 20190224 01:23:15< irker502> wesnoth: Severin Glöckner wesnoth:1.14 63d55d240855 / data/core/units/monsters/Fire_Dragon.cfg: Help: remove space between sprite and text for Fire Dragon https://github.com/wesnoth/wesnoth/commit/63d55d2408551f115bd40cd9de297caabb22ea92 20190224 02:04:14< irker502> wesnoth: doofus-01 wesnoth:1.14 da4afc7aae61 / / (70 files in 14 dirs): Some sprite animations (#3896) https://github.com/wesnoth/wesnoth/commit/da4afc7aae61685fa5e93afdc92d3e5a2b08fb3d 20190224 02:55:43-!- travis-ci [~travis-ci@ec2-54-234-95-175.compute-1.amazonaws.com] has joined #wesnoth-dev 20190224 02:55:44< travis-ci> wesnoth/wesnoth#20946 (1.14.6 - fb522fd : Charles Dang): The build passed. 20190224 02:55:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/497631850 20190224 02:55:44-!- travis-ci [~travis-ci@ec2-54-234-95-175.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190224 03:34:25< celticminstrel> MERGE ALL THE THINKS 20190224 03:34:53< celticminstrel> https://github.com/wesnoth/wesnoth/pull/3897 20190224 03:36:17< celticminstrel> That one for example. Maybe not right this minute, not certain if it's ready, but. 20190224 03:37:49<+wesdiscordbot> So if you need to release 1.14.7 immediately because it turns out there's a critical bug that makes the AI deadlock every Tuesday afternoon you're just going to have to skip the pot update, got it 20190224 03:38:13<+wesdiscordbot> To clarify, back in my days we'd not lift the string freeze until the release was actually published 20190224 03:38:23< celticminstrel> Ah, right, I guess merging string changes immediately after a release isn't the best idea. 20190224 03:38:54< celticminstrel> Maybe hold off on merging anything big, really. Small things should be fine though. 20190224 04:57:13< irker502> wesnoth/wesnoth:master Severin Glöckner 034618a33d Help: remove space between sprite and te AppVeyor: All builds passed 20190224 07:14:01<+wesdiscordbot> in that case, @Vultraz can we push back the 1.14.7 string freeze a week or so? 20190224 07:14:37<+wesdiscordbot> I have midterms this week and I'm not totally sure if I'll be able to chck over all of my PRs before march 2nd or 3rd 20190224 07:29:45-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190224 07:34:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190224 07:52:49< irker502> wesnoth/wesnoth:1.14.6 Charles Dang fb522fd923 Pre-release version bump AppVeyor: All builds passed 20190224 08:01:02<+wesdiscordbot> sure 20190224 08:03:10<+wesdiscordbot> 10th it is 20190224 09:00:46<+wesdiscordbot> @Vultraz it seems steam wants all partners to agree to new eula 20190224 09:01:52<+wesdiscordbot> Oh? 20190224 09:02:14<+wesdiscordbot> "Please contact the user who has Actual Authority privileges for your organization on Steamworks (this is usually the person who completed the initial paperwork with Valve) and have them visit ... to complete the agreement. 20190224 09:04:58<+wesdiscordbot> I'm not seeing anything 🤔 20190224 09:05:49<+wesdiscordbot> no new notifs on the account 20190224 09:06:25<+wesdiscordbot> it's on main page of partner.steamgames.com 20190224 09:06:42<+wesdiscordbot> home tab 20190224 09:07:23<+wesdiscordbot> oh there it is 20190224 09:08:36<+wesdiscordbot> and nothing can be uploaded until I deal with this? 20190224 09:11:41<+wesdiscordbot> it can I think 20190224 09:11:50<+wesdiscordbot> you just can't create new apps 20190224 09:11:56<+wesdiscordbot> I think it can wait 20190224 09:12:04<+wesdiscordbot> if it prevents me from uploading I'll tell 20190224 09:12:07<+wesdiscordbot> but it's unlikely 20190224 09:15:01<+wesdiscordbot> alright 20190224 09:16:11<+wesdiscordbot> let me know 20190224 09:25:52-!- TheJJ [~rofl@ipbcc0608f.dynamic.kabel-deutschland.de] has quit [Ping timeout: 245 seconds] 20190224 09:26:10-!- TheJJ [~rofl@ipbcc08c2e.dynamic.kabel-deutschland.de] has joined #wesnoth-dev 20190224 09:30:58<+wesdiscordbot> @Vultraz @loonycyborg I was able to upload package to steam 20190224 09:35:11<+wesdiscordbot> good, good 20190224 09:50:50<+wesdiscordbot> does anyone feel like going through SpellingMistakes for 1.14.7? There's a number of fixes there waiting to be merged 20190224 09:54:49< irker502> wesnoth/wesnoth:1.14 doofus-01 da4afc7aae Some sprite animations (#3896) AppVeyor: All builds passed 20190224 10:02:46<+wesdiscordbot> maybe @Yumi can as part of https://github.com/wesnoth/wesnoth/issues/3906 ? 20190224 10:35:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190224 12:16:06< irker502> wesnoth: josteph wesnoth:master 08c469561ca8 / images/icons/profiles/blade.png images/icons/profiles/blades.png src/reports.cpp: Sidebar: Show attack range and damage type icons https://github.com/wesnoth/wesnoth/commit/08c469561ca8b9dc90307fd97f32bfad599eec29 20190224 12:16:08< irker502> wesnoth: josteph wesnoth:master 9296158e04d2 / src/reports.cpp: Sidebar: Add some vertical padding after attacks that have specials. https://github.com/wesnoth/wesnoth/commit/9296158e04d2ec934c1c46f9eeb2f3f57ef098d3 20190224 12:36:28< Ivanovic> @Vultraz did you update the doc files and rerun a pot-update before release? 20190224 12:36:54<+wesdiscordbot> Loony did so 20190224 12:36:56< Ivanovic> (the manpages and manual have to be updated manually) 20190224 12:37:38< Ivanovic> ah, okay, perfect 20190224 12:38:21< Ivanovic> btw what is the plan for moving towards master? 20190224 12:38:53< Ivanovic> considering that 1.14.0 was ages ago it might make sense to start "real" efforts in master incl running a pot-update and stuff like that 20190224 12:39:29< Ivanovic> (I was for example surprised to see a major rewrite happen to a campaign in stable instead of in master and instead pushing for a new major release sooner) 20190224 12:54:26<+wesdiscordbot> There aren't that many changes in 1.15 to warrant a long dev series 20190224 12:55:49<+wesdiscordbot> I'm considering a very short (~3 months or less) dev cycle to fix any bugs that might have cropped back up during the rollback, and then releasing 1.16 with minimal changes over 1.14. 20190224 12:59:39<+wesdiscordbot> right now the most active areas are the Haldric prototype, campaign changes (Yumi and Sevu), and general fixes (jostephd). But there isn't really any big project lined up for a dev series. 20190224 13:01:43<+wesdiscordbot> campaign changes are acceptable for 1.14 20190224 13:03:43<+wesdiscordbot> @Vultraz there's Wings of Victory 20190224 13:04:03<+wesdiscordbot> that would be one reason to have a 1.16 20190224 13:04:15<+wesdiscordbot> but it's not something that requires 3 years of 1.15 😛 20190224 13:04:29<+wesdiscordbot> yeah, we shouldn't have a three years release cycle 20190224 13:04:45<+wesdiscordbot> 1.13 was around 3 years 20190224 13:04:49<+wesdiscordbot> about campaign changes by the way, I feel the new TSG/DiD could've been shipped as "official addons" if we wanted to 20190224 13:04:59<+wesdiscordbot> 1.12 came out in October 2014 and 1.14 in May 2018 20190224 13:05:10<+wesdiscordbot> nemaara already uploaded them as addons, literally all we'd have needed would have been to mark them as official in the description 20190224 13:05:33<+wesdiscordbot> yeah, so when would 1.16 be aimed for ? 20190224 13:05:52<+wesdiscordbot> like i said, 1.15 would maybe be ~3 months 20190224 13:06:05<+wesdiscordbot> starting when? 20190224 13:06:23<+wesdiscordbot> you mean, three months of stabilization/beta ? 20190224 13:06:55<+wesdiscordbot> well if WoV is coming, might as well get 1.15.0 out once its in. I don't know what's been going on on that front. I only heard mention of it again recently. 20190224 13:07:18<+wesdiscordbot> I didn't even realize it was still being worked on as a candidate for inclusion 20190224 13:07:59<+wesdiscordbot> @sigurdfd has been working on it 20190224 13:08:20<+wesdiscordbot> there were a bunch of commits to WoV.git over the weekend 20190224 13:08:31<+wesdiscordbot> https://github.com/sigurdfdragon/Wings_of_Victory/commits/master 20190224 13:08:57<+wesdiscordbot> that plan - start beta once WoV is in - sounds good to me, +1 20190224 13:09:24<+wesdiscordbot> while you're here vultraz have you seen my ping this morning ? 20190224 13:09:28<+wesdiscordbot> on github 20190224 13:09:37<+wesdiscordbot> Yeah. 20190224 13:10:16<+wesdiscordbot> it's a crash bug, I'd like to get it fixed in .7 20190224 13:10:30<+wesdiscordbot> turns out I don't know the fix 😬 20190224 13:11:13<+wesdiscordbot> could you at least explain why the PR is wrong? 20190224 13:11:19<+wesdiscordbot> so I know better for next time 20190224 13:14:15<+wesdiscordbot> I thought it had something to do with moving nodes between parent nodes, and that something in that implementation didn't get copied over, but it's neither of those things. 20190224 13:15:08<+wesdiscordbot> I see 20190224 13:15:29<+wesdiscordbot> Yes, if we could find the reason this originally worked that would be better than re-solving the problem 20190224 13:15:43<+wesdiscordbot> Which crash are you talking about? 20190224 13:16:32<+wesdiscordbot> @jyrkive https://github.com/wesnoth/wesnoth/issues/3849 and the PR #3853 for it 20190224 13:18:14<+wesdiscordbot> Ah, right, that crash. 20190224 13:19:01<+wesdiscordbot> Well, if the code used to work earlier, it must mean that the UI object was created somewhere before on_team_select() was called. 20190224 13:19:20<+wesdiscordbot> it's possible it didn't work 20190224 13:19:26<+wesdiscordbot> and i didn't catch the edge case 20190224 13:22:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190224 13:29:03<+wesdiscordbot> So how to proceed? 20190224 13:29:17<+wesdiscordbot> does the proposed fix work? 20190224 13:29:38<+wesdiscordbot> It did when I made the PR 20190224 14:02:32<+wesdiscordbot> I presume it still works with current 1.14. 20190224 14:06:46<+wesdiscordbot> @josteph The fix for the text domains works. 😮 20190224 14:08:46<+wesdiscordbot> @Konrad2 thanks 😃 20190224 14:09:11<+wesdiscordbot> That's something I've got to thank you for. xD 20190224 14:11:25<+wesdiscordbot> You're welcome. 😄 20190224 14:11:47<+wesdiscordbot> It was an interesting bug. 20190224 14:27:03<+wesdiscordbot> EI - The Crossing 20190224 14:27:14<+wesdiscordbot> Why does Dacyn not need to cross the river? 20190224 14:34:00<+wesdiscordbot> And regarding the feedback topic of Eastern Invasion: Every scenario from the 8th scenario onwards has the wrong number (true number + 1). And the 8th scenario has the wrong name (probably an old name). 20190224 14:34:18<+wesdiscordbot> *scenario developement topic 20190224 14:54:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190224 15:09:48-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer] 20190224 15:17:20-!- irker502 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190224 16:07:22-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190224 16:10:22-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 268 seconds] 20190224 16:31:54<+wesdiscordbot> @Pentarctagon @josteph some of those typos aren't really "typos" that I would fix, but since josteph has already dealt with them, I guess it's fine 20190224 17:12:21-!- irker316 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190224 17:12:21< irker316> wesnoth: josteph wesnoth:master e4cb8efc03d7 / data/themes/_initial.cfg: Theme: Remove the empty replay-label from the replay theme. https://github.com/wesnoth/wesnoth/commit/e4cb8efc03d7d20cc403180ec224e4aa1ef638ea 20190224 17:12:52< irker316> wesnoth: josteph wesnoth:1.14 56eb5c7bc913 / data/themes/_initial.cfg: Theme: Remove the empty replay-label from the replay theme. https://github.com/wesnoth/wesnoth/commit/56eb5c7bc913726b72501691a2935bb50190bb64 20190224 17:43:31<+wesdiscordbot> @josteph Thanks for reviewing. I tried not to include places where there was just a question of style. In "ford of Abez" for example, that was literally the only instance in mainline of a lowercase 'f' in that phrase, all others use capital 'F'. 20190224 17:43:40<+wesdiscordbot> @Yumi ^ 20190224 17:48:16<+wesdiscordbot> yea 20190224 17:48:30<+wesdiscordbot> that's fine 20190224 17:50:13< irker316> wesnoth/wesnoth:master josteph c385601666 Typo fixes AppVeyor: All builds passed 20190224 18:32:25<+wesdiscordbot> @Yumi Are the DiD changes safe for players upgrading 1.14.6->1.14.7 between scenarios? 20190224 19:01:44<+wesdiscordbot> meaning do start of scenario saves still work? 20190224 19:01:47<+wesdiscordbot> answer should be yes 20190224 19:03:42<+wesdiscordbot> hmm 20190224 19:03:57<+wesdiscordbot> there might be something finnicky that happens between S7 and S8 but I'll check that when I do my final pass through 20190224 19:04:59<+wesdiscordbot> I meant, what happens if someone is playing S7 on 1.14.6, upgrades to 1.14.7, then loads their middle-of-scenario save and wins and starts S8 20190224 19:06:02<+wesdiscordbot> right, I think that might cause a small problem in that guards may not spawn for S8 or they'll get an WML error 20190224 19:06:06<+wesdiscordbot> but it won't be gamebreaking 20190224 19:06:10<+wesdiscordbot> guards as in the pursuers 20190224 19:08:46<+wesdiscordbot> well, if it's playable I suppose it's fine. But this is exactly why campaign changes in a stable release are seen as unorthodox 20190224 19:08:56<+wesdiscordbot> (ref discussion this morning) 20190224 19:11:28<+wesdiscordbot> at the same time, if we keep waiting for the right time to do them, they'll never get done 20190224 19:12:45<+wesdiscordbot> I'm not suggesting to postpone the rewrites. 20190224 19:13:04<+wesdiscordbot> I'm just trying to agree with Ivanovic who said campaign rewrites are better done in 1.15 than .14 20190224 19:13:46<+wesdiscordbot> part of this is my fault, I'm not really very patient 20190224 19:14:18<+wesdiscordbot> so I'd be less likely to do them when 1.15/1.16 have unknown release dates "sometime in the future" 20190224 19:14:18< irker316> wesnoth: josteph wesnoth:master 97ca22e94bf2 / src/reports.cpp: UI: Prefix tooltips with what kind of information they show https://github.com/wesnoth/wesnoth/commit/97ca22e94bf2c4d5b35ff005ffb5c16f5862a5cc 20190224 19:14:20< irker316> wesnoth: josteph wesnoth:master ce75665ae56f / src/reports.cpp: Sidebar: Add jamming to the vision tooltip. https://github.com/wesnoth/wesnoth/commit/ce75665ae56fc4dc89ed446754d782f4f5e6f6bd 20190224 19:14:43<+wesdiscordbot> 1.16 will be three months after WoV merge 20190224 19:15:05<+wesdiscordbot> about DiD, two options, I think. Either keep DiD rewrite in 1.15 and then it'll be released even sooner 20190224 19:15:31<+wesdiscordbot> or merge DiDr to 1.14 but alongside DiD-1.14.6 rather than instead of 20190224 19:15:46<+wesdiscordbot> I mean, two options besides "replace DiD with DiDr in 1.14" 20190224 19:18:08<+wesdiscordbot> not my call 20190224 19:18:35<+wesdiscordbot> 1.14.6 is released already I think? 20190224 19:21:01< irker316> wesnoth: josteph wesnoth:1.14 db8a33baa4b5 / src/reports.cpp: UI: Prefix tooltips with what kind of information they show https://github.com/wesnoth/wesnoth/commit/db8a33baa4b5a5ec4e5cf8d915edef6c5b527c53 20190224 19:21:03< irker316> wesnoth: josteph wesnoth:1.14 8ee6ed786cc4 / src/reports.cpp: Sidebar: Add jamming to the vision tooltip. https://github.com/wesnoth/wesnoth/commit/8ee6ed786cc42defb0bc20d3a3b5891479d5ddea 20190224 19:21:05< irker316> wesnoth: josteph wesnoth:1.14 3bfb4892c4ff / changelog.md: Add #3327 to changelog https://github.com/wesnoth/wesnoth/commit/3bfb4892c4ff712555e78085d88b0bfe2e14f710 20190224 19:21:16<+wesdiscordbot> yeah 20190224 19:21:19<+wesdiscordbot> yes 20190224 19:21:23<+wesdiscordbot> so it would either be put in 1.14.7 or 1.15 20190224 19:21:26<+wesdiscordbot> but I meant, 1.14.7 could have two copies if DiD 20190224 19:21:38<+wesdiscordbot> I don't think that's a good idea 20190224 19:21:39<+wesdiscordbot> both DiD (as in .6) and DiDr (as in the addon) 20190224 19:21:51<+wesdiscordbot> why? 20190224 19:23:53<+wesdiscordbot> to me, as a player 20190224 19:24:13<+wesdiscordbot> it would look extremely weird to ship two official versions of the same campaign with the difference being that one is revised from the other 20190224 19:24:24<+wesdiscordbot> especially if my old save works on the new version and is playable 20190224 19:26:22<+wesdiscordbot> either way, it's really @Vultraz's decision as to where the revised DiD gets shipped 20190224 19:26:30<+wesdiscordbot> I don't think players are going to try using old save on new version 20190224 19:26:31<+wesdiscordbot> I don't have a preference 20190224 19:26:36<+wesdiscordbot> really? 20190224 19:26:44<+wesdiscordbot> I do that all the time for the games I play 20190224 19:26:52<+wesdiscordbot> you have push access 20190224 19:26:53<+wesdiscordbot> maybe it's just me 20190224 19:26:56<+wesdiscordbot> I don't think you're representative 20190224 19:27:11<+wesdiscordbot> and anyway... if players edit the campaign id in their savefiles, I don't care if it works or not 20190224 19:27:17<+wesdiscordbot> you shipped revised TSG 20190224 19:27:21<+wesdiscordbot> why not revised DID 20190224 19:27:35<+wesdiscordbot> yes, but I've been a player for much much longer than I have worked on any amount of code 20190224 19:27:50<+wesdiscordbot> @Vultraz because it's a stable release. Because if a player plays S7 on 1.14.6 and S8 on 1.14.7 it might not work 20190224 19:27:55<+wesdiscordbot> that doesn't answer my question 20190224 19:27:55<+wesdiscordbot> and we don't want to spend developer time on figuring out whether it would work 20190224 19:28:00<+wesdiscordbot> yes, these considerations applied to TSG too 20190224 19:28:03<+wesdiscordbot> well I'm not doing anything else in the meantime 20190224 19:28:04<+wesdiscordbot> 20/20 hindsight 20190224 19:28:04<+wesdiscordbot> on wesnoth 20190224 19:28:11<+wesdiscordbot> so it's not anyone else's time 20190224 19:28:14<+wesdiscordbot> 😮 20190224 19:28:19<+wesdiscordbot> I say just shit up 20190224 19:28:22<+wesdiscordbot> er 20190224 19:28:25<+wesdiscordbot> ship it 20190224 19:28:29<+wesdiscordbot> lol 20190224 19:28:30<+wesdiscordbot> sorry 😂 20190224 19:28:36<+wesdiscordbot> 😂 20190224 19:28:42<+wesdiscordbot> I like that extra win condition in DiD last scenario 20190224 19:28:47<+wesdiscordbot> I see the gambit influence 20190224 19:29:05<+wesdiscordbot> has subconsciously affected you 20190224 19:29:25<+wesdiscordbot> the horror! 20190224 19:29:29<+wesdiscordbot> :bowman: 20190224 19:29:30<+wesdiscordbot> I would prefer to take @Yumi 's addon, which is the revised campaign under a new campaign id, and shipped that in 1.14 20190224 19:29:50<+wesdiscordbot> that way the content gets out there, without concerns about breakages to some players 20190224 19:30:08<+wesdiscordbot> it makes no sense to ship two versions of the same campaign 20190224 19:30:45<+wesdiscordbot> then either ship it in 1.15, or someone needs to go through the changes and ensure upgrades won't break anything 20190224 19:31:02<+wesdiscordbot> I love new campaigns as much as anybody but we need to be careful not to break anything or all the hard work will be eclipsed by that 20190224 19:32:28<+wesdiscordbot> but that was what I was intending to do 20190224 19:32:33<+wesdiscordbot> just not at this moment 20190224 19:32:35<+wesdiscordbot> 0_0 20190224 19:33:27<+wesdiscordbot> yes, I understand. Just brainstorming. 20190224 19:34:00<+wesdiscordbot> as far as middle of scenario saves go, they won't break during the scenario because they use the entirety of the old scenario 20190224 19:34:11<+wesdiscordbot> so the only problem happens when there's code/variables that are carried over between scenarios 20190224 19:34:19<+wesdiscordbot> the only place that happens is between S7 and S8 20190224 19:34:28<+wesdiscordbot> (and from S1, the malin_used_necromancy one, but that was there before) 20190224 19:35:05<+wesdiscordbot> you get Xanthric in S11, but even if you don't, it doesn't break S12, he simply won't spawn 20190224 19:35:14<+wesdiscordbot> so I think the only place I need to check more carefully is S7-8 20190224 19:35:16<+wesdiscordbot> what about balancing? 20190224 19:35:25<+wesdiscordbot> old S3/S4 basically set up you for mass ghosts 20190224 19:35:32<+wesdiscordbot> new S3 gives you Revenants 20190224 19:35:51<+wesdiscordbot> overall there are less enemies than before, so if you use an old save on the new DiD, you'll probably find it too easy 20190224 19:36:26<+wesdiscordbot> that's still a bug in my book 😃 20190224 19:36:31<+wesdiscordbot> but whatever, I think I've made myself clear enough 20190224 19:36:31<+wesdiscordbot> I feel fine living with that 20190224 19:36:40<+wesdiscordbot> I think that much is acceptable, too. 20190224 19:37:15<+wesdiscordbot> you did remind me, I think someone said that the new version is a tad bit hard, so I have to look to reduce income on easier difficulties.. 20190224 19:50:55< irker316> wesnoth/wesnoth:master josteph 9296158e04 Sidebar: Add some vertical padding after AppVeyor: All builds passed 20190224 20:04:47<+wesdiscordbot> what's the difference between wb::future_map and wb::future_map_is_active? 20190224 20:05:28<+wesdiscordbot> in other words, when does resources::whiteboard->is_active() == false? 20190224 20:06:04<+wesdiscordbot> as opposed to resources::whiteboard itself being false 20190224 20:09:42<+wesdiscordbot> I'm guessing resources::whiteboard is available when one is the player but not when one is watching a replay? 20190224 20:09:55<+wesdiscordbot> AFAIK, resources::whiteboard is almost never null (barring the editor, early startup, etc.). 20190224 20:10:18<+wesdiscordbot> And is_active() returns false whenever the player isn't in planning mode. 20190224 20:10:46<+wesdiscordbot> So, std::future_map and std::future_map_if_active are practically equivalent, then? 20190224 20:10:55<+wesdiscordbot> The only difference between them is an is_active() check. 20190224 20:11:01<+wesdiscordbot> (in the constructors) 20190224 20:12:23<+wesdiscordbot> Trying to fix https://github.com/wesnoth/wesnoth/issues/3763 20190224 20:13:23<+wesdiscordbot> Err, sorry, they're not "equivalent", of course. 20190224 20:14:04<+wesdiscordbot> I meant, practically there are only two states then, is_active() == true and is_active() == false, so I don't need to worry about the ! resources::whiteboard state, which is the difference between the two RAII classes. 20190224 20:22:19< celticminstrel> I doubt anyone here actually understands the whiteboard. >_> 20190224 20:23:23< celticminstrel> But it's good that someone's working on it. 20190224 20:24:13<+wesdiscordbot> didn't gfgtdf fix it up a bunch at one point? 20190224 20:24:27< celticminstrel> Possibly? 20190224 20:24:50< celticminstrel> Did the bug with Suppose Dead (IIRC) ever get fixed though? 20190224 20:25:28< celticminstrel> Or maybe it was something about recruiting that I remember... whatever it was, it was disabled because it caused crashes or something. 20190224 20:26:56<+wesdiscordbot> suppose dead is disabled 20190224 20:26:57<+wesdiscordbot> the irony: https://www.wesnoth.org/forum/viewtopic.php?f=6&t=43898&start=30#p596901 20190224 20:29:12-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190224 20:32:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190224 20:34:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190224 21:18:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20190224 21:49:31<+wesdiscordbot> @loonycyborg @Vultraz Did any of you send an email out for packagers? 20190224 21:50:08<+wesdiscordbot> 🎉 https://itunes.apple.com/cz/app/the-battle-for-wesnoth/id1450738104?mt=12 20190224 21:50:53<+wesdiscordbot> I did just now 😛 20190224 21:55:33<+wesdiscordbot> .. 20190224 21:56:00< irker316> wesnoth/wesnoth:master josteph 5dcb608bb4 Help: Show damage type and range icons i AppVeyor: All builds passed 20190224 21:56:13<+wesdiscordbot> You know that emote is normally associated to playful or sarcastic remarks right? 20190224 21:56:35<+wesdiscordbot> There's nothing particularly funny about people losing track of what's supposed to be done during the release process 20190224 21:56:54<+wesdiscordbot> This emote is currently associated with remarks done by loonycyborg 20190224 21:57:22<+wesdiscordbot> Yeah, sure, except it's not 20190224 21:57:22<+wesdiscordbot> hmm 20190224 21:57:37<+wesdiscordbot> I think there should be a way to send email from script too 20190224 21:57:51<+wesdiscordbot> You could probably do that if you want yeah 20190224 21:57:53<+wesdiscordbot> but I don't have command line email clients 20190224 21:58:08<+wesdiscordbot> oof 20190224 21:58:58<+wesdiscordbot> Also @Vultraz Tad_Carlucci is whining on the forums about you not posting the release notes on Steam asap 20190224 22:21:42<+wesdiscordbot> oh for fuck's sake 20190224 22:24:24<+wesdiscordbot> @shadowm can you give me the BBCode output 20190224 22:25:22<+wesdiscordbot> I hope some day you learn to run it on your own 20190224 22:26:39<+wesdiscordbot> https://gist.github.com/shikadiqueen/48c27e23a9269c17ec3358d18854173e 20190224 22:29:40<+wesdiscordbot> there now he can stop complaining 20190224 22:30:16<+wesdiscordbot> Or you could not give him the chance :3 20190224 22:30:58<+wesdiscordbot> it's been less than 24 hours 20190224 22:31:15<+wesdiscordbot> dude has no patience 20190224 22:32:34<+wesdiscordbot> relatedly, is there going to be an announcement put up on the forums for 1.14.6? 20190224 22:33:12<+wesdiscordbot> I literally just remembered that was a thing 20190224 22:33:14<+wesdiscordbot> 😬 20190224 22:33:26<+wesdiscordbot> prepares to be murdered by shadowm 20190224 22:33:36<+wesdiscordbot> ... 20190224 22:33:42< celticminstrel> ... 20190224 22:33:43<+wesdiscordbot> >.> 20190224 22:34:27<+wesdiscordbot> hey it's been Many Months 20190224 22:36:40<+wesdiscordbot> ... 20190224 22:38:17< celticminstrel> ... 20190224 23:06:11< irker316> wesnoth/wesnoth:master josteph 148aacb209 Help: Show damage type and range icons i AppVeyor: All builds passed 20190224 23:19:44< irker316> wesnoth: doofus-01 wesnoth:master 915cdf93b7ef / data/core/ (69 files in 13 dirs): some basic animations - forwardporting PR#3896 https://github.com/wesnoth/wesnoth/commit/915cdf93b7efbc186f436aa8e6a2ede6862a0ab8 20190224 23:43:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] --- Log closed Mon Feb 25 00:00:32 2019