--- Log opened Sun Feb 24 00:00:31 2019 20190224 00:04:54-!- Haudegen [~quassel@178.115.237.87.static.drei.at] has quit [Read error: Connection reset by peer] 20190224 00:14:09-!- pseigo [~pseigo@unaffiliated/pseigo] has joined #wesnoth 20190224 00:40:03-!- pseigo [~pseigo@unaffiliated/pseigo] has quit [Quit: Leaving] 20190224 01:31:24-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20190224 07:29:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth 20190224 08:52:47-!- mthe878 [~mthe@unaffiliated/mthe] has joined #wesnoth 20190224 09:25:52-!- TheJJ [~rofl@ipbcc0608f.dynamic.kabel-deutschland.de] has quit [Ping timeout: 245 seconds] 20190224 09:26:10-!- TheJJ [~rofl@ipbcc08c2e.dynamic.kabel-deutschland.de] has joined #wesnoth 20190224 10:21:07-!- joemaro [~joemaro@113.red-2-142-182.dynamicip.rima-tde.net] has joined #wesnoth 20190224 10:33:10-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20190224 10:33:21-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Client Quit] 20190224 10:37:29-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20190224 11:22:33-!- Haudegen [~quassel@178.115.237.87.static.drei.at] has joined #wesnoth 20190224 11:46:11-!- joemaro_ [~joemaro@46.222.236.111] has joined #wesnoth 20190224 11:49:14-!- joemaro [~joemaro@113.red-2-142-182.dynamicip.rima-tde.net] has quit [Ping timeout: 255 seconds] 20190224 11:58:14<+wesdiscordbot> When will steam update my wesnoth? 😦 20190224 12:04:12-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20190224 12:05:41-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20190224 12:18:10-!- joemaro_ [~joemaro@46.222.236.111] has quit [Ping timeout: 246 seconds] 20190224 12:35:03<+wesdiscordbot> working on it atm 20190224 12:40:05<+wesdiscordbot> Thanks. 😃 20190224 13:53:34<+wesdiscordbot> done 20190224 14:05:34<+wesdiscordbot> Thanks. 😮 20190224 14:42:46-!- mthe878 [~mthe@unaffiliated/mthe] has quit [Ping timeout: 272 seconds] 20190224 14:58:20<+wesdiscordbot> sigh, still no fix for that decimal separator glitch 20190224 14:58:54<+wesdiscordbot> ? 20190224 15:00:21<+wesdiscordbot> there's a glitch that happens if your system decimal separator is set to ',' that breaks all functions that have decimal values, like most animations and the zoom 20190224 15:00:24<+wesdiscordbot> at least on win7 20190224 15:01:41-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20190224 15:01:59<+wesdiscordbot> has it been reported somewhere? 20190224 15:02:36<+wesdiscordbot> not sure, i assumed it had been, since several of us had been having the issue since 1.14 was released 20190224 15:03:02<+wesdiscordbot> it's the same thing that caused the 1 pixel high health and experience bar issue 20190224 15:03:26-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20190224 15:04:04<+wesdiscordbot> and there's at least one thread on the technical issues forum 20190224 15:04:16<+wesdiscordbot> probably more that just haven't been merged 20190224 15:10:30-!- Narrat [~Narrat@p5DED1739.dip0.t-ipconnect.de] has joined #wesnoth 20190224 15:13:46<+wesdiscordbot> system decimal separator?? 20190224 15:14:56<+wesdiscordbot> yes, when reading the files the game considers the decimal separator system setting and interprets all commas as decimal separators 20190224 15:15:09<+wesdiscordbot> what 20190224 15:15:32<+wesdiscordbot> it also truncates all actual decimal values because it doesn't register the '.' as a decimal separator 20190224 15:15:40<+wesdiscordbot> what 20190224 15:15:43<+wesdiscordbot> yes 20190224 15:15:59<+wesdiscordbot> how does that even happen 20190224 15:16:03<+wesdiscordbot> no idea 20190224 15:16:32<+wesdiscordbot> I have absolutely 0 knowledge of the game ever taking specific separator settings into account. 20190224 15:16:43<+wesdiscordbot> unless specified in the source 20190224 15:17:04<+wesdiscordbot> according to, since jostephd called it out in the thread, http://www.cplusplus.com/reference/cstdlib/strtod/: "Parses the C-string str interpreting its content as a floating point number (according to the current locale) ..." 20190224 15:18:50<+wesdiscordbot> there's only one use of strtod in the game... 20190224 15:18:59<+wesdiscordbot> maybe when it converts strings to numbers or something 20190224 15:19:29<+wesdiscordbot> i don't know, it's not something that happnes on linux and i have no idea about win10 either 20190224 15:20:15<+wesdiscordbot> what's your system? 20190224 15:20:19<+wesdiscordbot> win7 20190224 15:20:33<+wesdiscordbot> system language? 20190224 15:21:01<+wesdiscordbot> englishUS 20190224 15:21:03<+wesdiscordbot> doesn't matter 20190224 15:21:23<+wesdiscordbot> this is part of the location setting 20190224 15:21:36<+wesdiscordbot> or the aditional settings 20190224 15:21:38<+wesdiscordbot> looks like it was changed to strtod in https://github.com/wesnoth/wesnoth/commit/81e0a2007f0a01715c067c6b5a6272b8044c1fac#diff-498d06653ad4a59db94a430cfa6f3937 20190224 15:21:52<+wesdiscordbot> and you're running the game in english? 20190224 15:21:58<+wesdiscordbot> yes 20190224 15:22:29<+wesdiscordbot> so where does it get this weird separator 20190224 15:22:37<+wesdiscordbot> it's an aditional setting 20190224 15:22:52<+wesdiscordbot> @Vultraz see https://forums.wesnoth.org/viewtopic.php?f=4&t=48080#p634466 as well 20190224 15:23:12<+wesdiscordbot> because my location is slovenia it sets the decimal separator and digit grouping symbol as the reverse of what it is in US 20190224 15:24:48<+wesdiscordbot> you can change this separately to the location setting, but i don't particularly want to because i don't know how it might affect certain other programs 20190224 15:25:53<+wesdiscordbot> @jyrkive could you weigh in here, this sounds like the kind of thing you might be knowledgeable about 20190224 15:27:46<+wesdiscordbot> (also, what's the difference between std::stod and std::strtod.... 🤔 ) 20190224 15:29:46<+wesdiscordbot> Comma is also the decimal separator here, and the game works just fine for me. 20190224 15:30:08<+wesdiscordbot> Using comma as the decimal separator is so common that if it broke the game, like half of players would be affected. 20190224 15:30:09<+wesdiscordbot> what system? 20190224 15:30:26<+wesdiscordbot> I use Windows 10 and siduction GNU/Linux. 20190224 15:30:42<+wesdiscordbot> and the game works fine when i change the decimal separator to . 20190224 15:30:59<+wesdiscordbot> it might have something to do with win7 or something, i don't know 20190224 15:32:10<+wesdiscordbot> It might indeed by Win7 specific. IIRC, at least some string-to-number implementations on Windows use Windows's built-in functions. 20190224 15:36:33<+wesdiscordbot> I've opened #3945 for it on github, in any case. 20190224 16:04:04-!- mthe878 [~mthe@unaffiliated/mthe] has joined #wesnoth 20190224 16:28:10-!- mthe878 [~mthe@unaffiliated/mthe] has quit [Ping timeout: 244 seconds] 20190224 16:42:55-!- joemaro_ [~joemaro@32.red-2-142-152.dynamicip.rima-tde.net] has joined #wesnoth 20190224 17:19:45<+wesdiscordbot> yo whats Wesnoth getting patched to? 20190224 17:19:47<+wesdiscordbot> on Steam at least 20190224 17:21:15<+wesdiscordbot> 1.14.6 is the new version but well, what got patched in? 20190224 17:21:26<+wesdiscordbot> Bunch of miscellaneous bug fixes. 20190224 17:21:28<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/1.14.6/changelog.md 20190224 17:21:36<+wesdiscordbot> ah 20190224 17:21:49<+wesdiscordbot> Descent Into Darkness: Allow converting L3 necromancers to liches from S12 onwards (issue #3165). Added an alternative method of completing the campaign (issue #3167). S8, S9 (A Small Favor II & III): Clarify objectives. (PR #3711) S8 (A Small Favor II): Fixed units created via the plague ability not available in S9. (PR #3711) 20190224 17:21:56<+wesdiscordbot> soo the alt ending for DiD got patched in 20190224 17:23:08-!- mthe878 [~mthe@unaffiliated/mthe] has joined #wesnoth 20190224 17:36:16-!- mthe878 [~mthe@unaffiliated/mthe] has quit [Ping timeout: 250 seconds] 20190224 18:16:39-!- claymore [~claymore@unaffiliated/claymore] has joined #wesnoth 20190224 18:35:32<+wesdiscordbot> @levstk Can you test a patch if we produce one? 20190224 19:01:35-!- Haudegen [~quassel@178.115.237.87.static.drei.at] has quit [Remote host closed the connection] 20190224 19:26:20-!- Haudegen [~quassel@178.115.237.87.static.drei.at] has joined #wesnoth 20190224 19:50:09-!- mthe878 [~mthe@unaffiliated/mthe] has joined #wesnoth 20190224 20:53:32-!- Tobbi [~Tobbi@supertux/tobbi] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20190224 21:18:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20190224 21:41:00-!- claymore [~claymore@unaffiliated/claymore] has quit [Quit: Leaving] 20190224 22:05:56-!- joemaro- [~joemaro@189.red-37-12-50.dynamicip.rima-tde.net] has joined #wesnoth 20190224 22:07:32-!- joemaro_ [~joemaro@32.red-2-142-152.dynamicip.rima-tde.net] has quit [Ping timeout: 245 seconds] 20190224 22:19:14-!- joemaro- [~joemaro@189.red-37-12-50.dynamicip.rima-tde.net] has quit [Ping timeout: 250 seconds] 20190224 22:36:42-!- mthe878 [~mthe@unaffiliated/mthe] has quit [Ping timeout: 245 seconds] 20190224 22:38:16-!- Tobbi [~Tobbi@supertux/tobbi] has joined #wesnoth 20190224 23:54:30-!- Haudegen [~quassel@178.115.237.87.static.drei.at] has quit [Remote host closed the connection] --- Log closed Mon Feb 25 00:00:32 2019