--- Log opened Fri Mar 01 00:00:17 2019
20190301 00:06:15< irker563> wesnoth: gfgtdf wesnoth:1.14 a281ef045605 / src/display_chat_manager.cpp: fix display chat messages disappearing https://github.com/wesnoth/wesnoth/commit/a281ef045605154a074fe4f8257995a1ccd58606
20190301 00:13:34< irker563> wesnoth/wesnoth:master josteph c01f630384 Sidebar: Allow planning attacks by enemi AppVeyor: 1/4 builds failed
20190301 00:13:35< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22727037
20190301 00:33:09-!- travis-ci [~travis-ci@ec2-54-86-183-29.compute-1.amazonaws.com] has joined #wesnoth-dev
20190301 00:33:10< travis-ci> wesnoth/wesnoth#21015 (1.14 - a281ef0 : gfgtdf): The build has errored.
20190301 00:33:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/500093122
20190301 00:33:10-!- travis-ci [~travis-ci@ec2-54-86-183-29.compute-1.amazonaws.com] has left #wesnoth-dev []
20190301 00:47:40<+wesdiscordbot> <Pentarctagon> @Vultraz Were you going to get around to posting a 1.14.6 release announcement on the forums at some point, or should I just do that tomorrow?
20190301 00:47:47<+wesdiscordbot> <Vultraz> Could you do that
20190301 00:47:54<+wesdiscordbot> <Pentarctagon> ok
20190301 00:52:00< irker563> wesnoth/wesnoth:1.14 gfgtdf a281ef0456 fix display chat messages disappearing AppVeyor: vs2015/Release Failed
20190301 00:52:01< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22735302
20190301 01:21:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20190301 01:38:14< irker563> wesnoth/wesnoth:master nemaara a2f1cd6612 DiD: update dark mage description AppVeyor: 1/2 builds failed
20190301 01:38:15< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22728425
20190301 02:49:09< irker563> wesnoth/wesnoth:master nemaara 9a06126cb2 DiD: update dark mage description AppVeyor: All builds passed
20190301 03:44:36-!- celmin|away is now known as celticminstrel
20190301 04:01:04< irker563> wesnoth/wesnoth:master nemaara 8d1667e41b DiD: add marker to track orcs for S6 AppVeyor: 1/4 builds failed
20190301 04:01:05< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22731980
20190301 04:21:51< celticminstrel> Ugh, Wesnoth added one of the hated "We use cookies" popups that pops up every single time if you have cookies disabled (at least I assume it does; I have them enabled for Wesnoth so I'm not certain).
20190301 04:23:50< irker563> wesnoth/wesnoth:master josteph 2ea692e63b Allow planning enemy moves when whiteboa AppVeyor: 1/4 builds failed
20190301 04:23:51< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22732251
20190301 04:24:14<+wesdiscordbot> <Vultraz> I don't have cookies disabled but i see them on basically every site
20190301 04:24:31< celticminstrel> I think the idea is that they set a cookie to note that you've seen it.
20190301 04:24:42< celticminstrel> So if you have cookies disabled, it'll pop up every single time you visit the site.
20190301 04:24:57<+wesdiscordbot> <Vultraz> just saw the notice on the forums
20190301 04:25:02<+wesdiscordbot> <Vultraz> the cookie notice
20190301 04:25:04< celticminstrel> They should think up some other way to note that you've seen it.
20190301 04:25:13< celticminstrel> Mind you, that's probably not easy...
20190301 04:25:29< celticminstrel> Only way I can think of is storing a list of IP addresses that have seen it, and that's probably not very reliable.
20190301 04:25:49<+wesdiscordbot> <Vultraz> no reason to make things more complicated then necessary
20190301 04:26:16< celticminstrel> Plus it forces it to be server-side code, whereas the cookie version can be implemented purely in client-side JavaScript.
20190301 04:26:43<+wesdiscordbot> <Vultraz> why is this an issue for you
20190301 04:26:52< celticminstrel> So maybe there really isn't a better way... but that doesn't change that it's annoying.
20190301 04:27:02< celticminstrel> It's an issue because I have cookies disabled on most sites.
20190301 04:27:29<+wesdiscordbot> <Vultraz> you just said you have them enabled on the forums
20190301 04:27:35< celticminstrel> (At least it's not as bad as Indigo, which redirects you to a placeholder page and doesn't even let you browse without cookies.)
20190301 04:27:47<+wesdiscordbot> <Vultraz> or you could just enable cookies
20190301 04:28:05< celticminstrel> Why should I enable cookies to browse a public site? That's not reasonable at all.
20190301 04:28:18< celticminstrel> If I wanted to log into the site for something, sure, that's reasonable..
20190301 04:28:28< celticminstrel> (Though technically it can still be done without cookies.)
20190301 04:28:49< celticminstrel> (By encoding the session ID into the query string. phpBB does this if you disable cookies.)
20190301 04:28:52<+wesdiscordbot> <Vultraz> customized experience
20190301 04:29:04< celticminstrel> Maybe I don't want a customized experience.
20190301 04:29:14<+wesdiscordbot> <Vultraz> meh
20190301 04:30:20<+wesdiscordbot> <Vultraz> again, you said you have them enabled on the forums
20190301 04:31:34< celticminstrel> Yeah, so it's not gonna be an annoyance on the forums (heck, I'll probably forget about it by tomorrow), but it bugs me a bit that they've implemented something that bothers me elsewhere on the net.
20190301 04:42:35<+wesdiscordbot> <Vultraz> Isn't transparency better
20190301 04:42:44<+wesdiscordbot> <Vultraz> Also it's probably to be GDPR-compliant or something
20190301 04:43:00< celticminstrel> Sure.
20190301 04:43:24< celticminstrel> The idea of letting us know that you're using cookies is reasonable.
20190301 04:43:45< celticminstrel> Though, it's pretty crazy that you have to rely on the website to explicitly tell you. Why not just make the browser tell you?
20190301 04:43:59<+wesdiscordbot> <Vultraz> I suppose that's an idea
20190301 04:44:14<+wesdiscordbot> <Vultraz> Though, technically, it does
20190301 04:44:28<+wesdiscordbot> <Vultraz> if you click the padlock on Chrome it tells you how many cookies are in use
20190301 04:44:33<+wesdiscordbot> <Vultraz> on that page
20190301 04:45:54< celticminstrel> I mean, the browser could totally be configured to produce a popup functionally identical to the ones that all the websites pop up. If necessary there could even be a way for the website to code stuff into otherwise-invisible metadata that the browser will add to said popup.
20190301 04:46:40< celticminstrel> Even assuming it really needs to be the website's responsibility, it could be done in a way that doesn't cover up the website's content.
20190301 04:46:49<+wesdiscordbot> <Vultraz> That seems like something that could be abused
20190301 04:46:56< celticminstrel> Or it could be configured to automatically disappear if you scroll down a certain amount.
20190301 04:47:28< celticminstrel> Anything can be abused, that's not (by itself) an argument against it.
20190301 04:47:42<+wesdiscordbot> <Vultraz> also that just means EVEN MORE popups
20190301 05:01:49< celticminstrel> BTW @Vultraz you still need to either post the release announcement or find someone else willing to do it.
20190301 05:02:24<+wesdiscordbot> <Vultraz> I asked pent
20190301 05:02:30< celticminstrel> 'kay
20190301 05:05:35<+wesdiscordbot> <jyrkive> celticminstrel: Cookie popups exist because of EU law, so they're unfortunately not optional. 😦
20190301 05:06:17< celticminstrel> Couldn't there be better ways to implement them though?
20190301 05:06:40<+wesdiscordbot> <jyrkive> I doubt it.
20190301 05:06:57< celticminstrel> It's admittedly not (usually) as bad as Indigo, or GitHub's "Look at this new feature!" popups, but... at the very least they could be automatically hidden once you start scrolling down.
20190301 05:07:35< celticminstrel> Also, why are they even needed if you have cookies disabled? If you have cookies disabled, they're not actually setting any cookies.
20190301 05:07:54< celticminstrel> Couldn't it somehow try to detect whether cookies are enabled and only show the popup if they are?
20190301 05:08:10<+wesdiscordbot> <jyrkive> That kind of automatic hiding might just break the law (IANAL, so I don't know if it actually does).
20190301 05:08:27<+wesdiscordbot> <jyrkive> I'm not sure if it's possible to detect that cookies are disabled.
20190301 05:09:18< celticminstrel> IIRC trying to set a cookie (or at least local storage data) without cookies enabled will throw an exception (SecurityError or something like that).
20190301 05:09:28<+wesdiscordbot> <jyrkive> Didn't the cookie speccification originate from 1997 or something? It was way before anyone had really thought that users might want to disable them, or that websites might need to know that they're disabled.
20190301 05:09:43< celticminstrel> I might be getting confused with something else though, I guess.
20190301 05:09:50< celticminstrel> It's true that it's really old, sure.
20190301 05:10:40 * celticminstrel googles it; apparently it is indeed possible to detect if cookies are enabled.
20190301 05:10:50< celticminstrel> (Provided you at least have JavaScript enabled.)
20190301 05:11:02< celticminstrel> (Pretty sure the popups wouldn't even work if you disabled JS though.)
20190301 05:11:37< irker563> wesnoth: nemaara wesnoth:master 07e9a065cc88 / data/campaigns/Descent_Into_Darkness/maps/06_Return_to_Parthyn.map: DiD S6: updated map https://github.com/wesnoth/wesnoth/commit/07e9a065cc8893c53853da99f484b403e850f65a
20190301 05:11:39< irker563> wesnoth: nemaara wesnoth:master ca0992545366 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: updated scenario https://github.com/wesnoth/wesnoth/commit/ca0992545366ac99dab846f313a7ddf60323c2e3
20190301 05:11:41< irker563> wesnoth: nemaara wesnoth:master 5877c7882742 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: updated music https://github.com/wesnoth/wesnoth/commit/5877c7882742cd274d234ff782bca94e6266cd54
20190301 05:11:43< irker563> wesnoth: nemaara wesnoth:master d61ae1b61584 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: modified dialogue https://github.com/wesnoth/wesnoth/commit/d61ae1b615845944d837675c1c02704f71d5d511
20190301 05:11:45< irker563> wesnoth: nemaara wesnoth:master a217c1024181 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: gameplay rebalance https://github.com/wesnoth/wesnoth/commit/a217c1024181530e56540273247123f30f227a04
20190301 05:11:47< irker563> wesnoth: nemaara wesnoth:master 6a20d910858c / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: added missing space https://github.com/wesnoth/wesnoth/commit/6a20d910858cac21fe093349c4b4602c416c6b40
20190301 05:11:49< irker563> wesnoth: nemaara wesnoth:master c68dbbfb503e / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: added dialogue https://github.com/wesnoth/wesnoth/commit/c68dbbfb503e01808ddf0535fe2bf0f661aae1ab
20190301 05:11:51< irker563> wesnoth: nemaara wesnoth:master f814be4420a5 / data/campaigns/Descent_Into_Darkness/utils/bigmap.cfg: DiD: updated bigmap for S6 https://github.com/wesnoth/wesnoth/commit/f814be4420a57da41db95a7e875e2bb5206e914e
20190301 05:11:53< irker563> wesnoth: nemaara wesnoth:master 084c6cfc2001 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: typo/dialogue fixes https://github.com/wesnoth/wesnoth/commit/084c6cfc20019def2ab361987af4ee972bd17fca
20190301 05:11:55< irker563> wesnoth: nemaara wesnoth:master d32953a86ab2 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: changed male_message to message https://github.com/wesnoth/wesnoth/commit/d32953a86ab207cb03ffc270856ffd6b8863cbc0
20190301 05:11:57< irker563> wesnoth: nemaara wesnoth:master 91b07c05ad37 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: rebalanced ai gold https://github.com/wesnoth/wesnoth/commit/91b07c05ad372a5129b497963ecbe7d5bf5d1b0f
20190301 05:11:59< irker563> wesnoth: nemaara wesnoth:master d1c36af35854 / data/campaigns/Descent_Into_Darkness/maps/06_Return_to_Parthyn.map: DiD S6: added more villages near starting location https://github.com/wesnoth/wesnoth/commit/d1c36af3585401d52cfde16bc98ec342f454756c
20190301 05:12:01< irker563> wesnoth: nemaara wesnoth:master c6ccc72a6341 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: modified player starting villages/support https://github.com/wesnoth/wesnoth/commit/c6ccc72a634144aa76d77cd21a7899007227c0e2
20190301 05:12:03< irker563> wesnoth: nemaara wesnoth:master ec84831894f6 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: punctuation/typo fixes https://github.com/wesnoth/wesnoth/commit/ec84831894f6707afc00e682412f9dac6d810178
20190301 05:12:05< irker563> wesnoth: nemaara wesnoth:master 43a6db8f0654 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: dialogue fixes https://github.com/wesnoth/wesnoth/commit/43a6db8f065432484db975b2c50290a4a0ce9868
20190301 05:12:07< irker563> wesnoth: nemaara wesnoth:master da6f82549948 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: text revision https://github.com/wesnoth/wesnoth/commit/da6f82549948df6a276f1390b24207be3fafe10b
20190301 05:12:09< irker563> wesnoth: nemaara wesnoth:master 585dbd6004da / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: fixed bad indents https://github.com/wesnoth/wesnoth/commit/585dbd6004da3f0243ecd22b3c8c6a969a2e7e96
20190301 05:12:11< irker563> wesnoth: nemaara wesnoth:master 5f6b6a074ba5 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: revised dialogue https://github.com/wesnoth/wesnoth/commit/5f6b6a074ba5e70198232071b3e5e2167a741a05
20190301 05:12:13< irker563> wesnoth: nemaara wesnoth:master 02f915273b7e / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: dialogue/gameplay fixes https://github.com/wesnoth/wesnoth/commit/02f915273b7e3b0acb2827c9b7aaf799d45d12fa
20190301 05:12:15< irker563> wesnoth: nemaara wesnoth:master 0bb5eac1ecda / data/campaigns/Descent_Into_Darkness/images/misc/new-journey-blue.png: DiD: add recolored journey marker https://github.com/wesnoth/wesnoth/commit/0bb5eac1ecdac3c2ecfae9548c4ef60423aa2925
20190301 05:12:17< irker563> wesnoth: nemaara wesnoth:master d323294ffc7b / data/campaigns/Descent_Into_Darkness/utils/bigmap.cfg: DiD: add marker to track orcs for S6 https://github.com/wesnoth/wesnoth/commit/d323294ffc7b80d98ae61143f06db367879728ce
20190301 05:12:19< irker563> wesnoth: nemaara wesnoth:master c0b6505febdd / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: update dialogue and adjust ai gold https://github.com/wesnoth/wesnoth/commit/c0b6505febddaea513d550ed561f441baad6473b
20190301 05:12:21< irker563> wesnoth: nemaara wesnoth:master 723a52a76f6d / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: adjust ai gold and fix grammar https://github.com/wesnoth/wesnoth/commit/723a52a76f6d7514b5677b7453e6080f5770bd30
20190301 05:12:23< irker563> wesnoth: nemaara wesnoth:master 29d3cdd7d027 / data/campaigns/Descent_Into_Darkness/ (4 files in 4 dirs): Merge pull request #3857 from nemaara/DiD_S6 https://github.com/wesnoth/wesnoth/commit/29d3cdd7d027bc464307c778c62f211bf2c95ca0
20190301 05:12:25< irker563> wesnoth: nemaara wesnoth:1.14 4ce842e662f1 / data/campaigns/Descent_Into_Darkness/maps/06_Return_to_Parthyn.map: DiD S6: updated map https://github.com/wesnoth/wesnoth/commit/4ce842e662f153f086a88e9e5bc01d9783ee9927
20190301 05:12:27< irker563> wesnoth: nemaara wesnoth:1.14 59e4c5b065ac / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: updated scenario https://github.com/wesnoth/wesnoth/commit/59e4c5b065acdd4f37677df30a67e6b86dd1c853
20190301 05:12:29< irker563> wesnoth: nemaara wesnoth:1.14 7938e5156ed8 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: updated music https://github.com/wesnoth/wesnoth/commit/7938e5156ed8841c1946c8840cbca009ce7953e0
20190301 05:12:31< irker563> wesnoth: nemaara wesnoth:1.14 de78dae9d036 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: modified dialogue https://github.com/wesnoth/wesnoth/commit/de78dae9d0367339c478eaa18f55eb0f00d4349b
20190301 05:12:33< irker563> wesnoth: nemaara wesnoth:1.14 84c922ba1762 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: gameplay rebalance https://github.com/wesnoth/wesnoth/commit/84c922ba176285021c43f4c9b0b1ce28707e0c5c
20190301 05:12:35< irker563> wesnoth: nemaara wesnoth:1.14 3f2b3e10c869 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: added missing space https://github.com/wesnoth/wesnoth/commit/3f2b3e10c869a2364347ef575c0a07d46d0283c2
20190301 05:12:37< irker563> wesnoth: nemaara wesnoth:1.14 99f3b606c3ba / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: added dialogue https://github.com/wesnoth/wesnoth/commit/99f3b606c3baf309aec4deddca1526771c3f95de
20190301 05:12:39< irker563> wesnoth: nemaara wesnoth:1.14 1a9dd09616fa / data/campaigns/Descent_Into_Darkness/utils/bigmap.cfg: DiD: updated bigmap for S6 https://github.com/wesnoth/wesnoth/commit/1a9dd09616fa210accc6e4b44c080f01e367e169
20190301 05:12:41< irker563> wesnoth: nemaara wesnoth:1.14 44bf8c134b31 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: typo/dialogue fixes https://github.com/wesnoth/wesnoth/commit/44bf8c134b311373e53219331dbb606ccfae8865
20190301 05:12:43< irker563> wesnoth: nemaara wesnoth:1.14 ca95de6f39a6 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: changed male_message to message https://github.com/wesnoth/wesnoth/commit/ca95de6f39a6e986d4ee7d43c5cfb2972fd8ad13
20190301 05:12:45< irker563> wesnoth: nemaara wesnoth:1.14 ebbd7fd91e80 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: rebalanced ai gold https://github.com/wesnoth/wesnoth/commit/ebbd7fd91e80491edf3a7b33b234f26d06e384ab
20190301 05:12:47< irker563> wesnoth: nemaara wesnoth:1.14 a13a8c0376de / data/campaigns/Descent_Into_Darkness/maps/06_Return_to_Parthyn.map: DiD S6: added more villages near starting location https://github.com/wesnoth/wesnoth/commit/a13a8c0376de19ac2a6e72884fddb389ab1ebefb
20190301 05:12:49< irker563> wesnoth: nemaara wesnoth:1.14 0ab5e75b7a77 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: modified player starting villages/support https://github.com/wesnoth/wesnoth/commit/0ab5e75b7a770e5e15accf18f6d10d26a65849c5
20190301 05:12:51< irker563> wesnoth: nemaara wesnoth:1.14 f316f069b748 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: punctuation/typo fixes https://github.com/wesnoth/wesnoth/commit/f316f069b74881fd73a5b9d033d25fac3b17954c
20190301 05:12:53< irker563> wesnoth: nemaara wesnoth:1.14 22bf263c25b7 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: dialogue fixes https://github.com/wesnoth/wesnoth/commit/22bf263c25b7b63fb8cb4aaaf039eefe2fef9dc0
20190301 05:12:55< irker563> wesnoth: nemaara wesnoth:1.14 db38888042e4 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: text revision https://github.com/wesnoth/wesnoth/commit/db38888042e4d3654b5ca52428f3f9d0c6814176
20190301 05:12:57< irker563> wesnoth: nemaara wesnoth:1.14 57cfd2eb6442 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: fixed bad indents https://github.com/wesnoth/wesnoth/commit/57cfd2eb6442365c52e502c19368a1de0b189747
20190301 05:12:59< irker563> wesnoth: nemaara wesnoth:1.14 ec3a878e9f48 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: revised dialogue https://github.com/wesnoth/wesnoth/commit/ec3a878e9f48c8aba461c75be729574f08ab1481
20190301 05:13:01< irker563> wesnoth: nemaara wesnoth:1.14 1a32fdd650db / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: dialogue/gameplay fixes https://github.com/wesnoth/wesnoth/commit/1a32fdd650dba2a1d692f17359e2d9d83e071a4c
20190301 05:13:03< irker563> wesnoth: nemaara wesnoth:1.14 6936bda76b9d / data/campaigns/Descent_Into_Darkness/images/misc/new-journey-blue.png: DiD: add recolored journey marker https://github.com/wesnoth/wesnoth/commit/6936bda76b9d59dea34bc63dc2b505f6054c27af
20190301 05:13:05< irker563> wesnoth: nemaara wesnoth:1.14 0171f29347f0 / data/campaigns/Descent_Into_Darkness/utils/bigmap.cfg: DiD: add marker to track orcs for S6 https://github.com/wesnoth/wesnoth/commit/0171f29347f05cba88ce800589be783368ff246f
20190301 05:13:07< irker563> wesnoth: nemaara wesnoth:1.14 b22f2aa4284f / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: update dialogue and adjust ai gold https://github.com/wesnoth/wesnoth/commit/b22f2aa4284f44914bdc6a070aca00af58ac006a
20190301 05:13:09< irker563> wesnoth: nemaara wesnoth:1.14 c8b9e4acba24 / data/campaigns/Descent_Into_Darkness/scenarios/06_Return_to_Parthyn.cfg: DiD S6: adjust ai gold and fix grammar https://github.com/wesnoth/wesnoth/commit/c8b9e4acba24444aecbad7815b3378ed0df02329
20190301 05:17:16<+wesdiscordbot> <Vultraz> 23 commits for one scenario? wow
20190301 05:17:48< irker563> wesnoth/wesnoth:master nemaara 60fe2260e2 DiD S8: add variable handler for debug a AppVeyor: vs2015/Release Failed
20190301 05:17:49< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22738908
20190301 05:17:49<+wesdiscordbot> <Vultraz> very thorough
20190301 05:18:20<+wesdiscordbot> <Yumi> yup the scenarios that people review more have more commits on them
20190301 05:18:32<+wesdiscordbot> <Yumi> since I make a new commit to address each suggestion if I accept it
20190301 05:18:46< celticminstrel> Seems reasonable.
20190301 05:19:02<+wesdiscordbot> <Yumi> plus maps, macro files, scenario file, etc. get different commits for each one too
20190301 05:19:08<+wesdiscordbot> <Yumi> even if they get updated at the same time
20190301 05:19:27< celticminstrel> IMO they should be in the same commit if they're part of the same change tho.
20190301 05:19:52<+wesdiscordbot> <Iris> People have too many opinions around here
20190301 05:20:06< celticminstrel> Like if you added some item on the map that triggers an event, you might place a named location in the map and an event in the scenario, so that would be one commit.
20190301 05:20:07<+wesdiscordbot> <Iris> We need to build an anti-opinion shield to protect this project from opinions
20190301 05:21:28 * celticminstrel hugs Iris?
20190301 05:22:02<+wesdiscordbot> <Iris> Yeah, I'm not gonna try and conceal how muh it pisses me off that after dedicating my energy to fixing a long-standing issue that puts the project in a wobbly legal position the first thing some maverick does is to complain about the results
20190301 05:22:17<+wesdiscordbot> <Iris> Reminds me why I generally don't want to do anything for Wesnoth anymore
20190301 05:26:24-!- celticminstrel is now known as celmin|sleep
20190301 05:27:22<+wesdiscordbot> <Yumi> does anyone know why https://github.com/wesnoth/wesnoth/issues/1584 is still open?
20190301 05:27:25<+wesdiscordbot> <Yumi> it looks like it's fixed to me
20190301 05:27:57<+wesdiscordbot> <Vultraz> doesn't it still have the disable end turn stuff
20190301 05:28:12<+wesdiscordbot> <Yumi> yeah but it allows you to undo now
20190301 05:28:16<+wesdiscordbot> <Vultraz> oh huh there's a commit
20190301 05:28:30<+wesdiscordbot> <Vultraz> I guess it's fixed if it's fixed
20190301 05:28:43<+wesdiscordbot> <Yumi> :thonk:
20190301 05:28:55<+wesdiscordbot> <Yumi> I'll let someone else close it I guess, I haven't read it in detail so I may be missing something
20190301 05:29:19<+wesdiscordbot> <Yumi> so many old LoW issues I can't fix too
20190301 05:29:27<+wesdiscordbot> <Yumi> and NR
20190301 05:30:37<+wesdiscordbot> <Vultraz> forget LoW
20190301 05:30:57<+wesdiscordbot> <Vultraz> if we ever get 2.0 done it won't be part of it
20190301 05:31:12<+wesdiscordbot> <Yumi> I mean I wasn't intending to touch LoW
20190301 05:32:40<+wesdiscordbot> <Vultraz> "Everything the light touches is your kingdom!" "But what about that shadowy place?" "That's LoW, we don't go there"
20190301 05:32:46<+wesdiscordbot> <Yumi> zookeeper: didn't you fix this? https://github.com/wesnoth/wesnoth/issues/2902
20190301 05:32:48<+wesdiscordbot> <Yumi> can I close that
20190301 05:33:13<+wesdiscordbot> <Yumi> haa
20190301 05:33:39<+wesdiscordbot> <Yumi> things like LoW and NR aren't worth for me to touch since those issues would require quite a lot of work, and I might as well do a revision at htat point
20190301 05:33:58< celmin|sleep> (We should totally fix LoW/NR. Even if that means rewrite. Not a priority obviously.)
20190301 05:34:12<+wesdiscordbot> <Vultraz> we can do that in 2022
20190301 05:34:55< irker563> wesnoth: Iris Morelle wesnoth:1.14 f84b604d2712 / / (4 files in 3 dirs): Add utils::format_timespan() for formatting time lengths for user display https://github.com/wesnoth/wesnoth/commit/f84b604d27127488552e9b9bfcb9bb5e2419b250
20190301 05:34:58< irker563> wesnoth: Iris Morelle wesnoth:1.14 7de8dc02b898 / src/server/ (server_base.cpp server_base.hpp): server: Make it possible to send a [data] block in server responses https://github.com/wesnoth/wesnoth/commit/7de8dc02b8982485c868bfc77f71275f45832108
20190301 05:35:01< irker563> wesnoth: Iris Morelle wesnoth:1.14 c57f1748c90a / src/ (7 files in 2 dirs): wesnothd: Retrieve forum ban durations and send the remaining time to clients https://github.com/wesnoth/wesnoth/commit/c57f1748c90ab695a4a902248ac2ad00f348282e
20190301 05:35:02<+wesdiscordbot> <Yumi> shadowm has made some arguments for why we should keep LoW
20190301 05:35:04< irker563> wesnoth: Iris Morelle wesnoth:1.14 d70180214fe5 / changelog.md: Changelog entry for #3766 https://github.com/wesnoth/wesnoth/commit/d70180214fe50e89c47bfd3fe46193e3f30818ec
20190301 05:35:07< irker563> wesnoth: Iris Morelle wesnoth:master 37cca8468420 / / (4 files in 3 dirs): Add utils::format_timespan() for formatting time lengths for user display https://github.com/wesnoth/wesnoth/commit/37cca8468420298337d29dfde5a3fc28809b6af1
20190301 05:35:10< irker563> wesnoth: Iris Morelle wesnoth:master 6c14dcf72fac / src/server/ (server_base.cpp server_base.hpp): server: Make it possible to send a [data] block in server responses https://github.com/wesnoth/wesnoth/commit/6c14dcf72facceb9399899d2acfefafc3d63ec00
20190301 05:35:13< irker563> wesnoth: Iris Morelle wesnoth:master 6d567889cd64 / src/ (7 files in 2 dirs): wesnothd: Retrieve forum ban durations and send the remaining time to clients https://github.com/wesnoth/wesnoth/commit/6d567889cd64da6171da8b3b349ef4a0b6485b8a
20190301 05:35:16< irker563> wesnoth: Iris Morelle wesnoth:master 3c01a2718077 / changelog.md: Changelog entry for #3766 https://github.com/wesnoth/wesnoth/commit/3c01a2718077268ac3ea84ed801783829db33920
20190301 05:35:31<+wesdiscordbot> <Yumi> nevertheless, it may be enough trouble that we could drop it, so long as we find another MP campaign to have
20190301 05:35:33<+wesdiscordbot> <Vultraz> it's really low priority
20190301 05:35:36<+wesdiscordbot> <Yumi> sure
20190301 05:35:51<+wesdiscordbot> <Vultraz> we'll have to reevaluate what campaigns are ported to 2.0 and in what order
20190301 05:35:53<+wesdiscordbot> <Iris> LoW was a terrible choice for an MP campaign in the first place
20190301 05:36:02<+wesdiscordbot> <Iris> Because of its fragmented nature
20190301 05:36:28<+wesdiscordbot> <Yumi> I'm trying to clean up as many things as I can with the campaign and prose labels
20190301 05:36:28<+wesdiscordbot> <Iris> Retrofitting MP gameplay into an existing large campaign in general is suicidal
20190301 05:36:43<+wesdiscordbot> <Yumi> but the LoW and NR ones I generally can't deal with
20190301 05:36:55<+wesdiscordbot> <Vultraz> indeed
20190301 05:37:44<+wesdiscordbot> <Vultraz> it's not worth the time and effort
20190301 05:39:10<+wesdiscordbot> <Yumi> I guess those issues will be stuck there in limbo forever 😂
20190301 05:39:22<+wesdiscordbot> <Yumi> oh well, that's okay
20190301 05:41:26<+wesdiscordbot> <Vultraz> if we ever do do that nr rewrite it can be for 2.0
20190301 05:42:18<+wesdiscordbot> <Yumi> I can't wait to see all the hate if we do end up rewriting it 😂
20190301 05:42:50<+wesdiscordbot> <Vultraz> ¯_(ツ)_/¯
20190301 05:43:06<+wesdiscordbot> <Vultraz> let them hate
20190301 05:43:38<+wesdiscordbot> <Yumi> https://github.com/wesnoth/wesnoth/pull/3734
20190301 05:43:44<+wesdiscordbot> <Yumi> this PR is going to be tricky to deal with..
20190301 05:52:00< irker563> wesnoth/wesnoth:1.14 gfgtdf a281ef0456 fix display chat messages disappearing AppVeyor: 1/4 builds failed
20190301 05:52:01< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22735302
20190301 06:20:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20190301 06:25:51-!- travis-ci [~travis-ci@ec2-3-80-36-176.compute-1.amazonaws.com] has joined #wesnoth-dev
20190301 06:25:52< travis-ci> wesnoth/wesnoth#21021 (1.14 - c57f174 : Iris Morelle): The build failed.
20190301 06:25:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/500174689
20190301 06:25:52-!- travis-ci [~travis-ci@ec2-3-80-36-176.compute-1.amazonaws.com] has left #wesnoth-dev []
20190301 06:26:50<+wesdiscordbot> <Iris> Uh
20190301 06:27:13<+wesdiscordbot> <Iris> What on earth?
20190301 06:27:50<+wesdiscordbot> <Iris> It builds for me and the PR build had succeeded as well
20190301 06:28:40< irker563> wesnoth/wesnoth:1.14 Iris Morelle d70180214f Changelog entry for #3766 AppVeyor: vs2015/Release Failed
20190301 06:28:41< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22739564
20190301 06:30:15<+wesdiscordbot> <Iris> Oh, the PR checks don't include Travis for some reason...
20190301 06:30:26<+wesdiscordbot> <Iris> Anyway I'm going to need some help here because I can't even understand the error
20190301 06:31:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20190301 06:42:21<+wesdiscordbot> <Vultraz> I think the implicit conversion to std::time_t isn't working
20190301 06:43:52-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20190301 06:44:15<+wesdiscordbot> <Vultraz> or, no, that's not it
20190301 06:46:38<+wesdiscordbot> <Vultraz> my best guess is some type mismatch between int and long
20190301 06:47:06-!- travis-ci [~travis-ci@ec2-34-229-117-129.compute-1.amazonaws.com] has joined #wesnoth-dev
20190301 06:47:07< travis-ci> wesnoth/wesnoth#21022 (master - 6d56788 : Iris Morelle): The build was broken.
20190301 06:47:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/500174719
20190301 06:47:07-!- travis-ci [~travis-ci@ec2-34-229-117-129.compute-1.amazonaws.com] has left #wesnoth-dev []
20190301 07:07:11<+wesdiscordbot> <jyrkive> If no one else gets to it first, I can investigate the issue in the evening. On GNU/Linux, I compile with Clang by default.
20190301 08:15:42<+wesdiscordbot> <Pentarctagon> looks like a compiler version difference.  it works locally for me as well, and for travis using the ubuntu 18.04 image/gcc 7.3, but fails with the ubuntu 16.04 image/gcc 5.4 (and clang).
20190301 08:17:07<+wesdiscordbot> <Pentarctagon> (thanks for implementing that, by the way)
20190301 08:18:13<+wesdiscordbot> <Pentarctagon> also, locally I'm building with gcc 8 and c++14, so it doesn't look like a 14 vs 17 issue.
20190301 08:24:09<+wesdiscordbot> <Pentarctagon> Does anyone know if https://forums.wesnoth.org/viewtopic.php?f=4&t=39788 is still an issue?  It was originally reported for 1.11.7 Mac OS 10.6.8, which is below the minimum system requirements now.
20190301 08:26:43<+wesdiscordbot> <hrubymar10> @Pentarctagon it isn't
20190301 08:26:57<+wesdiscordbot> <Pentarctagon> great, thanks
20190301 08:28:00<+wesdiscordbot> <hrubymar10> Also these bugs aren't reproducible:
20190301 08:28:01<+wesdiscordbot> <hrubymar10> https://cdn.discordapp.com/attachments/259976436490829825/550957392448323585/unknown.png
20190301 08:28:58<+wesdiscordbot> <jyrkive> Have you made builds with OpenMP enabled?
20190301 08:30:47<+wesdiscordbot> <Pentarctagon> @hrubymar10 Could you add that after https://github.com/wesnoth/wesnoth/issues/1260#issuecomment-382698394 ?
20190301 08:33:07<+wesdiscordbot> <hrubymar10> Yes, we had discussion about it like 2 years ago? I can't remember exactly. We came to conclusion that OpenMP is not even use (that much) in current wesnoth src. Vultraz removed OpenMP completely from 1.15 after this discussion.
20190301 08:33:46<+wesdiscordbot> <jyrkive> Correct, but 1.14 still has it.
20190301 08:34:09<+wesdiscordbot> <hrubymar10> ok, so regarding my comment the discussion was nearly 1 year ago
20190301 08:35:01<+wesdiscordbot> <hrubymar10> Removed OpenMP-related code After some discussion, we concluded that this code was unmaintained, not even used in some places (display.cpp, units/frame.cpp), leaving the only area that really used it at all the image surface cache. Considering there was never really a conclusive benchmark of its benefits and because said surface cache will be used a lot less going forward, we're just removing it and simplifying
20190301 08:35:02<+wesdiscordbot> everything for everyone.  Closes wesnoth#1260 since it's now irrelevant.
20190301 08:38:08<+wesdiscordbot> <hrubymar10> I'll do more tests with current 1.14 branch, but I wasn't able to reproduce the issue during last tests
20190301 08:41:32< irker563> wesnoth/wesnoth:master Iris Morelle 3c01a27180 Changelog entry for #3766 AppVeyor: vs2015/Release Failed
20190301 08:41:33< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22739567
20190301 09:05:34<+wesdiscordbot> <Pentarctagon> all: https://forums.wesnoth.org/viewtopic.php?f=16&t=49406 I'll move it to Release Announcements, Compiling & Installation tomorrow, assuming it doesn't spawn some huge debate.
20190301 09:07:50<+wesdiscordbot> <Iris> why woluld people debate an announcement xD
20190301 09:08:16<+wesdiscordbot> <jyrkive> Because of bikeshedding, obviously.
20190301 09:17:39<+wesdiscordbot> <jyrkive> The announcement looks fine to me.
20190301 09:29:27< irker563> wesnoth/wesnoth:master nemaara e67c6fcbd3 UtBS: update stalwart description AppVeyor: vs2015/Release Failed
20190301 09:29:28< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22742238
20190301 10:17:49< irker563> wesnoth/wesnoth:master nemaara 60fe2260e2 DiD S8: add variable handler for debug a AppVeyor: 1/4 builds failed
20190301 10:17:50< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22738908
20190301 11:28:42< irker563> wesnoth/wesnoth:1.14 Iris Morelle d70180214f Changelog entry for #3766 AppVeyor: 1/4 builds failed
20190301 11:28:43< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22739564
20190301 13:16:03-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 268 seconds]
20190301 13:17:48-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20190301 13:21:13< Soliton> @Yumi re https://github.com/wesnoth/wesnoth/pull/3734  perhaps ask the author to write better commit messages. "code refactor" with a 100+ line commit is not particularly helpful for anyone trying to review (now or later to figure out why a change was done).
20190301 13:30:36< irker563> wesnoth/wesnoth:master Iris Morelle 3c01a27180 Changelog entry for #3766 AppVeyor: 1/4 builds failed
20190301 13:30:37< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22739567
20190301 13:42:37-!- madmax28_ [~madmax28@2001-4dd3-a087-0-ba27-ebff-febc-e0cb.ipv6dyn.netcologne.de] has joined #wesnoth-dev
20190301 13:44:39-!- madmax28 [~madmax28@xdsl-84-44-157-8.nc.de] has quit [Ping timeout: 244 seconds]
20190301 14:29:26< irker563> wesnoth/wesnoth:master nemaara e67c6fcbd3 UtBS: update stalwart description AppVeyor: 1/4 builds failed
20190301 14:29:28< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22742238
20190301 15:22:54< irker563> wesnoth: Gunter Labes wesnoth:revert-3948-def_multi_line_str_parser_test_fix b903c26a2c9b / data/tools/wesnoth/wmlparser3.py: Revert "Fix parser crash in defined multi line str test" https://github.com/wesnoth/wesnoth/commit/b903c26a2c9b40681655509c135c6117c1536e90
20190301 15:24:07-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 240 seconds]
20190301 15:26:15-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20190301 15:34:02< irker563> wesnoth/wesnoth:revert-3948-def_multi_line_str_parser_test_fix Gunter Labes b903c26a2c Revert "Fix parser crash in defined mult AppVeyor: vs2015/Release Failed
20190301 15:34:03< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22751697
20190301 15:38:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20190301 15:48:28<+wesdiscordbot> <Yumi> well that and I don't even know if the code is tested
20190301 15:48:39<+wesdiscordbot> <Yumi> plus I'd need to test it myself before committing
20190301 15:55:35-!- travis-ci [~travis-ci@ec2-52-200-244-196.compute-1.amazonaws.com] has joined #wesnoth-dev
20190301 15:55:36< travis-ci> wesnoth/wesnoth#21025 (revert-3948-def_multi_line_str_parser_test_fix - b903c26 : Gunter Labes): The build failed.
20190301 15:55:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/500392539
20190301 15:55:36-!- travis-ci [~travis-ci@ec2-52-200-244-196.compute-1.amazonaws.com] has left #wesnoth-dev []
20190301 15:59:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20190301 16:08:06< Soliton> i would assume it's tested but yeah i wouldn't commit extensive changes like that either without testing myself.
20190301 16:09:24< irker563> wesnoth: Gunter Labes wesnoth:master ef57c0d76b78 / data/tools/wesnoth/wmlparser3.py: Revert "Fix parser crash in defined multi line str test" (#3959) https://github.com/wesnoth/wesnoth/commit/ef57c0d76b78f4fa2a3edb34d95047cb217f5a05
20190301 16:18:30< elias> Soliton: I'm looking at http://addons.wesnoth.org/1.14/ - which addon is an example for the newline breaking things?
20190301 16:18:37< elias> I don't see anything obvious
20190301 16:19:02< elias> (or if not on that page, where else would I reproduce?)
20190301 16:19:44< Soliton> it's visible in the --list output.
20190301 16:20:04< Soliton> some addons with multiple authors have those newline delimited.
20190301 16:20:30< Soliton> actually alternatively there could be an option to only output select fields.
20190301 16:21:23< Soliton> the actual issue in the update script is that we're checking for deleted addons. so we parse the --list output to get all the current names and compare with what files we have.
20190301 16:22:44< Soliton> or maybe add json output or so.
20190301 16:22:44< elias> I see
20190301 16:23:17< Soliton> it's fine to leave the current output as a human readable thing that is not meant to be used in scripts.
20190301 16:24:18< elias> where is that update script?
20190301 16:24:19< Soliton> though it's not looking particularly human readable currently either. :-P
20190301 16:24:43< elias> yeah, I had to size my window over two monitors to see the extra newline :P
20190301 16:26:12< Soliton> i can pastebin the script in a bit. basically it puts --list output through  awk 'NR > 1 { print $2 }'  to get the second field and remove the header.
20190301 16:28:58< Soliton> http://ix.io/1Clr
20190301 16:32:13< elias> I see - can bash parse json?
20190301 16:32:28< Soliton> there's jq for that.
20190301 16:32:42< elias> neat
20190301 16:45:01-!- travis-ci [~travis-ci@ec2-54-196-11-233.compute-1.amazonaws.com] has joined #wesnoth-dev
20190301 16:45:02< travis-ci> wesnoth/wesnoth#21027 (master - ef57c0d : Gunter Labes): The build is still failing.
20190301 16:45:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/500415360
20190301 16:45:02-!- travis-ci [~travis-ci@ec2-54-196-11-233.compute-1.amazonaws.com] has left #wesnoth-dev []
20190301 17:39:32-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20190301 17:49:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20190301 17:57:51<+wesdiscordbot> <jyrkive> @Iris Bad news. I can't reproduce the build failure.
20190301 17:58:03<+wesdiscordbot> <jyrkive> The game builds just fine for me on Clang 7.0.1.
20190301 17:58:23<+wesdiscordbot> <jyrkive> Looks like the problem is specific to older compilers.
20190301 18:00:07-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Quit: nurupo.ga]
20190301 18:00:21-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20190301 18:07:53<+wesdiscordbot> <Pentarctagon> I guess for some reason it thinks that { 31104000, N_("timespan^$num year"),   N_("timespan^$num years")   }, // 12 months { 2592000,  N_("timespan^$num month"),  N_("timespan^$num months")  }, // 30 days { 604800,   N_("timespan^$num week"),   N_("timespan^$num weeks")   }, { 86400,    N_("timespan^$num day"),    N_("timespan^$num days")    }, { 3600,     N_("timespan^$num hour"),   N_("timespan^$num hours")   }, {
20190301 18:07:53<+wesdiscordbot> 60,       N_("timespan^$num minute"), N_("timespan^$num minutes") }, { 1,        N_("timespan^$num second"), N_("timespan^$num seconds") }, is supposed to be the list of arguments to the vector's constructor?
20190301 18:08:28<+wesdiscordbot> <jyrkive> Right.
20190301 18:09:32<+wesdiscordbot> <jyrkive> It should be direct-list-initialization, where the expression is an initializer list, and the vector constructor that takes a std::initializer_list as the first parameter is called.
20190301 18:09:33<+wesdiscordbot> <jyrkive> https://en.cppreference.com/w/cpp/language/list_initialization
20190301 18:10:02<+wesdiscordbot> <jyrkive> https://en.cppreference.com/w/cpp/container/vector/vector
20190301 18:12:26<+wesdiscordbot> <Pentarctagon> hm
20190301 18:13:38<+wesdiscordbot> <Pentarctagon> "Direct-list-initialization of enumerations" is listed as supported https://en.cppreference.com/w/cpp/compiler_support by gcc 7 and clang 3.9.  travis for the failed builds used gcc 5.4 and clang 3.8.
20190301 18:14:54<+wesdiscordbot> <Pentarctagon> so that sounds like it'd be the problem.
20190301 18:18:22<+wesdiscordbot> <jyrkive> It's irrelevant. It's a C++17 feature, and the master branch (which I built) uses C++14 by default.
20190301 18:32:53< irker563> wesnoth/wesnoth:master Gunter Labes ef57c0d76b Revert "Fix parser crash in defined mult AppVeyor: vs2015/Release Failed
20190301 18:32:54< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22753148
20190301 18:53:31<+wesdiscordbot> <Iris> 1.14 uses C++11
20190301 18:53:43<+wesdiscordbot> <Iris> So is the code I wrote not C++11?
20190301 18:54:21<+wesdiscordbot> <jyrkive> No, it's also valid C++11.
20190301 18:54:50<+wesdiscordbot> <Iris> I'm confused then as to why whatever version of gcc travis runs is confused
20190301 18:55:10<+wesdiscordbot> <jyrkive> I'd guess a compiler bug.
20190301 18:55:23<+wesdiscordbot> <Iris> Are we sure the issue is not with constructing time_t from int literals?
20190301 18:55:40<+wesdiscordbot> <Iris> It's been long enough I don't remember if int has a different size between 32-bit and 64-bit Intel
20190301 18:55:59<+wesdiscordbot> <Iris> But time_t's size is constant for the same operating system on both architectures IIRC
20190301 18:57:15<+wesdiscordbot> <jyrkive> I have experienced a compiler bug before, when I was working on Angry Birds. GCC rejected a lambda I wrote because it didn't capture this for calling a member function. The problem is that the function I was calling is static, and capturing this shouldn't be required.
20190301 18:58:24<+wesdiscordbot> <jyrkive> time_t is an unspecified type according to cppreference. It's even allowed to be floating point.
20190301 18:58:25<+wesdiscordbot> <jyrkive> https://en.cppreference.com/w/cpp/chrono/c/time_t
20190301 19:00:27<+wesdiscordbot> <Iris> Is Debian jessie too old for this xD
20190301 19:00:42<+wesdiscordbot> <Iris> I tried building on gcc 4.9 and apparently tuple doesn't exist
20190301 19:00:49<+wesdiscordbot> <Iris> Oh wait wrong header
20190301 19:02:04<+wesdiscordbot> <Iris> Well it's not the type difference at least
20190301 19:02:22<+wesdiscordbot> <Iris> test.cpp:17:2: error: converting to ‘std::tuple<int, const char*, const char*>’ from initializer list would use explicit constructor ‘constexpr std::tuple< <template-parameter-1-1> >::tuple(_UElements&& ...) [with _UElements = {int, const char (&)[19], const char (&)[20]}; <template-parameter-2-2> = void; _Elements = {int, const char*, const char*}]’  };
20190301 19:02:28<+wesdiscordbot> <Iris> That's after changing template param 1 to int
20190301 19:05:49<+wesdiscordbot> <Iris> I found a solution
20190301 19:06:24<+wesdiscordbot> <Iris> This compiles with GCC 4.9: https://gist.github.com/shikadiqueen/f41d39a2a132e59c42e8a28188d23025
20190301 19:06:25-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 257 seconds]
20190301 19:06:44<+wesdiscordbot> <Iris> The only difference is that the type of the elements is explicitly stated
20190301 19:07:42<+wesdiscordbot> <jyrkive> You could also try if wrapping each tuple to another pair of {} would help.
20190301 19:07:57< irker563> wesnoth: Charles Dang wesmere:master a03594b8eaa7 / static/docroot/index.php: Updated frontpage with links for 1.14.6 https://github.com/wesnoth/wesmere/commit/a03594b8eaa7715460a93d8e6222d247a628db27
20190301 19:08:04<+wesdiscordbot> <Iris> Would that be syntactically equivalent code?
20190301 19:08:15<+wesdiscordbot> <jyrkive> I'm not sure.
20190301 19:08:16-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20190301 19:08:25<+wesdiscordbot> <jyrkive> But it would be a few less characters per line.
20190301 19:08:28<+wesdiscordbot> <Iris> nope, that made it bloew up
20190301 19:09:00<+wesdiscordbot> <Vultraz> @Iris I think you need to do a thing to the fp now?
20190301 19:09:15<+wesdiscordbot> <Iris> Yes but I'm busy right now as you can see
20190301 19:09:45<+wesdiscordbot> <Vultraz> No rush.
20190301 19:10:03<+wesdiscordbot> <Iris> If I do double brackets it dumps a load of errors on me that start with this: https://gist.github.com/shikadiqueen/c72c839c0fff2385eb177c49ddcd3627
20190301 19:11:13<+wesdiscordbot> <jyrkive> Okay. Again choosing a wrong constructor and giving nonsensical errors, I see. 😦
20190301 19:11:27<+wesdiscordbot> <Vultraz> why is gcc 4.x so bad at this :thonk:
20190301 19:11:35<+wesdiscordbot> <Iris> To be fair GCC 4.x is a terrible choice for a C++11 compiler anyway
20190301 19:11:43<+wesdiscordbot> <Iris> But we need to support it so yay
20190301 19:11:50<+wesdiscordbot> <Iris> I'll just explicitly state the item types
20190301 19:12:10<+wesdiscordbot> <Vultraz> I suppose we do.
20190301 19:12:30<+wesdiscordbot> <jyrkive> Fortunately we only need to support it in 1.14.
20190301 19:12:44<+wesdiscordbot> <Iris> Isn't the Travis CI build broken on master too though?
20190301 19:12:45<+wesdiscordbot> <Vultraz> good reason to get 1.16 out then
20190301 19:12:59<+wesdiscordbot> <Iris> Yep it is broken too
20190301 19:13:14<+wesdiscordbot> <Iris> Vultraz this is a syntax issue
20190301 19:13:26<+wesdiscordbot> <Iris> Nobody's going to die because I needed to say the type a few times
20190301 19:13:26<+wesdiscordbot> <Pentarctagon> on master build #2 succeeds though, on 1.14 it fails.
20190301 19:13:36<+wesdiscordbot> <Iris> Oh okay, I'll patch 1.14 only then
20190301 19:14:06<+wesdiscordbot> <Pentarctagon> that's the one build that uses ubuntu 18.04/gcc 7 though
20190301 19:14:43<+wesdiscordbot> <Pentarctagon> builds 3-6 fail on master for the same reason builds 2-6 fail on 1.14.
20190301 19:15:29<+wesdiscordbot> <Iris> Uh
20190301 19:15:51<+wesdiscordbot> <Iris> I'm confused now, do I need to patch master as well? (Even though it's supposed to be built by C++14-compliant compilers...)
20190301 19:16:02<+wesdiscordbot> <jyrkive> Yes, you do.
20190301 19:16:02< irker563> wesnoth: Iris Morelle wesnoth:1.14 b86237494bfc / src/formula/string_utils.cpp: Fix FTBFS on older versions of GCC because of initializer list confusion https://github.com/wesnoth/wesnoth/commit/b86237494bfc0ccd85cfbe788c43279878890442
20190301 19:16:55<+wesdiscordbot> <Iris> Okay done
20190301 19:16:57< irker563> wesnoth: Iris Morelle wesnoth:master 1ce87e4a579d / src/formula/string_utils.cpp: Fix FTBFS on older versions of GCC because of initializer list confusion https://github.com/wesnoth/wesnoth/commit/1ce87e4a579dd23c6ed98d75a38696e1989fc543
20190301 19:17:45<+wesdiscordbot> <jyrkive> On Ubuntu 16.04 LTS (the OS we use on Travis), GCC 5.3.1 is available, but apparently it also suffers from this issue.
20190301 19:19:52<+wesdiscordbot> <Iris> Frontpage updated, I'll update the press release links in a bit
20190301 19:27:19< irker563> wesnoth: Iris Morelle wesnoth:master ad49853e0795 / utils/pofix.py: pofix: 1.14 announcement rules for 1.14.6 https://github.com/wesnoth/wesnoth/commit/ad49853e0795f2c4a92bab705431edd39585e418
20190301 19:27:23< irker563> wesnoth: Iris Morelle wesnoth:1.14 1af5d0e5f000 / utils/pofix.py: pofix: 1.14 announcement rules for 1.14.6 https://github.com/wesnoth/wesnoth/commit/1af5d0e5f000110096f45e387ac97d5276ea0e5c
20190301 19:27:36< irker563> wesnoth: Iris Morelle website:master 367e678bf1c5 / start/1.14/ (59 files in 2 dirs): announcement/1.14: pofix pass for 1.14.6 https://github.com/wesnoth/website/commit/367e678bf1c5907d0e6b20b243d2e0477b453fef
20190301 20:34:03< irker563> wesnoth/wesnoth:revert-3948-def_multi_line_str_parser_test_fix Gunter Labes b903c26a2c Revert "Fix parser crash in defined mult AppVeyor: 1/4 builds failed
20190301 20:34:04< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22751697
20190301 20:36:52-!- travis-ci [~travis-ci@ec2-54-198-92-12.compute-1.amazonaws.com] has joined #wesnoth-dev
20190301 20:36:53< travis-ci> wesnoth/wesnoth#21033 (1.14 - b862374 : Iris Morelle): The build is still failing.
20190301 20:36:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/500499587
20190301 20:36:53-!- travis-ci [~travis-ci@ec2-54-198-92-12.compute-1.amazonaws.com] has left #wesnoth-dev []
20190301 20:40:59< irker563> wesnoth/wesnoth:1.14 Andrius Štikonas 957cb2b132 Fix some spelling issues AppVeyor: vs2015/Release Failed
20190301 20:41:00< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22757230
20190301 20:49:38<+wesdiscordbot> <josteph> celmin, for https://github.com/wesnoth/wesnoth/issues/3941 we could move the attack name to the tooltip of the new image, then there's no concern about truncation
20190301 20:52:31< irker563> wesnoth/wesnoth:master Iris Morelle ad49853e07 pofix: 1.14 announcement rules for 1.14. AppVeyor: vs2015/Release Failed
20190301 20:52:32< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22757892
20190301 20:53:47< irker563> wesnoth: Charles Dang wesmere:master 7dba822b91ac / static/docroot/index.php: Fixup a03594b https://github.com/wesnoth/wesmere/commit/7dba822b91ac101550d610b36cb83c4a4b2118f6
20190301 20:53:52<+wesdiscordbot> <Vultraz> @Iris do you need to do the thing again
20190301 20:59:53-!- travis-ci [~travis-ci@ec2-34-224-222-46.compute-1.amazonaws.com] has joined #wesnoth-dev
20190301 20:59:54< travis-ci> wesnoth/wesnoth#21034 (master - 1ce87e4 : Iris Morelle): The build has errored.
20190301 20:59:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/500499987
20190301 20:59:54-!- travis-ci [~travis-ci@ec2-34-224-222-46.compute-1.amazonaws.com] has left #wesnoth-dev []
20190301 22:08:43<+wesdiscordbot> <Pentarctagon> The homepage link still doesn't work, so I'm assuming so.
20190301 22:08:55<+wesdiscordbot> <Pentarctagon> @Iris
20190301 22:13:53< Ravana> I expect https://github.com/wesnoth/wesnoth/issues/1321 should not be labeled in progress
20190301 22:15:50<+wesdiscordbot> <josteph> Ravana, fixed
20190301 22:43:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds]
20190301 22:52:43-!- Netsplit *.net <-> *.split quits: pydsigner
20190301 22:53:43-!- Netsplit over, joins: pydsigner
20190301 23:12:20< irker563> wesnoth/wesnoth:1.14 Iris Morelle 1af5d0e5f0 pofix: 1.14 announcement rules for 1.14. AppVeyor: vs2015/Release Failed
20190301 23:12:21< irker563> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22757896
20190301 23:23:04< irker563> wesnoth/wesnoth:master Gunter Labes ef57c0d76b Revert "Fix parser crash in defined mult AppVeyor: 1/4 builds failed
20190301 23:23:06< irker563> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22753148
20190301 23:28:35-!- madmax28_ [~madmax28@2001-4dd3-a087-0-ba27-ebff-febc-e0cb.ipv6dyn.netcologne.de] has quit [Quit: ZNC - https://znc.in]
20190301 23:28:50-!- madmax28 [~madmax28@2001-4dd3-a087-0-ba27-ebff-febc-e0cb.ipv6dyn.netcologne.de] has joined #wesnoth-dev
20190301 23:37:54<+wesdiscordbot> <Iris> @Pentarctagon @Vultraz done
20190301 23:52:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20190301 23:56:39<+wesdiscordbot> <Pentarctagon> thanks
--- Log closed Sat Mar 02 00:00:19 2019