--- Log opened Mon Mar 11 00:00:34 2019 20190311 00:58:45<+wesdiscordbot> @Yumi done? 20190311 00:59:03<+wesdiscordbot> ya 20190311 00:59:28<+wesdiscordbot> kkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk 20190311 00:59:40<+wesdiscordbot> kkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkkk 20190311 00:59:49<+wesdiscordbot> time for freeeeeeeeeeeeeeeeeeeeeeze 20190311 01:00:03<+wesdiscordbot> 😮 20190311 01:01:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190311 01:06:06<+wesdiscordbot> email sent 20190311 01:07:20< irker384> wesnoth/wesnoth:master nemaara f4e0b619cf LoW: raise player gold in S6-7 AppVeyor: All builds passed 20190311 02:45:44< irker384> wesnoth/wesnoth:1.14 nemaara 583cd0eb37 LoW: raise player gold in S6-7 AppVeyor: 1/4 builds failed 20190311 02:45:45< irker384> Details vs2017/Debug: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/22964793 20190311 02:48:14<+wesdiscordbot> @sigurdfd 👍 20190311 02:48:36< celticminstrel> ? 20190311 02:49:08<+wesdiscordbot> he opened a PR for WoV 20190311 02:49:13< celticminstrel> O_O 20190311 02:49:28<+wesdiscordbot> get on Discord so you can see the notifications 20190311 02:49:48< celticminstrel> I can see them on IRC though, just takes a tiny bit of effort. 20190311 02:49:56< celticminstrel> They're in a separate channel. 20190311 02:50:04<+wesdiscordbot> 🙄 20190311 02:50:13< celticminstrel> I can't see that emoticon. 20190311 02:50:23<+wesdiscordbot> :rolling_eyes: 20190311 02:50:41< celticminstrel> 9_9 20190311 03:03:16<+wesdiscordbot> 🙄 20190311 03:04:03< celticminstrel> Another emoticon I can't see. (Or is it the same one again?) 20190311 03:05:07<+wesdiscordbot> 🙄 20190311 03:05:24<+wesdiscordbot> Hopefully one day you'll realize that whenever you do that you're asking for that to happen 🤣 20190311 03:05:31< celticminstrel> ... 20190311 03:05:50< celticminstrel> It's not exactly my fault if I can't see them. 9_9 20190311 03:05:59<+wesdiscordbot> 🐟 20190311 03:06:17<+wesdiscordbot> 8_8 7_7 6_6 20190311 03:06:18< celticminstrel> <>< 20190311 03:06:37< celticminstrel> 8 and 7 don't really give an eyeroll impression tho 20190311 03:07:25<+wesdiscordbot> of course it's your fault because you choose not to use the correct platform 20190311 03:07:42< celticminstrel> It has nothing to do with my use of IRC instead of Discord. 20190311 03:08:03< celticminstrel> IRC users theoretically should be able to see those emoticons provided they have an appropriate font installed. 20190311 03:08:59<+wesdiscordbot> well you can't see custom emojis 20190311 03:09:07<+wesdiscordbot> :bhammer: 20190311 03:09:21< celticminstrel> That's true, but I can see their code, so it's close enough. 20190311 03:10:41<+wesdiscordbot> :iristhonk: 20190311 03:11:04< celticminstrel> TBH it's kinda a relief that I don't have to see "thonk". 20190311 03:13:11<+wesdiscordbot> 👺 20190311 03:14:23< celticminstrel> ...I was wondering WTH that was supposed to be, and it turns out to be an oni. Why is that even in emoji. -_- 20190311 03:14:56<+wesdiscordbot> :ch: 20190311 03:16:54<+wesdiscordbot> EXTRA THONK 20190311 03:17:43< celticminstrel> No thanks, I can do without the thonk. 20190311 03:18:40<+wesdiscordbot> no one can do without the :thonk: 20190311 03:18:40<+wesdiscordbot> 👹 20190311 03:18:48<+wesdiscordbot> 👻 20190311 03:19:08< celticminstrel> Maybe the first one was a tengu rather than an oni, because that one looks more like an oni. Whatever. 20190311 03:19:29< celticminstrel> Blame poor naming in the Unicode standard. 20190311 03:33:53<+wesdiscordbot> is 1 month enough for translators? 20190311 03:34:01<+wesdiscordbot> well I guess they can say if they need more 20190311 04:49:01-!- celticminstrel is now known as celmin|sleep 20190311 05:01:49< irker384> wesnoth/wesnoth:master josteph faa12e8496 fixup! Help: Reorder columns in unit hel AppVeyor: All builds passed 20190311 08:04:12-!- irker384 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190311 08:30:13-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 08:33:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190311 08:41:17-!- irker873 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190311 08:41:17< irker873> wesnoth/wesnoth:master sigurdfdragon 6aca00b565 Campaigns: Add Wings of Victory (Drakes) AppVeyor: All builds passed 20190311 09:38:42-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds] 20190311 09:50:56-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 10:40:19<+wesdiscordbot> I received the mail of String Freeze, but po files is not regenerated? https://github.com/wesnoth/wesnoth/tree/1.14/po 20190311 11:07:50<+wesdiscordbot> .....OOPS 20190311 11:07:57<+wesdiscordbot> @loonycyborg 20190311 11:08:09<+wesdiscordbot> @loonycyborg i forgot to ask you to regen the po files 20190311 11:08:50<+wesdiscordbot> @RatArmy sorry about that 20190311 11:08:58<+wesdiscordbot> right now? on 1.14 branch? 20190311 11:09:04<+wesdiscordbot> yes 20190311 11:09:17<+wesdiscordbot> string freeze has started 20190311 11:18:52<+wesdiscordbot> since it's not generated yet, could you add the translation mark for 3962 20190311 11:19:07<+wesdiscordbot> what? 20190311 11:19:57<+wesdiscordbot> string change issue about ~3 missing translation marks 20190311 11:22:08-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20190311 11:23:19<+wesdiscordbot> Oh, we got now graphics? cool create mode 100644 data/core/images/units/human-loyalists/paladin/paladin-se-defend2.png create mode 100644 data/core/images/units/merfolk/diviner-defend1.png 20190311 11:30:58< irker873> wesnoth: Severin Glöckner wesnoth:1.14 d102d7063264 / src/ (actions/advancement.cpp persist_var.cpp synced_user_choice.hpp): mark strings translatable (#3962) https://github.com/wesnoth/wesnoth/commit/d102d7063264618c1dad3e3919777324d4398e5c 20190311 11:40:19< irker873> wesnoth/wesnoth:1.14 Severin Glöckner d102d70632 mark strings translatable (#3962) AppVeyor: vs2015/Release Failed 20190311 11:40:20< irker873> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22977733 20190311 11:41:55-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 11:42:30< irker873> wesnoth: Severin Glöckner wesnoth:1.14 883552f0ac49 / src/ (4 files in 2 dirs): add translation comments (closes #3962) https://github.com/wesnoth/wesnoth/commit/883552f0ac4965ebc39a2e0a812df3cbb65866a1 20190311 11:43:32< irker873> wesnoth: Severin Glöckner wesnoth:master 6c134a51321c / src/ (actions/advancement.cpp persist_var.cpp synced_user_choice.hpp): mark strings translatable (#3962) https://github.com/wesnoth/wesnoth/commit/6c134a51321ca211edc89ad41f1db005c5567645 20190311 11:43:34< irker873> wesnoth: Severin Glöckner wesnoth:master 36d18e74b0d5 / src/ (4 files in 2 dirs): add translation comments (closes #3962) https://github.com/wesnoth/wesnoth/commit/36d18e74b0d530c6b84901d12eadeaaa641dacd7 20190311 11:44:09<+wesdiscordbot> this last commit leads to a compiler error 20190311 11:44:51<+wesdiscordbot> How does it need to be? 20190311 11:45:11<+wesdiscordbot> src/synced_user_choice.hpp:41:51: error: '_' was not declared in this scope 20190311 11:45:57<+wesdiscordbot> probably missing gettext header 20190311 11:46:02<+wesdiscordbot> IIRC, gettext.hpp must not be used in a header. 20190311 11:46:12<+wesdiscordbot> Thus, that string cannot be marked translatable. 20190311 11:51:08-!- travis-ci [~travis-ci@ec2-3-84-147-195.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 11:51:09< travis-ci> wesnoth/wesnoth#21207 (1.14 - d102d70 : Severin Glöckner): The build is still failing. 20190311 11:51:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504640777 20190311 11:51:09-!- travis-ci [~travis-ci@ec2-3-84-147-195.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 11:51:51< irker873> wesnoth/wesnoth:1.14 Severin Glöckner 883552f0ac add translation comments (closes #3962) AppVeyor: vs2017/Release Failed 20190311 11:51:52< irker873> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/22977953 20190311 11:51:59< irker873> wesnoth: Severin Glöckner wesnoth:1.14 f175651cb83f / src/synced_user_choice.hpp: revert 883552f partly, https://github.com/wesnoth/wesnoth/commit/f175651cb83f812297e1f10003dd5d74c18207fe 20190311 11:53:13< irker873> wesnoth: Severin Glöckner wesnoth:master ba41e6c3bf4c / src/synced_user_choice.hpp: revert 6c134a5 partly, https://github.com/wesnoth/wesnoth/commit/ba41e6c3bf4c44ec58ac9bc6a7757826511c1028 20190311 12:01:12< irker873> wesnoth: Severin Glöckner wesnoth:1.14 2763596bdb97 / src/persist_var.cpp: inculde header file for gettext (#3962) https://github.com/wesnoth/wesnoth/commit/2763596bdb9757f05ebf16711be21981df2c1dbc 20190311 12:01:23<+wesdiscordbot> so it should compile now … 20190311 12:02:48-!- travis-ci [~travis-ci@ec2-54-92-201-92.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 12:02:49< travis-ci> wesnoth/wesnoth#21208 (1.14 - 883552f : Severin Glöckner): The build is still failing. 20190311 12:02:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504644483 20190311 12:02:49-!- travis-ci [~travis-ci@ec2-54-92-201-92.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 12:09:02< irker873> wesnoth: Severin Glöckner wesnoth:master 82de38ac6e8c / src/persist_var.cpp: inculde header file for gettext (#3962) https://github.com/wesnoth/wesnoth/commit/82de38ac6e8c416d072c88250e29d601ef30e0fe 20190311 12:09:24<+wesdiscordbot> It does 🙀 20190311 12:13:05<+wesdiscordbot> Sorry gugs, I better leave off my hands of the C++ part 20190311 12:15:27-!- travis-ci [~travis-ci@ec2-3-91-100-142.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 12:15:28< travis-ci> wesnoth/wesnoth#21210 (1.14 - f175651 : Severin Glöckner): The build is still failing. 20190311 12:15:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504648245 20190311 12:15:28-!- travis-ci [~travis-ci@ec2-3-91-100-142.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 12:31:29<+wesdiscordbot> @jyrkive seems one can use gettext.hpp as well in header files. At least it compiles. 20190311 12:31:48-!- 07IABHS6N [~travis-ci@ec2-3-86-10-111.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 12:31:49< 07IABHS6N> wesnoth/wesnoth#21211 (master - ba41e6c : Severin Glöckner): The build is still failing. 20190311 12:31:49< 07IABHS6N> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504648707 20190311 12:31:49-!- 07IABHS6N [~travis-ci@ec2-3-86-10-111.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 12:32:03<+wesdiscordbot> Okay, I see. Then I guess I mixed up gettext.hpp and log.hpp. 20190311 12:35:37< irker873> wesnoth: Severin Glöckner wesnoth:1.14 c95974ab555b / src/synced_user_choice.hpp: Make the remaining string of #3962 translatable too https://github.com/wesnoth/wesnoth/commit/c95974ab555bd39c2105c6a9413fb98ad68f619e 20190311 12:38:17< celmin|sleep> You can use gettext.hpp in headers, but it's better to avoid it. 20190311 12:38:51< celmin|sleep> Originally gettext didn't even parse headers, though I think that was changed at some point. 20190311 12:41:40-!- celmin|sleep is now known as celmin|away 20190311 12:42:08-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20190311 12:42:25-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 12:50:52< irker873> wesnoth: Severin Glöckner wesnoth:master 8e67da4633a5 / src/synced_user_choice.hpp: Make the remaining string of #3962 translatable https://github.com/wesnoth/wesnoth/commit/8e67da4633a5a68a21078171dc82fa473ca38822 20190311 13:06:10-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 255 seconds] 20190311 13:08:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds] 20190311 13:09:15-!- travis-ci [~travis-ci@ec2-54-227-218-250.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 13:09:16< travis-ci> wesnoth/wesnoth#21213 (master - 82de38a : Severin Glöckner): The build failed. 20190311 13:09:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504655190 20190311 13:09:16-!- travis-ci [~travis-ci@ec2-54-227-218-250.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 13:20:09-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 13:20:32<+wesdiscordbot> I can see one problem with using translateable strings in headers 20190311 13:20:42<+wesdiscordbot> to which textdomain will they apply? 20190311 13:21:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20190311 13:23:35<+wesdiscordbot> Ah, right. Setting the textdomain in a header is a bad idea, and thus it will depend on where the header is #included. 20190311 13:23:56<+wesdiscordbot> The same string may even easily end up in multiple domains. 20190311 13:25:53< irker873> wesnoth: loonycyborg wesnoth:1.14 8e7c10e52e65 / / (1256 files in 22 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/8e7c10e52e659b352ecbd5872c43431c47e77011 20190311 13:27:41-!- travis-ci [~travis-ci@ec2-3-91-242-181.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 13:27:42< travis-ci> wesnoth/wesnoth#21214 (1.14 - c95974a : Severin Glöckner): The build is still failing. 20190311 13:27:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504665613 20190311 13:27:42-!- travis-ci [~travis-ci@ec2-3-91-242-181.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 13:28:21<+wesdiscordbot> @loonycyborg Are you going to announce in the mailing list that the pot files have been updated? 20190311 13:29:23<+wesdiscordbot> ok 20190311 13:29:30<+wesdiscordbot> I can send same mail as before 20190311 13:29:36<+wesdiscordbot> which is the target release date? 20190311 13:30:33<+wesdiscordbot> According to the string freeze email, it's April 11, 00:01 UTC. 20190311 13:30:37<+wesdiscordbot> indeed 20190311 13:31:24<+wesdiscordbot> i was going to write a followup email but if you;re going to do it go ahead 20190311 13:33:07<+wesdiscordbot> http://mailman.wesnoth.org/pipermail/i18n/2019-March/000033.html 20190311 13:33:13<+wesdiscordbot> seems mail was already sent 20190311 13:33:26<+wesdiscordbot> why would I need to send a second one of same content 😛 20190311 13:34:18<+wesdiscordbot> Not the same. The string freeze indeed started earlier today. What's new is that the pot files have now been updated. 😛 20190311 13:35:22<+wesdiscordbot> oh ok 20190311 13:38:02<+wesdiscordbot> sent 20190311 13:44:40-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds] 20190311 13:44:57-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 13:45:51<+wesdiscordbot> I don't see the email. I think the ML blocked it. 20190311 13:49:58-!- travis-ci [~travis-ci@ec2-3-84-147-195.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 13:49:59< travis-ci> wesnoth/wesnoth#21215 (master - 8e67da4 : Severin Glöckner): The build is still failing. 20190311 13:49:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504671170 20190311 13:49:59-!- travis-ci [~travis-ci@ec2-3-84-147-195.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 13:51:51-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 252 seconds] 20190311 13:59:04<+wesdiscordbot> ml tends to be lazy 20190311 14:09:22<+wesdiscordbot> I received the email now. 😃 20190311 14:10:35-!- travis-ci [~travis-ci@ec2-184-73-34-157.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 14:10:36< travis-ci> wesnoth/wesnoth#21216 (1.14 - 8e7c10e : loonycyborg): The build is still failing. 20190311 14:10:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504687621 20190311 14:10:36-!- travis-ci [~travis-ci@ec2-184-73-34-157.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 14:15:07-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 15:10:58-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds] 20190311 15:16:15<+wesdiscordbot> looks like my little DiD project brought the number of strings up to 662 20190311 15:16:25<+wesdiscordbot> just shy of tsg's 667 :thonk: 20190311 15:19:27< irker873> wesnoth/wesnoth:master Severin Glöckner 8e67da4633 Make the remaining string of #3962 trans AppVeyor: vs2015/Release Failed 20190311 15:19:28< irker873> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22979581 20190311 15:25:11-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 16:32:47-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds] 20190311 16:33:04-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 16:36:46-!- Ravana [~Ravana@wesnoth/mp-mod/ravana] has quit [Read error: Connection reset by peer] 20190311 16:40:19< irker873> wesnoth/wesnoth:1.14 Severin Glöckner d102d70632 mark strings translatable (#3962) AppVeyor: 1/2 builds failed 20190311 16:40:20< irker873> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22977733 20190311 16:51:52< irker873> wesnoth/wesnoth:1.14 Severin Glöckner 883552f0ac add translation comments (closes #3962) AppVeyor: 1/2 builds failed 20190311 16:51:53< irker873> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/22977953 20190311 17:27:42-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds] 20190311 17:54:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190311 18:57:38-!- Ravana [~Ravana@wesnoth/mp-mod/ravana] has joined #wesnoth-dev 20190311 19:52:03-!- irker873 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190311 20:06:23-!- madmax28 [~madmax28@2001-4dd6-fc48-0-ba27-ebff-febc-e0cb.ipv6dyn.netcologne.de] has joined #wesnoth-dev 20190311 20:08:44-!- madmax28_ [~madmax28@xdsl-87-78-223-70.nc.de] has quit [Ping timeout: 250 seconds] 20190311 20:18:21<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/554760038355566624/teamname.png 20190311 20:19:17<+wesdiscordbot> oof 20190311 20:19:33-!- irker772 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190311 20:19:34< irker772> wesnoth/wesnoth:master Severin Glöckner 8e67da4633 Make the remaining string of #3962 trans AppVeyor: 1/4 builds failed 20190311 20:19:34< irker772> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/22979581 20190311 20:19:53<+wesdiscordbot> That kinda looks like an implementation detail of tstring was misconverted to std::string? 20190311 20:26:15<+wesdiscordbot> @sevu works fine here 20190311 20:26:20<+wesdiscordbot> Is that 1.14 or master ? 20190311 20:26:34<+wesdiscordbot> It's 1.14... strange 20190311 21:12:31-!- gfgtdf [~Daniel@x4d030964.dyn.telefonica.de] has joined #wesnoth-dev 20190311 21:22:14< gfgtdf> does this only happen when use map settings is switched on? 20190311 21:44:32<+wesdiscordbot> gfgtdf, yes 20190311 21:46:17< gfgtdf> it is a known issue that the server simple_wml sometimes removes the transltable marker (_) from a string. The connect_engine has a workaround at https://github.com/wesnoth/wesnoth/blob/4bdfc41c068251dabc16ee7115466ac737446d2e/src/game_initialization/connect_engine.cpp#L151 that is only effective when use map setting is off 20190311 21:47:03< gfgtdf> it shoudl not be too hard to make it also work in the usemapsettings case, but the better solution would be to to fix simple_wml 20190311 21:48:00< gfgtdf> i once to tried to but had to revert if becasue it caused other bugs https://github.com/wesnoth/wesnoth/commit/717a43c49004aa0185c2f2fde7282af992e61356 20190311 21:54:32<+wesdiscordbot> Thanks for the background. I'm not going to look into those issues right now, however. It's too late. 20190311 21:54:59<+wesdiscordbot> Is this a regression from 1.14.6? I can't reproduce it with my installed wesnoth. 20190311 21:56:26< gfgtdf> hmm no i don't think so, were you using the same scenario with use map seting enabled ? 20190311 21:56:42<+wesdiscordbot> same scenario, map settings enabled 20190311 21:57:04<+wesdiscordbot> not the same source tree though 20190311 21:57:47-!- vn971 [~quassel@2a02:7aa0:1619::bac5:9483] has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.] 20190311 21:58:13-!- vn971 [~quassel@2a02:7aa0:1619::bac5:9483] has joined #wesnoth-dev 20190311 22:02:28< gfgtdf> hmm just tested and cannot reproduce it either. 20190311 22:15:47<+wesdiscordbot> confirmed, it's a regression. @sevu 20190311 22:16:53< gfgtdf> well we didnt test that yet, we'd need to check wheterh this happens for us aswell, is still very possibel that we is some aspect that he did differnt when testign that we dodn't look at yet. 20190311 22:18:01<+wesdiscordbot> I just did test it. 20190311 22:18:16<+wesdiscordbot> build origin/1.14, have bug, built 1.14.6 tag in the same worktree, don't have the bug 20190311 22:18:55<+wesdiscordbot> no other differences. (Unlike my previous test) 20190311 22:19:16< gfgtdf> oh ok didnt see that. 20190311 22:19:24< gfgtdf> then lets look at the differences 20190311 22:20:04<+wesdiscordbot> my fault, I wasn't clear enough that I did an additional test. 20190311 22:22:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190311 22:22:49< gfgtdf> the changes to /src since 1.14.6 are less than one github page https://github.com/wesnoth/wesnoth/commits/1.14/src/ . https://github.com/wesnoth/wesnoth/commit/3ba0bbb3438b3b8612d34b4eddf81cdf1e1ed1da seems to be be only the oynl commit on that list that touches the game mp staging code 20190311 22:23:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190311 22:24:48<+wesdiscordbot> I can reproduce the bug with the parent of that commit. 20190311 22:26:58<+wesdiscordbot> Wait, no... 20190311 22:28:03<+wesdiscordbot> sorry, it is that commit after all. 20190311 22:28:54<+wesdiscordbot> - treeitem["label"] = (formatter() << ("Team:") << " " << side->user_team_name()).str(); + treeitem["label"] = (formatter() << ("Team:") << " " << team.user_team_name).str(); Hmm... 20190311 22:30:29<+wesdiscordbot> gfgtdf, http://sprunge.us/9ikNad ? 20190311 22:32:07< gfgtdf> not sure, it could work, you'd need to test it. 20190311 22:33:07<+wesdiscordbot> It does work. I just don't know if it's correct. 20190311 22:37:10< irker772> wesnoth: nemaara wesnoth:master 8f23539834eb / data/campaigns/Northern_Rebirth/utils/herodeaths.cfg: NR: respawn white magi at Tallin's location https://github.com/wesnoth/wesnoth/commit/8f23539834eb137a041e1beaaf4630004e63369c 20190311 22:37:12< irker772> wesnoth: nemaara wesnoth:master d457bc7c8563 / changelog.md: Update changelog with NR fix https://github.com/wesnoth/wesnoth/commit/d457bc7c85638f12b0fbe7c4af24efc3322acecd 20190311 22:38:14< irker772> wesnoth: nemaara wesnoth:1.14 5f1bc7af592d / data/campaigns/Northern_Rebirth/utils/herodeaths.cfg: NR: respawn white magi at Tallin's location https://github.com/wesnoth/wesnoth/commit/5f1bc7af592dbc1876865aeb0a128016b9d860f2 20190311 22:38:16< irker772> wesnoth: nemaara wesnoth:1.14 39d6c097eacb / changelog.md: Update changelog with NR fix https://github.com/wesnoth/wesnoth/commit/39d6c097eacb0157ff7e5d71239f2509fa31af1b 20190311 23:10:29-!- travis-ci [~travis-ci@ec2-3-91-100-142.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 23:10:30< travis-ci> wesnoth/wesnoth#21217 (master - d457bc7 : nemaara): The build is still failing. 20190311 23:10:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504957009 20190311 23:10:30-!- travis-ci [~travis-ci@ec2-3-91-100-142.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 23:17:15< irker772> wesnoth/wesnoth:1.14 loonycyborg 8e7c10e52e pot-update and regenerate doc files AppVeyor: All builds passed 20190311 23:22:30< irker772> wesnoth: josteph wesnoth:master bf507ed142b8 / src/gui/dialogs/multiplayer/mp_staging.cpp: mp_staging: Fix regression: When "use map settings" was set, the team name's raw https://github.com/wesnoth/wesnoth/commit/bf507ed142b80abcabaeddd40985cd73849be468 20190311 23:22:34< irker772> wesnoth: josteph wesnoth:1.14 909629100e03 / src/gui/dialogs/multiplayer/mp_staging.cpp: mp_staging: Fix regression: When "use map settings" was set, the team name's raw https://github.com/wesnoth/wesnoth/commit/909629100e03ca4e6e839100ee6c7291a80dd771 20190311 23:23:03<+wesdiscordbot> @sevu If you test the fix ^^^ that would be nice 20190311 23:27:07-!- travis-ci [~travis-ci@ec2-3-85-15-245.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 23:27:08< travis-ci> wesnoth/wesnoth#21218 (1.14 - 39d6c09 : nemaara): The build is still failing. 20190311 23:27:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504957422 20190311 23:27:08-!- travis-ci [~travis-ci@ec2-3-85-15-245.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 23:27:13-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190311 23:36:08<+wesdiscordbot> @josteph works 20190311 23:36:28<+wesdiscordbot> thanks. 20190311 23:36:44<+wesdiscordbot> thanks for fixing 😃 20190311 23:36:56<+wesdiscordbot> I found a second one though 😦 20190311 23:39:25<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/554810636169904139/teams.png 20190311 23:39:29<+wesdiscordbot> unrelated to the fix 20190311 23:39:43<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/bf507ed142b80abcabaeddd40985cd73849be468/src/game_initialization/connect_engine.cpp#L129-L146 20190311 23:40:15<+wesdiscordbot> @sevu what's wrong in that image? 20190311 23:41:28<+wesdiscordbot> About the image: sides 5-9 have allow_player=no, and should be hidden in this screen. 20190311 23:41:58<+wesdiscordbot> unless you use debug mode, which is not the case 20190311 23:42:13<+wesdiscordbot> It works in 1.14.6 like that 20190311 23:43:05<+wesdiscordbot> the screenshot doesn't show sides 5-9. 20190311 23:43:11<+wesdiscordbot> it only shows side 1-4. 20190311 23:44:02<+wesdiscordbot> ah true.. It hides the teams in 1.14.6 too 20190311 23:45:15<+wesdiscordbot> so is there a bug here? 20190311 23:46:09<+wesdiscordbot> yes – the teamnames should be hidden too 20190311 23:46:33<+wesdiscordbot> that'll be due to https://github.com/wesnoth/wesnoth/commit/3ba0bbb3438b3b8612d34b4eddf81cdf1e1ed1da again 20190311 23:47:06<+wesdiscordbot> it fixed a crash, so I would prefer not to revert it altogether. 20190311 23:48:23<+wesdiscordbot> you're saying the teams should be hidden because of allow_player=no, though. that's not the same as what gfgtdf said on the PR (#3853) about hiding unused teams. 20190311 23:53:51-!- travis-ci [~travis-ci@ec2-3-91-100-142.compute-1.amazonaws.com] has joined #wesnoth-dev 20190311 23:53:52< travis-ci> wesnoth/wesnoth#21219 (master - bf507ed : josteph): The build is still failing. 20190311 23:53:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/504975372 20190311 23:53:52-!- travis-ci [~travis-ci@ec2-3-91-100-142.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190311 23:54:47< irker772> wesnoth: nemaara wesnoth:1.14 455fbb207a3e / data/campaigns/Northern_Rebirth/scenarios/ (4 files): NR: adjust gold if Krash is dead https://github.com/wesnoth/wesnoth/commit/455fbb207a3e467743434a66c96cf833474c19e2 20190311 23:54:49< irker772> wesnoth: nemaara wesnoth:1.14 fe9b743ae313 / changelog.md: Update changelog with NR fix https://github.com/wesnoth/wesnoth/commit/fe9b743ae313433f8b5880555e12291c3368c9e4 20190311 23:56:12< irker772> wesnoth: nemaara wesnoth:master 228af56d6bee / data/campaigns/Northern_Rebirth/scenarios/ (4 files): NR: adjust gold if Krash is dead https://github.com/wesnoth/wesnoth/commit/228af56d6bee37eece7a7430d0bf80d2cf1f4f9e 20190311 23:56:14< irker772> wesnoth: nemaara wesnoth:master 7489f38114f9 / changelog.md: Update changelog with NR fix https://github.com/wesnoth/wesnoth/commit/7489f38114f9a53ff1526fa5267851b0fffad83c 20190311 23:56:29<+wesdiscordbot> Certainly better than the hard crash 20190311 23:58:17<+wesdiscordbot> down to 4 campaign issues 😮 --- Log closed Tue Mar 12 00:00:37 2019