--- Log opened Sun Mar 17 00:00:28 2019 20190317 01:46:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190317 01:56:05<+wesdiscordbot> Wait, they can now? 20190317 01:56:14<+wesdiscordbot> I thought that they couldn’t before 20190317 03:09:21-!- gfgtdf [~Daniel@x5f70bac8.dyn.telefonica.de] has quit [Read error: Connection reset by peer] 20190317 03:30:18< celticminstrel> Idea: Make the addons client run the pbl file through the schema validator before uploading? 20190317 03:30:33< celticminstrel> Addons manager I mean, not the Python client (though you could do it for that one too). 20190317 03:31:23< celticminstrel> BTW, the translate key in the pbl doesn't actually do anything anymore, right? 20190317 04:05:15<+wesdiscordbot> celticminstrel: maybe validate pbl files on start up for any add-ons that have them as well, and display errors based on that? I'm thinking in particular of https://github.com/wesnoth/wesnoth/issues/3971 20190317 05:11:10-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds] 20190317 05:23:14-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190317 10:04:56-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20190317 10:06:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds] 20190317 10:06:20-!- wedge010 is now known as wedge009 20190317 10:23:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190317 11:11:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190317 11:38:42-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has joined #wesnoth-dev 20190317 11:53:03-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has quit [Ping timeout: 252 seconds] 20190317 12:31:11-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190317 14:52:03-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 246 seconds] 20190317 14:53:55-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20190317 15:01:21-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 244 seconds] 20190317 15:02:23-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20190317 15:09:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190317 15:15:36-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 250 seconds] 20190317 15:17:25-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20190317 15:22:26-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 272 seconds] 20190317 15:22:49-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20190317 15:30:12-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 246 seconds] 20190317 15:31:29-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20190317 16:04:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190317 17:07:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Read error: Connection reset by peer] 20190317 19:44:51-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190317 21:39:35<+wesdiscordbot> I have this code, which used to work in 1.12: https://gist.github.com/shikadiqueen/e5e006caea65762a8d2cb69c1687a759 20190317 21:41:13<+wesdiscordbot> Basically the idea is that the boss 1 stage 2 event fires if UNIT3 is directly opposite of UNIT1 while attacking UNIT2. The [variables] previous_facing variable holds the facing that UNIT2 has at the start of the attack sequence (it's redundant in hindsight, just $second_unit.facing would do). Negating that with the minus sign is supposed to make the SLF in the conditional block match only under the aforementioned 20190317 21:41:14<+wesdiscordbot> conditions. 20190317 21:41:30<+wesdiscordbot> But in 1.14 it doesn't match and execution falls back to the else branch. Why could this be? 20190317 21:49:16-!- irker019 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190317 21:49:16< irker019> wesnoth/wesnoth:master sigurdfdragon 3ccfd1b3a6 Campaigns: Add Wings of Victory (Drakes) AppVeyor: All builds passed 20190317 21:49:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190317 21:52:04< celticminstrel> Just to rule out the most trivial possible cause... you're absolutely certain that $second_unit.variables.previous_facing does in fact expand to a valid direction, right? 20190317 21:52:48<+wesdiscordbot> Yes 20190317 21:53:36< celticminstrel> Hmm... 20190317 21:54:48< celticminstrel> So if it holds "n" that should be equivalent to adjacent=s which would mean it should match... the unit on the hex south of $x1,$y2? Negating a direction should definitely work, if not it's a bug. 20190317 21:55:14< celticminstrel> It was definitely working when I added the :cw / :ccw syntax. 20190317 21:55:28<+wesdiscordbot> x2,y2 20190317 21:55:36< celticminstrel> Right, right, typo. 20190317 21:55:43<+wesdiscordbot> How could I easily test of negative directions work using :Lia? 20190317 21:55:50<+wesdiscordbot> :lua rather 20190317 21:56:22< celticminstrel> Hmm... not sure... 20190317 21:57:30< celticminstrel> I suppose you could try the wesnoth.map_location functions that involve directions, but I'm not sure if they actually support the - syntax; depends whether it was supported directly in the map_location class or implemented somewhere else. 20190317 21:58:12< celticminstrel> (Maybe we changed the name of that table to wesnoth.map or wesnoth.location or something? I can't remember.) 20190317 22:20:12-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190317 23:20:57-!- madmax28 [~madmax28@2001-4dd6-d445-0-ba27-ebff-febc-e0cb.ipv6dyn.netcologne.de] has joined #wesnoth-dev 20190317 23:22:32-!- madmax28_ [~madmax28@xdsl-78-35-254-14.nc.de] has quit [Ping timeout: 245 seconds] 20190317 23:39:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20190317 23:53:25<+wesdiscordbot> Do you think gfgtdf would know? 20190317 23:53:41< irker019> wesnoth/wesnoth:1.14 Steve Cotton 0aa3975011 NR S02: Neater way to check that there's AppVeyor: All builds passed 20190317 23:53:46< celticminstrel> Well.. he might? 20190317 23:54:00<+wesdiscordbot> Do you think he might know? 20190317 23:54:15< celticminstrel> I think it's possible. --- Log closed Mon Mar 18 00:00:29 2019