--- Log opened Thu Apr 18 00:00:35 2019 20190418 00:20:50-!- irker469 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190418 00:20:50< irker469> wesnoth/wesnoth:master Nils Kneuper ed6fe0b194 updated Dutch translation AppVeyor: All builds passed 20190418 00:55:47-!- heirecka_ [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20190418 01:02:44-!- Netsplit *.net <-> *.split quits: aidanhs, heirecka 20190418 01:02:44-!- heirecka_ is now known as heirecka 20190418 01:09:09-!- Netsplit over, joins: aidanhs 20190418 02:50:51< irker469> wesnoth/wesnoth:1.14 Nils Kneuper 8f7c986681 updated Dutch translation AppVeyor: All builds passed 20190418 02:53:01< celticminstrel> @Yumi maybe comment on WoV PR soonish? 20190418 02:57:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190418 02:59:03<+wesdiscordbot> erm wat 20190418 03:02:18<+wesdiscordbot> I guess I can look at it, not sure what I'm expected to say tho 😮 20190418 03:12:45<+wesdiscordbot> hmm yeah, I don't really see anything I'd want specifically changed for now 20190418 03:15:40<+wesdiscordbot> don't think I have time to play it before release, but I suspect that the gameplay should be okay 20190418 03:15:55<+wesdiscordbot> release -> PR merging 20190418 04:53:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190418 05:50:59-!- irker469 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190418 05:53:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20190418 06:18:17-!- irker367 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190418 06:18:18< irker367> wesnoth/wesnoth:1.14 nemaara 70b60e16ef EI S16: make Konrad II have only the loy AppVeyor: All builds passed 20190418 08:14:47<+wesdiscordbot> UtBS 20190418 08:16:00<+wesdiscordbot> The tooltip for the 'daze' affliction says 'defense' instead of 'defence'. 20190418 08:19:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190418 08:22:34<+wesdiscordbot> That's not a bug unless you're using the British English translation 20190418 08:23:18< irker367> wesnoth/wesnoth:master nemaara aae617f7a8 EI S16: make Konrad II have only the loy AppVeyor: All builds passed 20190418 08:25:14<+wesdiscordbot> defence is actually a thing in British English? Interesting. 🤔 20190418 08:25:33<+wesdiscordbot> There's several spellings that vary between American and British English, too many to list here 20190418 08:29:37< vn971> Bitron: yeah, in US at least it's "defense" 20190418 08:38:23<+wesdiscordbot> Hm. I singled 'defense' out as the wrong word, because the 'daze' and 'formation' description refer to the same thing as 'defence'. 20190418 08:38:53<+wesdiscordbot> And yeah, apparently I am using the British English Translation. 20190418 08:40:13<+wesdiscordbot> It may be out of date 20190418 08:40:13<+wesdiscordbot> Wedge009: See above. (You're the GB English translation maintainer according to the wiki.) 20190418 08:41:08<+wesdiscordbot> (this might be a redundant reminder but strings that haven't been added to a translation or are currently fuzzy show up in the original form) 20190418 09:12:44< wedge009> Yes, it's spelled defence in English, I'll check the po files - might have been that way before I started. 20190418 09:26:21< wedge009> As best as I can tell en_GB is using defence where it's supposed, for all cases not just UtBS. 20190418 09:26:44< wedge009> Konrad2: where do you find the daze affliction? Is it different from stunned? 20190418 09:28:25< wedge009> Oh, is it this line? 'dazed: This unit is dazed. It suffers a -10% penalty to both its defense and chance to hit (except for magical attacks).' 20190418 09:28:43< wedge009> The localisation is 'dazed: This unit is dazed. It suffers a -10% penalty to both its defence and chance to hit (except for magical attacks).' 20190418 09:31:15< wedge009> What units has this daze ability? 20190418 11:03:04< irker367> wesnoth/wesnoth:master sigurdfdragon 7fd6ddf923 Campaigns: Add Wings of Victory (Drakes) AppVeyor: All builds passed 20190418 11:07:44<+wesdiscordbot> wedge009 It's specific for UtBS, the Quenoth Mystic and it's Shaman advances. 20190418 11:07:58< wedge009> its :p 20190418 11:08:00< wedge009> Okay, thanks. 20190418 11:08:10<+wesdiscordbot> Huh. Right, thanks. ^^ 20190418 11:09:40< wedge009> I just checked the Steam version (which I assume is the same as the wesnoth.org release) and it shows as defence. 20190418 11:10:08< wedge009> BTW, why are the official releases marked as modified these days? Building from a 'dirty' repository? 20190418 11:11:40< wedge009> Konrad2: Are you using a development build or official release? 20190418 11:15:30<+wesdiscordbot> https://github.com/wesnoth/wesnoth/issues/4030#issuecomment-484430482 20190418 11:15:52<+wesdiscordbot> "There is still something strange about ms_after. If I set ms_after for the intro music, it hangs before the intro music starts to play. And if I set ms_after in the prestart event, it hangs before that music starts to play. Doesn't it mean that the sound engine takes ms_after of the wrong track?" 20190418 11:16:05<+wesdiscordbot> Can I fix this in the 1.14 branch, or should it be only in master? 20190418 11:18:18<+wesdiscordbot> wedge009 Wesnoth 1.14.7 20190418 11:18:19<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/568394866686689280/dazed.png 20190418 11:18:49<+wesdiscordbot> It's the official steam release. 20190418 11:21:19< wedge009> jyrkive: If you're able to resolve it why shouldn't it go in 1.14? Or does it potentially require a huge change? (The engine rewrite you mentioned.) 20190418 11:22:33< wedge009> Konrad2: So it looks like a unit which is suffering from daze, I was looking at the attack description for the mystics. 20190418 11:22:55<+wesdiscordbot> Yeah, it's the affliction, not the attack special. ^^ 20190418 11:23:44<+wesdiscordbot> wedge009: No, not really. But it would be an API change (albeit just making the behavior match the existing documentation). 20190418 11:24:42< wedge009> I don't see why making the implementation match the documentation is a bad thing, unless it breaks stuff for people relying on the existing non-documented behaviour. 20190418 11:26:42< wedge009> Konrad2: Confirmed in Steam, but it's definitely the correct spelling in the po translation. And those were done ages ago when the string freeze was first put in place. 20190418 11:29:30< wedge009> https://github.com/wesnoth/wesnoth/blob/1.14/po/wesnoth-utbs/en_GB.po#L137 20190418 11:29:46< wedge009> I'll update my own translations from 1.14 and see what happens. 20190418 11:30:19<+wesdiscordbot> UtBS S2 is missing a 'Turns run out' lose condition in the scenario objectives. 20190418 11:30:29<+wesdiscordbot> Same for S1 actually. 20190418 11:31:28<+wesdiscordbot> Also, is it intentional that units suffer from poison during the day if they are cared('healed') for by a unit without a cure ability? 20190418 11:32:42<+wesdiscordbot> End the turn, Garak will be poisoned and lose hp due to being poisoned next turn despite being next to a +4 heal unit. 20190418 11:32:43<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/568398498383527946/UtBS-Across_the_Harsh_Sands_Turn_4.gz 20190418 11:46:19<+wesdiscordbot> Btw, why do other living beings (except scorpions) suffer from dehydration in this scenario? 20190418 11:46:25< wedge009> Can't recall the specific scenario, but I thought only cure cures poison, not heal. 20190418 11:47:18<+wesdiscordbot> Heal doesn't cure poison, but it 'negates' it. It doesn't remove it, but you won't take damage that turn, nor will you be healed. 20190418 12:30:33< wedge009> I can't remember if that's shown as -8 +8, or does the poisoned unit not show anything at all? 20190418 12:31:15< wedge009> If the healer is only +4, then the poisoned unit will still lose HP overall. 20190418 12:39:00< vn971> no wait, the heal description says something like "or stop poison" I think? So a combination of poison and heal+4 should give a zero HP change? 20190418 12:39:47< vn971> or not? :thinking: 20190418 12:41:06<+wesdiscordbot> elvish shamen cancel out poison of units next to them for that turn. 20190418 12:42:02< wedge009> In the old days, I distinctly remember a healer (+8) and poisoned unit cancel each other out by showing both occurring. So a +4 healer wouldn't be able to completely cancel the poisoning. But I don't know if things have changed since then. 20190418 12:42:41< wedge009> Or whether there are special units like Elvish Shamen that do completely cancel the effects of poison (apparently). 20190418 12:43:03<+wesdiscordbot> with the shaman, nothing shows up - it's like the unit isn't poisoned for as long as the shaman is next to them. 20190418 12:43:03< vn971> Shaman I think 20190418 12:43:34< vn971> I'm just at work, can't test right now -- but it should be fairly easy. 20190418 12:44:12< vn971> in multi-player, you also won't suffer from poison on your turn, but then again ally unit won't help you on their turn if you're poisoned as well. 20190418 12:44:42< vn971> I think -^ 20190418 12:45:50< vn971> which, now that I think of it, changes the order of things a bit BTW. If you want "positive" healing, you try to position your units around allied healer so that, when it's ally turn, your units will be healed. 20190418 12:46:18< vn971> for "counter-poisoning", however, the ally can just run to your units on their turn and it'll still be in time. 20190418 12:47:06< vn971> / I've explained from a point of view of the poisoned side of course, same logic applies if you are the healer and must heal somebody.) 20190418 12:47:23< wedge009> Looks like the mechanics have changed. The +4 heal shaman seems to cancel (but not remove) the poisoning. 20190418 12:48:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190418 12:51:45< wedge009> Oh I see, Konrad2 was quoting the ability description. 20190418 12:51:57-!- celticminstrel is now known as celmin|away 20190418 12:54:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190418 13:03:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190418 13:04:56< wedge009> Konrad2: I just did a fresh build on 1.14 branch and still get 'defense'. 20190418 13:07:16<+wesdiscordbot> wedge009 Sorry, but I have no idea why that would be. :/ I really only know how to point out inconsistencies, but mostly I don't know how to fix them. 20190418 13:10:04< wedge009> I think that might be a premature confirmation - I rechecked the configuration on that machine and realised translations aren't working on it. Recompiling (again - sigh) on a machine where translations do work... 20190418 13:11:57< wedge009> Not asking you to fix. 20190418 13:37:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190418 13:42:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20190418 13:42:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190418 13:45:28< wedge009> Konrad2: Okay, confirming it is a genuine problem - 'defence' on the mystic and 'defense' on the victim. :/ 20190418 14:00:25< wedge009> Konrad2, Iris, Bitron, jyrkive: Screen shot while using en_GB - https://cdn.discordapp.com/attachments/259976436490829825/568394866686689280/dazed.png 20190418 14:00:31< wedge009> Source - https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Under_the_Burning_Suns/lua/theme.lua#L26 20190418 14:00:36< wedge009> Translation - https://github.com/wesnoth/wesnoth/blob/1.14/po/wesnoth-utbs/en_GB.po#L137 20190418 14:00:42< wedge009> Contrast working example: 20190418 14:00:47< wedge009> Source - https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg#L119 20190418 14:00:51< wedge009> Translation - https://github.com/wesnoth/wesnoth/blob/1.14/po/wesnoth-utbs/en_GB.po#L16154 20190418 14:01:28< wedge009> Problem is with 1.14.7 release and current 1.14 branch. Is there something different with the way the Lua strings are handled that would make it appear to not honour translation texts? 20190418 14:02:24< wedge009> Konrad2: If we don't get a resolution to this, can you record this as an issue please? 20190418 14:03:26-!- irker367 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190418 14:14:42<+wesdiscordbot> wedge009 Sure, but I'll only get to it in some hours. 20190418 14:15:08<+wesdiscordbot> @Bitron @jyrkive ^ 20190418 14:46:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190418 14:46:13-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190418 15:04:26-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20190418 15:04:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190418 15:36:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190418 17:01:16-!- Ravana [~Ravana@wesnoth/mp-mod/ravana] has joined #wesnoth-dev 20190418 17:14:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190418 18:32:00-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190418 18:32:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds] 20190418 21:18:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190418 21:21:44<+wesdiscordbot> Hmm 20190418 21:22:05<+wesdiscordbot> @Yumi - I tried to create a branch in the wesnoth repository but it doesn't seem to allow that 20190418 21:22:13<+wesdiscordbot> Am I missing something really simple? 20190418 21:23:06<+wesdiscordbot> only people with commit access can create branches on the main wesnoth repository. otherwise, you should create a fork and then make your changes there. 20190418 21:23:15<+wesdiscordbot> Okay I will do that! 20190418 21:23:40-!- irker868 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190418 21:23:40< irker868> wesnoth/wesnoth:master nemaara d64dafc500 UtBS S2: dialogue tweak AppVeyor: All builds passed 20190418 22:21:17<+wesdiscordbot> @The_Gnat so dunefolk is ready now? 20190418 22:32:29-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190418 22:33:42<+wesdiscordbot> We are only waiting for missing sprites. 20190418 22:46:14<+wesdiscordbot> right, I need to look at stats still 20190418 22:46:23<+wesdiscordbot> is the one on the server up to date? 20190418 22:57:35<+wesdiscordbot> Yes. It should be up to date. 20190418 23:19:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds] 20190418 23:26:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190418 23:54:44< celmin|away> Spam in umc-dev or whatever it's called, was that person dealt with already? 20190418 23:54:57<+wesdiscordbot> Yes 20190418 23:55:03< celmin|away> Okay just making sure 20190418 23:55:21< celmin|away> Kinda thought they were since they'd stopped but... --- Log closed Fri Apr 19 00:00:36 2019