--- Log opened Fri Apr 19 00:00:36 2019 20190419 00:01:22< irker868> wesnoth/wesnoth:1.14 nemaara 3b36a4490a UtBS S2: dialogue tweak AppVeyor: All builds passed 20190419 00:12:32<+wesdiscordbot> "so dunefolk is ready now?" - @Yumi - Yes it is nearly complete, but don't worry I will wait for your feedback! 20190419 00:13:06<+wesdiscordbot> The main thing now is converting it from an UMC add-on to mainline which requires renaming id''s and such 20190419 00:13:20<+wesdiscordbot> once I stop getting distracted watching spongebob, I'll look at the stats again XD 20190419 00:13:28<+wesdiscordbot> xD 20190419 00:15:08-!- celmin|away is now known as celticminstrel 20190419 00:16:31<+wesdiscordbot> okay okay okay no more spongebob for now 🍍 20190419 01:39:00<+wesdiscordbot> ` 20190419 01:59:52< irker868> wesnoth/wesnoth:master Jyrki Vesterinen b023b818c7 Fix [music] ms_after= setting fade-out t AppVeyor: All builds passed 20190419 04:36:47< irker868> wesnoth/wesnoth:1.14 Jyrki Vesterinen 5cc530141b Changelog and RELEASE_NOTES entry for co AppVeyor: All builds passed 20190419 05:27:56-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190419 06:39:12< irker868> wesnoth/wesnoth:master DisherProject 5ca7089e9f UtBS S8: Buff gate guardians AppVeyor: All builds passed 20190419 07:38:40< irker868> wesnoth/wesnoth:master DisherProject 0deea1f8ad UtBS S8: Buff gate guardians AppVeyor: All builds passed 20190419 08:31:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190419 08:32:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190419 08:36:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190419 08:38:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190419 10:25:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190419 10:25:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20190419 10:31:13<+wesdiscordbot> So, who had the idea to create the 'formation' ability? Is that person still around? 20190419 10:38:47-!- irker868 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190419 10:52:41<+wesdiscordbot> @Ravana Can you explain to me how 'This unit gains +10% bonus to defence when another unit with the same ability is adjancent to it.' results into '....it takes 3 allies with formation to reduce 60 to 50.' 20190419 10:52:55<+wesdiscordbot> I don't get it. 😦 20190419 10:58:45< Ravana> https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg#L624 20190419 11:02:44<+wesdiscordbot> Why does this then work? 20190419 11:02:44<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/568753334400581643/unknown.png 20190419 11:04:15< Ravana> it should not 20190419 11:08:12<+wesdiscordbot> There is also the thing that, while you've send me the code, it does not explain how the player is expected to get understand that your stated behavior from the description of the ability at all. 20190419 11:08:33<+wesdiscordbot> While the screenshot over there perfectly conforms with the description. 20190419 11:09:28<+wesdiscordbot> (There is still the question why 'formation' doesn't work against units created by debug mode though...) 20190419 11:09:52< Ravana> it works through unit placed 20190419 11:10:11<+wesdiscordbot> ? 20190419 11:10:23<+wesdiscordbot> I don't know what you mean. 20190419 11:10:46< Ravana> and documentation has "Units created via debug mode" as unit placed triggers 20190419 11:11:01< Ravana> though 20190419 11:11:09< Ravana> it does not affect side 1 units 20190419 11:11:17< Ravana> and debug units start as side 1 20190419 11:11:25< Ravana> that has to be it 20190419 11:11:51< Ravana> if you advance those debug units after you change side it should work 20190419 11:12:19<+wesdiscordbot> Hm, so it's some kind of bug with an existing workaround? 20190419 11:12:31< Ravana> not really 20190419 11:12:44< Ravana> debug mode is not expected not to break game 20190419 11:13:12<+wesdiscordbot> Oh, okay. :C 20190419 11:13:23< vn971> There's always the possibility to also rewrite it in Lua and make it work nicer I guess, without debug unit creation limitations for example. πŸ™ƒ 20190419 11:13:51< vn971> but while you can rewrite most of the stuff, usually it doesn't worth the effort... 20190419 11:13:52< Ravana> https://github.com/wesnoth/wesnoth/blob/1.14/data/campaigns/Under_the_Burning_Suns/utils/abilities.cfg#L545 that stops debug event 20190419 11:14:56< vn971> oh, we're not even in UMC channel. We could have this conversation there.. 20190419 11:15:06< Ravana> its core game 20190419 11:16:15< vn971> ah, OK 20190419 11:16:49<+wesdiscordbot> I don't even know what conclusion to take from the whole discussion. Is formation broken or is it not? Does it work as intended? I thought I knew before, but now I just have no clue and no idea how to test it. xD 20190419 11:17:15< Ravana> not sure either 20190419 11:17:30< Ravana> at least we know it does not work as described 20190419 11:17:45<+wesdiscordbot> Well...no. 20190419 11:18:04<+wesdiscordbot> It works as described, but you told me that the code says something else. 20190419 11:18:21<+wesdiscordbot> (And I don't understand the code good enough to say anything about that.) 20190419 11:19:01<+wesdiscordbot> looking at the code Ravana sent earlier, there is a number of versions of this ability, it seems. like, formation_enemy_3 says count=3-5 but formation_enemy_1 says count=1-5 20190419 11:19:09< Ravana> I thought your original issue was that it did not in fact work as described 20190419 11:20:58<+wesdiscordbot> Yeah, but that was cleared up by pointing out that it doesn't work with debug mode created units. 20190419 11:21:18< Ravana> debug mode created enemies 20190419 11:21:24<+wesdiscordbot> Repeating my tests with recruited (and then side changed) units worked. 20190419 11:21:28< Ravana> created units with formation should work 20190419 11:22:04<+wesdiscordbot> I have no consistent result to confirm that. xD 20190419 11:25:17<+wesdiscordbot> I guess we know now that it works as described, but not the way you read the code for it. That's another issue, maybe? 20190419 11:27:01< Ravana> it has separate implementation on master 20190419 12:58:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190419 13:13:27<+wesdiscordbot> Okay. Does it also have a different description? 20190419 13:21:52< Ravana> I don't think so 20190419 13:31:11<+wesdiscordbot> I hope that changes at some point. 20190419 13:31:20<+wesdiscordbot> Something else: http://forums.wesnoth.org/viewtopic.php?p=641377#p641379 20190419 14:01:50-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds] 20190419 14:16:46-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190419 14:55:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190419 14:56:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190419 15:18:48-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20190419 15:19:05-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190419 15:19:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190419 15:20:09<+wesdiscordbot> Sorry, where is the correct FORMATION code? I need it to fix this UMC one day. 20190419 15:21:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190419 15:23:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190419 16:27:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190419 17:06:39-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190419 18:23:44-!- irker226 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190419 18:23:44< irker226> wesnoth/wesnoth:master DisherProject 30af6a75a2 UtBS: Add "Turns run out" objectives AppVeyor: All builds passed 20190419 18:25:31-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20190419 18:27:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds] 20190419 18:27:00-!- wedge010 is now known as wedge009 20190419 19:30:00<+wesdiscordbot> Who is maintaining Android build? It occurred to me that it’s a good moment to cooperate on some things. 20190419 19:30:53<+wesdiscordbot> that would be alep: https://forums.wesnoth.org/viewtopic.php?f=6&t=48327 20190419 19:49:14<+wesdiscordbot> Thanks. 20190419 20:57:08-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190419 21:06:18-!- sevu [~sevu@p5B28FA31.dip0.t-ipconnect.de] has joined #wesnoth-dev 20190419 21:20:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20190419 21:24:33-!- irker226 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190419 21:48:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190419 22:59:02-!- sevu [~sevu@p5B28FA31.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds] 20190419 23:13:26-!- sevu [~sevu@p5B28FA31.dip0.t-ipconnect.de] has joined #wesnoth-dev --- Log closed Sat Apr 20 00:00:37 2019