--- Log opened Mon May 06 00:00:48 2019 20190506 03:33:15-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190506 04:50:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190506 05:50:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 268 seconds] 20190506 06:59:43-!- irker383 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190506 06:59:43< irker383> wesnoth/wesnoth:1.14 doofus-01 79bc80227c adding new great wolf portrait, re-assig AppVeyor: All builds passed 20190506 07:14:18-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190506 08:03:06-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 252 seconds] 20190506 08:30:43-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190506 08:44:46< vn971> Hm https://pointsgame.net/vn971/temp/2019.05.06_10:44:22_42f7537.png 20190506 08:44:55< vn971> Just clicked on a game in lobby 20190506 08:46:13< vn971> it's reproducible right now. * restart wesnoth client * go to current lobby * select the game "для кота" (WC2) * on the right panel click button "Observe". 20190506 09:02:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190506 09:08:33< Soliton> do you have wc2 installed? 20190506 09:28:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190506 09:28:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20190506 09:39:08-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 255 seconds] 20190506 09:47:07-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds] 20190506 09:47:29-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev 20190506 10:00:08-!- irker383 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190506 10:01:51-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190506 10:11:44< vn971> Soliton: nope 20190506 10:12:49< Soliton> does the game use modifications? 20190506 10:15:07< Soliton> if you try again with --log-debug=lobby you may get more info in the log output. 20190506 10:22:33<+wesdiscordbot> The game doesn't log more information about it. 20190506 10:23:27<+wesdiscordbot> The error message is shown when a match 1) does not require any add-ons, and 2) your copy of Wesnoth does not have all required add-ons. 20190506 10:23:36<+wesdiscordbot> Of course, that's logically impossible. 20190506 10:23:38<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/60fd504caf46bbb1648de369303b76225d805e5d/src/gui/dialogs/multiplayer/lobby.cpp#L951 20190506 10:25:40< Soliton> https://github.com/wesnoth/wesnoth/blob/60fd504caf46bbb1648de369303b76225d805e5d/src/game_initialization/lobby_data.cpp#L515 this is where the game logs more information. 20190506 10:26:29<+wesdiscordbot> Ah, I see. I didn't know that there was logging about this. 20190506 10:26:53< Soliton> it doesn't seem like that case is what's happening though. 20190506 10:27:50< Soliton> from reading the code it seems to me that if a modification is missing it does not add a required addon though. 20190506 10:28:22< Soliton> so that could be a case where that error would show. 20190506 10:29:52< Soliton> https://github.com/wesnoth/wesnoth/blob/60fd504caf46bbb1648de369303b76225d805e5d/src/game_initialization/lobby_data.cpp#L301 there it changes addons_outcome but does not add to required_addons. 20190506 10:31:20< Soliton> requiring those two variables to be in sync seems like a bad design anyway. 20190506 10:31:29<+wesdiscordbot> Agreed. 20190506 10:33:53<+wesdiscordbot> agh. that's code i worked on 20190506 12:07:18-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 252 seconds] 20190506 12:08:15<+wesdiscordbot> @hrubymar10 I wasn't planning to backport that, since it's effectively an API change for addons with custom ranges/types. But maybe I'm being too conservative. 20190506 12:08:51<+wesdiscordbot> @hrubymar10 I do backport that in my local build. 20190506 12:10:35<+wesdiscordbot> @josteph and you are talking about icons feature from master? (which I pointed yesterday) 20190506 12:10:44<+wesdiscordbot> @hrubymar10 Yeah, sorry. 20190506 12:10:50<+wesdiscordbot> Np 😄 20190506 12:11:24<+wesdiscordbot> https://github.com/wesnoth/wesnoth/projects/4 20190506 12:12:11<+wesdiscordbot> I like this feature and I believe that it could be also in 1.14.x series. Also 1.15 and 1.16 series don't seems to be released anytime soon 20190506 12:12:51<+wesdiscordbot> We could backport it if we want to. It handles gracefully attacks with custom ranges or types. 20190506 12:13:20<+wesdiscordbot> If the range or type doesn't have an image, then the "melee-impact" text form is showed. 20190506 12:14:18<+wesdiscordbot> If a unit has two attacks, one of the attacks has mainline ranges/types and one attack has custom ranges/types, then it'd look a bit funny... That's the only downside to backporting that I can think of. 20190506 12:16:46<+wesdiscordbot> @Vultraz Can I rename this milestone to 1.14.9 ? https://github.com/wesnoth/wesnoth/milestone/17 20190506 12:20:38<+wesdiscordbot> Yes 20190506 12:22:00-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190506 12:42:40-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190506 12:52:39<+wesdiscordbot> @josteph ^^ 20190506 12:55:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190506 12:58:03-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds] 20190506 13:11:47<+wesdiscordbot> replied 20190506 13:12:33-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190506 14:22:09-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 258 seconds] 20190506 14:34:07-!- valdar [~atarocch@93.56.172.28] has quit [Read error: No route to host] 20190506 14:34:29-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190506 14:35:09-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190506 15:17:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190506 17:02:01-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190506 19:39:25-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20190506 20:29:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190506 21:01:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190506 22:03:41-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds] 20190506 22:06:18-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190506 22:06:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190506 22:48:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190506 23:51:24-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Tue May 07 00:00:49 2019