--- Log opened Wed May 08 00:00:50 2019 20190508 00:46:52-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190508 01:40:40< irker451> wesnoth/wesnoth:1.14 josteph 43cc33ee2d mp_staging: Fix terminology in tooltip AppVeyor: All builds passed 20190508 03:33:22-!- celmin|away [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190508 04:33:38< irker451> wesnoth/wesnoth:1.14 Steve Cotton d56884c60b tips: Clarify that these are about the e AppVeyor: All builds passed 20190508 05:06:59-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Ping timeout: 276 seconds] 20190508 05:07:38-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20190508 05:39:31-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20190508 05:40:02-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20190508 07:28:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190508 07:33:57-!- irker451 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190508 07:52:50<+wesdiscordbot> @Pentarctagon @celmin - Would you mind if I added into the PR a commit for a few multiplayer scenarios as well. So far I found Hornshark needs updating for the DF era (it has starting units asigned for all the other default factions). 20190508 07:52:58<+wesdiscordbot> I would think Dark forecast might also 20190508 08:20:30<+wesdiscordbot> @The_Gnat you can, but that's kind of extra at this point. 20190508 08:22:35<+wesdiscordbot> True, but after all these months xD between sprites and re-balance and all it might as well be a wholistic revision 20190508 08:23:15< Soliton> "the PR" means the dunefolk balancing changes? doesn't seem to belong in there. might as well do a separate PR. 20190508 08:23:47< Soliton> the more you put into one PR the less likely it gets merged. 20190508 08:38:22<+wesdiscordbot> Okay yeah I am new to how you do this 20190508 08:38:23<+wesdiscordbot> xD 20190508 08:38:35<+wesdiscordbot> In that case I can make to PR's? 20190508 08:38:49< Soliton> you can make as many as you like. 20190508 08:39:06<+wesdiscordbot> 😉 20190508 08:39:38<+wesdiscordbot> My original question was not so much as to whether I 'can' do something (I know what I 'can' do) but whether you would approve of such 20190508 08:39:46<+wesdiscordbot> If the PR isn't accepted there is no point haha 20190508 08:40:47<+wesdiscordbot> @Soliton - So what do you think? Do you think that with the DF rework a change in the scenario is meritted? 20190508 08:41:48< Soliton> it is probably meritted with or without. that's why i'm saying it does not belong to the balancing changes. it can be decided on independently. 20190508 08:42:49< Soliton> of course what units you choose might be influenced by the balancing changes... 20190508 08:43:01<+wesdiscordbot> Hmm... Good point 20190508 08:43:07< Soliton> in the case of hornshark at least. 20190508 08:43:56< Soliton> how do the balancing changes come along? i haven't read the forum in a while only your initial posts. 20190508 08:45:18<+wesdiscordbot> Very well, actually they are pretty much done 20190508 08:45:31< Soliton> my comment about not overloading one PR is just about the nature of decision making really. the smaller the PR the more likely one person can go through it quickly and decide on it and merge it or request changes. 20190508 08:45:35<+wesdiscordbot> We have made a few updates and haven't recieved any more comments 20190508 08:46:45< Soliton> the more you put in the more likely it is one person doesn't want to decide on it alone because it takes a while to check everything, maybe parts are not in their area of expertise etc. 20190508 08:46:46<+wesdiscordbot> Yeah that makes sense 20190508 08:47:43<+wesdiscordbot> Though it is a pretty massive amount of changes already.... 20190508 08:48:01< Soliton> thus i would be very weary to put even more in. 20190508 08:48:21<+wesdiscordbot> Yeah 20190508 08:48:31<+wesdiscordbot> I wonder, how do you developers normally approach large balance changes 20190508 08:48:39<+wesdiscordbot> Such as this project? 20190508 08:48:49< Soliton> i don't think we ever have. 20190508 08:49:01<+wesdiscordbot> Oh haha 20190508 08:49:04<+wesdiscordbot> Understandable 20190508 08:49:19<+wesdiscordbot> I guess for a change such as this, it needs to be cohesive and so it has to all come together 20190508 08:49:49< Soliton> sure, it makes sense for the dunefolk. 20190508 08:50:52<+wesdiscordbot> If you don't mind me asking balance-wise what is the dev's feeling as to the changes we have made, is the confidence level high or are you mostly still skeptical? 20190508 08:50:58< Soliton> perhaps the holy -> arcane thing was the biggest change before this. 20190508 08:51:14<+wesdiscordbot> Yes 20190508 08:51:50< Soliton> from what i remember reading about your changes it looked well thought out and tested and no obvious issue, i think. 20190508 08:52:35<+wesdiscordbot> Okay 👍 good to know. I was just curious about how much review you think would be necessary before approving it 20190508 08:53:09< Soliton> a lot of review happened in the forum discussions. i would only expect technical details at this point. 20190508 08:54:26<+wesdiscordbot> Great! Good to ensure that we are on the same page! 20190508 08:54:47<+wesdiscordbot> Perhaps in future (if you want) we can review the MP scenarios in light of the DF 20190508 08:56:18< Soliton> it certainly would be nice to get them into any scenario that features all the other default factions in some hardcoded way. like hornshark you pointed out or some survival map. 20190508 08:58:35<+wesdiscordbot> okay sounds like a plan 20190508 08:58:46<+wesdiscordbot> but as a different PR 😉 20190508 12:45:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190508 12:59:49-!- celticminstrel is now known as celmin|away 20190508 16:24:01-!- irker604 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190508 16:24:01< irker604> wesnoth/wesnoth:1.14 Steve Cotton e422c42921 tips: Clarify that these are about the e AppVeyor: All builds passed 20190508 17:51:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190508 18:08:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190508 18:08:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20190508 18:13:22-!- stikonas_ is now known as stikonas 20190508 18:54:43< irker604> wesnoth/wesnoth:master Steve Cotton e1e7bf7585 tips: Clarify that these are about the e AppVeyor: All builds passed 20190508 20:15:03-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 250 seconds] 20190508 20:15:03-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 250 seconds] 20190508 20:15:18-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190508 20:16:44-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20190508 20:54:24-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Read error: Connection reset by peer] 20190508 21:02:59-!- sevu [~sevu@p5B28F703.dip0.t-ipconnect.de] has joined #wesnoth-dev 20190508 21:03:18< sevu> about to bisect 4053 20190508 21:03:37< sevu> how can I turn of _FORTIFY_SOURCE 20190508 21:04:21< sevu> it's set by scons... to compile quicker I use -O0, but that's not a good mix witht he macro, can I somehow undefine it? 20190508 21:04:54< sevu> -O0 set by extra_release_flags 20190508 21:05:54<+wesdiscordbot> Use opt=-O0 instead. 20190508 21:06:02<+wesdiscordbot> It disables source fortification for you. 20190508 21:07:05< sevu> Thanks 20190508 21:27:16-!- travis-ci [~travis-ci@ec2-107-20-42-205.compute-1.amazonaws.com] has joined #wesnoth-dev 20190508 21:27:16< travis-ci> wesnoth/wesnoth#21514 (1.14 - 6007309 : Martin Hrubý (hrubymar10)): The build has errored. 20190508 21:27:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/529983161 20190508 21:27:17-!- travis-ci [~travis-ci@ec2-107-20-42-205.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190508 21:31:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20190508 21:55:20-!- irker604 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190508 22:05:19-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20190508 22:16:18<+wesdiscordbot> @hrubymar10 don't do that please 20190508 22:16:30<+wesdiscordbot> If you look at previous commits to that file you'll see it's not as simple as you think 20190508 22:17:14<+wesdiscordbot> @Iris I am really sorry... I was thinking that I am pushing into my fork... 20190508 22:17:30<+wesdiscordbot> Sorry about that 20190508 22:19:15<+wesdiscordbot> @Iris I wanted to ask you later, if you can do po update, because I don't have required po4a package and I can't install it (it isn't available for macOS) 20190508 22:19:34<+wesdiscordbot> I'll do it in a bit, was busy upgrading the forums 20190508 22:19:58<+wesdiscordbot> Can you post in the release announcement thread for the sake of completeness? 20190508 22:20:22<+wesdiscordbot> I'm editing the OP but I'd like you to post a reply pointing out that a new revision was released anyway 20190508 22:21:01<+wesdiscordbot> Hm 20190508 22:21:32<+wesdiscordbot> Yes, I can post in release announcement thread 20190508 22:24:21<+wesdiscordbot> So should I create reply to 1.14.7 announcement https://forums.wesnoth.org/viewtopic.php?f=5&t=49712 ? Or you want me to create special thread for it? I don't think that it is necessary. It would be probably enough if you can update old announcement with new shasum 20190508 22:24:31<+wesdiscordbot> Post a reply to the existing thread 20190508 22:24:48<+wesdiscordbot> I already edited the OP 20190508 22:25:37<+wesdiscordbot> Right, so we have a problem 20190508 22:25:45<+wesdiscordbot> The file on SF.net is in the 1.14.8 folder 20190508 22:26:10<+wesdiscordbot> I never expected this situation to happen, where the latest release is in different folders for different platforms 20190508 22:26:41<+wesdiscordbot> So as a result https://github.com/wesnoth/wesmere/pull/13 is going to cause an invalid link to be generated (https://sourceforge.net/projects/wesnoth/files/wesnoth-1.14/wesnoth-1.14.7/Wesnoth_1.14.8a.dmg/download) 20190508 22:27:14<+wesdiscordbot> I see 20190508 22:27:32<+wesdiscordbot> We can create another "special case" 20190508 22:27:38<+wesdiscordbot> iOS is handled like that 20190508 22:28:01<+wesdiscordbot> https://github.com/hrubymar10/wesmere/blob/master/static/docroot/index.php#L69 20190508 22:28:09<+wesdiscordbot> I know my own code... 20190508 22:28:21<+wesdiscordbot> I don't want these special cases though, why can't you just move the file to where it really belongs? 20190508 22:29:19<+wesdiscordbot> Doesn't have sourceforge any kind of "endpoint" which targets to default download for selected platform? 20190508 22:29:33<+wesdiscordbot> Not to my knowledge 20190508 22:29:43<+wesdiscordbot> https://sourceforge.net/projects/wesnoth/files/latest/download 20190508 22:29:55<+wesdiscordbot> on mac it points to mac download 20190508 22:30:05<+wesdiscordbot> We don't want that 20190508 22:30:14<+wesdiscordbot> There's separate links for each platform for a reason 20190508 22:30:30<+wesdiscordbot> Can you say yes or no to the above please? 20190508 22:30:47<+wesdiscordbot> to moving into 1.14.7 folder? 20190508 22:31:10<+wesdiscordbot> Yes, that's what I asked 20190508 22:31:48<+wesdiscordbot> Well I can do that ofc. But you will have version 1.14.8 in 1.14.7 folder which looks weird 20190508 22:32:05<+wesdiscordbot> So is having a 1.14.8 folder with only the mac release 20190508 22:33:30<+wesdiscordbot> So should I move it? 20190508 22:33:39<+wesdiscordbot> If you can yes 20190508 22:35:22<+wesdiscordbot> done 20190508 22:35:42<+wesdiscordbot> https://sourceforge.net/projects/wesnoth/files/wesnoth-1.14/wesnoth-1.14.7/Wesnoth_1.14.8a.dmg/download 20190508 22:36:15<+wesdiscordbot> thanks 20190508 22:36:55<+wesdiscordbot> I thank you 20190508 22:37:23<+wesdiscordbot> Your PR has a mistake still actually 20190508 22:37:40<+wesdiscordbot> It refers to Wesnoth_1.14.8.dmg when it's actually Wesnoth_1.14.8a.dmg 20190508 22:38:27<+wesdiscordbot> I see... Should I update my PR or are you going to change it directly? 20190508 22:38:46<+wesdiscordbot> if you update your PR that'd be great bc I'm multitasking right now 20190508 22:43:32<+wesdiscordbot> Fixed 20190508 22:44:26<+wesdiscordbot> What about the wesnoth/website which I broke by mistake? 20190508 22:46:21<+wesdiscordbot> I'll sort it out in a moment 20190508 22:46:25<+wesdiscordbot> Currently it won't do anything at all 20190508 22:48:56<+wesdiscordbot> Can I edit your 1.14.7 announcement post and fix broken macOS download link? (pointing to 1.14.8 dir) 20190508 22:50:42<+wesdiscordbot> fixed 20190508 22:51:01<+wesdiscordbot> ok 20190508 23:15:32-!- irker466 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190508 23:15:32< irker466> wesnoth/wesnoth:1.14 Iris Morelle 635401a307 pofix: 1.14 announcement rules for 1.14. AppVeyor: vs2017/Release Failed 20190508 23:15:32< irker466> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24408242 20190508 23:19:20-!- valdar [~atarocch@93.56.172.28] has quit [Remote host closed the connection] 20190508 23:23:48-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190508 23:24:12-!- valdar [~atarocch@93.56.172.28] has quit [Remote host closed the connection] 20190508 23:24:43-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190508 23:51:00-!- celmin|away is now known as celticminstrel --- Log closed Thu May 09 00:00:44 2019