--- Log opened Thu May 09 00:00:44 2019 20190509 00:28:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190509 01:12:32< irker466> wesnoth/wesnoth:1.14 Martin Hrubý (hrubymar10) e1a9d9e6d4 Fix Xcode project AppVeyor: All builds passed 20190509 03:07:24< irker466> wesnoth/wesnoth:master Martin Hrubý (hrubymar10) a97a91a1d4 Fix Xcode project AppVeyor: All builds passed 20190509 03:08:49-!- shiki [~sevu@p5B28F954.dip0.t-ipconnect.de] has joined #wesnoth-dev 20190509 03:12:27-!- sevu [~sevu@p5B28F703.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds] 20190509 03:14:55-!- shiki [~sevu@p5B28F954.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds] 20190509 03:41:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190509 04:15:25< irker466> wesnoth/wesnoth:1.14 Iris Morelle 635401a307 pofix: 1.14 announcement rules for 1.14. AppVeyor: 1/4 builds failed 20190509 04:15:26< irker466> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24408242 20190509 06:35:18< irker466> wesnoth/wesnoth:master Iris Morelle 19b326ce03 pofix: 1.14 announcement rules for 1.14. AppVeyor: All builds passed 20190509 08:09:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190509 08:19:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190509 09:35:27-!- irker466 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190509 10:12:26-!- vihta [sid239753@gateway/web/irccloud.com/x-fiuhcuvzgcqijvnp] has quit [Ping timeout: 258 seconds] 20190509 10:13:41-!- vihta [sid239753@gateway/web/irccloud.com/x-oisraothaaofmnye] has joined #wesnoth-dev 20190509 10:20:37<+wesdiscordbot> I have been working on my own on the issue of improving the documentation. I have an idea of writing a script that could grab the data from the generated files from Doxygen and copy the contents into the database of the wiki. However my question on that is whether it would be actually useful for the goals of the editors of the wiki and whether there are any plans to implement the same doxygen software for the 20190509 10:20:38<+wesdiscordbot> documentation of the newest 2.0 wesnoth version. In case you have plans to move the documentation mechanism to a newer one let me know. 20190509 10:22:11<+wesdiscordbot> I said in #spanish we have https://devdocs.wesnoth.org/, I'm not sure if there's anything more specific that you want in the wiki? 20190509 10:22:39<+wesdiscordbot> (Or conversely in devdocs.w.o) 20190509 10:24:53< Soliton> there is no need to build another tool that does what doxygen already does. improving the documentation should be done be improving the doxygen comments and adding more. 20190509 10:25:44<+wesdiscordbot> Okay, my apologies 20190509 10:27:15<+wesdiscordbot> I am sleepy, I did not explain myself correctly. My idea was to have a copy of the contents of the doxygen docs into the wiki in the same way that there is a reference for the Lua functions, however you are right, it makes no sense 20190509 10:27:49<+wesdiscordbot> in this case though I have another question, the Lua documentation has been manually written so far? 20190509 10:28:06<+wesdiscordbot> Yes, that's right. 20190509 10:28:15< Soliton> most parts of the wiki are not generated, yes. 20190509 10:30:25<+wesdiscordbot> The only part of the wiki that is generated by a tool (but not automatically) at the moment is the Credits page. The GUI2 documentation was originally supposed to be generated by a tool as well but the source has probably undergone extensive comment rot, and the (custom) tool and annotation format weren't properly documented by the author as far as I remember anyway 20190509 10:31:40<+wesdiscordbot> then would there be any use of integrating a preprocessor tool so that doxygen also documents the lua functions? My assumption is yes, but I would like to know what plans you have in that regard 20190509 10:33:27< Soliton> i'd first look if doxygen cannot already be made to support lua or such a preprocessor exits. 20190509 10:33:48< Soliton> i'd be somewhat surprised if there was nothing existing. 20190509 10:34:46<+wesdiscordbot> I checked the docs, by default it does not support it, but some have written preprocessors for it, although some are a bit outdated, like this one: https://github.com/alecchen/doxygen-lua 20190509 10:35:24<+wesdiscordbot> Is there maybe some other documentation solution for lua? 20190509 10:35:35<+wesdiscordbot> A native one, rather than a doxygen extension/preprocessor 20190509 10:36:08<+wesdiscordbot> that's another possibility 20190509 10:36:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190509 10:36:36<+wesdiscordbot> I shall look into both options and ask for opinions, once I have a more educated opinion on that subject 20190509 10:36:37<+wesdiscordbot> thanks 20190509 10:37:29< Soliton> i'd say in general generating the documentation from inline comments would be welcome. what we currently have in the wiki is not bad either though so it needs to live up to that. 20190509 10:40:33<+wesdiscordbot> I see, I will come up with a solution for that, then. 20190509 10:49:00<+wesdiscordbot> thank you 20190509 10:49:16<+wesdiscordbot> and by the way, in addition to tools, another thing that would help is simply to write more documentation 20190509 10:49:27<+wesdiscordbot> for undocumented lua/C++ functions, for example 20190509 10:49:33<+wesdiscordbot> It's worth noting that most of the Lua API lives in the C++ source 20190509 10:50:08<+wesdiscordbot> Such as here: https://github.com/wesnoth/wesnoth/blob/master/src/scripting/game_lua_kernel.cpp 20190509 10:50:10<+wesdiscordbot> ... which makes it hard to use inline comments in lua files to document it... 20190509 10:53:12<+wesdiscordbot> yes, I want to document as much as I can 20190509 10:57:42<+wesdiscordbot> well actually, if most of the lua code is integrated into the c++ source code, then it could be documented directly where it's used inside said c++ code. In any case, thanks for clarifying my questions 20190509 10:58:19<+wesdiscordbot> Most of it but not all 20190509 10:58:43<+wesdiscordbot> There's several parts of the Lua API that exist in Lua land instead, including the WML API itself 20190509 10:59:02<+wesdiscordbot> (The subset of WML that is handled by the game events engine anyway) 20190509 10:59:40<+wesdiscordbot> @Technomancer Documenting the lua code with the C++ code wouldn't be very intuitive 20190509 10:59:52<+wesdiscordbot> The Lua API is used by UMC authors who may not know C++ 20190509 11:00:06<+wesdiscordbot> I think documenting Lua API in Doxygen comments in C++ code wouldn't work. The parameters and return types of the C++ functions are unrelated to their corresponding parameters and return types from Lua's POV. 20190509 11:00:33<+wesdiscordbot> Every function receives a lua_State* pointer and returns an integer. 20190509 11:01:01<+wesdiscordbot> Could we have a fake lua file with declarations of the lua functions implemented in C++? That file would be used by the documentation generator but not by the game 20190509 11:01:25<+wesdiscordbot> Kinda like having a .hpp file with declarations inside #ifdef DOXYGEN blocks, but the other way around 20190509 11:01:56<+wesdiscordbot> That would probably work. I'm not sure if it would be an improvement over the current situation, mind you. 20190509 11:04:01<+wesdiscordbot> Imma read the preprocessor's code and try using it assuming it can be integrated without too many issues I will use it along with C++, otherwise I will update the code of that repo 20190509 11:04:23<+wesdiscordbot> that is the lua preprocessor 20190509 17:36:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190509 18:50:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190509 18:50:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20190509 19:41:48-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190509 19:44:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190509 20:24:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds] 20190509 21:19:53< vn971> oooops, wesnoth died again. 20190509 21:20:02< vn971> wesnoth: /build/wesnoth/src/wesnoth/src/attack_prediction.cpp:1668: static void {anonymous}::monte_carlo_combat_matrix::scale_probabilities(const std::vector&, std::vector&, double, unsigned int): Assertion `std::abs(std::accumulate(target.begin(), target.end(), 0.0) - 1.0) < 0.001' failed. 20190509 21:20:12< vn971> with the prediction assertion again I mean. 20190509 21:20:56< vn971> crashes themselves are appearing a bit less often I guess, now that a few game-creation-window ones got understood&fixed. 20190509 21:21:19< vn971> this is 1.14.7 ---^ 20190509 21:25:21-!- irker716 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190509 21:25:21< irker716> wesnoth/wesnoth:1.14 Steve Cotton 168087a37e DiD S09: Unblock the book if one of DV's AppVeyor: All builds passed 20190509 21:46:33< vn971> created issue out of that: https://github.com/wesnoth/wesnoth/issues/4068 20190509 23:51:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Fri May 10 00:00:46 2019