--- Log opened Fri May 10 00:00:46 2019
20190510 00:25:53-!- irker716 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20190510 01:29:01-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20190510 03:28:44-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20190510 04:31:21-!- irker589 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20190510 04:31:21< irker589> wesnoth/wesnoth:master newfrenchy83 8e9c7dcda8 fix level up emove overlay from unit AppVeyor: All builds passed
20190510 07:31:43-!- irker589 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout]
20190510 08:26:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20190510 08:28:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20190510 11:15:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20190510 11:58:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20190510 13:01:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20190510 16:20:37-!- irker350 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20190510 16:20:37< irker350> wesnoth/wesnoth:master newfrenchy83 2e99349d14 Update attack_type.cpp AppVeyor: vs2017/Release Failed
20190510 16:20:37< irker350> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24451271
20190510 17:12:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20190510 17:45:12< irker350> wesnoth/wesnoth:1.14 josteph 8e10e7efb9 Stats dialog: Split the "1/2 3%" column  AppVeyor: All builds passed
20190510 20:08:35<+wesdiscordbot> <Iris> @loonycyborg You didn't backport the SQL client fix to 1.14, right?
20190510 20:10:19<+wesdiscordbot> <Iris> I tried to reproduce the bug on 1.14 just now and failed until I realized that it's a bit more specific than I thought
20190510 20:10:53<+wesdiscordbot> <Iris> In order to reproduce it's not enough with restarting the MySQL server -- wesnothd will properly reconnect on the next query. You need to have it fail a query by having it be performed while the MySQL server is down first.
20190510 20:12:20<+wesdiscordbot> <Iris> Then if you bring the MySQL server back up you'll start getting errors every time a query has to be run
20190510 20:12:39<+wesdiscordbot> <Iris> 20190510 16:09:56 error mp_user_handler: Could not connect to database: 2058: Can't connect twice. Already connected
20190510 20:17:58-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has joined #wesnoth-dev
20190510 20:20:24< irker350> wesnoth/wesnoth:master newfrenchy83 2e99349d14 Update attack_type.cpp AppVeyor: 1/4 builds failed
20190510 20:20:25< irker350> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24451271
20190510 20:27:40<+wesdiscordbot> <loonycyborg> @Iris yes I did not backport it
20190510 20:27:42<+wesdiscordbot> <loonycyborg> 38dbf99a0b802c333eb3cf46506e9b6a125dcb13
20190510 20:27:47<+wesdiscordbot> <loonycyborg> it is in master
20190510 20:28:44<+wesdiscordbot> <loonycyborg> to give you a chance to test both with and without the fix
20190510 20:31:26-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has quit [Ping timeout: 252 seconds]
20190510 20:32:10<+wesdiscordbot> <Iris> Well see above about the results without it
20190510 20:33:06<+wesdiscordbot> <loonycyborg> I already rebuilt and restarted master server to have it
20190510 20:33:35<+wesdiscordbot> <Iris> Yeah but I'm testing locally
20190510 20:34:43<+wesdiscordbot> <Iris> I'm testing with the 1.14 server and client on my own machine so I don't have to go through hoops to test the before/after state
20190510 20:42:47<+wesdiscordbot> <Iris> @loonycyborg the fix works
20190510 20:43:13<+wesdiscordbot> <loonycyborg> nice, I'll backport it tomorrow if you won't
20190510 20:43:26<+wesdiscordbot> <Iris> I can backport it now
20190510 21:56:42-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has joined #wesnoth-dev
20190510 22:10:35-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has quit [Ping timeout: 248 seconds]
20190510 23:00:42< irker350> wesnoth/wesnoth:1.14 josteph 2c1c144c7d Hit stats: Don't serialize by_cth_inflic AppVeyor: All builds passed
20190510 23:25:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20190510 23:49:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20190510 23:56:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
--- Log closed Sat May 11 00:00:47 2019