--- Log opened Mon May 20 00:00:05 2019 20190520 00:06:53-!- irker588 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190520 00:06:53< irker588> wesnoth/wesnoth:master newfrenchy83 c9efa9fc89 Merge branch 'master' into patch-15 AppVeyor: All builds passed 20190520 00:12:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190520 00:20:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190520 00:41:24-!- octalot [~steve@213-225-8-202.nat.highway.a1.net] has joined #wesnoth-dev 20190520 00:41:24-!- octalot [~steve@213-225-8-202.nat.highway.a1.net] has quit [Client Quit] 20190520 02:12:18< irker588> wesnoth/wesnoth:master newfrenchy83 a4ec8de7ef reverse update changelog AppVeyor: All builds passed 20190520 04:38:31-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190520 04:42:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190520 04:44:31< irker588> wesnoth/wesnoth:1.14 josteph faa36ea4fa statistics_dialog: Restore color in the AppVeyor: All builds passed 20190520 05:52:02-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds] 20190520 07:24:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190520 07:43:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190520 07:44:52-!- irker588 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190520 11:39:13-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 245 seconds] 20190520 11:43:36-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev 20190520 11:47:09-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20190520 11:48:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds] 20190520 11:48:32-!- wedge010 is now known as wedge009 20190520 11:50:07< wedge009> LeonardTheThird: From what I observed, the more recent VS project files are all XML based and there aren't too many differences between them. You should be able to compare what you have with the repository version just fine. 20190520 11:52:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190520 12:03:48<+wesdiscordbot> @LeonardTheThird ^ what wedge009 said 20190520 12:34:32-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190520 12:54:30-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20190520 12:56:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds] 20190520 12:56:13-!- wedge010 is now known as wedge009 20190520 13:10:02-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20190520 13:12:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds] 20190520 13:12:46-!- wedge010 is now known as wedge009 20190520 13:27:12-!- valdar [~atarocch@93.56.172.28] has quit [Ping timeout: 258 seconds] 20190520 13:31:18-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190520 15:13:08-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190520 15:18:13<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/580051660546768936/unknown.png 20190520 15:18:28<+wesdiscordbot> What happened to the blade there? 20190520 15:20:23< Soliton> a tree grew through it? maybe there is a wose hiding nearby. 20190520 15:22:53<+wesdiscordbot> https://github.com/wesnoth/wesnoth/issues/3600, maybe 20190520 15:23:05<+wesdiscordbot> good point 20190520 15:31:05-!- valdar [~atarocch@93.56.172.28] has quit [Ping timeout: 258 seconds] 20190520 15:33:26-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190520 15:36:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds] 20190520 15:43:56<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/580058128960454684/unknown.png 20190520 15:44:15<+wesdiscordbot> looks like the problem isn't just with the forest terrain 20190520 15:56:59-!- gfgtdf [~Daniel@x4d011c95.dyn.telefonica.de] has joined #wesnoth-dev 20190520 15:57:12< gfgtdf> zookeeper: an opinion on pr #4088 ? 20190520 16:12:36-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20190520 16:16:04< zookeeper> gfgtdf, aside from the broken indent at https://github.com/wesnoth/wesnoth/pull/4088/files#diff-cc615f28e29d4bfd31432358e127e588R23 and typos in comments, i don't see anything obviously wrong with it. 20190520 16:16:06< zookeeper> although, wouldn't it now be redundant to use both {TRAIT_LOYAL} and {IS_LOYAL}? in https://github.com/wesnoth/wesnoth/pull/4088/files#diff-9ff94893b90369ff37eddb88fd290609 for example. 20190520 16:16:57< zookeeper> if TRAIT_LOYAL now sets the overlay, all those IS_LOYAL calls can be removed, right? 20190520 16:21:10-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Ping timeout: 268 seconds] 20190520 16:33:36< celticminstrel> Yeah 20190520 16:33:46< celticminstrel> Think so 20190520 16:36:41< gfgtdf> ye, IS_LOYAL can be removed (although there might be a few cases where trait?loyal is used without the corresponing trait), just didn'T do it yet to maek the pr easir to review 20190520 16:39:22-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190520 16:53:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190520 17:00:47< celticminstrel> A few cases where what, gfgtdf? 20190520 17:01:16< gfgtdf> somce codes afaik use IS_LOYAL withotu actually givein the TRAIT_LOYAL trait 20190520 17:01:32< celticminstrel> Ah. 20190520 17:37:07-!- gfgtdf [~Daniel@x4d011c95.dyn.telefonica.de] has quit [Quit: Leaving] 20190520 18:22:46-!- irker861 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190520 18:22:46< irker861> wesnoth/wesnoth:master newfrenchy83 e13c005bba fix berserk continue the fight to infini AppVeyor: All builds passed 20190520 18:37:56<+wesdiscordbot> I had a similar idea here: https://github.com/spixi/wesnoth/commit/4a998dd177768886eb3a672b2cf6cfa2319cb8ae Maybe we could also get rid of the hero and expendable leader overlays? 20190520 18:39:22< celticminstrel> Ehh... 20190520 18:40:36< celticminstrel> Those things don't really have any game meaning though 20190520 18:40:55< celticminstrel> Or if they do it's encoded into the objectives and the overlay is just a helpful indicator. 20190520 18:42:03<+wesdiscordbot> the die event could be simplified with a SUF on a hero attribute, for example 20190520 18:43:01< celticminstrel> Probably not actually, heroes each have their own death message usually... 20190520 18:43:17< celticminstrel> I mean you could always use an if in the one event but that feels less clean. 20190520 18:55:55<+wesdiscordbot> I understand. And what about the suggestion to pair the loyal overlay to Unit::loyal() (which in fact checks for upkeep = loyal)? Like the crown overlay is paired to Unit::can_recruit(). Even the {NO_UPKEEP} macro comes with the overlay. 20190520 19:08:21-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has joined #wesnoth-dev 20190520 19:22:14-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has quit [Ping timeout: 252 seconds] 20190520 21:17:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20190520 21:23:18-!- irker861 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190520 21:48:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190520 21:49:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20190520 22:02:47-!- irker019 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190520 22:02:47< irker019> wesnoth/wesnoth:master newfrenchy83 c5df2c8795 add documentation for bool_ability and c AppVeyor: All builds passed 20190520 23:52:35< irker019> wesnoth/wesnoth:master gfgtdf 592b5512fd move loyal overlays to the loyal trait AppVeyor: All builds passed --- Log closed Tue May 21 00:00:06 2019