--- Log opened Wed May 22 00:00:08 2019 20190522 00:15:58-!- irker919 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190522 00:15:58< irker919> wesnoth/wesnoth:master newfrenchy83 ea8b2a05e4 Update attack.cpp AppVeyor: All builds passed 20190522 00:26:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20190522 00:27:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190522 01:38:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190522 03:16:20-!- irker919 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190522 04:21:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190522 04:51:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190522 05:30:07-!- vihta [sid239753@gateway/web/irccloud.com/x-oisraothaaofmnye] has quit [Ping timeout: 276 seconds] 20190522 05:33:57-!- vihta [sid239753@gateway/web/irccloud.com/x-fvdukfrjxqeahkzy] has joined #wesnoth-dev 20190522 05:47:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 246 seconds] 20190522 09:08:14-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Ping timeout: 252 seconds] 20190522 09:10:17-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev 20190522 10:52:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190522 10:56:16-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has joined #wesnoth-dev 20190522 11:10:20-!- Appleman1234 [~Appleman1@2001:44b8:21b3:4001::100] has quit [Ping timeout: 252 seconds] 20190522 12:05:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190522 13:00:31-!- celticminstrel is now known as celmin|sleep 20190522 13:44:33<+wesdiscordbot> @ghype where is the current dune burner? is https://forums.wesnoth.org/viewtopic.php?p=642238#p642238 the latest ? 20190522 13:44:37<+wesdiscordbot> the sprites 20190522 14:46:39<+wesdiscordbot> what should I do about this travis error? https://travis-ci.org/wesnoth/wesnoth/jobs/535723665#L3460 20190522 14:46:45<+wesdiscordbot> src/gui/dialogs/statistics_dialog.cpp:154:28: error: lambda capture 'shift' is not required to be captured for this use [-Werror,-Wunused-lambda-capture] 20190522 14:46:55<+wesdiscordbot> shift is a local variable, the lambda body does use it 20190522 14:56:00<+wesdiscordbot> never mind, I see, it's a const int so it doesn't have to be captured to be used 20190522 15:20:17-!- Rh0nda is now known as Rhonda 20190522 15:27:38-!- irker309 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190522 15:27:38< irker309> wesnoth/wesnoth:1.14 josteph e4d04ffe7e statistics_dialog: Fix -Wunused-lambda-c AppVeyor: vs2017/Release Failed 20190522 15:27:38< irker309> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24731874 20190522 15:57:29< Soliton> curious; when looking at the addon stats the most downloaded addon is EoM resources with 10k more downloads than EoM itself. EoM has been updated 5 times and resources 3 times. i wonder if there is some bug that makes wesnoth download dependencies more often than needed? 20190522 16:05:13< Ravana> EoMa resources is dependency of ageless 20190522 16:05:37< Soliton> ah, that explains it. 20190522 16:06:58< irker309> wesnoth/wesnoth:1.14 josteph 1107133a30 fixup! statistics_dialog: Don't show pro AppVeyor: vs2017/Release Failed 20190522 16:06:59< irker309> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24733275 20190522 16:12:59<+wesdiscordbot> @josteph current state of burner 20190522 16:12:59<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/580790210921627668/post_burner.png 20190522 16:17:43<+wesdiscordbot> @ghype Thanks! 20190522 16:22:03-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 258 seconds] 20190522 16:35:37<+wesdiscordbot> So, about the shift capture again 20190522 16:35:51<+wesdiscordbot> I removed shift from the capture list, and now appveyor complains 20190522 16:35:53<+wesdiscordbot> ....\src\gui\dialogs\statistics_dialog.cpp(155): error C3493: 'shift' cannot be implicitly captured because no default capture mode has been specified [C:\projects\wesnoth\projectfiles\VC14\wesnoth.vcxproj] 20190522 16:37:32<+wesdiscordbot> is that something that needs to be done in the vcxproj file ? 20190522 16:40:17< Soliton> use statistics::stats::decimal_shift? 20190522 16:41:32<+wesdiscordbot> what are you doing? 20190522 16:42:13<+wesdiscordbot> @Vultraz https://github.com/jostephd/wesnoth/blob/ef186cc3d14f0bb6c5f5f6f05a09d1facdc7ca0e/src/gui/dialogs/statistics_dialog.cpp#L154-L159 20190522 16:42:24<+wesdiscordbot> I 20190522 16:42:27<+wesdiscordbot> 'm looking at that, yes 20190522 16:42:32<+wesdiscordbot> appveyor complains if the capture list is empty, travis if it's not empty 20190522 16:42:41<+wesdiscordbot> what is travis's error? 20190522 16:42:55<+wesdiscordbot> look 20 lines above in discord 20190522 16:43:03<+wesdiscordbot> 2 hours ago 20190522 16:43:09<+wesdiscordbot> 🤔 20190522 16:43:28<+wesdiscordbot> just try [&] or [=] then 20190522 16:46:45<+wesdiscordbot> Another suggestion: try to make shift a constexpr constant. 20190522 16:47:18<+wesdiscordbot> It might be that MSVC doesn't realize that it's a compile-time constant, and constexpr should force it to understand. 20190522 16:47:56<+wesdiscordbot> constexpr support was introduced in Visual Studio 2015, which is the minimum version that master branch requires at the moment. 20190522 16:49:44<+wesdiscordbot> the PR targets 1.14 right now, but I have been meaning to rebase it to master 20190522 16:49:58<+wesdiscordbot> the appveyor build does use 2015 even there, though 20190522 16:50:34<+wesdiscordbot> pushed 6df6c602c16, let's see 20190522 16:50:43<+wesdiscordbot> thanks for the help folks 20190522 16:56:31< irker309> wesnoth/wesnoth:1.14 josteph 2059ec91d3 statistics_dialog: Don't show probabilit AppVeyor: All builds passed 20190522 17:00:31< Soliton> if that doesn't help there are more workarounds here: https://stackoverflow.com/questions/52416362/unused-lambda-capture-warning-when-capture-is-actually-used 20190522 17:03:52<+wesdiscordbot> Hmm, quite an unfortunate situation. Explicitly capturing constants isn't a bad practice and I don't really like that Clang warns about it. 20190522 17:05:01<+wesdiscordbot> We could disable the warning in the build script ? 20190522 17:05:04<+wesdiscordbot> -Wno-whatever 20190522 17:06:00<+wesdiscordbot> I'd be fine with that. 20190522 17:21:02<+wesdiscordbot> disabled the warning https://github.com/wesnoth/wesnoth/pull/4070/commits/79bfe5c4d9831b10c38408a2309bbc3b2fd951e7 20190522 17:21:47<+wesdiscordbot> Soliton, Vultraz, thanks for the suggestions but I think this approach is better 20190522 17:23:14< Soliton> sure, i don't mind. 20190522 17:26:56< Soliton> i'd add some comments to your lambda though or give those other constants proper names. 20190522 17:28:00<+wesdiscordbot> Soliton, I didn't write the code inside the lambda, I just deduplicated it 20190522 17:28:18<+wesdiscordbot> It could be made better, yes, but it was just a drive by commit for me 20190522 17:29:08<+wesdiscordbot> and by the way, are travis/appveyor going to run on the latest push to 4070? I added 3 commits in 2 pushes but I don't see builds scheduled 20190522 17:31:12<+wesdiscordbot> IIRC, they tend to fall behind when there is a commit burst. 20190522 17:45:11<+wesdiscordbot> Do I need to do anything other than wait some more? 20190522 17:45:30<+wesdiscordbot> I'm going to rebase later anyway 20190522 17:45:32<+wesdiscordbot> I think waiting is enough. 20190522 17:45:52<+wesdiscordbot> Okay. I've waited a bit before asking, but I'll wait some more. 😃 20190522 17:59:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190522 18:12:58< Ivanovic> hi everyone 20190522 18:13:40< Ivanovic> Necrosporus contacted me asking to be unmuted again after being muted by ShikadiQueen a while ago 20190522 18:13:46< Ivanovic> is it okay to lift that flag? 20190522 18:16:36<+wesdiscordbot> @josteph I think Travis and AppVeyor have lost track of your pull request. The last commit they tried to build is this: https://github.com/wesnoth/wesnoth/commit/1107133a30d388bd93ba6f084e735994eadb04b2 20190522 18:16:47<+wesdiscordbot> Rebasing might help. 20190522 18:17:06<+wesdiscordbot> Ivanovic: no 20190522 18:17:27<+wesdiscordbot> @jyrkive Will do. Thanks for checking. 20190522 18:17:55< Ivanovic> Iris: you should probably explain the reasoning to Necrosporus to ensure some understanding for it (Necrosporus was not able to give me the reason for the muting) 20190522 18:18:10<+wesdiscordbot> That looks like an auto-generated commit message, by the way 20190522 18:18:10<+wesdiscordbot> I have better things to do with my time 20190522 18:18:36<+wesdiscordbot> (I also have better things to do with my time than being explained how to do moderation) 20190522 18:19:07< Ivanovic> I am not explaining this or questioning your reasons, just stating that he does not understand the reason 20190522 18:21:08<+wesdiscordbot> If he doesn't know, then he's being incredibly dense. 20190522 18:28:53< Ivanovic> oookay, that is hard 20190522 18:28:54< Ivanovic> :) 20190522 18:29:14<+wesdiscordbot> @jyrkive Rebased. I still don't see an orange circle next to the latest commit, though. 20190522 18:31:22<+wesdiscordbot> Yeah, looks like they have lost track of the PR for good. 20190522 18:31:48<+wesdiscordbot> All right, I'll try to build the branch with VS2015 locally. Poor man's CI. 20190522 18:31:56<+wesdiscordbot> 😂 20190522 18:34:01<+wesdiscordbot> 5>h:\battle for wesnoth\external\include\boost\mpl\aux_\preprocessed\plain\bind.hpp(206): fatal error C1060: compiler is out of heap space (compiling source file ....\src\server\ban.cpp) 20190522 18:34:17<+wesdiscordbot> Okay, this is strange. Let's try a full clean rebuild... 20190522 18:34:24<+wesdiscordbot> Does it happen on clean 1.14 too? 20190522 18:34:38<+wesdiscordbot> I can try it later. 20190522 18:41:45<+wesdiscordbot> Okay, it indeed happens with 1.14 too. 20190522 18:42:24<+wesdiscordbot> Looks like I'm actually near to the commit charge limit of 16 GB. I guess enabling the swap file would help (I have it disabled for performance). 20190522 19:01:56<+wesdiscordbot> @jyrkive 4070 is being built now 20190522 19:02:03<+wesdiscordbot> by appveyor/travis 20190522 19:03:03<+wesdiscordbot> Good. 😃 20190522 19:03:37<+wesdiscordbot> On my end, enabling the pagefile allows building to progress further. Commit charge peaked at 17,75 GB. Still compiling. 20190522 19:04:09<+wesdiscordbot> Oh, another peak at 18,65 GB. 20190522 19:04:38<+wesdiscordbot> Can you isolate how much of that is used by the build process? 20190522 19:04:41<+wesdiscordbot> (Still nowhere near the limit, which should be 32 GB now: twice the amount of physical memory.) 20190522 19:04:54<+wesdiscordbot> What was the commit charge before the build, do you remember? 20190522 19:04:58<+wesdiscordbot> the actual value, not the limit 20190522 19:05:10<+wesdiscordbot> About 15 GB. Surprisingly high. 20190522 19:06:08<+wesdiscordbot> The build completed without any warnings from VS2015. 😃 20190522 19:06:13<+wesdiscordbot> I have 16GB RAM and I build in a tmpfs and never had problems with that. 20190522 19:06:25<+wesdiscordbot> Not sure if it uses swap though, I think not but never checked. 20190522 19:06:30<+wesdiscordbot> Great 😃 Thanks again for testing. 20190522 19:06:35<+wesdiscordbot> That's because Linux overcommits memory unlike Windows. 20190522 19:06:46<+wesdiscordbot> https://superuser.com/a/786655 20190522 19:06:47<+wesdiscordbot> I never got the original clang error but I think the scons/cmake changes are safe enough 20190522 19:07:08<+wesdiscordbot> The list of flags in the lines I changed are identical to the ones in travis' original error. 20190522 19:56:36-!- irker309 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190522 20:15:53-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190522 20:15:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20190522 20:22:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20190522 20:27:37-!- irker058 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190522 20:27:37< irker058> wesnoth/wesnoth:1.14 josteph e4d04ffe7e statistics_dialog: Fix -Wunused-lambda-c AppVeyor: 1/2 builds failed 20190522 20:27:37< irker058> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24731874 20190522 20:28:07-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190522 20:30:31< irker058> wesnoth/wesnoth:1.14 josteph fd1d9b9f09 statistics_dialog: Don't show probabilit AppVeyor: vs2017/Release Failed 20190522 20:30:32< irker058> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24737660 20190522 20:30:58-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 252 seconds] 20190522 20:41:32-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190522 21:02:36-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190522 21:03:21-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 258 seconds] 20190522 21:06:58< irker058> wesnoth/wesnoth:1.14 josteph 1107133a30 fixup! statistics_dialog: Don't show pro AppVeyor: 2/4 builds failed 20190522 21:06:59< irker058> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/24733275 20190522 21:07:00< irker058> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/24733276 20190522 22:40:09<+wesdiscordbot> Ivanovic: the short version is that he was being incredibly argumentative about a topic a minimal importance, even after he was told multiple times both to stop and that the thing he was objecting to happening didn't actually happen. 20190522 22:41:53<+wesdiscordbot> he also had great difficulty with the concept that just because he has an opinion on something doesn't mean that anyone else has to care about it. 20190522 23:31:44-!- celmin|sleep is now known as celticminstrel --- Log closed Thu May 23 00:00:34 2019