--- Log opened Wed May 29 00:00:42 2019 20190529 00:03:48<+wesdiscordbot> @Vultraz is there "find all references" for an identifier in godot? 20190529 00:57:15-!- celmin|away is now known as celticminstrel 20190529 01:37:26-!- irker119 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190529 02:30:05<+wesdiscordbot> @jyrkive there are some issues: - boost's tristate needs to be explicitly casted to bool, even after comparison operator - not using SDL_CreateRenderer() at all, results in fatal error - function getting desktop size from renderer needs its error checked, or at least the SDL_Point struct zero-initialized (right now returns garbage from stack) - an exception catch clause with non-const reference I'm unaware whether the 20190529 02:30:06<+wesdiscordbot> opengl branch works at all, given lack of renderer logic despite a comment to the opposite effect. Any ideas? 20190529 02:57:04<+wesdiscordbot> To put it bluntly, i am not aware of any significant amount of work having been done on that branch 20190529 02:57:11<+wesdiscordbot> There was some boilerplate work 20190529 02:57:25<+wesdiscordbot> But it hasn’t been actively developed 20190529 02:58:07<+wesdiscordbot> The largest attempt to rewrite the renderer was my own I guess like...two years ago? Using SDL_Texture 20190529 02:58:19<+wesdiscordbot> Also, what do you mean find all references? 20190529 02:58:53< celticminstrel> It's a super-useful tool. 20190529 02:59:04< celticminstrel> Find all places a given function (for example) is called. 20190529 02:59:20< celticminstrel> It's different from just a simple text search because it's aware of the code semantics. 20190529 02:59:31< celticminstrel> So for example if you had a local variable with the same name somewhere, it wouldn't count that. 20190529 02:59:45< celticminstrel> Sadly VS Code does not seem to have this feature though. :/ 20190529 02:59:57< celticminstrel> At least, not yet. 20190529 03:36:48-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190529 03:55:40<+wesdiscordbot> @Vultraz find all places that call given function or use a particular variable 20190529 03:57:44<+wesdiscordbot> ah 20190529 03:57:52<+wesdiscordbot> no it just has text search 20190529 03:57:53<+wesdiscordbot> AFAIK 20190529 03:59:46<+wesdiscordbot> @sthalik if you want to help with v2.0 I can give you access to the dedicated channel 20190529 04:00:21<+wesdiscordbot> @Vultraz yes, please 20190529 05:55:06<+wesdiscordbot> @sthalik The OpenGL branch is indeed not even supposed to launch at this point. 20190529 05:58:20<+wesdiscordbot> I'm not using a tristate anywhere in my code. 20190529 05:59:08<+wesdiscordbot> I guess whichever tristate you're talking about is likely from Vultraz's code (the branch is built on top of his branch at the moment), which I plan to eventually get rid of anyway. 20190529 06:01:03<+wesdiscordbot> SDL_CreateRenderer() is not supposed to be used. The branch should use OpenGL for rendering directly. https://github.com/wesnoth/wesnoth/blob/opengl/src/ogl/context.cpp#L43 creates the OpenGL context. 20190529 06:02:09<+wesdiscordbot> I haven't written a function to "get desktop size from renderer", so that must be Vultraz's code as well. 20190529 06:03:02<+wesdiscordbot> That note about catching with non-const reference is valid. Will need to fix. 20190529 06:04:02<+wesdiscordbot> "Also maybe it's good to do separate mergeable changes that can be put into master quicker." - that's completely impossible to do with a full rendering pipeline rewrite. 20190529 06:04:52<+wesdiscordbot> The current rendering logic just draws everything right then and there. The logic in OpenGL branch, like I said, is supposed to work by instead submitting draw operations and then batching and executing them all at once at the end. 20190529 06:05:14<+wesdiscordbot> In addition,. it's not possible to use OpenGL and the SDL renderer simultaneously. 20190529 06:09:50<+wesdiscordbot> do you still plan on working on the branch? 20190529 06:10:02<+wesdiscordbot> Yeah, when I have energy to do so. 20190529 08:28:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190529 08:32:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190529 11:54:58<+wesdiscordbot> are wesnoth inc financials publicly available ? 20190529 11:56:01<+wesdiscordbot> specifically how donated funds are used 20190529 11:56:31<+wesdiscordbot> no, we don't currently make that info available 20190529 11:56:48<+wesdiscordbot> and there isn't anything to make available since we only have liberapay set up and that only recently 😛 20190529 11:57:18<+wesdiscordbot> understood, but Wesnoth Inc has existed for longer than that 20190529 11:57:35<+wesdiscordbot> anyway, someone was asking https://forums.wesnoth.org/viewtopic.php?f=6&t=49668&p=642769#p642719 20190529 11:58:14<+wesdiscordbot> Hard to tell but I won't be surprised if there are people out there who wouldn't donate unless we show them some numbers about how their money would be used. 20190529 11:58:29<+wesdiscordbot> that's fair 20190529 12:23:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190529 12:27:11<+wesdiscordbot> do you want to reply to the thread and tell the person if wesnoth inc will consider publishing more info about how it uses donation funds? 20190529 12:54:13-!- celticminstrel is now known as celmin|away 20190529 13:08:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190529 17:34:51-!- gfgtdf [~androirc@134.76.63.8] has joined #wesnoth-dev 20190529 18:26:20-!- gfgtdf [~androirc@134.76.63.8] has quit [Ping timeout: 258 seconds] 20190529 18:46:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190529 19:25:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190529 19:25:14-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190529 19:36:51-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190529 19:36:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190529 20:55:59-!- travis-ci [~travis-ci@ec2-54-210-138-219.compute-1.amazonaws.com] has joined #wesnoth-dev 20190529 20:55:59< travis-ci> wesnoth/wesnoth#21652 (master - 3cb71e2 : sigurdfdragon): The build has errored. 20190529 20:55:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/538932775 20190529 20:56:00-!- travis-ci [~travis-ci@ec2-54-210-138-219.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190529 22:04:16-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20190529 22:10:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190529 22:10:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190529 22:58:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] --- Log closed Thu May 30 00:00:29 2019