--- Log opened Wed Jun 05 00:00:37 2019 20190605 00:01:22-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20190605 00:13:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190605 00:13:07-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190605 00:35:48-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20190605 00:36:36-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190605 01:34:03-!- behalebabo [~behalebab@unaffiliated/behalebabo] has quit [Remote host closed the connection] 20190605 01:34:43-!- behalebabo [~behalebab@unaffiliated/behalebabo] has joined #wesnoth-dev 20190605 01:37:27-!- stikonas__ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190605 03:28:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190605 08:14:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190605 08:23:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190605 10:07:47<+wesdiscordbot> @Vultraz Let me clarify. The screenshot that had wrong left padding is as of the commit before the -5. The commit that adds -5 fixes the left padding for me, but adds a schema warning. I'm not sure if the warning is legit or a false positive (haven't had time to check) 20190605 10:08:09<+wesdiscordbot> And by the way, the PR is based on 1.14 still, I should rebase it to master at some point 20190605 10:09:17<+wesdiscordbot> Blah, ok I’ll need to take a closer look 20190605 10:10:37<+wesdiscordbot> that'd be fantastic 20190605 10:11:01<+wesdiscordbot> I'm just addressing your GH review and then I'll rebase to master 20190605 10:12:38<+wesdiscordbot> the borders were correct in the screenshot you had in the original post 🤔 20190605 10:13:44<+wesdiscordbot> what do they look like currently w/ latest changes? 20190605 10:14:01<+wesdiscordbot> they were broken by 8683ec711969e24d9e85e6b30b74e9e4ae7f5133 20190605 10:14:04<+wesdiscordbot> let me get a screenshot 20190605 10:14:53<+wesdiscordbot> hMMM 20190605 10:15:15<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/585773612774981632/2019-06-05-101458_338x455_scrot.png 20190605 10:15:31<+wesdiscordbot> that looks....fine? 20190605 10:15:36<+wesdiscordbot> if I remove the -5, then in the hits table the "0 / 0" isn't aligned with "Overall" 20190605 10:15:39<+wesdiscordbot> yeah, but that's with the -5 20190605 10:15:48<+wesdiscordbot> 🤔 20190605 10:15:58<+wesdiscordbot> yeah honestly see 20190605 10:16:03<+wesdiscordbot> aligning things with headers I' 20190605 10:16:12<+wesdiscordbot> ve found is a pain in the ass >_> 20190605 10:16:33<+wesdiscordbot> It's an art, basically, because GUI2 is just awkward like that 20190605 10:18:39<+wesdiscordbot> yeah, GUI2 is odd sometimes, but aligning things does make dialogs look so much better 😃 20190605 10:18:53<+wesdiscordbot> There's a reason I have that giant comment in that dialog's WML about a grid getting borders and not child widgets 😬 20190605 10:19:06<+wesdiscordbot> I guess I'll just take alook once it's merged somewhere 20190605 10:19:09<+wesdiscordbot> see what I can do 20190605 10:20:37<+wesdiscordbot> GUI2 is just a mess 20190605 10:22:14<+wesdiscordbot> thanks, that'd be appreciated 20190605 10:22:19<+wesdiscordbot> I'm planning to merge it to master 20190605 10:22:44<+wesdiscordbot> Not planning to merge it to 1.14 20190605 10:28:08-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190605 10:29:59-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 258 seconds] 20190605 11:15:02-!- irker631 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190605 11:15:02< irker631> wesnoth/wesnoth:1.14 josteph 0d73e1451f Another code style change. AppVeyor: vs2017/Release Failed 20190605 11:15:02< irker631> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/25056921 20190605 12:26:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190605 12:57:13-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.] 20190605 14:15:19-!- irker631 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190605 16:15:05-!- irker743 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190605 16:15:05< irker743> wesnoth/wesnoth:1.14 josteph 0d73e1451f Another code style change. AppVeyor: 2/4 builds failed 20190605 16:15:05< irker743> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/25056921 20190605 16:15:05< irker743> Details vs2015/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-7lnpw/builds/25056922 20190605 17:19:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190605 17:53:21-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190605 17:58:31-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20190605 17:58:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190605 18:53:21-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Remote host closed the connection] 20190605 19:15:59-!- irker743 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190605 19:17:17-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190605 19:26:28<+wesdiscordbot> Is there some documentation somewhere about the overall design of the wesnoth code base? Like UML or something. 20190605 19:27:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190605 19:27:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190605 20:26:40< Soliton> not really. there are some forum posts and wiki pages from dave about some design ideas. 20190605 21:37:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190605 21:38:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 246 seconds] 20190605 21:46:59<+wesdiscordbot> Ah too bad. 20190605 22:16:36<+wesdiscordbot> iirc there was a book by him or article 20190605 22:16:41<+wesdiscordbot> but I forgot where 😛 20190605 22:20:10<+wesdiscordbot> https://www.aosabook.org/en/wesnoth.html 20190605 22:20:22<+wesdiscordbot> though some details there are most definitely obsolete now 20190605 22:20:52<+wesdiscordbot> like in don't apply to current version 20190605 23:25:28-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 258 seconds] 20190605 23:56:53-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev --- Log closed Thu Jun 06 00:00:36 2019