--- Log opened Fri Jun 07 00:00:38 2019 20190607 00:07:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20190607 00:09:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190607 00:34:57-!- celmin|away is now known as celticminstrel 20190607 00:59:11-!- irker483 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190607 01:23:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190607 02:35:50-!- irker146 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190607 02:35:50< irker146> wesnoth/wesnoth:1.14 doofus-01 564f3e90b1 adjusting bat cropping for help pages AppVeyor: All builds passed 20190607 03:32:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190607 04:08:12< irker146> wesnoth/wesnoth:master doofus-01 3fb552396b dread bat portrait AppVeyor: All builds passed 20190607 06:18:42-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has quit [Ping timeout: 252 seconds] 20190607 06:22:28-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has joined #wesnoth-dev 20190607 06:23:00-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has quit [Max SendQ exceeded] 20190607 06:25:11-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has joined #wesnoth-dev 20190607 06:29:06< wedge009> loonycyborg: Even if old, that was an interesting read. And for some of the other chapters too. 20190607 06:54:36< irker146> wesnoth/wesnoth:1.14 Severin Glöckner d4e84be8d8 ANL: disable swamp trick AppVeyor: All builds passed 20190607 07:34:36-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190607 09:54:37-!- irker146 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190607 10:53:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190607 12:27:46-!- valdar [~atarocch@93.56.172.28] has quit [Ping timeout: 272 seconds] 20190607 12:29:40-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 272 seconds] 20190607 12:29:50-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190607 12:30:14-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190607 12:34:57-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190607 13:06:53-!- celticminstrel is now known as celmin|away 20190607 14:07:00-!- Nobun [~user@host160-123-dynamic.47-79-r.retail.telecomitalia.it] has joined #wesnoth-dev 20190607 16:04:48-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds] 20190607 16:24:33<+wesdiscordbot> @loonycyborg Thanks for the link! 20190607 16:25:10<+wesdiscordbot> Is there anyway to get the specials_context result, auto ctx to stick around outside of a scope? I'm looking to call different specials_context functions depending on an if check, but this breaks as the ctx is in a different scope than the following code. I'm guessing it's something to do with the intrusive pointers disappearing. 20190607 16:55:51< Soliton> what exactly do you mean with scope? 20190607 16:56:50<+wesdiscordbot> declare a variable of that type outside of that scope? 20190607 16:57:34<+wesdiscordbot> in C++ variables declared in scope are automatically destructed when leaving that scope 20190607 16:57:36< Soliton> perhaps you want to use smart pointers to manage dynamic object lifetime. 20190607 16:59:45<+wesdiscordbot> So basically declare a variable in scope where you want to use it and and assign result to it instead of inplace auto declaration 20190607 17:09:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190607 17:30:05<+wesdiscordbot> So what I wanted to do was basically this: IF Regular mode auto ctx = regular specials_context ELSE auto ctx = different specials_context ENDIF [Stuff to do with specials reports here] The issue is that as soon as the program exits the closing bracket of the else, all the variables that the different specials_context set, are changed back to null (as far as I can tell). @loonycyborg Ya, I realize that 20190607 17:30:06<+wesdiscordbot> stack variables are gone as soon as you leave scope, so I had already tried something like this: attack_type::specials_context_t ctx = regular specials_context IF Different condition ctx = different specials_context ENDIF That gives me an error about "Attempting to reference a deleted function." 20190607 17:30:58<+wesdiscordbot> Can you post the full error message in GitHub Gist, Pastebin or something? 20190607 17:31:19<+wesdiscordbot> sure, 1 sec 20190607 17:31:26<+wesdiscordbot> hmm interesting 20190607 17:34:46<+wesdiscordbot> https://pastebin.com/baXtRg6c 20190607 17:37:29<+wesdiscordbot> operator= is deleted function, means that assigning to it is not supported 20190607 17:38:01<+wesdiscordbot> I'm not sure maybe var = std::move(specials_context) will bypass it 20190607 17:38:23<+wesdiscordbot> I think it would be better to use pointers. 20190607 17:39:11<+wesdiscordbot> A pointer can always be reassigned. They require different syntax to work with though. 20190607 17:39:53<+wesdiscordbot> Ya... that makes sense. 20190607 17:41:24<+wesdiscordbot> Ayyy, there we go. 20190607 17:42:48< Soliton> if you just need to decide between two specials_context to create without weird lifetimes you could use the ternary operator instead of if. 20190607 17:44:39<+wesdiscordbot> I'm still not really clear why the first thing that I did didn't work though. It looks like all the specials_context functions do is set certain variables on the weapon passed into them. So even thought the ctx variable obviously isn't around after the end of the if statement, I don't know why the changes to the weapon also disappear. 20190607 17:45:12<+wesdiscordbot> Soliton: Ooh, that sounds cleaner. 20190607 17:45:21< Soliton> presumably that's the point of the specials_context class. 20190607 17:45:41< Soliton> to make sure all changes are reverted. 20190607 17:53:16<+wesdiscordbot> Ahh, I see. Well, it's definitely working in that regard, lol. 20190607 19:57:30<+wesdiscordbot> @jyrkive I've playtested #4107 and the behavior looks good to me. 20190607 19:59:53<+wesdiscordbot> All right. I don't want to merge the PR before the automated builds pass, mind you. 20190607 20:05:13<+wesdiscordbot> Sure. 20190607 20:12:42<+wesdiscordbot> > I don't want to merge the PR before the automated builds pass, mind you. The suspense... XD 20190607 20:16:21<+wesdiscordbot> Well, don't hold your breath. I'll go to bed before that. 😉 20190607 20:27:59<+wesdiscordbot> tests pass here 20190607 20:29:20-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190607 20:54:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20190607 20:54:12-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190607 21:24:38-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190607 21:55:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190607 21:57:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190607 22:03:07-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds] 20190607 22:09:34< vn971> New bug, Dark Sorcerer does not lose traits when leveling to Lich: https://github.com/wesnoth/wesnoth/issues/4108 20190607 22:10:26< vn971> I'm currently trying to build 1.14.0 to test if it's an OOS, but compilation fails. 20190607 22:11:03< vn971> if anybody has a 1.14.0, or any other earlier 1.14 release handy, I'd appreciate testing the Lich behavior.. 20190607 22:15:58< vn971> Or even a test on 1.12 would be interesting. I'm pretty sure it was not possible to e.g. have a "quick" Lich with MP7 before. 20190607 22:17:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds] 20190607 22:26:30<+wesdiscordbot> 1.12 has the Lich with traits. 20190607 22:26:45<+wesdiscordbot> (The advanced Lich.) 20190607 22:27:29<+wesdiscordbot> The 'Lich shouldn't have traits' thing is rather recent. 20190607 22:28:44<+wesdiscordbot> While we are at it, random Lichs should have names. :thonk: 20190607 22:28:51< vn971> Konrad2: oh... I'll test with 1.14.0 now, and will at least remove the "bug" label in issue tracker if it's indeed consistent. 20190607 23:01:08-!- Nobun [~user@host160-123-dynamic.47-79-r.retail.telecomitalia.it] has quit [Quit: WeeChat 2.1-dev] --- Log closed Sat Jun 08 00:00:39 2019