--- Log opened Wed Jun 12 00:00:45 2019 20190612 01:13:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190612 01:20:32-!- celmin|away is now known as celticminstrel 20190612 02:14:30< irker157> wesnoth/wesnoth:master Alexander van Gessel 45e54883ff Restore 3-significant-digit si_string (c AppVeyor: All builds passed 20190612 02:52:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190612 03:37:58-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 245 seconds] 20190612 03:48:43-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has quit [Ping timeout: 248 seconds] 20190612 03:52:19-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has joined #wesnoth-dev 20190612 04:25:26-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190612 05:15:12-!- irker157 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190612 06:04:37-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190612 06:54:57<+wesdiscordbot> Any idea why auto saves might not be deleted at the end of the scenario, even though I have selected that option? 20190612 06:55:38<+wesdiscordbot> I still have all 68 auto saves for this one, and normally it works. 20190612 06:55:38<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/588260100842455041/CbaN-The_Nightmare_Colosseum_replay.gz 20190612 06:58:17-!- irker312 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190612 06:58:17< irker312> wesnoth/wesnoth:1.14 Severin Glöckner 5767e980e8 ANL: use loyal trait to mark the lack of AppVeyor: All builds passed 20190612 08:19:44-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190612 08:22:02-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190612 08:35:08< irker312> wesnoth/wesnoth:1.14 Severin Glöckner 17007b537a ANL: refactor variable AppVeyor: All builds passed 20190612 09:46:22< Soliton> perhaps that scenario ends in some special way? can you reproduce? 20190612 10:33:17<+wesdiscordbot> @Konrad2 I found what causes that behaviour. Original scenario name contains colon "The Nightmare: Colosseum". Savefiles doesn't contain the colon and they are not removed. I will rename the scenario. Sorry for inconvenience. P.S. I knew that the colon is not safe 😀 But I am really bad at giving names ("the" and "a" is also a trouble). Could you help please? So there is a pattern that scenarios that represent 20190612 10:33:17<+wesdiscordbot> nightmares of the main character have "nightmare" in their name. Also that particular nightmare is about fighting in a colosseum 😁 What scenario name would you suggest? 20190612 11:01:32< Soliton> well, that sounds like a wesnoth issue still. if there is no bug report about that it'd be nice if someone can file one. 20190612 11:02:40< Soliton> wesnoth should just use the same names in the case of writing and deleting saves. 20190612 11:21:56<+wesdiscordbot> Scenario name is a translatable string by the way. That may introduce additional problems. 20190612 11:23:18< Soliton> if we can write a savefile with whatever name we should be able to delete it as well. really shouldn't be that difficult. :-) 20190612 11:23:46< Soliton> probably just different code is used to figure out the name in either case. 20190612 11:30:35<+wesdiscordbot> This characters are removed when scenario name is used as a savefile name https://github.com/wesnoth/wesnoth/blob/60fd504caf46bbb1648de369303b76225d805e5d/src/savegame.cpp#L417-L424 20190612 11:33:01<+wesdiscordbot> We can give whatever name to a scenario (scenario developers are involved in that as well as translators), but we can't use whatever name as a file name because of the filesystem limitations. 20190612 11:34:05< Soliton> sure, but that is all irrelevant to figuring out what filename to delete. you just use the same logic as when saving. 20190612 11:35:04< Soliton> if you want to investigate further find the code that does the deletion and see how it figures out the name there. 20190612 11:35:09-!- irker312 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190612 11:35:57<+wesdiscordbot> It should just call savegame::create_filename() instead of rolling its own logic... 20190612 11:36:45-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev 20190612 11:43:13<+wesdiscordbot> @sergey You could just call it Nightmare Colosseum. 20190612 11:43:56<+wesdiscordbot> Btw, we have a 'Skyrim Era' on our 1.10 add-on server. Is that a copyright problem? 20190612 12:24:25-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190612 12:32:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190612 12:40:33<+wesdiscordbot> @jyrkive savegame::create_filename() creates a filename based on campaign abbreviation, scenario name, turn number and special words like Auto-Save, replay, etc When removing the savefiles we don't want to create a specific file name. We are fetching savefiles and filter them by a prefix (composed of campaign abbreviation, scenario name and Auto-Saveas I understand) 20190612 12:40:33<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/60fd504caf46bbb1648de369303b76225d805e5d/src/savegame.cpp#L67-L78 What we should probably do is to remove illegal characters from the prefix https://github.com/wesnoth/wesnoth/blob/60fd504caf46bbb1648de369303b76225d805e5d/src/savegame.cpp#L429-L431 In order to not duplicate code the logic of removing illegal characters could be extracted to a method. 20190612 12:42:11<+wesdiscordbot> Removal of illegal characters is a single function call, two lines. Not worth extracting to a method of its own IMO. 20190612 12:43:17<+wesdiscordbot> depends on where you're getting the whitelist/blacklist 20190612 12:43:49< celticminstrel> Ooh the AI is talking ;p 20190612 12:43:51< Soliton> that's already its own function. 20190612 12:45:27< Soliton> @sergey good work! now you could make a pull request with a fix... ;-) 20190612 12:47:58<+wesdiscordbot> I could, but I don't have prepared environment in order to test it. What I am going to do is to create an issue and explain how to fix it. 20190612 12:49:47<+wesdiscordbot> I would be happy to contribute if I would be a C++ developer, but that's not the case. 20190612 12:52:29-!- celticminstrel is now known as celmin|away 20190612 13:18:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190612 17:07:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20190612 17:07:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190612 17:22:47-!- stikonas_ is now known as stikonas 20190612 18:59:07-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds] 20190612 19:13:48-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190612 20:44:49<+wesdiscordbot> So right now I'm getting a bunch of exceptions when debugging wesnoth, going through them 1 by 1 trying to figure out what's going on. First (and second) are here: https://github.com/wesnoth/wesnoth/blob/aa901478c22be3dc0c32cdcf4c4807f19af2f428/src/picture.cpp#L1245 Looks like these exceptions just gets thrown if there isn't a preference overriding the default scale_hex/scale_zoom. Which I assume means that I 20190612 20:44:50<+wesdiscordbot> don't need to be worried about it. Is this correct? 20190612 21:01:51-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20190612 21:01:54-!- timotei__ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190612 21:13:55<+wesdiscordbot> @LeonardTheThird Note there's no code that sets scale_hex/scale_zoom 20190612 21:15:07<+wesdiscordbot> So the code is only used if someone edits their preferences file by hand. (Or maybe old versions used to set that preference) 20190612 21:15:20<+wesdiscordbot> Either way, this looks like an exception that gets thrown in normal operation 20190612 21:15:26<+wesdiscordbot> Nothing to worry about 20190612 21:20:59-!- timotei__ [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20190612 21:24:50-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190612 21:29:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20190612 21:43:00-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer] 20190612 21:43:39-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev 20190612 22:04:18<+wesdiscordbot> Cool, that's one down. I'm getting several others, but they appear to be similar "normal running" ones as well. The interesting ones now are the 700+ I get on terrain building when loading a level. Looks like it keeps trying to parse '.' and '*' as numbers. I say 700+ because I had to stop it at 702. 20190612 22:05:42<+wesdiscordbot> Wesnoth is built around using exceptions for non-exceptional situations 😐 20190612 22:05:47<+wesdiscordbot> (sadly) 20190612 22:06:14<+wesdiscordbot> The entire main gameplay loop is exited by throwing an exception, for example 20190612 22:45:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds] 20190612 22:52:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190612 23:09:37-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20190612 23:41:00-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190612 23:44:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds] 20190612 23:48:49-!- stikonas_ is now known as stikonas 20190612 23:50:15<+wesdiscordbot> ... I must confess I don't have much experience with try/catch stuff but... that seems a bit crazy? 20190612 23:51:33<+wesdiscordbot> it is 20190612 23:51:43<+wesdiscordbot> it's bad design 20190612 23:52:53-!- celmin|away is now known as celticminstrel 20190612 23:53:05< celticminstrel> PRs welcome if you think you can reduce the unexceptional exception count. 20190612 23:59:53<+wesdiscordbot> why does it interfere with your work though? --- Log closed Thu Jun 13 00:00:12 2019