--- Log opened Thu Jun 13 00:00:12 2019 --- Day changed Thu Jun 13 2019 20190613 00:00:12<+wesdiscordbot> I think debug tools can be made to catch only particular type of exception 20190613 00:54:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190613 01:25:18< celticminstrel> Even if that's possible, what if the type of exception you want to catch happens to be one of the ones that's thrown everywhere? 20190613 03:01:47<+wesdiscordbot> Ya, I can work alright with them there. I hadn't even noticed them until I started checking the output window. It's just harder to know if something is actually going wrong somewhere if having hundreds of exceptions is the norm. 🤷 20190613 03:16:24< celticminstrel> Right, and if you think you can improve the situation, feel free! 20190613 03:16:44< celticminstrel> I'm pretty sure some of the exceptions cannot be eliminated. 20190613 03:17:12< celticminstrel> But a lot of the std::invalid_argument and the like probably can be. 20190613 03:17:20< celticminstrel> Maybe I spelled that wrong... 20190613 03:17:58< celticminstrel> Ah, no, that's indeed the one I was thinking of. 20190613 03:18:12< celticminstrel> The one thrown by stoi when you pass it something that's not a number. 20190613 03:20:07< celticminstrel> Oh my, apparently stoi can also through std::out_of_range... do we actually catch that? 20190613 03:21:01< celticminstrel> Like stoi("9223372036854775807") would throw that according to the documentation. 20190613 03:50:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190613 05:59:35<+wesdiscordbot> Yes, we catch it. I wrote the current implementation of lexical_cast. 20190613 06:00:58<+wesdiscordbot> https://github.com/wesnoth/wesnoth/blob/aa901478c22be3dc0c32cdcf4c4807f19af2f428/src/lexical_cast.hpp#L290 20190613 06:01:55<+wesdiscordbot> @LeonardTheThird I recommend that you disable breaking on first-chance exceptions (i.e. when an exception is thrown). Exceptions are usually interesting only if they aren't caught. 20190613 06:04:07<+wesdiscordbot> For example, if you're using Visual Studio, here is Microsoft's documentation about how to break on first-chance exceptions: https://docs.microsoft.com/en-us/visualstudio/debugger/managing-exceptions-with-the-debugger?view=vs-2019 20190613 06:04:22<+wesdiscordbot> To disable that, just uncheck the checkbox instead of checking it. 20190613 07:08:38-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190613 07:14:12-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20190613 07:29:49-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190613 07:54:50-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 244 seconds] 20190613 07:55:37-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev 20190613 10:52:39-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Caught sigterm, terminating...] 20190613 10:53:08-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20190613 10:56:44<+wesdiscordbot> Does anyone know why this happened? https://github.com/wesnoth/wesnoth/commit/a4da90f921da02fdf1f5c827055bf51dbe853378#diff-7c7efbed9f4ea67ab046385d27aa6d49R182 20190613 10:56:54<+wesdiscordbot> It's about setting the column header label to "" 20190613 11:01:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190613 11:31:25-!- travis-ci [~travis-ci@ec2-52-90-32-242.compute-1.amazonaws.com] has joined #wesnoth-dev 20190613 11:31:25< travis-ci> wesnoth/wesnoth#21699 (master - a4da90f : josteph): The build passed. 20190613 11:31:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/545187124 20190613 11:31:25-!- travis-ci [~travis-ci@ec2-52-90-32-242.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190613 12:25:57-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190613 12:45:59-!- celticminstrel is now known as celmin|away 20190613 12:55:53-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 245 seconds] 20190613 14:19:20-!- travis-ci [~travis-ci@ec2-54-161-131-131.compute-1.amazonaws.com] has joined #wesnoth-dev 20190613 14:19:20< travis-ci> wesnoth/wesnoth#21701 (1.14 - 6dfc837 : Nils Kneuper): The build passed. 20190613 14:19:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/545245842 20190613 14:19:20-!- travis-ci [~travis-ci@ec2-54-161-131-131.compute-1.amazonaws.com] has left #wesnoth-dev [] 20190613 15:14:21<+wesdiscordbot> @Forum Mods sublte spambot https://r.wesnoth.org/p643445 20190613 15:14:55<+wesdiscordbot> thanks 20190613 15:52:53-!- irker351 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190613 15:52:53< irker351> wesnoth/wesnoth:1.14 Nils Kneuper 6dfc837b76 updated Turkish translation AppVeyor: vs2017/Release Failed 20190613 15:52:53< irker351> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/25256668 20190613 17:03:49< irker351> wesnoth/wesnoth:master josteph a4da90f921 statistics_dialog: Hide the "This Turn" AppVeyor: All builds passed 20190613 17:04:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190613 17:27:56< irker351> wesnoth/wesnoth:1.14 josteph 1bf5a189a8 statistics_dialog: Hide the "This Turn" AppVeyor: vs2017/Release Failed 20190613 17:27:57< irker351> Details: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/25261542 20190613 17:33:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190613 19:36:02<+wesdiscordbot> Soliton, can you give an example? 20190613 19:36:14<+wesdiscordbot> Something like, "40%: 400 / 1000" ? 20190613 19:36:34< Soliton> yes. 20190613 19:37:48<+wesdiscordbot> It would be trivial to implement this. 20190613 19:37:55<+wesdiscordbot> I'm not sure we should. 20190613 19:38:13<+wesdiscordbot> Every number we add, we need to document and explain and so on ... 20190613 19:40:07< Soliton> i was just clarifying my histogram proposal. i'm not saying that is the most interesting thing to show. 20190613 19:40:26<+wesdiscordbot> OK 20190613 19:40:45< Soliton> i have not come up with anything more interesting so far though. (not that i tried.) also afair i was not the only one talking about a histogram. 20190613 19:41:11<+wesdiscordbot> a histogram is what the thread started with. 20190613 19:41:44<+wesdiscordbot> Right now I'm thinking of showing actual hits, expected hits, and a number between 0 and 100 that's basically the first percentage in the current implementation 20190613 19:41:57<+wesdiscordbot> I'm just wondering how to make it clear 20190613 19:45:46< Soliton> so what kind of histogram was that? 20190613 19:46:43<+wesdiscordbot> sorry, what ? 20190613 19:46:52< Soliton> "a histogram is what the thread started with." 20190613 19:46:54<+wesdiscordbot> in the thread ? 20190613 19:47:01< Soliton> yes. 20190613 19:47:48<+wesdiscordbot> https://forums.wesnoth.org/viewtopic.php?f=12&t=49785#p641777, first post, last spoiler 20190613 19:48:52< Soliton> oh, so exactly the same? 20190613 19:50:03<+wesdiscordbot> yeah 20190613 19:52:25< irker351> wesnoth/wesnoth:master Nils Kneuper fc2ba5be24 updated Turkish translation AppVeyor: All builds passed 20190613 20:52:47< irker351> wesnoth/wesnoth:1.14 Nils Kneuper 6dfc837b76 updated Turkish translation AppVeyor: 1/2 builds failed 20190613 20:52:48< irker351> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/25256668 20190613 21:33:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20190613 21:53:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190613 22:27:57< irker351> wesnoth/wesnoth:1.14 josteph 1bf5a189a8 statistics_dialog: Hide the "This Turn" AppVeyor: 1/4 builds failed 20190613 22:27:58< irker351> Details vs2017/Release: https://ci.appveyor.com/project/wesnoth/wesnoth-605wt/builds/25261542 20190613 23:04:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20190613 23:05:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190613 23:27:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20190613 23:27:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190613 23:55:04-!- celmin|away is now known as celticminstrel 20190613 23:59:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] --- Log closed Fri Jun 14 00:00:49 2019