--- Log opened Tue Jun 18 00:00:55 2019 20190618 00:44:38-!- celmin|away is now known as celticminstrel 20190618 01:18:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20190618 01:31:13-!- irker542 [~irker@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev 20190618 01:31:13< irker542> wesnoth/wesnoth:master josteph ad374ef552 menu_handler: See all units in linger mo AppVeyor: All builds passed 20190618 03:51:46< irker542> wesnoth/wesnoth:1.14 newfrenchy83 81df6d0fed Update attack.cpp AppVeyor: All builds passed 20190618 04:04:59-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20190618 06:02:04< irker542> wesnoth/wesnoth:1.14 Severin Glöckner 8bbdd1a027 AoI map adjustments AppVeyor: All builds passed 20190618 08:07:45< irker542> wesnoth/wesnoth:master Severin Glöckner 7a96934c71 AoI map adjustments AppVeyor: All builds passed 20190618 10:15:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190618 10:42:44-!- valdar [~atarocch@93.56.172.28] has quit [Remote host closed the connection] 20190618 11:07:57-!- irker542 [~irker@wesnoth/umc-dev/bot/shikadibot] has quit [Quit: transmission timeout] 20190618 11:30:20-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190618 12:09:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20190618 12:59:54-!- celticminstrel is now known as celmin|away 20190618 13:16:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds] 20190618 14:04:33< Soliton> @Konrad2 are you saying it does not apply the search again when it updates the list after deleting a save? sounds like a bug. 20190618 14:05:55<+wesdiscordbot> Soliton: Not exactly. Instead it doesn't skip savefiles that are hidden by the search when deleting a save. 20190618 14:07:43< Soliton> what does that mean. it deletes the wrong save? 20190618 14:18:38<+wesdiscordbot> As I understand it, imagine the search filter hides the second save file in the list 20190618 14:18:45<+wesdiscordbot> And then you select the first and delete it, 20190618 14:18:59<+wesdiscordbot> then the file that was second in the unfiltered list would become the selected one 20190618 14:19:00<+wesdiscordbot> ? 20190618 14:32:31<+wesdiscordbot> and what soliton means is that that the filtered list is not regenerated, the existing selection is simply reapplied to the modified list 20190618 14:43:58-!- boucman_work [~boucman@wesnoth/developer/boucman] has joined #wesnoth-dev 20190618 14:53:16< Soliton> indeed, that was my first guess. 20190618 15:03:29<+wesdiscordbot> @josteph Has described it correctly. 20190618 15:04:28< Soliton> so it should re-apply the search filter when updating the file list. please file a bug report. 20190618 15:04:38<+wesdiscordbot> Soliton: If your aim were to delete multiple saves in the row and you just know you'll have to click delete a lot and that's what you do, then yes, you might delete wrong saves. 20190618 15:04:56-!- valdar [~atarocch@93.56.172.28] has quit [Remote host closed the connection] 20190618 15:05:42<+wesdiscordbot> Is your summary the same as 'it doesn't skip saves excluded by the filter'? 🤔 20190618 15:06:57< Soliton> i find double negatives do not make a statement easier to understand. 20190618 15:08:06< Soliton> it's not the way i would say it since it suggests the issue has anything to do with the filter but it probably means the same in essence. 20190618 15:08:32< Soliton> the issue is that the filter is NOT applied again. 20190618 15:08:57< Soliton> (as i understand it anyway. someone would need to look at the code to verify, of course.) 20190618 15:10:31<+wesdiscordbot> I'm just not sure what you mean with the filter being not applied. :( 20190618 15:11:03< Soliton> it shows files that do not match the filter, right? 20190618 15:12:07< Soliton> (after you delete a file.) 20190618 15:29:53<+wesdiscordbot> what probably happens is this: 1) get list of files in the save directory 2) determine a 'selection' (of POSITIONS, not filenames) in this list based on the search that was done 3) display part of the list, depending on the selection 20190618 15:31:02<+wesdiscordbot> when you delete a file, it is probably removed from the list of files, making 1) is unnecessary, but 2) is also skipped, so it's now filtering the list of actual files based on how the filter matched the previous list 20190618 15:31:11<+wesdiscordbot> this makes 3) display the wrong thing 20190618 15:33:29< Soliton> yeah, that would be my guess as well. the filter results in selected indices of the complete list and those are simply reused without applying the filter again. 20190618 15:36:57<+wesdiscordbot> I was hoping to explain it to @Konrad2 a little better 20190618 15:38:15< Soliton> what does an ai know of human understanding though!? 20190618 15:39:29-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Excess Flood] 20190618 15:39:41-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev 20190618 15:52:16<+wesdiscordbot> breaking things down into understandable steps tends to work for both 20190618 16:03:54-!- valdar [~atarocch@93.56.172.28] has joined #wesnoth-dev 20190618 16:07:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 245 seconds] 20190618 16:20:53-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev 20190618 16:25:02<+wesdiscordbot> ...I guess? I'd probably be more sure of this was in my native language, so I'll just post two screenshots to make sure we are all on the same page. 20190618 16:32:52< Soliton> https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/game_load.cpp#L436 deletion is handled here and it does not appear to re-apply the filter. 20190618 16:34:29<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/590580074365976601/filter1.png 20190618 16:34:32<+wesdiscordbot> https://cdn.discordapp.com/attachments/259976436490829825/590580102748700701/filter2.png 20190618 16:35:54< Soliton> ah, so it only selects a wrong entry doesn't really show it in the list. 20190618 16:36:36< Soliton> then just the logic that chooses the new selection after deletion needs to be fixed. 20190618 16:36:57<+wesdiscordbot> Can I ask you to file the bug report? I don't seem to be able to get across what the bug is annd I'm probably lacking in technical terms. 20190618 16:37:21< Soliton> well, your screenshots made it perfectly clear. :-) 20190618 16:38:07< Soliton> best way to show what's wrong IMO. 20190618 16:39:11< Soliton> whoever fixes it will figure out the implementation details but i can add a comment what i think needs to be done. 20190618 16:39:42< Soliton> this should be a "good first issue". 20190618 16:42:57<+wesdiscordbot> 'Savefile filter does not work correctly'? 20190618 16:43:44< Soliton> deleting a game can select a game not in the list when a filter is active 20190618 16:43:58< Soliton> deleting a save* 20190618 16:44:12< Soliton> well, something like that. 20190618 16:45:13< Soliton> the filter works fine and it actually doesn't need to be re-applied as i thought. instead the function that decides what save file to show next needs to respect the filter. 20190618 16:46:24< Soliton> excellent, thanks! 20190618 16:50:47<+wesdiscordbot> Btw, is it intended that 'plague' is always grayed (greyed?) out in the attack dialog? 20190618 16:51:25< Soliton> /** @todo do_select_item needs to test for shown flag. */ 20190618 16:51:39<+wesdiscordbot> Wait no, it's not always... Hm. 20190618 16:52:12<+wesdiscordbot> Oh, it's not greyed out when there is a chance to kill. Neat. 20190618 16:52:58<+wesdiscordbot> My bad, I forgot that the defending unit was standing on a village. 20190618 16:54:06< Soliton> yeah, villagers bury their fallen. 20190618 16:57:15<+wesdiscordbot> *burn 20190618 16:57:29<+wesdiscordbot> Bury doesn't help, as shown in SotA. 20190618 17:00:44< Soliton> i thought it says bury somewhere in the help or so. might be misremembering. 20190618 17:27:50<+wesdiscordbot> Huh. I never checked that. 20190618 17:27:58<+wesdiscordbot> But burying really wouldn't help. 20190618 17:32:05-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20190618 17:57:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20190618 20:11:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 245 seconds] 20190618 20:28:00-!- valdar [~atarocch@93.56.172.28] has quit [Read error: Connection reset by peer] 20190618 22:11:22-!- boucman_work [~boucman@wesnoth/developer/boucman] has quit [Ping timeout: 272 seconds] 20190618 22:12:26-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has quit [Read error: Connection reset by peer] 20190618 22:20:37-!- ToBeFree [ToBeFree@wikimedia/ToBeFree] has joined #wesnoth-dev --- Log closed Wed Jun 19 00:00:56 2019