--- Log opened Fri Jun 07 00:00:38 2019
20190607 00:34:57-!- celmin|away is now known as celticminstrel
20190607 03:32:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20190607 10:53:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-umc-dev
20190607 12:34:57-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-umc-dev
20190607 13:06:53-!- celticminstrel is now known as celmin|away
20190607 20:52:25< vn971> Wait, shouldn't lvl3 Lich have no abilities?
20190607 20:52:38< vn971> I'm observing a game now where Lich is intelligent,quick
20190607 20:52:40< vn971> MP7
20190607 20:54:18<+wesdiscordbot> <Pentarctagon> do traits stay on a unit if they become undead on leveling up?
20190607 20:54:40<+wesdiscordbot> <Pentarctagon> the original DA had those traits, I assume
20190607 20:57:12< vn971> yeah, but I thought traits are lost when DA levels to Lich.
20190607 20:57:26< vn971> I'm thinking if it's a regression.
20190607 20:58:35<+wesdiscordbot> <Pentarctagon> maybe check what happens in 1.12
20190607 21:00:25<+wesdiscordbot> <josteph> I remember seeing an issue about this
20190607 21:01:01<+wesdiscordbot> <josteph> traits preserved, new traits don't get added, something like that
20190607 21:01:11<+wesdiscordbot> <josteph> Lich usually has the undead trait
20190607 21:01:42<+wesdiscordbot> <Pentarctagon> ...usually?
20190607 21:01:54<+wesdiscordbot> <josteph> vn971's Lich doesn't 😃
20190607 21:02:08<+wesdiscordbot> <josteph> but if you :create a Lich, it'll have that trait
20190607 21:02:50<+wesdiscordbot> <Pentarctagon> I'm not sure if a living lich would be agonizing or if all the nerves would already be gone by then.
20190607 21:03:03<+wesdiscordbot> <Pentarctagon> sounds pretty terrible either way really
20190607 21:03:48<+wesdiscordbot> <josteph> ?
20190607 21:04:05<+wesdiscordbot> <josteph> I'm just saying, there are two things odd here
20190607 21:04:11<+wesdiscordbot> <josteph> 1) Why is the Lich intelligent,quick
20190607 21:05:02<+wesdiscordbot> <josteph> 2) Why doesn't the Lich have the undead trait https://github.com/wesnoth/wesnoth/blob/564f3e90b14a0c2601b53fe126fc3626e3cf8330/data/core/units.cfg#L388
20190607 21:06:13<+wesdiscordbot> <Pentarctagon> wouldn't that mean it can be poisoned, drained, etc?
20190607 21:07:25<+wesdiscordbot> <josteph> Maybe? If I actually advance a Dark Adept to Lich it gets three traits
20190607 21:07:38<+wesdiscordbot> <josteph> undead plus the two original ones
20190607 21:09:57<+wesdiscordbot> <josteph> https://github.com/wesnoth/wesnoth/issues/2382
20190607 21:18:39<+wesdiscordbot> <Pentarctagon> vn971 even opened that issue
20190607 21:18:41<+wesdiscordbot> <Pentarctagon> 😛
20190607 21:32:43< vn971> Pentarctagon: it's a different issue. When you manually upgrade.
20190607 21:33:05< vn971> but now I've seen Lich retaining its abilities naturally, with no custom add-on taking role (I think).
20190607 21:46:33< vn971> yeah indeed, behavior changed.
20190607 21:47:04< vn971> I can repro DA advancing to Lich. (Testing again on Afterlife map, but it shouldn't be related.)
20190607 21:51:10< vn971> I went on and raised it as a bug: https://github.com/wesnoth/wesnoth/issues/4108
20190607 22:07:26< vn971> dammit, tried to compile 1.14.0, but compilation fails.(
20190607 22:07:33< vn971>    v.emplace_back("auto_vflip=" + utils::bool_string(auto_vflip_));
20190607 22:07:39< vn971> src/units/frame.cpp:457:53: error: cannot convert ‘const boost::logic::tribool’ to ‘bool’
20190607 22:07:42< vn971> smth like that
20190607 22:17:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20190607 23:16:08<+wesdiscordbot> <Pentarctagon> sounds similar to https://github.com/wesnoth/wesnoth/issues/3646
--- Log closed Sat Jun 08 00:00:39 2019